Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 03:59:03PM +, John Levon wrote: On Tue, Dec 02, 2003 at 04:08:07PM +0100, Andre Poenitz wrote: When you change the width of the lyx window the buffer doesn't change. I assume that's what you were referring to as being fixed somehow I can't reproduce this with current cvs. What version are you using? It has very recently been fixed (i.e. current CVS works). You've confused me a little bit now, since your reply just said that it *had* been fixed :) The message you were responding to was meant as an announcement of the fix. However, I like the meaning of 'fix' you used. I suppose, we could simplify the core quite a bit if we fix more things like this... Andre'
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 03:59:03PM +, John Levon wrote: > On Tue, Dec 02, 2003 at 04:08:07PM +0100, Andre Poenitz wrote: > > > > When you change the width of the lyx window the buffer doesn't change. I > > > assume that's what you were referring to as being fixed somehow > > > > I can't reproduce this with current cvs. What version are you using? > > It has very recently been fixed (i.e. current CVS works). You've > confused me a little bit now, since your reply just said that it *had* > been fixed :) The message you were responding to was meant as an announcement of the fix. However, I like the meaning of 'fix' you used. I suppose, we could simplify the core quite a bit if we fix more things like this... Andre'
Re: [PATCH] fix exit crash
On Sun, Nov 30, 2003 at 03:41:15AM +, John Levon wrote: -text() is NULL when you're shutting down with a discarded document open. Fix accesses Btw, the 'resize' problem is fixed now, too. Andre'
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 12:20:24PM +0100, Andre Poenitz wrote: Btw, the 'resize' problem is fixed now, too. That it doesn't actually resize the buffer at all ? good john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 02:29:23PM +, John Levon wrote: On Tue, Dec 02, 2003 at 12:20:24PM +0100, Andre Poenitz wrote: Btw, the 'resize' problem is fixed now, too. That it doesn't actually resize the buffer at all ? For the humour impaired: Example please. Andre'
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 03:44:28PM +0100, Andre Poenitz wrote: Btw, the 'resize' problem is fixed now, too. That it doesn't actually resize the buffer at all ? For the humour impaired: Example please. When you change the width of the lyx window the buffer doesn't change. I assume that's what you were referring to as being fixied somehow john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 02:56:32PM +, John Levon wrote: On Tue, Dec 02, 2003 at 03:44:28PM +0100, Andre Poenitz wrote: Btw, the 'resize' problem is fixed now, too. That it doesn't actually resize the buffer at all ? For the humour impaired: Example please. When you change the width of the lyx window the buffer doesn't change. I assume that's what you were referring to as being fixied somehow I can't reproduce this with current cvs. What version are you using? Andre'
Re: [PATCH] fix exit crash
On Tuesday 02 December 2003 14:56, John Levon wrote: When you change the width of the lyx window the buffer doesn't change. I assume that's what you were referring to as being fixied somehow I don't see that with xforms, gtk or qt... Maybe it is ncurses frontend that is broke. ;-) john -- José Abílio LyX and docbook, a perfect match. :-)
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 04:08:07PM +0100, Andre Poenitz wrote: When you change the width of the lyx window the buffer doesn't change. I assume that's what you were referring to as being fixed somehow I can't reproduce this with current cvs. What version are you using? It has very recently been fixed (i.e. current CVS works). You've confused me a little bit now, since your reply just said that it *had* been fixed :) john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.
Re: [PATCH] fix exit crash
On Sun, Nov 30, 2003 at 03:41:15AM +, John Levon wrote: > > ->text() is NULL when you're shutting down with a discarded document > open. > > Fix accesses Btw, the 'resize' problem is fixed now, too. Andre'
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 12:20:24PM +0100, Andre Poenitz wrote: > Btw, the 'resize' problem is fixed now, too. That it doesn't actually resize the buffer at all ? good john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 02:29:23PM +, John Levon wrote: > On Tue, Dec 02, 2003 at 12:20:24PM +0100, Andre Poenitz wrote: > > > Btw, the 'resize' problem is fixed now, too. > > That it doesn't actually resize the buffer at all ? For the humour impaired: Example please. Andre'
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 03:44:28PM +0100, Andre Poenitz wrote: > > > Btw, the 'resize' problem is fixed now, too. > > > > That it doesn't actually resize the buffer at all ? > > For the humour impaired: Example please. When you change the width of the lyx window the buffer doesn't change. I assume that's what you were referring to as being fixied somehow john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 02:56:32PM +, John Levon wrote: > On Tue, Dec 02, 2003 at 03:44:28PM +0100, Andre Poenitz wrote: > > > > > Btw, the 'resize' problem is fixed now, too. > > > > > > That it doesn't actually resize the buffer at all ? > > > > For the humour impaired: Example please. > > When you change the width of the lyx window the buffer doesn't change. I > assume that's what you were referring to as being fixied somehow I can't reproduce this with current cvs. What version are you using? Andre'
Re: [PATCH] fix exit crash
On Tuesday 02 December 2003 14:56, John Levon wrote: > > When you change the width of the lyx window the buffer doesn't change. I > assume that's what you were referring to as being fixied somehow I don't see that with xforms, gtk or qt... Maybe it is ncurses frontend that is broke. ;-) > john -- José Abílio LyX and docbook, a perfect match. :-)
Re: [PATCH] fix exit crash
On Tue, Dec 02, 2003 at 04:08:07PM +0100, Andre Poenitz wrote: > > When you change the width of the lyx window the buffer doesn't change. I > > assume that's what you were referring to as being fixed somehow > > I can't reproduce this with current cvs. What version are you using? It has very recently been fixed (i.e. current CVS works). You've confused me a little bit now, since your reply just said that it *had* been fixed :) john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.
Re: [PATCH] fix exit crash
On Sun, Nov 30, 2003 at 03:41:15AM +, John Levon wrote: -text() is NULL when you're shutting down with a discarded document open. Fix accesses Looks ok. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
Re: [PATCH] fix exit crash
On Sun, Nov 30, 2003 at 03:41:15AM +, John Levon wrote: > > ->text() is NULL when you're shutting down with a discarded document > open. > > Fix accesses Looks ok. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
[PATCH] fix exit crash
-text() is NULL when you're shutting down with a discarded document
open.
Fix accesses
regards
john
Index: BufferView_pimpl.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v
retrieving revision 1.471
diff -u -a -p -r1.471 BufferView_pimpl.C
--- BufferView_pimpl.C 28 Nov 2003 15:53:22 - 1.471
+++ BufferView_pimpl.C 30 Nov 2003 03:39:34 -
@@ -293,9 +293,6 @@ void BufferView::Pimpl::buffer(Buffer *
// set current buffer
buffer_ = b;
- buffer_-text().init(bv_);
- buffer_-text().textwidth_ = workarea().workWidth();
- buffer_-text().fullRebreak();
top_y_ = 0;
@@ -310,6 +307,10 @@ void BufferView::Pimpl::buffer(Buffer *
if (buffer_) {
lyxerr[Debug::INFO] Buffer addr: buffer_ endl;
connectBuffer(*buffer_);
+
+ buffer_-text().init(bv_);
+ buffer_-text().textwidth_ = workarea().workWidth();
+ buffer_-text().fullRebreak();
// If we don't have a text object for this, we make one
if (bv_-text() == 0)
[PATCH] fix exit crash
->text() is NULL when you're shutting down with a discarded document
open.
Fix accesses
regards
john
Index: BufferView_pimpl.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v
retrieving revision 1.471
diff -u -a -p -r1.471 BufferView_pimpl.C
--- BufferView_pimpl.C 28 Nov 2003 15:53:22 - 1.471
+++ BufferView_pimpl.C 30 Nov 2003 03:39:34 -
@@ -293,9 +293,6 @@ void BufferView::Pimpl::buffer(Buffer *
// set current buffer
buffer_ = b;
- buffer_->text().init(bv_);
- buffer_->text().textwidth_ = workarea().workWidth();
- buffer_->text().fullRebreak();
top_y_ = 0;
@@ -310,6 +307,10 @@ void BufferView::Pimpl::buffer(Buffer *
if (buffer_) {
lyxerr[Debug::INFO] << "Buffer addr: " << buffer_ << endl;
connectBuffer(*buffer_);
+
+ buffer_->text().init(bv_);
+ buffer_->text().textwidth_ = workarea().workWidth();
+ buffer_->text().fullRebreak();
// If we don't have a text object for this, we make one
if (bv_->text() == 0)
