Re: Backport of po/Makefile.in.in ok?
Am 11.10.2010 um 16:45 schrieb Stephan Witt: > Am 11.10.2010 um 13:55 schrieb BH: > >> On Mon, Oct 11, 2010 at 2:22 AM, Stephan Witt wrote: >>> Am 10.10.2010 um 22:56 schrieb Jean-Marc Lasgouttes: Personnally, I hav no problem with my 0.18.1 from macports. >>> >>> How did you get it? >>> I tried "port search gettext" and got the answer >>> gettext @0.17 (devel) >>> GNU gettext package >> >> gettext 0.18.1.1 for me. (Have you tried port selfupdate?) > > No. I'm not familiar with macport... > I thought that "port search" mentions the newest available version. > Then I'll do it this way. Ok, I did it. And have to sort out the build environment again :-( autotools based build doesn't find the Qt4 libraries but iconv now gets linked twice... I'll fix the announced spell checker crash when I'm able to build again. But I guess gettext is working now. Stephan
Re: Backport of po/Makefile.in.in ok?
Am 11.10.2010 um 13:55 schrieb BH: > On Mon, Oct 11, 2010 at 2:22 AM, Stephan Witt wrote: >> Am 10.10.2010 um 22:56 schrieb Jean-Marc Lasgouttes: >>> Personnally, I hav no problem with my 0.18.1 from macports. >> >> How did you get it? >> I tried "port search gettext" and got the answer >> gettext @0.17 (devel) >>GNU gettext package > > gettext 0.18.1.1 for me. (Have you tried port selfupdate?) No. I'm not familiar with macport... I thought that "port search" mentions the newest available version. Then I'll do it this way. Stephan
Re: Backport of po/Makefile.in.in ok?
On Mon, Oct 11, 2010 at 2:22 AM, Stephan Witt wrote: > Am 10.10.2010 um 22:56 schrieb Jean-Marc Lasgouttes: >> Personnally, I hav no problem with my 0.18.1 from macports. > > How did you get it? > I tried "port search gettext" and got the answer > gettext @0.17 (devel) > GNU gettext package gettext 0.18.1.1 for me. (Have you tried port selfupdate?) BH
Re: Backport of po/Makefile.in.in ok?
Am 10.10.2010 um 22:56 schrieb Jean-Marc Lasgouttes: > Le 10 oct. 10 à 17:50, Jürgen Spitzmüller a écrit : >> Actually, I do not know enough of gettext to judge if this change would have >> unwanted side effects. > > I don't either... > >> Since it is a workaround, I wonder if we can limit this fix to MacOSx only or >> upgrade gettext? But as I said, I do not understand this very well. > > The queston is not to upgrade gettext, because the bug is not in the version > that we ship > (the translation code), but in the gettext utilities that people use. So > developpers should > be advised to have a recent version of gettext on OS X. > > Personnally, I hav no problem with my 0.18.1 from macports. How did you get it? I tried "port search gettext" and got the answer gettext @0.17 (devel) GNU gettext package So I thought it's the current version. > I would vote for removing the workaround in trunk and advise developers to > update their > machine in the relevant INSTALL file (and maybe give the workaround of > overriding > MESMERGE_UPDATE on the make command line). I dislike adding too much code for > working > around bugs, because this code will stay, and I suspect that some people like > this backup thing. I don't need the backup feature. But in principle you're right. Stephan
Re: Backport of po/Makefile.in.in ok?
Le 10 oct. 10 à 17:50, Jürgen Spitzmüller a écrit : Actually, I do not know enough of gettext to judge if this change would have unwanted side effects. I don't either... Since it is a workaround, I wonder if we can limit this fix to MacOSx only or upgrade gettext? But as I said, I do not understand this very well. The queston is not to upgrade gettext, because the bug is not in the version that we ship (the translation code), but in the gettext utilities that people use. So developpers should be advised to have a recent version of gettext on OS X. Personnally, I hav no problem with my 0.18.1 from macports. I would vote for removing the workaround in trunk and advise developers to update their machine in the relevant INSTALL file (and maybe give the workaround of overriding MESMERGE_UPDATE on the make command line). I dislike adding too much code for working around bugs, because this code will stay, and I suspect that some people like this backup thing. JMarc
Re: Backport of po/Makefile.in.in ok?
Am Sonntag 10 Oktober 2010 schrieb Jürgen Spitzmüller: > Stephan Witt wrote: > > I've locally modified the msgmerge call to get it work on MacOSX. > > It's like that already in trunk. Ok to backport? > > Actually, I do not know enough of gettext to judge if this change would > have unwanted side effects. > > I understand that the change (--backup=none) disables the production of po > file backups (*.po~) during the merging process, and I understand that this > is a workaround for a bug in gettext that is supposed to be fixed as of > gettext 0.18 (https://savannah.gnu.org/bugs/index.php?26149). > > Since it is a workaround, I wonder if we can limit this fix to MacOSx only > or upgrade gettext? But as I said, I do not understand this very well. > > Jean-Marc, do you have an opinion on this? > > Jürgen It is the same, we use for cmake build. Kornel signature.asc Description: This is a digitally signed message part.
Re: Backport of po/Makefile.in.in ok?
Stephan Witt wrote: > I've locally modified the msgmerge call to get it work on MacOSX. > It's like that already in trunk. Ok to backport? Actually, I do not know enough of gettext to judge if this change would have unwanted side effects. I understand that the change (--backup=none) disables the production of po file backups (*.po~) during the merging process, and I understand that this is a workaround for a bug in gettext that is supposed to be fixed as of gettext 0.18 (https://savannah.gnu.org/bugs/index.php?26149). Since it is a workaround, I wonder if we can limit this fix to MacOSx only or upgrade gettext? But as I said, I do not understand this very well. Jean-Marc, do you have an opinion on this? Jürgen
Backport of po/Makefile.in.in ok?
Jürgen, I've locally modified the msgmerge call to get it work on MacOSX. It's like that already in trunk. Ok to backport? Stephan Index: po/Makefile.in.in === --- po/Makefile.in.in (Revision 35586) +++ po/Makefile.in.in (Arbeitskopie) @@ -56,7 +56,7 @@ XGETTEXT_yes = @XGETTEXT_015@ XGETTEXT = $(XGETTEXT_$(USE_MSGCTXT)) MSGMERGE = msgmerge -MSGMERGE_UPDATE = @MSGMERGE@ --update +MSGMERGE_UPDATE = @MSGMERGE@ --update --backup=none MSGINIT = msginit MSGCONV = msgconv MSGFILTER = msgfilter
