Embedding feature slows down updateLabels() very significantly!
I think... Abdel.
Re: Embedding feature slows down updateLabels() very significantly!
On 9/11/07, Abdelrazak Younes [EMAIL PROTECTED] wrote: I think... I have not done any profiling but this is possible. Because EmbeddedFiles now saves inset pointers (not ParConstIterator), EmbeddedFiles::update() should be moved out of updateLabels() and iscalled with inset addition and removal. I am not quite sure what is the best way to do this though. Cheers, Bo
Re: Embedding feature slows down updateLabels() very significantly!
I am not quite sure what is the best way to do this though. With a patch that I just submitted for review, this is the last major problem that needs to be resolved. Basically, I need to call EmbeddedFiles::update() (or emit embeddingChanged() signal) when an inset that has embedded files is created/removed/modified. Do you have any good idea? I am not against the idea of an 'update' button that forces the update. This will be most efficient. Cheers, Bo
Embedding feature slows down updateLabels() very significantly!
I think... Abdel.
Re: Embedding feature slows down updateLabels() very significantly!
On 9/11/07, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > I think... I have not done any profiling but this is possible. Because EmbeddedFiles now saves inset pointers (not ParConstIterator), EmbeddedFiles::update() should be moved out of updateLabels() and iscalled with inset addition and removal. I am not quite sure what is the best way to do this though. Cheers, Bo
Re: Embedding feature slows down updateLabels() very significantly!
> I am not quite sure what is > the best way to do this though. With a patch that I just submitted for review, this is the last major problem that needs to be resolved. Basically, I need to call EmbeddedFiles::update() (or emit embeddingChanged() signal) when an inset that has embedded files is created/removed/modified. Do you have any good idea? I am not against the idea of an 'update' button that forces the update. This will be most efficient. Cheers, Bo
