Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-04 Thread Richard Kimberly Heck

On 4/3/24 06:43, Jean-Marc Lasgouttes wrote:

Le 02/04/2024 à 14:11, Kornel Benko a écrit :

Am Mon, 01 Apr 2024 20:24:10 +0100
schrieb José Matos :

What Qt version is available there?


This is qt5.4.0. And probably you are right.


This one should be fixed in master at 6260689fd552. Please confirm.

Riki, this will be candidate for 2.4.0.


Yes, go ahead.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Kornel Benko
Am Wed, 3 Apr 2024 14:53:06 +0200
schrieb Jean-Marc Lasgouttes :

> Le 02/04/2024 à 14:12, Kornel Benko a écrit :
> >> The first one looks like a matter of old gcc that does not like the {}
> >> constructor (don't remember the name).
> >>
> >> JMarc
> > 
> > If so, can something be done here?
> 
> This compiles fine here, can you check that it does for you too?
> 
> Also, I do not know how to test this code. Riki can you confirm that it 
> makes sense?
> 
> JMarc
> 
> 
> 

Compiles here too. The resulting executable seems also correct. Thanks.

Kornel


pgpcuJknwvQ4i.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Jean-Marc Lasgouttes

Le 02/04/2024 à 14:12, Kornel Benko a écrit :

The first one looks like a matter of old gcc that does not like the {}
constructor (don't remember the name).

JMarc


If so, can something be done here?


This compiles fine here, can you check that it does for you too?

Also, I do not know how to test this code. Riki can you confirm that it 
makes sense?


JMarc



From 62d212a2f0c7ff851f03aa4c4fd5c9d138f9b4a1 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes 
Date: Wed, 3 Apr 2024 14:49:13 +0200
Subject: [PATCH] Construct tuple explicitly for older compilers

gcc < 6 refuses to use {foo, bar, baz} to construct a tuple in this context.
---
 src/frontends/qt/GuiRef.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/frontends/qt/GuiRef.cpp b/src/frontends/qt/GuiRef.cpp
index 6a2446a5a6..f400aae8eb 100644
--- a/src/frontends/qt/GuiRef.cpp
+++ b/src/frontends/qt/GuiRef.cpp
@@ -455,7 +455,8 @@ void GuiRef::redoRefs()
 	for (auto const & theref : refs_) {
 		// first: plain label name, second: gui name, third: pretty name
 		QString const lab = toqstr(get<0>(theref));
-		refsNames.append({lab, toqstr(get<1>(theref)), toqstr(get<2>(theref))});
+		// {a, b, c} is nicer, but gcc < 6 barks on it
+		refsNames.append(make_tuple(lab, toqstr(get<1>(theref)), toqstr(get<2>(theref;
 		if (groupCB->isChecked()) {
 			if (lab.contains(":")) {
 QString const pref = lab.split(':')[0];
-- 
2.25.1

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Kornel Benko
Am Wed, 3 Apr 2024 12:43:59 +0200
schrieb Jean-Marc Lasgouttes :

> Le 02/04/2024 à 14:11, Kornel Benko a écrit :
> > Am Mon, 01 Apr 2024 20:24:10 +0100
> > schrieb José Matos :  
> >> What Qt version is available there?  
> > 
> > This is qt5.4.0. And probably you are right.  
> 
> This one should be fixed in master at 6260689fd552. Please confirm.
> 
> Riki, this will be candidate for 2.4.0.
> 
> JMarc
> 

Thanks, this one error is gone. Confirmed.

Kornel


pgp9r8pqWS2eb.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Jean-Marc Lasgouttes

Le 02/04/2024 à 14:11, Kornel Benko a écrit :

Am Mon, 01 Apr 2024 20:24:10 +0100
schrieb José Matos :

What Qt version is available there?


This is qt5.4.0. And probably you are right.


This one should be fixed in master at 6260689fd552. Please confirm.

Riki, this will be candidate for 2.4.0.

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Kornel Benko
Am Tue, 2 Apr 2024 14:53:22 +0200
schrieb Jean-Marc Lasgouttes :

> Le 02/04/2024 à 14:12, Kornel Benko a écrit :
> >> The first one looks like a matter of old gcc that does not like the {}
> >> constructor (don't remember the name).
> >>
> >> JMarc  
> > 
> > If so, can something be done here?  
> 
> I can't right now, but basically yes.
> 
> JMarc
> 

Thanks, would be nice to have.

Kornel


pgpmBWFgKRa70.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-02 Thread Jean-Marc Lasgouttes

Le 02/04/2024 à 14:12, Kornel Benko a écrit :

The first one looks like a matter of old gcc that does not like the {}
constructor (don't remember the name).

JMarc


If so, can something be done here?


I can't right now, but basically yes.

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-02 Thread Kornel Benko
Am Mon, 1 Apr 2024 21:29:00 +0200
schrieb Jean-Marc Lasgouttes :

> Le 01/04/2024 à 21:24, José Matos a écrit :
> > On Mon, 2024-04-01 at 20:44 +0200, Kornel Benko wrote:  
> >> Attached the the errors for src/frontends/qt/GuiRef.cpp and
> >> src/frontends/qt/GuiWorkArea.cpp.
> >>
> >> This is on a debian computer used by my wife, so I am somewhat
> >> reluctant to upgrade there.
> >> If I create a package on a different computer, the resulting
> >> executable does not run
> >> there because it expects many newer libraries.
> >>
> >>Kornel  
> > 
> > I suspect that the problem is the Qt version.
> > 
> > What Qt version is available there?  
> 
> The first one looks like a matter of old gcc that does not like the {} 
> constructor (don't remember the name).
> 
> JMarc

If so, can something be done here?

Kornel


pgp_QzxCF0ra_.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-02 Thread Kornel Benko
Am Mon, 01 Apr 2024 20:24:10 +0100
schrieb José Matos :

> On Mon, 2024-04-01 at 20:44 +0200, Kornel Benko wrote:
> > Attached the the errors for src/frontends/qt/GuiRef.cpp and
> > src/frontends/qt/GuiWorkArea.cpp.
> > 
> > This is on a debian computer used by my wife, so I am somewhat
> > reluctant to upgrade there.
> > If I create a package on a different computer, the resulting
> > executable does not run
> > there because it expects many newer libraries.
> > 
> > Kornel  
> 
> I suspect that the problem is the Qt version.
> 
> What Qt version is available there?

This is qt5.4.0. And probably you are right.

Kornel


pgpvfUSBLlc27.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-01 Thread Jean-Marc Lasgouttes

Le 01/04/2024 à 21:24, José Matos a écrit :

On Mon, 2024-04-01 at 20:44 +0200, Kornel Benko wrote:

Attached the the errors for src/frontends/qt/GuiRef.cpp and
src/frontends/qt/GuiWorkArea.cpp.

This is on a debian computer used by my wife, so I am somewhat
reluctant to upgrade there.
If I create a package on a different computer, the resulting
executable does not run
there because it expects many newer libraries.

Kornel


I suspect that the problem is the Qt version.

What Qt version is available there?


The first one looks like a matter of old gcc that does not like the {} 
constructor (don't remember the name).


JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-01 Thread José Matos
On Mon, 2024-04-01 at 20:44 +0200, Kornel Benko wrote:
> Attached the the errors for src/frontends/qt/GuiRef.cpp and
> src/frontends/qt/GuiWorkArea.cpp.
> 
> This is on a debian computer used by my wife, so I am somewhat
> reluctant to upgrade there.
> If I create a package on a different computer, the resulting
> executable does not run
> there because it expects many newer libraries.
> 
>   Kornel

I suspect that the problem is the Qt version.

What Qt version is available there?
-- 
José Abílio
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Errors compiling lyx2.4 with gcc 5.4.0

2024-04-01 Thread Kornel Benko
Attached the the errors for src/frontends/qt/GuiRef.cpp and
src/frontends/qt/GuiWorkArea.cpp.

This is on a debian computer used by my wife, so I am somewhat reluctant to 
upgrade there.
If I create a package on a different computer, the resulting executable does 
not run
there because it expects many newer libraries.

Kornel


ErrorsGcc5.4.0
Description: Binary data


pgpbdwXc2LQli.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel