Re: [LyX/master] Only \protect labels in \thanks notes
On Sun, Sep 22, 2024 at 05:18:40PM GMT, Jürgen Spitzmüller wrote: > Am Sonntag, dem 22.09.2024 um 11:50 +0200 schrieb Jürgen Spitzmüller: > > Yes. No idea what the issue here is (as it only breaks with the > > Spanish version). > > It's the "nohyper" option that is (only) used in the Spanish version. > > I'll change that. Thanks, Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: How to underline and color hyperlinks?
On Sun, Sep 22, 2024 at 6:46 PM Richard Kimberly Heck
wrote:
>
> This looks like a bug to me. The user has "Use Hyperref" turned on, and does
> not have "No frames around links" checked, but there are no frames around
> \href links, but they are only colored. Shouldn't there be?
>
The "cololinks" option in the hyperref package disables the borders
at the beginning of the document. If you want both you need to add the
following to the preamble after enabling colored links
\AtBeginDocument{\hypersetup{pdfborder=0 0 1}}
Its a question of whether the GUI should indicate
things similar to the LaTeX implementation or not.
Besides that, these borders are not part of the
printed version, I don't think it is relevant to the
reported problem.
Udi
>
>
>
> Forwarded Message
> Subject: How to underline and color hyperlinks?
> Date: Sun, 22 Sep 2024 08:59:28 +
> From: Stef Pillaert
> To: lyx-users
>
>
> Something I'm struggling with for a long time now...
> A (probably simple?) thing: I don't succeed in giving hyperlinks both a color
> and underline them.
> I want this, since my students often print my course material in black&white
> (easier reading/studying than reading on laptop screen, and B/W is a lot
> cheaper then printing in color 🙁).
> This way, they sometimes don't see/notice that there is actually a hyperlink
> they should click on (what they have to do starting from the digital version
> of the of the text, of course 😉)
> Thanks for pointing me in the right direction. I've added a MWE, so you can
> see what settings I'm using.
> Stef
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Only \protect labels in \thanks notes
Am Sonntag, dem 22.09.2024 um 11:50 +0200 schrieb Jürgen Spitzmüller: > Yes. No idea what the issue here is (as it only breaks with the > Spanish version). It's the "nohyper" option that is (only) used in the Spanish version. I'll change that. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sun, 22 Sep 2024 11:20:12 +0200 schrieb Scott Kostyshak : > On Sun, Sep 22, 2024 at 10:23:36AM GMT, Kornel Benko wrote: > > Am Thu, 19 Sep 2024 22:46:36 +0200 > > schrieb Scott Kostyshak : > > > > > On Wed, Sep 18, 2024 at 11:42:34AM GMT, Scott Kostyshak wrote: > > > > On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote: > > > > > > > > But now using pdf your patch makes more sense. > > > > > > > > Sounds good. I'll apply it. > > > > > > Done at c7be9780. > > > > > > > First I will see if any new tests fail with > > > > it though. > > > > > > These tests fail for me now: > > > > > > export/doc/ja/UserGuide_lyx16 > > > export/doc/ja/UserGuide_lyx20 > > > export/examples/ja/Modules/LilyPond_Book_lyx16 > > > export/examples/ja/Modules/LilyPond_Book_lyx20 > > > > > > But it's not clear it's worth the time to fix them so I inverted them at > > > 92c7c33d. > > > > > > Scott > > > > With the attached (tested -R lyx20), I get > > 99% tests passed, 1 tests failed out of 381 > > > > 3689 - INVERTED.TODO_export/examples/Articles/Chess/Game_1_lyx20 (Failed) > > Looks very nice, thanks! I had wondered how to return/read multiple > values using CMake. Your solution of regex-splitting on "/" seems simple > and good for this case (i.e., I cannot imagine a format that uses '/' in > its name and I'm sure that would break other things as well). > > I would say +1 to commit. I can run the full set of ctests after you > commit in the next days. > > Scott Done at 3add2204. Kornel pgpsUj89z0R0W.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Only \protect labels in \thanks notes
Am Samstag, dem 21.09.2024 um 21:57 +0200 schrieb Scott Kostyshak: > I think this commit broke the following tests: > > export/examples/es/Handouts/Tufte_Handout_lyx22 (Failed) > export/examples/es/Handouts/Tufte_Handout_lyx23 (Failed) > DEFAULTOUTPUT_export/examples/es/Handouts/Tufte_Handout_pdf2 > (Failed) Yes. No idea what the issue here is (as it only breaks with the Spanish version). Setting "Put fragile content out of moving arguments" solves it, but of course not for the 2.3 exports. I worked around it for now by moving the labels manually out of the sections. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sun, Sep 22, 2024 at 10:23:36AM GMT, Kornel Benko wrote: > Am Thu, 19 Sep 2024 22:46:36 +0200 > schrieb Scott Kostyshak : > > > On Wed, Sep 18, 2024 at 11:42:34AM GMT, Scott Kostyshak wrote: > > > On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote: > > > > > > But now using pdf your patch makes more sense. > > > > > > Sounds good. I'll apply it. > > > > Done at c7be9780. > > > > > First I will see if any new tests fail with > > > it though. > > > > These tests fail for me now: > > > > export/doc/ja/UserGuide_lyx16 > > export/doc/ja/UserGuide_lyx20 > > export/examples/ja/Modules/LilyPond_Book_lyx16 > > export/examples/ja/Modules/LilyPond_Book_lyx20 > > > > But it's not clear it's worth the time to fix them so I inverted them at > > 92c7c33d. > > > > Scott > > With the attached (tested -R lyx20), I get > 99% tests passed, 1 tests failed out of 381 > > 3689 - INVERTED.TODO_export/examples/Articles/Chess/Game_1_lyx20 (Failed) Looks very nice, thanks! I had wondered how to return/read multiple values using CMake. Your solution of regex-splitting on "/" seems simple and good for this case (i.e., I cannot imagine a format that uses '/' in its name and I'm sure that would break other things as well). I would say +1 to commit. I can run the full set of ctests after you commit in the next days. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Thu, 19 Sep 2024 22:46:36 +0200
schrieb Scott Kostyshak :
> On Wed, Sep 18, 2024 at 11:42:34AM GMT, Scott Kostyshak wrote:
> > On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote:
>
> > > But now using pdf your patch makes more sense.
> >
> > Sounds good. I'll apply it.
>
> Done at c7be9780.
>
> > First I will see if any new tests fail with
> > it though.
>
> These tests fail for me now:
>
> export/doc/ja/UserGuide_lyx16
> export/doc/ja/UserGuide_lyx20
> export/examples/ja/Modules/LilyPond_Book_lyx16
> export/examples/ja/Modules/LilyPond_Book_lyx20
>
> But it's not clear it's worth the time to fix them so I inverted them at
> 92c7c33d.
>
> Scott
With the attached (tested -R lyx20), I get
99% tests passed, 1 tests failed out of 381
3689 - INVERTED.TODO_export/examples/Articles/Chess/Game_1_lyx20 (Failed)
Kornel
diff --git a/development/autotests/export.cmake b/development/autotests/export.cmake
index 40bc0f0cb5..6053e5b827 100755
--- a/development/autotests/export.cmake
+++ b/development/autotests/export.cmake
@@ -228,23 +228,15 @@ if (extension MATCHES "\\.lyx$")
include(${TOP_SRC_DIR}/development/autotests/CheckLoadErrors.cmake)
get_md5sum(LYX_SOURCE source_md5sum _err)
message(STATUS "Executing ${PERL_EXECUTABLE} ${readDefaultOutputFormat} ${LYX_SOURCE}")
execute_process(
COMMAND ${PERL_EXECUTABLE} ${readDefaultOutputFormat} "${LYX_SOURCE}"
-OUTPUT_VARIABLE _export_format)
- message(STATUS "readDefaultOutputFormat = ${_export_format}")
- if (${_export_format} MATCHES "pdf2")
-set(_texformat "pdflatex")
- elseif(${_export_format} MATCHES "pdf3")
-# Ideally we would set to "platex" if Japanese, and "latex" if not Japanese.
-# For example, currently we invert export/examples/Articles/Chess/Game_1_lyx because
-# it should be exported to "latex" instead of "platex".
-set(_texformat "platex")
- elseif(${_export_format} MATCHES "pdf4")
-set(_texformat "xetex")
- elseif(${_export_format} MATCHES "pdf5")
-set(_texformat "luatex")
+OUTPUT_VARIABLE _formats)
+ message(STATUS "readDefaultOutputFormat = ${_formats}")
+ if (${_formats} MATCHES "^([a-z]+)/(pdf[2345]?)$")
+set(_texformat ${CMAKE_MATCH_1})
+set(_export_format ${CMAKE_MATCH_2})
else()
set(_texformat "empty")
endif()
foreach(_lv RANGE 1 20)
diff --git a/development/autotests/readDefaultOutputFormat.pl b/development/autotests/readDefaultOutputFormat.pl
index 496cfeeaa5..fbc06fc525 100644
--- a/development/autotests/readDefaultOutputFormat.pl
+++ b/development/autotests/readDefaultOutputFormat.pl
@@ -4,11 +4,11 @@
#
use strict;
my $useNonTexFonts = undef;
my $outputFormat = undef;
-my $outputFormat = undef;
+my $texFormat = undef;
my $language = undef;
if (-e "$ARGV[0]") {
if (open(FI, "$ARGV[0]")) {
while (my $l = ) {
chomp($l);
@@ -22,38 +22,79 @@ if (-e "$ARGV[0]") {
$language = $1;
}
last if (defined($useNonTexFonts) && defined($outputFormat) && defined($language));
}
close(FI);
+if (defined($ARGV[1])) {
+ print "outputformat = \"$outputFormat\"\n";
+ print "useNonTexFonts = \"$useNonTexFonts\"\n";
+ print "language = \"$language\"\n";
+}
}
}
-if (defined($useNonTexFonts) && defined($outputFormat)) {
+if ($language eq "japanese") {
if ($useNonTexFonts) {
-if ($outputFormat eq "default") {
- if ($language eq "japanese") {
-$outputFormat = "pdf4";
+if ($outputFormat =~ /^(default|pdf4)$/) {
+ $outputFormat = "pdf4";
+ $texFormat = "xetex";
+}
+elsif ($outputFormat =~ /^pdf[35]?$/) {
+ if ($outputFormat =~ /^pdf3?$/) {
+$texFormat = "platex";
}
else {
-$outputFormat = "pdf5";
+$texFormat = "luatex";
}
}
+else {
+ $outputFormat = undef;
+}
}
- elsif ($outputFormat eq "default") {
-if ($language eq "japanese") {
+ else { # using tex font
+if ($outputFormat =~ /^(default|pdf3)$/) {
$outputFormat = "pdf3";
+ $texFormat = "platex";
+}
+elsif ($outputFormat =~ /^pdf5$/) {
+ $texFormat = "luatex";
}
else {
- $outputFormat = "pdf2";
+ $outputFormat = undef;
}
}
- if ($outputFormat !~ /^pdf/) {
-$outputFormat = undef;
+}
+else { # not a japanese language
+ if ($useNonTexFonts) {
+if ($outputFormat =~ /^(default|pdf4)$/) {
+ $texFormat = "xetex";
+}
+elsif ($outputFormat eq "pdf5") {
+ $texFormat = "luatex";
+}
+else {
+ $outputFormat = undef;
+}
+ }
+ else { # using tex fonts
+if ($outputFormat =~ /^(default|pdf2)$/) {
+ $outputFormat = "pdf2";
+ $texFormat = "pdflatex";
+}
+elsif ($outputFormat eq "pdf5") {
+ $texFormat = "luatex";
+}
+elsif ($outputFormat eq "pdf3") {
+ $texFormat = "latex";
+}
+else {
+ $outputFormat = undef;
+}
}
}
if (defined($outputFormat)) {
- print
Re: [LyX/master] Only \protect labels in \thanks notes
On Sat, Sep 21, 2024 at 09:31:40AM GMT, Juergen Spitzmueller wrote: > commit d43e82a5a79e167c27140b609895ffdcd1ed8997 > Author: Juergen Spitzmueller > Date: Sat Sep 21 11:30:08 2024 +0200 > > Only \protect labels in \thanks notes > > See https://marc.info/?l=lyx-users&m=136394387505489 > --- I think this commit broke the following tests: export/examples/es/Handouts/Tufte_Handout_lyx22 (Failed) export/examples/es/Handouts/Tufte_Handout_lyx23 (Failed) DEFAULTOUTPUT_export/examples/es/Handouts/Tufte_Handout_pdf2 (Failed) Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: LyX 2.4.2 Tarballs
On Thu, Sep 19, 2024 at 06:00:08PM +0200, Jean-Pierre Chrétien wrote: > > We might hold off briefly on building binaries until we're sure there > > are no other problems. > > Compiles and runs the UserGuide flawlessly on Debian bookworm with +1 P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: LyX 2.4.2 Tarballs
Hi all, the binaries for macOS are ready and uploaded. I’ve sent the link to Riki. Stephan > Am 19.09.2024 um 17:15 schrieb Richard Kimberly Heck : > > Here: > > https://drive.google.com/drive/folders/1eRWa19xe9BwJ_jgNXg8w27JpPJChye6l?usp=sharing > > I am having trouble accessing the LyX ftp server, due to a change in my IP. > You should verify the signatures. > > We might hold off briefly on building binaries until we're sure there are no > other problems. > > Riki > > > -- > lyx-devel mailing list > lyx-devel@lists.lyx.org > http://lists.lyx.org/mailman/listinfo/lyx-devel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor()
On Thu, Sep 19, 2024 at 10:56:51PM +0200, Jean-Marc Lasgouttes wrote: > Le 10/09/2024 ?? 15:56, Pavel Sanda a écrit : > > On Fri, Sep 06, 2024 at 03:33:24PM +0200, Jean-Marc Lasgouttes wrote: > > > Then, I changed the outline to yield the same effect. I expect some of you > > > to hate it, but discussion is good and this is not the final design. > > > Again, > > > clicking several times on an element shows what is below it, around it, > > > and > > > so forth. > > > > If you are interested in feedback, I launched master to test outline and > > found > > that centering is somewhat annoying as I expect to see way more content > > following > > the (sub/..)section title I clicked on than above it. So I would prefer to > > stay > > to 2.3 situation. > > Before I revert that part, did you try to click several times on the toc > entry? I personally think that it is a good way to look around cursor > position. Yes, I tried. I am not against that functionality, but I would like the first click puts the cursor on the top. > > > * there is some ad-hoc code that adds twice the height of a typical row > > > before the paragraph. In passing, this means that a tall row (Chapter) > > > will > > > be barely shown completely. I remember that changing that has met > > > resistance > > > and I had to revert it. How is this useful to you? > > > > Maybe it's related to the discussion how search scrolling is done? One > > pushback > > I remember was that we lost few lines of context on top before the searched > > text at some point and made you scroll the context back to screen... > > So, what do you want t see above? The previous row of text? Two rows? Just > ask, I can give it a go to see whether it works. Two columns seem reasonable, but no hard opinion. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor()
Le 10/09/2024 à 15:56, Pavel Sanda a écrit : On Fri, Sep 06, 2024 at 03:33:24PM +0200, Jean-Marc Lasgouttes wrote: Then, I changed the outline to yield the same effect. I expect some of you to hate it, but discussion is good and this is not the final design. Again, clicking several times on an element shows what is below it, around it, and so forth. If you are interested in feedback, I launched master to test outline and found that centering is somewhat annoying as I expect to see way more content following the (sub/..)section title I clicked on than above it. So I would prefer to stay to 2.3 situation. Before I revert that part, did you try to click several times on the toc entry? I personally think that it is a good way to look around cursor position. * there is some ad-hoc code that adds twice the height of a typical row before the paragraph. In passing, this means that a tall row (Chapter) will be barely shown completely. I remember that changing that has met resistance and I had to revert it. How is this useful to you? Maybe it's related to the discussion how search scrolling is done? One pushback I remember was that we lost few lines of context on top before the searched text at some point and made you scroll the context back to screen... So, what do you want t see above? The previous row of text? Two rows? Just ask, I can give it a go to see whether it works. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Wed, Sep 18, 2024 at 11:42:34AM GMT, Scott Kostyshak wrote: > On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote: > > But now using pdf your patch makes more sense. > > Sounds good. I'll apply it. Done at c7be9780. > First I will see if any new tests fail with > it though. These tests fail for me now: export/doc/ja/UserGuide_lyx16 export/doc/ja/UserGuide_lyx20 export/examples/ja/Modules/LilyPond_Book_lyx16 export/examples/ja/Modules/LilyPond_Book_lyx20 But it's not clear it's worth the time to fix them so I inverted them at 92c7c33d. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Could not find LaTeX command for character....
On Thu, Sep 19, 2024 at 04:24:21PM GMT, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 18.09.2024 um 12:49 +0200 schrieb Scott Kostyshak: > > Is this worth fixing? > > Not sure it's worth the effort. Nobody seems to have complained about > it so far, and 2.0 is quite old. > > If somebody feels like tackling it, revert_verbatim in lyx_2.1.py is to > blame. Sounds good, let's skip this then. Thanks, Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: LyX 2.4.2 Tarballs
Am Do., 19. Sept. 2024 um 17:16 Uhr schrieb Richard Kimberly Heck < rikih...@gmail.com>: > Here: > > > https://drive.google.com/drive/folders/1eRWa19xe9BwJ_jgNXg8w27JpPJChye6l?usp=sharing > > I am having trouble accessing the LyX ftp server, due to a change in my > IP. You should verify the signatures. > > We might hold off briefly on building binaries until we're sure there > are no other problems. > Compiles without issues and runs. Uploaded to my drive as usual, you may publish it as you want. -- Eugene -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: LyX 2.4.2 Tarballs
On Thu, 2024-09-19 at 11:15 -0400, Richard Kimberly Heck wrote: > Here: > > https://drive.google.com/drive/folders/1eRWa19xe9BwJ_jgNXg8w27JpPJChye6l?usp=sharing > > I am having trouble accessing the LyX ftp server, due to a change in > my > IP. You should verify the signatures. > > We might hold off briefly on building binaries until we're sure there > are no other problems. > > Riki Built this for Fedora on copr: https://copr.fedorainfracloud.org/coprs/jamatos/lyx-next/ It compiled correctly and builds and runs perfectly. :-) -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: LyX 2.4.2 Tarballs
Le 19/09/2024 à 17:15, Richard Kimberly Heck a écrit : Here: https://drive.google.com/drive/folders/1eRWa19xe9BwJ_jgNXg8w27JpPJChye6l?usp=sharing I am having trouble accessing the LyX ftp server, due to a change in my IP. You should verify the signatures. We might hold off briefly on building binaries until we're sure there are no other problems. Compiles and runs the UserGuide flawlessly on Debian bookworm with Configuration Host type: x86_64-pc-linux-gnu Special build flags: build=release callback-printing use-enchant Bundled libraries:nod C++ Compiler:g++ (12.2.0) C++ Compiler flags: -fPIC -O2 -std=c++17 C++ Compiler user flags: Linker flags: -rdynamic Linker user flags: Qt Frontend: Qt version: 5.15.8 Packaging: posix LyX binary dir: /usr/local/bin LyX files dir: /usr/local/share/lyx-2.4.2 -- Jean-Pierre -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Am Donnerstag, dem 19.09.2024 um 16:16 +0200 schrieb Jean-Marc Lasgouttes: > What I have in mind as a simpler alternative is this (like the last > patch, with vector instead of map). Seems to make sense. I have no time to look closer now, unfortunately. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Could not find LaTeX command for character....
Am Mittwoch, dem 18.09.2024 um 12:49 +0200 schrieb Scott Kostyshak: > Is this worth fixing? Not sure it's worth the effort. Nobody seems to have complained about it so far, and 2.0 is quite old. If somebody feels like tackling it, revert_verbatim in lyx_2.1.py is to blame. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Le 19/09/2024 à 15:40, Jürgen Spitzmüller a écrit :
Am Donnerstag, dem 19.09.2024 um 15:14 +0200 schrieb Jean-Marc
Lasgouttes:
But why go from a vector<> to a map<>?
Frankly: I can't remember.
What I have in mind as a simpler alternative is this (like the last
patch, with vector instead of map).
Unfortunately, I have no idea how to test it properly.
JMarc
From 8a73dd337ee3479247cee0e90db2adcbae7033ac Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes
Date: Fri, 13 Sep 2024 17:10:58 +0200
Subject: [PATCH] Use a vector instead of map
Typically, to check whether an element is present and set to true, instead of
foo.find(c) != foo.end() && foo.find(c)->second
one uses
foo[c]
This avoids puzzlement of Coverity scan when seeing that find() result
is dereferenced without checking that it is not equal to end().
Moreover, this makes the code much much clearer. I still do not
understand it, though ;)
---
src/insets/InsetTabular.cpp | 55 ++---
1 file changed, 21 insertions(+), 34 deletions(-)
diff --git a/src/insets/InsetTabular.cpp b/src/insets/InsetTabular.cpp
index a36808fd56..a5dcecd0c9 100644
--- a/src/insets/InsetTabular.cpp
+++ b/src/insets/InsetTabular.cpp
@@ -2613,7 +2613,7 @@ void Tabular::TeXTopHLine(otexstream & os, row_type row, list const &
// is done in Tabular::TeXBottomHLine(...)
// get for each column the topline (if any)
- map topline, topltrims, toprtrims;
+ vector topline(ncols()), topltrims(ncols()), toprtrims(ncols());
col_type nset = 0;
bool have_trims = false;
for (auto const & c : columns) {
@@ -2634,10 +2634,9 @@ void Tabular::TeXTopHLine(otexstream & os, row_type row, list const &
topltrims[c] = topltrims[c-1];
toprtrims[c] = toprtrims[c-1];
}
- if (topline.find(c) != topline.end() && topline.find(c)->second)
+ if (topline[c])
++nset;
- if ((topltrims.find(c) != topltrims.end() && topltrims.find(c)->second)
- || (toprtrims.find(c) != toprtrims.end() && toprtrims.find(c)->second))
+ if (topltrims[c] || toprtrims[c])
have_trims = true;
}
@@ -2669,7 +2668,7 @@ void Tabular::TeXTopHLine(otexstream & os, row_type row, list const &
if (cl < c)
continue;
c = cl;
- if (topline.find(c)->second) {
+ if (topline[c]) {
col_type offset = 0;
for (col_type j = 0 ; j < c; ++j)
if (column_info[j].alignment == LYX_ALIGN_DECIMAL)
@@ -2679,21 +2678,18 @@ void Tabular::TeXTopHLine(otexstream & os, row_type row, list const &
while (isPartOfMultiColumn(row, c))
++c;
string trim;
-if (topltrims.find(c) != topltrims.end()
- && topltrims.find(c)->second)
+if (topltrims[c])
trim = "l";
col_type cstart = c;
-for ( ; c < ncols() - 1 && topline.find(c + 1)->second ; ++c) {
+for ( ; c < ncols() - 1 && topline[c + 1] ; ++c) {
if (isMultiColumn(cellIndex(row, c))
&& c < ncols() - 1 && isPartOfMultiColumn(row, c + 1))
continue;
- if (c > cstart && topltrims.find(c) != topltrims.end()
- && topltrims.find(c)->second) {
+ if (c > cstart && topltrims[c]) {
if (!isPartOfMultiColumn(row, c))
--c;
break;
- } else if (toprtrims.find(c) != toprtrims.end()
- && toprtrims.find(c)->second)
+ } else if (toprtrims[c])
break;
}
@@ -2701,8 +2697,7 @@ void Tabular::TeXTopHLine(otexstream & os, row_type row, list const &
if (column_info[j].alignment == LYX_ALIGN_DECIMAL)
++offset;
col_type lastcol = (*it1 == *it2) ? c + 1 + offset : columns.size() - c + offset;
-if (toprtrims.find(c) != toprtrims.end()
-&& toprtrims.find(c)->second)
+if (toprtrims[c])
trim += "r";
os << cline;
@@ -2761,8 +2756,8 @@ void Tabular::TeXBottomHLine(otexstream & os, row_type row, list const
bottomltrims[c] = bottomltrims[c-1];
bottomrtrims[c] = bottomrtrims[c-1];
}
-
- nextrowset &= topline.find(c) != topline.end() && topline.find(c)->second;
+
+ nextrowset &= topline[c];
}
// combine this row's bottom lines and next row's toplines if necessary
@@ -2770,15 +2765,12 @@ void Tabular::TeXBottomHLine(otexstream & os, row_type row, list const
bool have_trims = false;
for (auto const & c : columns) {
if (!nextrowset)
- bottomline[c] = bottomline.find(c)->second || topline.find(c)->second;
- bottomltrims[c] = (bottomltrims.find(c) != bottomltrims.end() && bottomltrims.find(c)->second)
-|| (topltrims.find(c) != topltrims.end() && topltrims.find(c)->second);
- bottomrtrims[c] = (bottomrtrims.find(c) != bottomrtrims.end() && bottomrtrims.find(c)->second)
-|| (toprtrims.find(c) != toprtrims.end() && toprtrims.find(c)->second);
+ bottomline[c] |= topline[c];
+ bottomltrims[c] |= topltrims[c];
+ bottomrtrims[c] |= toprtrims[c];
if (bottomline.find(c)->second)
++nset;
- if ((bottomltrims.find(c) != bottomltrims.end() && bottomltrims.find(c)->second)
- || (bottomrtrims.find(c) != bottomrtrims.end() && bo
Re: Coverity musings
Am Donnerstag, dem 19.09.2024 um 15:14 +0200 schrieb Jean-Marc Lasgouttes: > But why go from a vector<> to a map<>? Frankly: I can't remember. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Le 15/09/2024 à 18:14, Jürgen Spitzmüller a écrit : Am Samstag, dem 14.09.2024 um 20:07 +0200 schrieb Jean-Marc Lasgouttes: Back in history, the structure was not a map but a vecor. It is used to track things like "is there a line below this cell?". I am not sure why Juergen changed it to a map To track whether the lines are trimmed (in booktabs midrule case). (returning back to this) But why go from a vector<> to a map<>? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Wed, Sep 18, 2024 at 09:58:05AM GMT, Kornel Benko wrote: > Am Tue, 17 Sep 2024 21:53:07 +0200 > schrieb Scott Kostyshak : > > > > Should be working now. > > > > Very nice! Thanks! > > > > What do you think of the attached patch? If you agree with the approach, > > can you please double-check the code carefully? Specifically, I don't > > know if my use of _err vs. _errx is correct. Feel free to adapt and > > commit. > > The idea was (I think) not to error out if export to pdflatex went wrong. For > instance if > we are using docbook only. Ah that makes sense and now I understand the previous code better. > But now using pdf your patch makes more sense. Sounds good. I'll apply it. First I will see if any new tests fail with it though. > P.S. > Thanks for the amend BTW. I only realized it because of Bash highlighting. > It probably happened while using emacs _and_ vi simultaneously > on the same file :( That does sounds like playing with some strong chemicals that don't mix ;) Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Wed, Sep 18, 2024 at 09:51:36AM GMT, Jürgen Spitzmüller wrote: > Am Dienstag, dem 17.09.2024 um 21:59 +0200 schrieb Scott Kostyshak: > > Thanks for figuring out the issue. > > > > I have no idea. I guess the question is whether to switch to a > > different font or just leave it as is? I'm not sure if Koji would > > have an idea. > > I tried Noto Serif CJK JP, but this even has more missing characters. > > I think the solution would be setting a different font for maths with > unicode-math or mathspec, but I am not familiar with those packages, > and my attempts only made things worse. I would say let's leave this one for later then if it's OK for you, since it seems complicated. I'll log your comments where we invert this test. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Dienstag, dem 17.09.2024 um 21:59 +0200 schrieb Scott Kostyshak: > Thanks for figuring out the issue. > > I have no idea. I guess the question is whether to switch to a > different font or just leave it as is? I'm not sure if Koji would > have an idea. I tried Noto Serif CJK JP, but this even has more missing characters. I think the solution would be setting a different font for maths with unicode-math or mathspec, but I am not familiar with those packages, and my attempts only made things worse. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Tue, 17 Sep 2024 21:53:07 +0200 schrieb Scott Kostyshak : > > Should be working now. > > Very nice! Thanks! > > What do you think of the attached patch? If you agree with the approach, > can you please double-check the code carefully? Specifically, I don't > know if my use of _err vs. _errx is correct. Feel free to adapt and > commit. The idea was (I think) not to error out if export to pdflatex went wrong. For instance if we are using docbook only. But now using pdf your patch makes more sense. > Scott > > [0001-ctests-exit-with-error-if-export-to-.tex-fails.patch text/x-diff (986 > Bytes)] Kornel P.S. Thanks for the amend BTW. It probably happened while using emacs _and_ vi simultaneously on the same file :( pgpf6GO33FKsj.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Tue, Sep 17, 2024 at 06:20:39PM GMT, Jürgen Spitzmüller wrote:
> Am Montag, dem 16.09.2024 um 14:33 +0200 schrieb Jürgen Spitzmüller:
> > I have also fixed most of Math, but there is a
> > remaining issue -- a NULL character (0x) somewhere which cannot
> > be displayed by the Japanese system font, I cannot figure out where.
>
> The construct that breaks is the formula
>
> \[
> \mathbf{\int_{n}^{2}f(\theta)=\Gamma}\qquad\textrm{\textbackslash
> mathbfを使用した数式}
> \]
>
> in sec. 11.2. It's the \Gamma, for that matter. If replaced by \gamma
> (though not \Delta), the document compiles.
>
> Apparently, the Japanese font chokes with this character.
>
> Ideas?
Thanks for figuring out the issue.
I have no idea. I guess the question is whether to switch to a different
font or just leave it as is? I'm not sure if Koji would have an idea.
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Tue, Sep 17, 2024 at 06:49:10PM GMT, Kornel Benko wrote:
> Am Tue, 17 Sep 2024 17:38:50 +0200
> schrieb Scott Kostyshak :
>
> > On Tue, Sep 17, 2024 at 04:12:42PM GMT, Jürgen Spitzmüller wrote:
> > > Am Dienstag, dem 17.09.2024 um 15:15 +0200 schrieb Kornel Benko:
> > > > I see the following differences between the created between *.23.lyx
> > > > and *.23.23.lyx
> > > > files
> > > > > % Added by lyx2lyx
> > > > > %% This document must be processed with xelatex or
> > > > lualatex!
> > > > > \AtBeginDocument{%
> > > > > }
> > > > With each lyx2lyx conversion added.
> > >
> > > OK, the empty addition should be avoided (although it is harmless
> > > noise). Done. The duplication on repeated conversion is difficult to
> > > avoid.
> >
> > Thanks! The tests now pass for me.
> >
> > @Kornel: I still get the following error in the log:
> >
> > -- Create the corresponding .tex file
> > "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_ob3mao/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29.tex"
> > Error: Couldn't export file
> > No information for exporting the format LaTeX (pdflatex).
> >
> > So my questions from before are still relevant. Further, it makes me
> > think that we should do something with that error code (so that if there
> > is an error in the log the test fails).
> >
> > Scott
>
> Should be working now.
Very nice! Thanks!
What do you think of the attached patch? If you agree with the approach,
can you please double-check the code carefully? Specifically, I don't
know if my use of _err vs. _errx is correct. Feel free to adapt and
commit.
Scott
From 937d0776c99c92faf26d3b73894820bf4a32401a Mon Sep 17 00:00:00 2001
From: Scott Kostyshak
Date: Tue, 17 Sep 2024 21:49:48 +0200
Subject: [PATCH] ctests: exit with error if export to .tex fails
---
development/autotests/export.cmake | 5 +
1 file changed, 5 insertions(+)
diff --git a/development/autotests/export.cmake b/development/autotests/export.cmake
index d8a737eb63..3d071105ce 100755
--- a/development/autotests/export.cmake
+++ b/development/autotests/export.cmake
@@ -283,6 +283,11 @@ if (extension MATCHES "\\.lyx$")
COMMAND ${lyx} -userdir "${LYX_TESTS_USERDIR}" -E ${_texformat} ${used_tex_file} "${LYX_SOURCE}"
RESULT_VARIABLE _errx)
endif()
+if(_errx)
+ set(_err -1)
+ Summary(_err "Exporting ${LYX_SOURCE} to format ${_texformat} failed")
+ break()
+endif()
endif()
endif()
get_md5sum(result_file_name result_md5sum _err)
--
2.43.0
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Tue, 17 Sep 2024 17:38:50 +0200
schrieb Scott Kostyshak :
> On Tue, Sep 17, 2024 at 04:12:42PM GMT, Jürgen Spitzmüller wrote:
> > Am Dienstag, dem 17.09.2024 um 15:15 +0200 schrieb Kornel Benko:
> > > I see the following differences between the created between *.23.lyx
> > > and *.23.23.lyx
> > > files
> > > > % Added by lyx2lyx
> > > > %% This document must be processed with xelatex or
> > > lualatex!
> > > > \AtBeginDocument{%
> > > > }
> > > With each lyx2lyx conversion added.
> >
> > OK, the empty addition should be avoided (although it is harmless
> > noise). Done. The duplication on repeated conversion is difficult to
> > avoid.
>
> Thanks! The tests now pass for me.
>
> @Kornel: I still get the following error in the log:
>
> -- Create the corresponding .tex file
> "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_ob3mao/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29.tex"
> Error: Couldn't export file
> No information for exporting the format LaTeX (pdflatex).
>
> So my questions from before are still relevant. Further, it makes me
> think that we should do something with that error code (so that if there
> is an error in the log the test fails).
>
> Scott
Should be working now.
Kornel
pgp4IUDygkkXn.pgp
Description: Digitale Signatur von OpenPGP
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Montag, dem 16.09.2024 um 14:33 +0200 schrieb Jürgen Spitzmüller:
> I have also fixed most of Math, but there is a
> remaining issue -- a NULL character (0x) somewhere which cannot
> be displayed by the Japanese system font, I cannot figure out where.
The construct that breaks is the formula
\[
\mathbf{\int_{n}^{2}f(\theta)=\Gamma}\qquad\textrm{\textbackslash
mathbfを使用した数式}
\]
in sec. 11.2. It's the \Gamma, for that matter. If replaced by \gamma
(though not \Delta), the document compiles.
Apparently, the Japanese font chokes with this character.
Ideas?
--
Jürgen
signature.asc
Description: This is a digitally signed message part
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Tue, Sep 17, 2024 at 04:12:42PM GMT, Jürgen Spitzmüller wrote:
> Am Dienstag, dem 17.09.2024 um 15:15 +0200 schrieb Kornel Benko:
> > I see the following differences between the created between *.23.lyx
> > and *.23.23.lyx
> > files
> > > % Added by lyx2lyx
> > > %% This document must be processed with xelatex or
> > lualatex!
> > > \AtBeginDocument{%
> > > }
> > With each lyx2lyx conversion added.
>
> OK, the empty addition should be avoided (although it is harmless
> noise). Done. The duplication on repeated conversion is difficult to
> avoid.
Thanks! The tests now pass for me.
@Kornel: I still get the following error in the log:
-- Create the corresponding .tex file
"/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_ob3mao/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29.tex"
Error: Couldn't export file
No information for exporting the format LaTeX (pdflatex).
So my questions from before are still relevant. Further, it makes me
think that we should do something with that error code (so that if there
is an error in the log the test fails).
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Outliner does not respect tree depth after removing text selection inside the section (2.4 regression)
On Tue, Sep 17, 2024 at 04:29:38PM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 17.09.2024 um 15:03 +0200 schrieb Pavel Sanda: > > - open some structured text (eg any manual) > > - set tree depth to some higher level (eg 2) by the slider in toc > > dialog > > - go inside any section, highlight the text and remove/replace it > > - the outliner tree depth gets reset to 0 irrespective of the slider > > position > > > > Works fine in 2.3; bisect in 2.4 leads to > > Please file a ticket. No time to look into it now. #13098. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Outliner does not respect tree depth after removing text selection inside the section (2.4 regression)
Am Dienstag, dem 17.09.2024 um 15:03 +0200 schrieb Pavel Sanda: > - open some structured text (eg any manual) > - set tree depth to some higher level (eg 2) by the slider in toc > dialog > - go inside any section, highlight the text and remove/replace it > - the outliner tree depth gets reset to 0 irrespective of the slider > position > > Works fine in 2.3; bisect in 2.4 leads to Please file a ticket. No time to look into it now. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Do not output empty statement in lyx2lyx reversion
Am Dienstag, dem 17.09.2024 um 14:14 + schrieb Juergen Spitzmueller: > commit 2e408d2fdccffddebcd05eb2c6ccf6e9607def61 > Author: Juergen Spitzmueller > Date: Tue Sep 17 15:53:18 2024 +0200 > > Do not output empty statement in lyx2lyx reversion Candidate for stable -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Dienstag, dem 17.09.2024 um 15:15 +0200 schrieb Kornel Benko:
> I see the following differences between the created between *.23.lyx
> and *.23.23.lyx
> files
> > % Added by lyx2lyx
> > %% This document must be processed with xelatex or
> lualatex!
> > \AtBeginDocument{%
> > }
> With each lyx2lyx conversion added.
OK, the empty addition should be avoided (although it is harmless
noise). Done. The duplication on repeated conversion is difficult to
avoid.
--
Jürgen
signature.asc
Description: This is a digitally signed message part
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Tue, 17 Sep 2024 11:43:51 +0200
schrieb Scott Kostyshak :
> On Sun, Sep 15, 2024 at 07:05:02PM GMT, Scott Kostyshak wrote:
>
> >
> > The following tests FAILED:
> > 3134 - INVERTED.TODO_export/doc/ja/UserGuide_pdf5_systemF (Failed)
> > 5020 - export/examples/es/Curricula_Vitae/Modern_CV_lyx22 (Failed)
> > 5021 - export/examples/es/Curricula_Vitae/Modern_CV_lyx23 (Failed)
>
> ^ These have been resolved.
>
> > 5719 -
> > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx20
> > (Failed) 5720 -
> > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx21
> > (Failed) 5721 -
> > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx22
> > (Failed) 5722 -
> > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx23
> > (Failed) 7410 -
> > export/templates/ja/Articles/Japanese_Article_%28JS_Bundle_for_LuaTeX%29_lyx23
> > (Failed) 7419 -
> > export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%29_lyx23
> > (Failed) 7428 -
> > export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23
> > (Failed) 7437 -
> > export/templates/ja/Books/Japanese_Book_%28JS_Bundle_for_LuaTeX%29_lyx23
> > (Failed)
> > 7446 -
> > export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%29_lyx23
> > (Failed) 7455 -
> > export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23
> > (Failed) 7476 -
> > export/templates/ja/Reports/Japanese_Report_%28JS_Bundle_for_LuaTeX%29_lyx23
> > (Failed)
> > 7485 -
> > export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%29_lyx23
> > (Failed) 7494 -
> > export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23
> > (Failed)
>
> Kornel, do the above tests fail for you also? When I look in the log I
> see the following:
>
> -- Create the corresponding .tex file
> "/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_ybegAu/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29.tex"
> Error: Couldn't export file
> No information for exporting the format LaTeX (pdflatex).
>
> I think this is an issue in our testing code. In export.cmake, we have
> "pdflatex" hardcoded:
>
> execute_process(
> COMMAND ${lyx} -userdir "${LYX_TESTS_USERDIR}" -E pdflatex
> ${used_tex_file}
> "${LYX_SOURCE}" RESULT_VARIABLE _errx)
>
> For the above tests, the default output format is PDF (LuaTeX), so
> ideally we would export to format "luatex". I don't know how to do this.
> Is the only way to parse the file for the default output format and then
> code up all of the cases, e.g., "PDF (luatex) -> luatex", "PDF (xetex) ->
> xetex",
> etc. ?
>
> By the way, I wonder if in our core LyX code it would be helpful to have
> the special format "defaulttex" which would export to the TeX language
> corresponding to the "default" format. This seems potentially useful to
> users, but I don't recall anyone requesting it so maybe not.
>
> Also, do you remember the purpose of exporting to .tex? Here is my
> guess, and I propose to add it as a comment if you think it is correct:
>
> # We export to .tex to check for bugs in our LaTeX export code. We do
> # not actually do anything with this .tex file.
>
> Scott
I see the following differences between the created between *.23.lyx and
*.23.23.lyx
files
> % Added by lyx2lyx
> %% This document must be processed with xelatex or lualatex!
> \AtBeginDocument{%
> }
With each lyx2lyx conversion added.
Kornel
pgpeaRIgqfScJ.pgp
Description: Digitale Signatur von OpenPGP
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sun, Sep 15, 2024 at 07:05:02PM GMT, Scott Kostyshak wrote:
>
> The following tests FAILED:
> 3134 - INVERTED.TODO_export/doc/ja/UserGuide_pdf5_systemF (Failed)
> 5020 - export/examples/es/Curricula_Vitae/Modern_CV_lyx22 (Failed)
> 5021 - export/examples/es/Curricula_Vitae/Modern_CV_lyx23 (Failed)
^ These have been resolved.
> 5719 -
> export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx20 (Failed)
> 5720 -
> export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx21 (Failed)
> 5721 -
> export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx22 (Failed)
> 5722 -
> export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx23 (Failed)
> 7410 -
> export/templates/ja/Articles/Japanese_Article_%28JS_Bundle_for_LuaTeX%29_lyx23
> (Failed)
> 7419 -
> export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%29_lyx23
> (Failed)
> 7428 -
> export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23
> (Failed)
> 7437 -
> export/templates/ja/Books/Japanese_Book_%28JS_Bundle_for_LuaTeX%29_lyx23
> (Failed)
> 7446 -
> export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%29_lyx23
> (Failed)
> 7455 -
> export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23
> (Failed)
> 7476 -
> export/templates/ja/Reports/Japanese_Report_%28JS_Bundle_for_LuaTeX%29_lyx23
> (Failed)
> 7485 -
> export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%29_lyx23
> (Failed)
> 7494 -
> export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23
> (Failed)
Kornel, do the above tests fail for you also? When I look in the log I
see the following:
-- Create the corresponding .tex file
"/home/scott/lyxbuilds/master-master/CMakeBuild/autotests/out-home/AbC_ybegAu/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29.tex"
Error: Couldn't export file
No information for exporting the format LaTeX (pdflatex).
I think this is an issue in our testing code. In export.cmake, we have
"pdflatex" hardcoded:
execute_process(
COMMAND ${lyx} -userdir "${LYX_TESTS_USERDIR}" -E pdflatex ${used_tex_file}
"${LYX_SOURCE}"
RESULT_VARIABLE _errx)
For the above tests, the default output format is PDF (LuaTeX), so
ideally we would export to format "luatex". I don't know how to do this.
Is the only way to parse the file for the default output format and then
code up all of the cases, e.g., "PDF (luatex) -> luatex", "PDF (xetex) ->
xetex",
etc. ?
By the way, I wonder if in our core LyX code it would be helpful to have
the special format "defaulttex" which would export to the TeX language
corresponding to the "default" format. This seems potentially useful to
users, but I don't recall anyone requesting it so maybe not.
Also, do you remember the purpose of exporting to .tex? Here is my
guess, and I propose to add it as a comment if you think it is correct:
# We export to .tex to check for bugs in our LaTeX export code. We do
# not actually do anything with this .tex file.
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Tue, Sep 17, 2024 at 09:51:54AM GMT, Jürgen Spitzmüller wrote: > Am Dienstag, dem 17.09.2024 um 08:01 +0200 schrieb Jürgen Spitzmüller: > > Am Montag, dem 16.09.2024 um 18:04 +0200 schrieb Scott Kostyshak: > > > To make sure I understand, now the following test fails for you > > > (i.e., the export succeeds)? > > > > > > ctest -R 'INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF' > > > > This looks like a problem in the polyglossia XeTeX code of Chinese. > > I'll check later. > > Actually a language nesting problem. For now, I worked around it in the > doc. Excellent, thanks! It is always a good feeling to uninvert tests. Done at e3d26bcb. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Dienstag, dem 17.09.2024 um 08:01 +0200 schrieb Jürgen Spitzmüller: > Am Montag, dem 16.09.2024 um 18:04 +0200 schrieb Scott Kostyshak: > > To make sure I understand, now the following test fails for you > > (i.e., the export succeeds)? > > > > ctest -R 'INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF' > > This looks like a problem in the polyglossia XeTeX code of Chinese. > I'll check later. Actually a language nesting problem. For now, I worked around it in the doc. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Montag, dem 16.09.2024 um 18:04 +0200 schrieb Scott Kostyshak: > To make sure I understand, now the following test fails for you > (i.e., the export succeeds)? > > ctest -R 'INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF' This looks like a problem in the polyglossia XeTeX code of Chinese. I'll check later. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mon, 16 Sep 2024 18:04:29 +0200 schrieb Scott Kostyshak : > On Mon, Sep 16, 2024 at 02:33:29PM GMT, Jürgen Spitzmüller wrote: > > Am Sonntag, dem 15.09.2024 um 19:37 +0200 schrieb Scott Kostyshak: > > > It is strange (to me) that this export succeeds (i.e., the inverted > > > test fails), but the corresponding XeTeX export fails. The LuaTeX > > > output looks fine to my eyes though. > > > > The Japanese fonts do not cover some quotation marks. No idea why only > > Xe* nags about this (maybe Lua* falls back to a suitable font). > > > > In any case, fixed. > > To make sure I understand, now the following test fails for you (i.e., the > export > succeeds)? > > ctest -R 'INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF' > > On my last test run, this test was passing. I'll try a clean build and > test run tomorrow maybe. Kornel, what is the result of the above test > for you? > > Scott Here it pass Test project /usr/BUILD/BuildLyxGitQt6.2.4local-clang15.0.7 Start 3140: INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF 1/1 Test #3140: INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF ... Passed 162.38 sec 100% tests passed, 0 tests failed out of 1 Label Time Summary: manuals:export:inverted:todo= 162.38 sec*proc (1 test) ... Probably because of missing characters in FreeSerif fonts. Kornel pgpHNnAjjvZx1.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Mon, Sep 16, 2024 at 02:33:29PM GMT, Jürgen Spitzmüller wrote: > Am Sonntag, dem 15.09.2024 um 19:37 +0200 schrieb Scott Kostyshak: > > It is strange (to me) that this export succeeds (i.e., the inverted > > test fails), but the corresponding XeTeX export fails. The LuaTeX > > output looks fine to my eyes though. > > The Japanese fonts do not cover some quotation marks. No idea why only > Xe* nags about this (maybe Lua* falls back to a suitable font). > > In any case, fixed. To make sure I understand, now the following test fails for you (i.e., the export succeeds)? ctest -R 'INVERTED.TODO_export/doc/ja/UserGuide_pdf4_systemF' On my last test run, this test was passing. I'll try a clean build and test run tomorrow maybe. Kornel, what is the result of the above test for you? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Mon, Sep 16, 2024 at 05:06:10PM GMT, Jürgen Spitzmüller wrote:
> Am Montag, dem 16.09.2024 um 16:42 +0200 schrieb Scott Kostyshak:
> > Great! These tests are failing now though:
> >
> > export/doc/ja/Additional_lyx22 (Failed)
> > export/doc/ja/Additional_lyx23 (Failed)
> > export/doc/ja/Additional_dvi (Failed)
> > UNRELIABLE.NONSTANDARD_export/doc/ja/Additional_pdf (Failed)
> > export/doc/ja/Additional_pdf3 (Failed)
> >
> > For example, I can reproduce export/doc/ja/Additional_lyx23 manually
> > with:
> >
> > lyx -e lyx23x Additional.lyx && lyx -e lyx23x Additional.23.lyx &&
> > lyx -e default Additional.23.23.lyx
> >
> > The LaTeX error I get is:
> >
> > ! LaTeX Error: Missing \begin{document}.
>
> Better now?
Yes, thanks!
At bdc6df14ed I uninverted the systemF tests corresponding to
now-successful exports of the ja Additional manual.
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Montag, dem 16.09.2024 um 16:42 +0200 schrieb Scott Kostyshak:
> Great! These tests are failing now though:
>
> export/doc/ja/Additional_lyx22 (Failed)
> export/doc/ja/Additional_lyx23 (Failed)
> export/doc/ja/Additional_dvi (Failed)
> UNRELIABLE.NONSTANDARD_export/doc/ja/Additional_pdf (Failed)
> export/doc/ja/Additional_pdf3 (Failed)
>
> For example, I can reproduce export/doc/ja/Additional_lyx23 manually
> with:
>
> lyx -e lyx23x Additional.lyx && lyx -e lyx23x Additional.23.lyx &&
> lyx -e default Additional.23.23.lyx
>
> The LaTeX error I get is:
>
> ! LaTeX Error: Missing \begin{document}.
Better now?
--
Jürgen
signature.asc
Description: This is a digitally signed message part
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Mon, Sep 16, 2024 at 02:33:29PM GMT, Jürgen Spitzmüller wrote:
> Am Sonntag, dem 15.09.2024 um 19:37 +0200 schrieb Scott Kostyshak:
> > It is strange (to me) that this export succeeds (i.e., the inverted
> > test fails), but the corresponding XeTeX export fails. The LuaTeX
> > output looks fine to my eyes though.
>
> The Japanese fonts do not cover some quotation marks. No idea why only
> Xe* nags about this (maybe Lua* falls back to a suitable font).
>
> In any case, fixed.
>
> > Note also that the Japanese Additional and Math documents fail for
> > system fonts with LuaTeX and XeTeX.
>
> Additional is fixed. I have also fixed most of Math, but there is a
> remaining issue -- a NULL character (0x) somewhere which cannot be
> displayed by the Japanese system font, I cannot figure out where.
Great! These tests are failing now though:
export/doc/ja/Additional_lyx22 (Failed)
export/doc/ja/Additional_lyx23 (Failed)
export/doc/ja/Additional_dvi (Failed)
UNRELIABLE.NONSTANDARD_export/doc/ja/Additional_pdf (Failed)
export/doc/ja/Additional_pdf3 (Failed)
For example, I can reproduce export/doc/ja/Additional_lyx23 manually with:
lyx -e lyx23x Additional.lyx && lyx -e lyx23x Additional.23.lyx && lyx -e
default Additional.23.23.lyx
The LaTeX error I get is:
! LaTeX Error: Missing \begin{document}.
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Mon, Sep 16, 2024 at 02:55:29PM GMT, Jürgen Spitzmüller wrote:
> Am Montag, dem 16.09.2024 um 12:20 +0200 schrieb Scott Kostyshak:
> > Regarding this test,
> >
> > export/examples/es/Curricula_Vitae/Modern_CV_lyx23
> >
> > I reproduce manually with:
> >
> > lyx -e lyx23x Modern_CV.lyx && lyx -e lyx23x Modern_CV.23.lyx &&
> > lyx -e default Modern_CV.23.23.lyx
> >
> > I get the following LaTeX error (although I'm not sure it gives you
> > enough information?)
> >
> > ! Extra \endcsname.
> > ...an {cvcolumnscounter}@def\endcsname
> >
> > {p{0.5\cvcolumnswidth }}\e...
>
> Fixed.
Thanks! They pass now.
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Montag, dem 16.09.2024 um 12:20 +0200 schrieb Scott Kostyshak:
> Regarding this test,
>
> export/examples/es/Curricula_Vitae/Modern_CV_lyx23
>
> I reproduce manually with:
>
> lyx -e lyx23x Modern_CV.lyx && lyx -e lyx23x Modern_CV.23.lyx &&
> lyx -e default Modern_CV.23.23.lyx
>
> I get the following LaTeX error (although I'm not sure it gives you
> enough information?)
>
> ! Extra \endcsname.
> ...an {cvcolumnscounter}@def\endcsname
>
> {p{0.5\cvcolumnswidth }}\e...
Fixed.
--
Jürgen
signature.asc
Description: This is a digitally signed message part
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Registration
On Mon, Sep 16, 2024 at 02:21:05PM +0200, Daniel wrote: > > Trac is playing tricks with me. It obfuscates the email once you log out. > > Better now? > > > > Pavel > > Yes, perfect. Thanks for report. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 19:37 +0200 schrieb Scott Kostyshak: > It is strange (to me) that this export succeeds (i.e., the inverted > test fails), but the corresponding XeTeX export fails. The LuaTeX > output looks fine to my eyes though. The Japanese fonts do not cover some quotation marks. No idea why only Xe* nags about this (maybe Lua* falls back to a suitable font). In any case, fixed. > Note also that the Japanese Additional and Math documents fail for > system fonts with LuaTeX and XeTeX. Additional is fixed. I have also fixed most of Math, but there is a remaining issue -- a NULL character (0x) somewhere which cannot be displayed by the Japanese system font, I cannot figure out where. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Registration
On 2024-09-16 13:56, Pavel Sanda wrote: On Mon, Sep 16, 2024 at 01:37:34PM +0200, Daniel wrote: Maybe I misunderstood but my browser (Firefox 130) shows the attached. Trac is playing tricks with me. It obfuscates the email once you log out. Better now? Pavel Yes, perfect. Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mon, 16 Sep 2024 14:17:57 +0200 schrieb Kornel Benko : > Am Mon, 16 Sep 2024 13:13:35 +0200 > schrieb "Jürgen Spitzmüller" : > > > Am Montag, dem 16.09.2024 um 12:50 +0200 schrieb Kornel Benko: > > > Maybe the error output on terminal when using lyx can help. Looks > > > like dvipdfm chokes. > > > > Yes, I also have these invalid font errors sometimes. I solved some of > > them by installing another version or format of the font. I think > > "virtual" fonts can cause such problems. > > > > I tried to create an mwe. Removing the Tibetan part (inside the branch) makes > the > compilation succeed. > Leaving the Tibetan part alone, the compilation part fails. > (dvipdfm chokes on _any_ tibetan char) > > > Kornel Turns out I have local tibetan fonts together with installed from package fonts-noto-extra. Removing my local fonts cured the compilation. Thanks for being patient. Kornel pgpvwB2bJ5PxW.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mon, 16 Sep 2024 13:13:35 +0200 schrieb "Jürgen Spitzmüller" : > Am Montag, dem 16.09.2024 um 12:50 +0200 schrieb Kornel Benko: > > Maybe the error output on terminal when using lyx can help. Looks > > like dvipdfm chokes. > > Yes, I also have these invalid font errors sometimes. I solved some of > them by installing another version or format of the font. I think > "virtual" fonts can cause such problems. > I tried to create an mwe. Removing the Tibetan part (inside the branch) makes the compilation succeed. Leaving the Tibetan part alone, the compilation part fails. (dvipdfm chokes on _any_ tibetan char) Kornel pgpa2uzkahe_Y.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Registration
On Mon, Sep 16, 2024 at 01:37:34PM +0200, Daniel wrote: > Maybe I misunderstood but my browser (Firefox 130) shows the attached. Trac is playing tricks with me. It obfuscates the email once you log out. Better now? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Montag, dem 16.09.2024 um 12:50 +0200 schrieb Kornel Benko: > Maybe the error output on terminal when using lyx can help. Looks > like dvipdfm chokes. Yes, I also have these invalid font errors sometimes. I solved some of them by installing another version or format of the font. I think "virtual" fonts can cause such problems. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mon, 16 Sep 2024 12:08:57 +0200 schrieb "Jürgen Spitzmüller" : > Am Montag, dem 16.09.2024 um 11:53 +0200 schrieb Kornel Benko: > > I tried, but still failing. > > Running out of ideas. The warnings are more or less harmless. Don't > know what your issue is. > Maybe the error output on terminal when using lyx can help. Looks like dvipdfm chokes. Kornel ErrorOutCompilingFromLyxGui Description: Binary data pgpHp3x54JjE1.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sun, Sep 15, 2024 at 10:31:14PM GMT, Scott Kostyshak wrote:
> On Sun, Sep 15, 2024 at 09:28:48PM GMT, Jürgen Spitzmüller wrote:
> > Am Sonntag, dem 15.09.2024 um 19:05 +0200 schrieb Scott Kostyshak:
> > > The following tests FAILED:
> >
> > I need concrete error messages, as these tests pass for me.
>
> Fair enough, I'll reproduce them and post the error messages manually
> when I can.
Regarding this test,
export/examples/es/Curricula_Vitae/Modern_CV_lyx23
I reproduce manually with:
lyx -e lyx23x Modern_CV.lyx && lyx -e lyx23x Modern_CV.23.lyx && lyx -e
default Modern_CV.23.23.lyx
I get the following LaTeX error (although I'm not sure it gives you enough
information?)
! Extra \endcsname.
...an {cvcolumnscounter}@def\endcsname
{p{0.5\cvcolumnswidth
}}\e...
Scott
signature.asc
Description: PGP signature
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Montag, dem 16.09.2024 um 11:53 +0200 schrieb Kornel Benko: > I tried, but still failing. Running out of ideas. The warnings are more or less harmless. Don't know what your issue is. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mon, 16 Sep 2024 08:49:09 +0200 schrieb "Jürgen Spitzmüller" : > Am Sonntag, dem 15.09.2024 um 19:21 +0200 schrieb Kornel Benko: > > I have > > Font : IPAMincho Regular [IPA] > > Font : IPAPMincho Regular [IPA] > > Font : IPAX0208Mincho Regular [IPA] > > Font : IPAX0208PMincho Regular [IPA] > > Font : IPAex Mincho Regular [IPA] > > Font : IPAmj Mincho Regular [IPA] > > > > but not IPAexMincho, if that may be the cause. > > I don't think so. We use this font (without space in name) in many > (most?) Japanese documents. All these do would then fail for you. > > Try again after the recent change. I tried, but still failing. I'd like to post the full log, but even the gzipped file seems big. $ ls -l supported-languages_polyglossia-XeTeX.log.gz -rw-rw-r-- 1 kornel kornel 13662 Sep 16 11:35 supported-languages_polyglossia-XeTeX.log.gz It contains no errors, but plenty of warnings like ... Package polyglossia Warning: No hyphenation patterns were loaded for (polyglossia)`albanian|breton|lao|sami' (polyglossia)I will use \language=\l@nohyphenation instead. ... Class scrartcl Warning: Trying emergency fix for bookmark level gap, (scrartcl) because toclevel of `part' (-1) (scrartcl) is more than 1 lower than currently lowest (scrartcl) known level (1). (scrartcl) Note: This fix can fail and you should load (scrartcl) package `bookmark' to avoid usage of this (scrartcl) fix on input line 737. ... LaTeX Warning: Unused global option(s): [albanian,amharic,ancientgreek,armenian,asturian,bahasa,bahasam,basque,beng ali,breton,bulgarian,churchslavic,coptic,croatian,czech,divehi,esperanto,estoni an,farsi,finnish,friulan,galician,hebrew,hindi,icelandic,interlingua,irish,japa nese,kannada,khmer,lao,latin,latvian,lithuanian,lowersorbian,malayalam,marathi, nynorsk,occitan,piedmontese,polish,polutonikogreek,portuges,romanian,romansh,sa min,sanskrit,scottish,serbian,serbianc,slovak,slovene,syriac,tamil,telugu,thai, tibetan,turkish,turkmen,ukrainian,uppersorbian,urdu,welsh]. ... LaTeX Warning: No \author given. ... xxx=MonomakhUnicode|NotoSerifDevanagari|IPAexMincho|NotoSerifKhmer|NotoSerifTamil|NotoSerifTibetan LaTeX Font Warning: Font shape `TU/xxx(0)/m/it' undefined (Font) using `TU/xxx(0)/m/n' instead on input line 248 ... Here is how much of TeX's memory you used: 29785 strings out of 474235 781329 string characters out of 5741808 1332316 words of memory out of 500 51617 multiletter control sequences out of 15000+60 565750 words of font info for 361 fonts, out of 800 for 9000 1348 hyphenation exceptions out of 8191 108i,8n,107p,10953b,624s stack positions out of 1i,1000n,2p,20b,20s Error 256 (driver return code) generating output; file supported-languages_polyglossia-XeTeX.pdf may not be valid. ... In fact, the pdf is not readable with okular. Kornel pgpcPcqOEUsRF.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Registration
On Mon, Sep 16, 2024 at 11:21:52AM +0200, Daniel wrote: > On 2024-09-13 10:44, Pavel Sanda wrote: > > On Thu, Sep 12, 2024 at 11:32:55AM +0200, Daniel wrote: > > > Are there any alternatives in the pipe? > > > > Not really, but I can improve the description to be more straightforward. > > > > Pavel > > > Thanks. What does "lyx-devel@???" stand for? lyx-de...@lyx.org? > lyx-devel@lists.lyx.org? I don't find it obvious from the description. My browser shows lyx-devel@lists.lyx.org. I put it in the same sentence so it's more clear we are talking about the mailling list). Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Registration
On 2024-09-13 10:44, Pavel Sanda wrote: On Thu, Sep 12, 2024 at 11:32:55AM +0200, Daniel wrote: Are there any alternatives in the pipe? Not really, but I can improve the description to be more straightforward. Pavel Thanks. What does "lyx-devel@…" stand for? lyx-de...@lyx.org? lyx-devel@lists.lyx.org? I don't find it obvious from the description. Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
On Sat, Sep 14, 2024 at 08:07:27PM +0200, Jean-Marc Lasgouttes wrote: > So, conveniently, the missing cells will be added and initialized to > "false". Ok, this is what I was expecting. What I was not getting is that is's actually correct to have those elements present in the structure as well, they just the default signal "off". We might pay little performance price of having map larger (thus operations on it), but that's neglibigle for 100 line table. So my only comment is that, while this is correct and convenient, comments should be added to the code so apart from coverity human readers have chance to get quickly the logic behind. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 19:21 +0200 schrieb Kornel Benko:
> I have
> Font : IPAMincho Regular [IPA]
> Font : IPAPMincho Regular [IPA]
> Font : IPAX0208Mincho Regular [IPA]
> Font : IPAX0208PMincho Regular [IPA]
> Font : IPAex Mincho Regular [IPA]
> Font : IPAmj Mincho Regular [IPA]
>
> but not IPAexMincho, if that may be the cause.
I don't think so. We use this font (without space in name) in many
(most?) Japanese documents. All these do would then fail for you.
Try again after the recent change.
> With the TL24 version of polyglossia (from Jul 15 2024) the error is
> the same.
> The next error is:
> ...
> LaTeX.cpp (867): Log line: ! Font
> \TU/NotoSansTibetan(0)/m/n/10.95=name:Noto Sans
> Tibetan:mode=node;languag LaTeX.cpp (1156): line: 1528
> Desc: Font \TU/NotoSansTibetan(0)/m/n/10.95=name:Noto Sans
> Tibetan:mode=node;languag
> Text: \begin
> {quote}
> I wasn't able to read the size data for this font,
> so I will ignore the font specification.
> [Wizards can fix TFM files using TFtoPL/PLtoTF.]
> You might try inserting a different font spec;
> e.g., type `I\font='.
>
> LaTeX.cpp (867): Log line: Inserting `polyglossia-tibt.process' in
> `pre_linebreak_filter'.
> LaTeX.cpp (867): Log line:
> LaTeX.cpp (867): Log line: LaTeX Font Warning: Font shape
> `TU/NotoSansTibetan(0)/m/it'
> undefined LaTeX.cpp (867): Log line: (Font) using
> `TU/NotoSansTibetan(0)/m/n' instead on input line 152 LaTeX.cpp
> (867): Log line: 9.
That looks like a problem with this font at your side.
> > > 3681 -
> > > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Ast
> > > roph
> > > ysics_dvi3_systemF (Failed)
> > > 3685 -
> > > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Ast
> > > roph
> > > ysics_pdf4_systemF (Failed)
> > > 3687 -
> > > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Ast
> > > roph
> > > ysics_pdf5_systemF (Failed)
> > > 6497 -
> > > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_As
> > > trop
> > > hysics_dvi3_systemF (Failed)
> > > 6501 -
> > > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_As
> > > trop
> > > hysics_pdf4_systemF (Failed)
> > > 6503 -
> > > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_As
> > > trop
> > > hysics_pdf5_systemF (Failed)
> >
> > This class does not work with polyglossia. It is hardcoded to babel
> > (and probably classic latex). I switched the package settings
> > accordingly.
>
> These are still failing.
> ...
> LaTeX.cpp (867): Log line:
> (/usr9/local/texlive/2024/texmf-
> dist/tex/generic/gettitlestring/gettitlestring. LaTeX.cpp
> (867): Log line: sty LaTeX.cpp (867): Log line: Package:
> gettitlestring 2019/12/15 v1.6
> Cleanup title references (HO) LaTeX.cpp (867): Log line:
> (/usr9/local/texlive/2024/texmf-
> dist/tex/latex/kvoptions/kvoptions.sty LaTeX.cpp (867):
> Log line: Package: kvoptions 2022-06-15 v3.15 Key value format for
> package options (HO)
> LaTeX.cpp (867): Log line: )) LaTeX.cpp (867): Log line:
> \c@section@level=\count312
> LaTeX.cpp (867): Log line:
> LaTeX.cpp (867): Log line: ! LaTeX hooks Error: Sorting rule for
> 'begindocument' hook
> applied too late. LaTeX.cpp (1156): line: 360
> Desc: LaTeX hooks Error: Sorting rule for 'begindocument' hook
> applied too late.
> Text: ...e{begindocument}{showkeys}{before}{nameref}
>
>
> LaTeX.cpp (867): Log line: You tried to set the ordering of hook
> 'begindocument' using
> LaTeX.cpp (867): Log line:
> \DeclareHookRule{begindocument}{showkeys}{before}{nameref}
> LaTeX.cpp (867): Log line: but hook 'begindocument' was already used
> as a one-time hook,
> thus sorting is LaTeX.cpp (867): Log line: no longer possible.
> Declare the rule before
> the hook is used.
Cannot reproduce this (I do have ctest reports for these files, but
these are due to diff issues in roundtrip, AFAICS)
>
> Kornel
--
Jürgen
signature.asc
Description: This is a digitally signed message part
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sun, Sep 15, 2024 at 09:28:48PM GMT, Jürgen Spitzmüller wrote: > Am Sonntag, dem 15.09.2024 um 19:05 +0200 schrieb Scott Kostyshak: > > The following tests FAILED: > > I need concrete error messages, as these tests pass for me. Fair enough, I'll reproduce them and post the error messages manually when I can. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 19:05 +0200 schrieb Scott Kostyshak: > The following tests FAILED: I need concrete error messages, as these tests pass for me. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sun, Sep 15, 2024 at 07:05:02PM GMT, Scott Kostyshak wrote: > The following tests FAILED: > 3134 - INVERTED.TODO_export/doc/ja/UserGuide_pdf5_systemF (Failed) It is strange (to me) that this export succeeds (i.e., the inverted test fails), but the corresponding XeTeX export fails. The LuaTeX output looks fine to my eyes though. Note also that the Japanese Additional and Math documents fail for system fonts with LuaTeX and XeTeX. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sun, 15 Sep 2024 18:37:14 +0200
schrieb "Jürgen Spitzmüller" :
> Am Sonntag, dem 15.09.2024 um 17:58 +0200 schrieb Kornel Benko:
> > With the latest (649c5e9b) change there are only these 10 tests
> > failing here.
>
> > The following tests FAILED:
> > 490 - DEFAULTOUTPUT_export/export/latex/languages/supported-
> > languages_polyglossia-XeTeX_pdf4_systemF (Failed)
> > 492 -
> > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported-
> > languages_polyglossia_dvi3_systemF (Failed)
> > 493 -
> > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported-
> > languages_polyglossia_pdf4_systemF (Failed)
> > 494 -
> > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported-
> > languages_polyglossia_pdf5_systemF (Failed)
>
> These don't fail for me. Do you have recent polyglossia master? If yes,
> what are the errors?
I have, but still errors.
...
LaTeX.cpp (867): Log line:
LaTeX.cpp (867): Log line: luaotfload | db : Reload initiated (formats:
otf,ttf,ttc);
reason: Font "Noto Sa LaTeX.cpp (867): Log line: ns Tibetan" not found.
LaTeX.cpp (867): Log line:
LaTeX.cpp (867): Log line: ! Package fontspec Error:
LaTeX.cpp (1156): line: 84
Desc: Package fontspec Error:
Text: \newfontfamily
\CJKfont{IPAexMincho}
LaTeX.cpp (867): Log line: A font might not be found for many reasons.
LaTeX.cpp (867): Log line: Check the spelling, where the font is installed
etc. etc.
LaTeX.cpp (867): Log line:
...
I have
Font : IPAMincho Regular [IPA]
Font : IPAPMincho Regular [IPA]
Font : IPAX0208Mincho Regular [IPA]
Font : IPAX0208PMincho Regular [IPA]
Font : IPAex Mincho Regular [IPA]
Font : IPAmj Mincho Regular [IPA]
but not IPAexMincho, if that may be the cause.
With the TL24 version of polyglossia (from Jul 15 2024) the error is the same.
The next error is:
...
LaTeX.cpp (867): Log line: ! Font \TU/NotoSansTibetan(0)/m/n/10.95=name:Noto
Sans
Tibetan:mode=node;languag LaTeX.cpp (1156): line: 1528
Desc: Font \TU/NotoSansTibetan(0)/m/n/10.95=name:Noto Sans
Tibetan:mode=node;languag
Text: \begin
{quote}
I wasn't able to read the size data for this font,
so I will ignore the font specification.
[Wizards can fix TFM files using TFtoPL/PLtoTF.]
You might try inserting a different font spec;
e.g., type `I\font='.
LaTeX.cpp (867): Log line: Inserting `polyglossia-tibt.process' in
`pre_linebreak_filter'.
LaTeX.cpp (867): Log line:
LaTeX.cpp (867): Log line: LaTeX Font Warning: Font shape
`TU/NotoSansTibetan(0)/m/it'
undefined LaTeX.cpp (867): Log line: (Font) using
`TU/NotoSansTibetan(0)/m/n' instead on input line 152 LaTeX.cpp (867): Log
line: 9.
> > 3681 -
> > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph
> > ysics_dvi3_systemF (Failed)
> > 3685 -
> > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph
> > ysics_pdf4_systemF (Failed)
> > 3687 -
> > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph
> > ysics_pdf5_systemF (Failed)
> > 6497 -
> > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop
> > hysics_dvi3_systemF (Failed)
> > 6501 -
> > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop
> > hysics_pdf4_systemF (Failed)
> > 6503 -
> > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop
> > hysics_pdf5_systemF (Failed)
>
> This class does not work with polyglossia. It is hardcoded to babel
> (and probably classic latex). I switched the package settings
> accordingly.
These are still failing.
...
LaTeX.cpp (867): Log line:
(/usr9/local/texlive/2024/texmf-dist/tex/generic/gettitlestring/gettitlestring.
LaTeX.cpp
(867): Log line: sty LaTeX.cpp (867): Log line: Package: gettitlestring
2019/12/15 v1.6
Cleanup title references (HO) LaTeX.cpp (867): Log line:
(/usr9/local/texlive/2024/texmf-dist/tex/latex/kvoptions/kvoptions.sty
LaTeX.cpp (867):
Log line: Package: kvoptions 2022-06-15 v3.15 Key value format for package
options (HO)
LaTeX.cpp (867): Log line: )) LaTeX.cpp (867): Log line:
\c@section@level=\count312
LaTeX.cpp (867): Log line:
LaTeX.cpp (867): Log line: ! LaTeX hooks Error: Sorting rule for
'begindocument' hook
applied too late. LaTeX.cpp (1156): line: 360
Desc: LaTeX hooks Error: Sorting rule for 'begindocument' hook applied too late.
Text: ...e{begindocument}{showkeys}{before}{nameref}
LaTeX.cpp (867): Log line: You tried to set the ordering of hook
'begindocument' using
LaTeX.cpp (867): Log line:
\DeclareHookRule{begindocument}{showkeys}{before}{nameref}
LaTeX.cpp (867): Log line: but hook 'begindocument' was already used as a
one-time hook,
thus sorting is LaTeX.cpp (867): Log line: no longer possible. Declare the rule
before
the hook is used.
Kornel
pgpOLQI6Bfki5.pgp
Description: Digitale Signatur von OpenPGP
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/
Re: ctests failing on current master
On Sun, Sep 15, 2024 at 06:37:14PM GMT, Jürgen Spitzmüller wrote: > Am Sonntag, dem 15.09.2024 um 17:58 +0200 schrieb Kornel Benko: > > With the latest (649c5e9b) change there are only these 10 tests > > failing here. > > > The following tests FAILED: > > 490 - DEFAULTOUTPUT_export/export/latex/languages/supported- > > languages_polyglossia-XeTeX_pdf4_systemF (Failed) > > 492 - > > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported- > > languages_polyglossia_dvi3_systemF (Failed) > > 493 - > > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported- > > languages_polyglossia_pdf4_systemF (Failed) > > 494 - > > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported- > > languages_polyglossia_pdf5_systemF (Failed) > > These don't fail for me. Do you have recent polyglossia master? If yes, > what are the errors? I don't think these were passing for me before (I am missing a font), so I can't give my data point. > > 3681 - > > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph > > ysics_dvi3_systemF (Failed) > > 3685 - > > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph > > ysics_pdf4_systemF (Failed) > > 3687 - > > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph > > ysics_pdf5_systemF (Failed) > > 6497 - > > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop > > hysics_dvi3_systemF (Failed) > > 6501 - > > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop > > hysics_pdf4_systemF (Failed) > > 6503 - > > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop > > hysics_pdf5_systemF (Failed) > > This class does not work with polyglossia. It is hardcoded to babel > (and probably classic latex). I switched the package settings > accordingly. > > -- > Jürgen Of the tests that were failing for me before, these are my current failures: The following tests FAILED: 3134 - INVERTED.TODO_export/doc/ja/UserGuide_pdf5_systemF (Failed) 5020 - export/examples/es/Curricula_Vitae/Modern_CV_lyx22 (Failed) 5021 - export/examples/es/Curricula_Vitae/Modern_CV_lyx23 (Failed) 5719 - export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx20 (Failed) 5720 - export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx21 (Failed) 5721 - export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx22 (Failed) 5722 - export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx23 (Failed) 7410 - export/templates/ja/Articles/Japanese_Article_%28JS_Bundle_for_LuaTeX%29_lyx23 (Failed) 7419 - export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%29_lyx23 (Failed) 7428 - export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23 (Failed) 7437 - export/templates/ja/Books/Japanese_Book_%28JS_Bundle_for_LuaTeX%29_lyx23 (Failed) 7446 - export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%29_lyx23 (Failed) 7455 - export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23 (Failed) 7476 - export/templates/ja/Reports/Japanese_Report_%28JS_Bundle_for_LuaTeX%29_lyx23 (Failed) 7485 - export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%29_lyx23 (Failed) 7494 - export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23 (Failed) Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 17:58 +0200 schrieb Kornel Benko: > With the latest (649c5e9b) change there are only these 10 tests > failing here. > The following tests FAILED: > 490 - DEFAULTOUTPUT_export/export/latex/languages/supported- > languages_polyglossia-XeTeX_pdf4_systemF (Failed) > 492 - > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported- > languages_polyglossia_dvi3_systemF (Failed) > 493 - > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported- > languages_polyglossia_pdf4_systemF (Failed) > 494 - > UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported- > languages_polyglossia_pdf5_systemF (Failed) These don't fail for me. Do you have recent polyglossia master? If yes, what are the errors? > 3681 - > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph > ysics_dvi3_systemF (Failed) > 3685 - > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph > ysics_pdf4_systemF (Failed) > 3687 - > UNRELIABLE.NONSTANDARD_export/examples/Articles/Astronomy_%26_Astroph > ysics_pdf5_systemF (Failed) > 6497 - > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop > hysics_dvi3_systemF (Failed) > 6501 - > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop > hysics_pdf4_systemF (Failed) > 6503 - > UNRELIABLE.NONSTANDARD_export/templates/Articles/Astronomy_%26_Astrop > hysics_pdf5_systemF (Failed) This class does not work with polyglossia. It is hardcoded to babel (and probably classic latex). I switched the package settings accordingly. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Am Samstag, dem 14.09.2024 um 20:07 +0200 schrieb Jean-Marc Lasgouttes: > Back in history, the structure was not a map but a > vecor. It is used to track things like "is there a line below > this cell?". I am not sure why Juergen changed it to a map To track whether the lines are trimmed (in booktabs midrule case). -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sun, 15 Sep 2024 17:31:53 +0200 schrieb "Jürgen Spitzmüller" : > Am Sonntag, dem 15.09.2024 um 17:15 +0200 schrieb Jürgen Spitzmüller: > > Am Sonntag, dem 15.09.2024 um 17:08 +0200 schrieb Kornel Benko: > > > That's better. Attached the remaining tests here. > > > > You don't have the Source Han Code JP font installed, right? > > > > https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.ttc > > > > But wait, I will switch to Noto Sans Mono JP instead. > With the latest (649c5e9b) change there are only these 10 tests failing here. Kornel ExportFailed Description: Binary data pgpUwlHrr9x_0.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sun, 15 Sep 2024 17:15:09 +0200 schrieb "Jürgen Spitzmüller" : > Am Sonntag, dem 15.09.2024 um 17:08 +0200 schrieb Kornel Benko: > > That's better. Attached the remaining tests here. > > You don't have the Source Han Code JP font installed, right? > > https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.ttc > I don't. Wanted to try to use only available on ubuntu. Kornel pgpaRQfnKNsZr.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 17:15 +0200 schrieb Jürgen Spitzmüller: > Am Sonntag, dem 15.09.2024 um 17:08 +0200 schrieb Kornel Benko: > > That's better. Attached the remaining tests here. > > You don't have the Source Han Code JP font installed, right? > > https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.ttc But wait, I will switch to Noto Sans Mono JP instead. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 17:08 +0200 schrieb Kornel Benko: > That's better. Attached the remaining tests here. You don't have the Source Han Code JP font installed, right? https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.ttc -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sun, 15 Sep 2024 16:02:55 +0200 schrieb "Jürgen Spitzmüller" : > Am Sonntag, dem 15.09.2024 um 15:46 +0200 schrieb Kornel Benko: > > At least these tests compiles fine if using > > Serif: Noto Serif CJK HK > > Sans: Noto Sans CJK HK > > Mono: Noto Sans CJK HK > > Not quite the correct fonts. I have added the Noto fonts for Simplified > Chinese (i.e., SC) instead. And Mono of course needs to use "Sans > Mono", not (variable) Sans. > That's better. Attached the remaining tests here. Kornel ExportFailed Description: Binary data pgpkIOg_xKMgy.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 15:46 +0200 schrieb Kornel Benko: > At least these tests compiles fine if using > Serif: Noto Serif CJK HK > Sans: Noto Sans CJK HK > Mono: Noto Sans CJK HK Not quite the correct fonts. I have added the Noto fonts for Simplified Chinese (i.e., SC) instead. And Mono of course needs to use "Sans Mono", not (variable) Sans. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sun, 15 Sep 2024 14:01:36 +0200 schrieb "Jürgen Spitzmüller" : > export/doc/zh_CN/Intro_pdf4_systemF (Failed) > export/doc/zh_CN/Intro_pdf5_systemF (Failed) At least these tests compiles fine if using Serif: Noto Serif CJK HK Sans: Noto Sans CJK HK Mono: Noto Sans CJK HK These fonts are part of package fonts-noto-cjk-extra. Kornel diff --git a/lib/doc/zh_CN/Intro.lyx b/lib/doc/zh_CN/Intro.lyx index 762040272b..21e74ad09d 100644 --- a/lib/doc/zh_CN/Intro.lyx +++ b/lib/doc/zh_CN/Intro.lyx @@ -1,7 +1,7 @@ -#LyX 2.4 created this file. For more info see https://www.lyx.org/ -\lyxformat 620 +#LyX 2.5 created this file. For more info see https://www.lyx.org/ +\lyxformat 630 \begin_document \begin_header \save_transient_properties true \origin /systemlyxdir/doc/zh_CN/ \textclass article @@ -9,16 +9,16 @@ \maintain_unincluded_children no \language chinese-simplified \language_package default \inputencoding utf8-cjk \fontencoding auto -\font_roman "lmodern" "default" -\font_sans "default" "default" -\font_typewriter "default" "default" +\font_roman "lmodern" "Noto Serif CJK HK" +\font_sans "default" "Noto Sans CJK HK" +\font_typewriter "default" "Noto Sans CJK HK" \font_math "auto" "auto" \font_default_family default -\use_non_tex_fonts false +\use_non_tex_fonts true \font_sc false \font_roman_osf false \font_sans_osf false \font_typewriter_osf false \font_sf_scale 100 100 @@ -69,10 +69,11 @@ \use_indices false \paperorientation portrait \suppress_date false \justification true \use_refstyle 0 +\use_formatted_ref 0 \use_minted 0 \use_lineno 0 \index ç´¢å¼ \shortcut idx \color #008000 pgpgwDMy3Up0s.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 14:01 +0200 schrieb Jürgen Spitzmüller: > > DEFAULTOUTPUT_export/export/latex/languages/supported- > > languages_polyglossia-XeTeX_pdf4_systemF (Failed) > > Have to look into this ... Fixed. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Samstag, dem 14.09.2024 um 23:59 +0200 schrieb Scott Kostyshak: > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > toc_pdf4_systemF (Failed) > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > toc_pdf5_systemF (Failed) > export/export/latex/languages/ja-listings-uncodable- > error_dvi3_systemF (Failed) > export/export/latex/languages/ja-listings-uncodable- > error_pdf4_systemF (Failed) > export/export/latex/languages/ja-listings-uncodable- > error_pdf5_systemF (Failed) These are most likely due to the missing font. > DEFAULTOUTPUT_export/export/latex/languages/supported- > languages_polyglossia-XeTeX_pdf4_systemF (Failed) Have to look into this ... > INVERTED.TODO_export/doc/ja/UserGuide_pdf5_systemF (Failed) Don't know. I would probably uninvert it. > export/doc/zh_CN/Intro_pdf4_systemF (Failed) > export/doc/zh_CN/Intro_pdf5_systemF (Failed) > export/doc/zh_CN/Tutorial_pdf4_systemF (Failed) > export/doc/zh_CN/Tutorial_pdf5_systemF (Failed) Fixed. You need the Noto * CJK SC fonts: https://github.com/notofonts/noto-cjk/tree/main/Sans#downloading-noto-sans-cjk > export/examples/es/Curricula_Vitae/Modern_CV_lyx22 (Failed) > export/examples/es/Curricula_Vitae/Modern_CV_lyx23 (Failed) > export/examples/es/Curricula_Vitae/Modern_CV_pdf2 (Failed) > export/examples/es/Curricula_Vitae/Modern_CV_pdf5_texF (Failed) Fixed. > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx20 > (Failed) > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx21 > (Failed) > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx22 > (Failed) > export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx23 > (Failed) > export/templates/ja/Articles/Japanese_Article_%28JS_Bundle_for_LuaTeX > %29_lyx23 (Failed) > export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_L > uaTeX%29_lyx23 (Failed) > export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_L > uaTeX%2C_vertical_Writing%29_lyx23 (Failed) > export/templates/ja/Books/Japanese_Book_%28JS_Bundle_for_LuaTeX%29_ly > x23 (Failed) > export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX% > 29_lyx23 (Failed) > export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX% > 2C_vertical_Writing%29_lyx23 (Failed) > export/templates/ja/Reports/Japanese_Report_%28JS_Bundle_for_LuaTeX%2 > 9_lyx23 (Failed) > export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_Lua > TeX%29_lyx23 (Failed) > export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_Lua > TeX%2C_vertical_Writing%29_lyx23 (Failed) Need to check ... -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Sonntag, dem 15.09.2024 um 10:30 +0200 schrieb Scott Kostyshak: > Thanks, that's easy enough. And where do I put that file? I just opened it with KFontView and hit the install button. That installed it to ~/.fonts/s/SourceHanCodeJP.ttc It seems that XeTeX does have problems with this sort of font format, so we might go for an alternative. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sun, Sep 15, 2024 at 08:58:56AM GMT, Jürgen Spitzmüller wrote: > Am Samstag, dem 14.09.2024 um 19:34 +0200 schrieb Scott Kostyshak: > > After cloning the repository, it is 262M. Probably I just need a few > > files from there? If so, can you tell me which files? > > Just this: > https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.ttc Thanks, that's easy enough. And where do I put that file? Is the following a reasonable place? "$( kpsewhich -var-value TEXMFLOCAL )"/fonts If so, where in that directory? Currently that directory contains the following for me: $ ls "$( kpsewhich -var-value TEXMFLOCAL )"/fonts afm enc map source tfm type1 vf The directory structure is as follows, but I did not find any ttc file in there so not sure where to put this file: . ./afm ./enc ./map ./source ./tfm ./type1 ./vf ./afm/omegahe8 ./afm/public ./enc/dvips ./map/dvips ./source/hebrew ./source/local ./tfm/local ./tfm/omegahe8 ./tfm/public ./type1/local ./type1/omegahe8 ./type1/public ./vf/local ./vf/public ./afm/public/culmus ./enc/dvips/culmus ./tfm/public/culmus ./type1/public/culmus ./vf/public/culmus Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Samstag, dem 14.09.2024 um 19:34 +0200 schrieb Scott Kostyshak: > After cloning the repository, it is 262M. Probably I just need a few > files from there? If so, can you tell me which files? Just this: https://github.com/adobe-fonts/source-han-code-jp/releases/download/2.012R/SourceHanCodeJP.ttc -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sat, Sep 14, 2024 at 01:27:38PM GMT, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 11.09.2024 um 17:15 +0200 schrieb Kornel Benko: > > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > > toc_pdf4_systemF > > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > > toc_pdf5_systemF > > Should be fixed. Basically appropriate non-TeX fonts needed to be set > (as presumably in some other failing systemF tests as well) > > > > export/export/latex/languages/ja-listings-uncodable- > > > error_dvi3_systemF > > > export/export/latex/languages/ja-listings-uncodable- > > > error_pdf4_systemF > > > export/export/latex/languages/ja-listings-uncodable- > > > error_pdf5_systemF > > These, for instance. Here, we need to agree on an appropriate > typewriter font that supports CJK. > > Some Japanese docs use IPAex Gothic, but that's actually not a > typewriter (monospace) font, but a sans serif. I'm not sure if it's helpful since I haven't installed the Source Han Code font yet, but the following tests fail for me on current LyX master (52157c93) and current polyglossia master (3d36fb11). Note however that my TL hasn't been updated in a couple of months, so again I'm not sure if this is helpful. There is one inverted test. If the output seems correct, then we can "uninvert" it. UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN-toc_pdf4_systemF (Failed) UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN-toc_pdf5_systemF (Failed) export/export/latex/languages/ja-listings-uncodable-error_dvi3_systemF (Failed) export/export/latex/languages/ja-listings-uncodable-error_pdf4_systemF (Failed) export/export/latex/languages/ja-listings-uncodable-error_pdf5_systemF (Failed) DEFAULTOUTPUT_export/export/latex/languages/supported-languages_polyglossia-XeTeX_pdf4_systemF (Failed) INVERTED.TODO_export/doc/ja/UserGuide_pdf5_systemF (Failed) export/doc/zh_CN/Intro_pdf4_systemF (Failed) export/doc/zh_CN/Intro_pdf5_systemF (Failed) export/doc/zh_CN/Tutorial_pdf4_systemF (Failed) export/doc/zh_CN/Tutorial_pdf5_systemF (Failed) export/examples/es/Curricula_Vitae/Modern_CV_lyx22 (Failed) export/examples/es/Curricula_Vitae/Modern_CV_lyx23 (Failed) export/examples/es/Curricula_Vitae/Modern_CV_pdf2 (Failed) export/examples/es/Curricula_Vitae/Modern_CV_pdf5_texF (Failed) export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx20 (Failed) export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx21 (Failed) export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx22 (Failed) export/examples/ja/Articles/Japanese_Article_%28JLReq_Class%29_lyx23 (Failed) export/templates/ja/Articles/Japanese_Article_%28JS_Bundle_for_LuaTeX%29_lyx23 (Failed) export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%29_lyx23 (Failed) export/templates/ja/Articles/Japanese_Article_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23 (Failed) export/templates/ja/Books/Japanese_Book_%28JS_Bundle_for_LuaTeX%29_lyx23 (Failed) export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%29_lyx23 (Failed) export/templates/ja/Books/Japanese_Book_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23 (Failed) export/templates/ja/Reports/Japanese_Report_%28JS_Bundle_for_LuaTeX%29_lyx23 (Failed) export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%29_lyx23 (Failed) export/templates/ja/Reports/Japanese_Report_%28Standard_Class_for_LuaTeX%2C_vertical_Writing%29_lyx23 (Failed) Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Le 14/09/2024 à 15:40, Pavel Sanda a écrit : Can you explain what that construct works? If I understand correctly we are changing the underlying structure and that does not feel right for "search" procedure. Apart from that if we search extensively the memory will grow as well? First, for the first question: AFAIU, the loop is always over the columns of the tabular, so that 100 elements in the structure would already be extraordinary. Back in history, the structure was not a map but a vecor. It is used to track things like "is there a line below this cell?". I am not sure why Juergen changed it to a map, but the good thing about it is that now Coverity cannot complain that a value that it read/written might be outside of bounds ;) A reasonable solution would have been a set (containing the columns that are "on", whatever this means). However, this is not convenient since there are places where the value for a column is copied the the next one. So, back to the map<>. A lot of code was like if (topline.find(c) != topline.end() && topline.find(c)->second) that is "if we have data for this column and the data is "true" do something". Coverity was complaining in places where the first part of the test was missing. All this code was safe, though. Now, the description of the [] operator says: https://en.cppreference.com/w/cpp/container/map/operator_at Inserts value_type(key, T()) if the key does not exist. [...] If an insertion is performed, the mapped value is value-initialized (default-constructed for class types, zero-initialized otherwise) and a reference to it is returned. So, conveniently, the missing cells will be added and initialized to "false". Having a vector should be equivalent and saner, except that we may have to convince Coverity that the bounds are respected. What I wrote above is my understanding of the situation. My question about it is whether I miss something. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
On Sat, Sep 14, 2024 at 02:07:55PM GMT, Jürgen Spitzmüller wrote: > Am Samstag, dem 14.09.2024 um 13:27 +0200 schrieb Jürgen Spitzmüller: > > These, for instance. Here, we need to agree on an appropriate > > typewriter font that supports CJK. > > Source Han Code seems to work well: > https://github.com/adobe-fonts/source-han-code-jp After cloning the repository, it is 262M. Probably I just need a few files from there? If so, can you tell me which files? I still wonder if there is a lighter weight way to satisfy this dependency? I'm happy to adapt if there is not an easier way. Ideally, my personal preference would be something that's in the Ubuntu repositories, but I understand if others don't give much importance to that (or if it's just not feasible). Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Le 14/09/2024 à 00:43, Richard Kimberly Heck a écrit : Do you have access to coverity? I think I did, but I do not remember how to access it. The password, etc, is probably saved in Firefox, if you just send me the URL. Have a look here. https://scan.coverity.com/projects/4164 You do have an account. The bugs of interest are the ones which are not of category "Performance". JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
On Fri, Sep 13, 2024 at 05:54:05PM +0200, Jean-Marc Lasgouttes wrote: > * still lots of places where Coverity wants us to use std::move because the > variable that is copied will not be used any more. I tend to think that we > should avoid that and reduce our use of move() to the minimum, unless > profiling shows that we have an issue. Do we have an agreement on that? No surprise, I agree. > * Places where I understand the issue, but fixing requires some work and is > a bit scary. Example in the patch below: Jürgen, could you please have a > look and tell me why we should not do that? It is too simple, I fear I am > missing something. Can you explain what that construct works? If I understand correctly we are changing the underlying structure and that does not feel right for "search" procedure. Apart from that if we search extensively the memory will grow as well? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Samstag, dem 14.09.2024 um 13:27 +0200 schrieb Jürgen Spitzmüller: > These, for instance. Here, we need to agree on an appropriate > typewriter font that supports CJK. Source Han Code seems to work well: https://github.com/adobe-fonts/source-han-code-jp -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mittwoch, dem 11.09.2024 um 17:15 +0200 schrieb Kornel Benko: > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > toc_pdf4_systemF > > UNRELIABLE.WRONG_OUTPUT_export/export/latex/CJK/zh_CN- > > toc_pdf5_systemF Should be fixed. Basically appropriate non-TeX fonts needed to be set (as presumably in some other failing systemF tests as well) > > export/export/latex/languages/ja-listings-uncodable- > > error_dvi3_systemF > > export/export/latex/languages/ja-listings-uncodable- > > error_pdf4_systemF > > export/export/latex/languages/ja-listings-uncodable- > > error_pdf5_systemF These, for instance. Here, we need to agree on an appropriate typewriter font that supports CJK. Some Japanese docs use IPAex Gothic, but that's actually not a typewriter (monospace) font, but a sans serif. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Am Freitag, dem 13.09.2024 um 17:54 +0200 schrieb Jean-Marc Lasgouttes: > Jürgen, could you please have a look and tell me why we should not do > that? It is too simple, I fear I am missing something. I do not understand if and why that works, but if you say so, I believe you. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Do not use rand() to set a BranchList id
Am Freitag, dem 13.09.2024 um 11:14 +0200 schrieb Jean-Marc Lasgouttes: > Jürgen, could you double-check this? Makes sense to me. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] use std::move() instead of copying when value is no longer used
Thanks. I would have done it otherwise. A good time to recall that "premature optimization is the root of all evil." JMarc Le 14 septembre 2024 11:01:03 GMT+02:00, "Jürgen Spitzmüller" a écrit : >Am Dienstag, dem 10.09.2024 um 15:21 +0200 schrieb Jean-Marc >Lasgouttes: >> I agree with that. However, I have not found the toggle that tells >> Coverity to skip this proposal. This is most of our reports. > >In any case, I will revert the respective commit. > >-- >Jürgen >-- >lyx-devel mailing list >lyx-devel@lists.lyx.org >http://lists.lyx.org/mailman/listinfo/lyx-devel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mittwoch, dem 11.09.2024 um 18:33 +0200 schrieb Kornel Benko: > > Oh, the Spanish docs are not using > > polyglossia... Is there a sane error > > message? > > > > ?? They pass now here. This is without the polyglossia in git, but > with updated TL24. Maybe also due to my babel options fix. -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctests failing on current master
Am Mittwoch, dem 11.09.2024 um 18:46 +0300 schrieb Udicoudco: > > export/doc/es/Tutorial_dvi3_systemF > > export/doc/es/Tutorial_pdf4_systemF > > export/doc/es/Tutorial_pdf5_systemF > > These ones are compiling fine for me after > a fix from Jürgen at 498135ef383a6e75. > Are you testing with the master branch of > polyglossia? Yes, I have fixed an issue in polyglossia. These problems should be history with an up-to-date checkout of polyglossia master. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] use std::move() instead of copying when value is no longer used
Am Dienstag, dem 10.09.2024 um 15:21 +0200 schrieb Jean-Marc Lasgouttes: > I agree with that. However, I have not found the toggle that tells > Coverity to skip this proposal. This is most of our reports. In any case, I will revert the respective commit. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
On 9/13/24 3:53 PM, Jean-Marc Lasgouttes wrote: Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the program, but am not sure of a proper fix. * Places where I do not even understand what the issue is :( Happy to have a look at some of those. Do you have access to coverity? I think I did, but I do not remember how to access it. The password, etc, is probably saved in Firefox, if you just send me the URL. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the issue, but fixing requires some work and is a bit scary. Example in the patch below: Jürgen, could you please have a look and tell me why we should not do that? It is too simple, I fear I am missing something. I suspect that the reason people did not do it that way is the one you mention: because it creates a new key value. I guess these are always initialized properly? As far as I could check, yes, bool() zero-initializes the boolean. Ans the number of new values is the number of columns of the tabular. Actually it used to be a vector at some time. * Places where I understand the program, but am not sure of a proper fix. * Places where I do not even understand what the issue is :( Happy to have a look at some of those. Do you have access to coverity? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Coverity musings
On 9/13/24 11:54 AM, Jean-Marc Lasgouttes wrote: So what remains now? * still lots of places where Coverity wants us to use std::move because the variable that is copied will not be used any more. I tend to think that we should avoid that and reduce our use of move() to the minimum, unless profiling shows that we have an issue. Do we have an agreement on that? Yes here. * Places where I understand the issue, but fixing requires some work and is a bit scary. Example in the patch below: Jürgen, could you please have a look and tell me why we should not do that? It is too simple, I fear I am missing something. I suspect that the reason people did not do it that way is the one you mention: because it creates a new key value. I guess these are always initialized properly? * Places where I understand the program, but am not sure of a proper fix. * Places where I do not even understand what the issue is :( Happy to have a look at some of those. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Do not use rand() to set a BranchList id
Le 13/09/2024 à 11:37, Pavel Sanda a écrit : On Fri, Sep 13, 2024 at 11:14:13AM +0200, Jean-Marc Lasgouttes wrote: Le 13/09/2024 ?? 11:11, Jean-Marc Lasgouttes a écrit : commit 9f40eaee15d53ce418a728d3ff3716541d35775f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:07:05 2024 +0200 Do not use rand() to set a BranchList id Use a simple counting instead, beecause Coverity complains that rand() is not safe, and counting is siimpler anyway. What does it mean rand is not safe? Thread safe? Or not necessarily giving unique result? No, Coverity mumbles about security blah blah, cryptography blah blah. Independently of that, I think that the new code makes more sense: number the lists, do not give them an arbitrary ten-digit id. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Do not use rand() to set a BranchList id
On Fri, Sep 13, 2024 at 11:14:13AM +0200, Jean-Marc Lasgouttes wrote: > Le 13/09/2024 ?? 11:11, Jean-Marc Lasgouttes a écrit : > > commit 9f40eaee15d53ce418a728d3ff3716541d35775f > > Author: Jean-Marc Lasgouttes > > Date: Fri Sep 13 11:07:05 2024 +0200 > > > > Do not use rand() to set a BranchList id > > Use a simple counting instead, beecause Coverity complains that rand() > > is not safe, and counting is siimpler anyway. What does it mean rand is not safe? Thread safe? Or not necessarily giving unique result? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Do not use rand() to set a BranchList id
Le 13/09/2024 à 11:11, Jean-Marc Lasgouttes a écrit :
commit 9f40eaee15d53ce418a728d3ff3716541d35775f
Author: Jean-Marc Lasgouttes
Date: Fri Sep 13 11:07:05 2024 +0200
Do not use rand() to set a BranchList id
Use a simple counting instead, beecause Coverity complains that rand()
is not safe, and counting is siimpler anyway.
Jürgen, could you double-check this?
JMarc
---
src/BranchList.cpp | 5 +
src/BranchList.h | 3 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/BranchList.cpp b/src/BranchList.cpp
index fc61065a4b..37e746293d 100644
--- a/src/BranchList.cpp
+++ b/src/BranchList.cpp
@@ -32,6 +32,11 @@ docstring const & Branch::branch() const
return branch_;
}
+static int list_id_generator = 0;
+
+BranchList::BranchList()
+ : separator_(from_ascii("|")), id_(++list_id_generator) {}
+
void Branch::setBranch(docstring const & s)
{
diff --git a/src/BranchList.h b/src/BranchList.h
index 7ff833650d..bd32c4db4a 100644
--- a/src/BranchList.h
+++ b/src/BranchList.h
@@ -14,7 +14,6 @@
#include "support/docstring.h"
-#include // rand()
#include
@@ -104,7 +103,7 @@ public:
typedef List::const_iterator const_iterator;
///
- BranchList() : separator_(from_ascii("|")), id_(rand()) {}
+ BranchList();
///
docstring separator() const { return separator_; }
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
