Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-05 Thread Enrico Forestieri 
On Mon, Jun 05, 2017 at 07:37:08AM +0200, Kornel Benko wrote:

> Am Montag, 5. Juni 2017 um 03:50:47, schrieb Enrico Forestieri 
> 
> > On Sun, Jun 04, 2017 at 01:08:06PM +0200, Guillaume MM wrote:
> > 
> > > Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :
> > > > On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:
> > > > 
> > > > > I am wondering since this results in a different vertical spacing.
> > > > 
> > > > No, this will not change the vertical spacing.
> > > It actually does, as shown with diffpdf.
> > 
> > I don't see any difference,
> 
> Have you used diffpdf?
> Here the snapshot of 'diffpdf -a'

The old code was wrong.

-- 
Enrico

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Kornel Benko 
Am Montag, 5. Juni 2017 um 03:50:47, schrieb Enrico Forestieri 
> On Sun, Jun 04, 2017 at 01:08:06PM +0200, Guillaume MM wrote:
>
> > Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :
> > > On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:
> > >
> > > > I am wondering since this results in a different vertical spacing.
> > >
> > > No, this will not change the vertical spacing.
> > It actually does, as shown with diffpdf.
>
> I don't see any difference,

Have you used diffpdf?
Here the snapshot of 'diffpdf -a'

> but, if it is so, then the commit corrected
> another bug. If there is no size change between paragraphs, adding
> {\small\par} is gratuitous.
>

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Enrico Forestieri 
On Sun, Jun 04, 2017 at 01:08:06PM +0200, Guillaume MM wrote:

> Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :
> > On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:
> > 
> > > I am wondering since this results in a different vertical spacing.
> > 
> > No, this will not change the vertical spacing.
> It actually does, as shown with diffpdf.

I don't see any difference, but, if it is so, then the commit corrected
another bug. If there is no size change between paragraphs, adding
{\small\par} is gratuitous.

-- 
Enrico

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Scott Kostyshak 
On Sun, Jun 04, 2017 at 12:33:10PM +0200, Kornel Benko wrote:

> All of the above pass here now.

+1 All ctests are back to where they were before.

Scott

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Guillaume MM 

Le 04/06/2017 à 02:27, Enrico Forestieri a écrit :

On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:


I am wondering since this results in a different vertical spacing.


No, this will not change the vertical spacing.

It actually does, as shown with diffpdf.

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-04 Thread Kornel Benko 
Am Sonntag, 4. Juni 2017 um 03:15:42, schrieb Enrico Forestieri 
> On Sun, Jun 04, 2017 at 02:17:20AM +0200, Enrico Forestieri wrote:
> 
> > On Sat, Jun 03, 2017 at 05:25:44PM -0400, Scott Kostyshak wrote:
> > 
> > > On Sat, Jun 03, 2017 at 05:26:52PM +0200, Enrico Forestieri wrote:
> > > > commit 55bbd67cde18184082b074f669a6b81cc48257b6
> > > > Author: Enrico Forestieri 
> > > > Date:   Sat Jun 3 17:26:05 2017 +0200
> > > > 
> > > > Fix bugs #10650 and #9598
> > > 
> > > I think this commit broke the following tests:
> > > 
> > > export/doc/de/Additional_dvi (Failed)
> > > export/doc/de/Additional_dvi3_texF (Failed)
> > > export/doc/de/Additional_pdf (Failed)
> > > DEFAULTOUTPUT_export/doc/de/Additional_pdf2 (Failed)
> > > export/doc/de/Additional_pdf3 (Failed)
> > > export/doc/de/Additional_pdf5_texF (Failed)
> > > export/doc/es/Additional_dvi (Failed)
> > > UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_dvi3_texF (Failed)
> > > export/doc/es/Additional_pdf (Failed)
> > > DEFAULTOUTPUT_export/doc/es/Additional_pdf2 (Failed)
> > > export/doc/es/Additional_pdf3 (Failed)
> > > UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_pdf5_texF (Failed)
> > > 
> > > When exporting de/Additional manually to pdflatex, I get the following 
> > > error:
> > > 
> > > ! Paragraph ended before \foreignlanguage  was complete.
> > 
> > Thanks, I'll have a look.
> 
> Please, can you try again?
> 

All of the above pass here now.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-03 Thread Enrico Forestieri 
On Sun, Jun 04, 2017 at 02:17:20AM +0200, Enrico Forestieri wrote:

> On Sat, Jun 03, 2017 at 05:25:44PM -0400, Scott Kostyshak wrote:
> 
> > On Sat, Jun 03, 2017 at 05:26:52PM +0200, Enrico Forestieri wrote:
> > > commit 55bbd67cde18184082b074f669a6b81cc48257b6
> > > Author: Enrico Forestieri 
> > > Date:   Sat Jun 3 17:26:05 2017 +0200
> > > 
> > > Fix bugs #10650 and #9598
> > 
> > I think this commit broke the following tests:
> > 
> > export/doc/de/Additional_dvi (Failed)
> > export/doc/de/Additional_dvi3_texF (Failed)
> > export/doc/de/Additional_pdf (Failed)
> > DEFAULTOUTPUT_export/doc/de/Additional_pdf2 (Failed)
> > export/doc/de/Additional_pdf3 (Failed)
> > export/doc/de/Additional_pdf5_texF (Failed)
> > export/doc/es/Additional_dvi (Failed)
> > UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_dvi3_texF (Failed)
> > export/doc/es/Additional_pdf (Failed)
> > DEFAULTOUTPUT_export/doc/es/Additional_pdf2 (Failed)
> > export/doc/es/Additional_pdf3 (Failed)
> > UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_pdf5_texF (Failed)
> > 
> > When exporting de/Additional manually to pdflatex, I get the following 
> > error:
> > 
> > ! Paragraph ended before \foreignlanguage  was complete.
> 
> Thanks, I'll have a look.

Please, can you try again?

-- 
Enrico

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-03 Thread Enrico Forestieri 
On Sat, Jun 03, 2017 at 11:27:25PM +0200, Guillaume MM wrote:

> Le 03/06/2017 à 17:26, Enrico Forestieri a écrit :
> > commit 55bbd67cde18184082b074f669a6b81cc48257b6
> > Author: Enrico Forestieri 
> > Date:   Sat Jun 3 17:26:05 2017 +0200
> > 
> >  Fix bugs #10650 and #9598
> 
> Hi Enrico,
> 
> It seems that the above commit changes the output of the attached file.

Yes, it changes the latex code but not the typeset output.

> Before:
> 
> \documentclass{scrartcl}
> \begin{document}
> \begin{abstract}
> Lorem
> \begin{itemize}
> \item Ipsum{\small \par}
> \item Dolor{\small \par}
> \end{itemize}
> \end{abstract}
> \end{document}
> 
> After:
> 
> \documentclass{scrartcl}
> \begin{document}
> \begin{abstract}
> Lorem
> \begin{itemize}
> \item Ipsum
> \item Dolor
> \end{itemize}
> \end{abstract}
> \end{document}
> 
> Note that the font size of the abstract is small.

Exactly. If you look at the LyX code, the font size is not changed
anywhere. Thus, everything is typeset in small size and there is
no need for {\small\par}. The old code was outputting it, but it
is superfluous.

> I am wondering since this results in a different vertical spacing. Is
> this change intended? Which one is the desired output (I am not certain
> about the first one)?

No, this will not change the vertical spacing. Moreover, if you try
changing the size of the text from small to some other size, you will see
that the old and new code are doing the same thing. Only that the new one
seems to be smarter.

-- 
Enrico

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-03 Thread Enrico Forestieri 
On Sat, Jun 03, 2017 at 05:25:44PM -0400, Scott Kostyshak wrote:

> On Sat, Jun 03, 2017 at 05:26:52PM +0200, Enrico Forestieri wrote:
> > commit 55bbd67cde18184082b074f669a6b81cc48257b6
> > Author: Enrico Forestieri 
> > Date:   Sat Jun 3 17:26:05 2017 +0200
> > 
> > Fix bugs #10650 and #9598
> 
> I think this commit broke the following tests:
> 
> export/doc/de/Additional_dvi (Failed)
> export/doc/de/Additional_dvi3_texF (Failed)
> export/doc/de/Additional_pdf (Failed)
> DEFAULTOUTPUT_export/doc/de/Additional_pdf2 (Failed)
> export/doc/de/Additional_pdf3 (Failed)
> export/doc/de/Additional_pdf5_texF (Failed)
> export/doc/es/Additional_dvi (Failed)
> UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_dvi3_texF (Failed)
> export/doc/es/Additional_pdf (Failed)
> DEFAULTOUTPUT_export/doc/es/Additional_pdf2 (Failed)
> export/doc/es/Additional_pdf3 (Failed)
> UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_pdf5_texF (Failed)
> 
> When exporting de/Additional manually to pdflatex, I get the following error:
> 
> ! Paragraph ended before \foreignlanguage  was complete.

Thanks, I'll have a look.

-- 
Enrico

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-03 Thread Guillaume MM 

Le 03/06/2017 à 17:26, Enrico Forestieri a écrit :

commit 55bbd67cde18184082b074f669a6b81cc48257b6
Author: Enrico Forestieri 
Date:   Sat Jun 3 17:26:05 2017 +0200

 Fix bugs #10650 and #9598


Hi Enrico,

It seems that the above commit changes the output of the attached file.

Before:

\documentclass{scrartcl}
\begin{document}
\begin{abstract}
Lorem
\begin{itemize}
\item Ipsum{\small \par}
\item Dolor{\small \par}
\end{itemize}
\end{abstract}
\end{document}

After:

\documentclass{scrartcl}
\begin{document}
\begin{abstract}
Lorem
\begin{itemize}
\item Ipsum
\item Dolor
\end{itemize}
\end{abstract}
\end{document}

Note that the font size of the abstract is small.

I am wondering since this results in a different vertical spacing. Is
this change intended? Which one is the desired output (I am not certain
about the first one)?



small-par.lyx
Description: application/lyx

Re: [LyX/master] Fix bugs #10650 and #9598

2017-06-03 Thread Scott Kostyshak 
On Sat, Jun 03, 2017 at 05:26:52PM +0200, Enrico Forestieri wrote:
> commit 55bbd67cde18184082b074f669a6b81cc48257b6
> Author: Enrico Forestieri 
> Date:   Sat Jun 3 17:26:05 2017 +0200
> 
> Fix bugs #10650 and #9598

I think this commit broke the following tests:

export/doc/de/Additional_dvi (Failed)
export/doc/de/Additional_dvi3_texF (Failed)
export/doc/de/Additional_pdf (Failed)
DEFAULTOUTPUT_export/doc/de/Additional_pdf2 (Failed)
export/doc/de/Additional_pdf3 (Failed)
export/doc/de/Additional_pdf5_texF (Failed)
export/doc/es/Additional_dvi (Failed)
UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_dvi3_texF (Failed)
export/doc/es/Additional_pdf (Failed)
DEFAULTOUTPUT_export/doc/es/Additional_pdf2 (Failed)
export/doc/es/Additional_pdf3 (Failed)
UNRELIABLE.WRONG_OUTPUT_export/doc/es/Additional_pdf5_texF (Failed)

When exporting de/Additional manually to pdflatex, I get the following error:

! Paragraph ended before \foreignlanguage  was complete.

Scott


signature.asc
Description: PGP signature