Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > ATM there is no way to inhibit completion but you can set "minimum > characters for words that should be completed" to 100 to effectively > disable the feature. Ok, I see, my misconception was that completion somehow uses spellcheck dictionary. This explains why I found the behaviour puzzling... Pavel
Re: [LyX/master] Unbreak completion in text mode
Le 03/07/2018 à 17:44, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Could you give me a step-by-step example where triangle does not appear before you switch tab? Super easy, just launch lyx, create new file, write "hel" and no triangle. This is normal, since completion is done according to other words present in documents Open the example with figure+note, edit the note, triangle appears. Because "help" appears somewhere, right? Go back to tab1, hit enter and write "hel" again. The triangle is there now. Yes, the word "help" from the other tab is used to propose a completion. ATM there is no way to inhibit completion but you can set "minimum characters for words that should be completed" to 100 to effectively disable the feature. JMarc
Re: [LyX/master] Unbreak completion in text mode
Le 04/07/2018 à 04:40, Richard Kimberly Heck a écrit : On 07/03/2018 07:18 PM, Pavel Sanda wrote: Jean-Marc Lasgouttes wrote: Le 03/07/2018 ?? 15:01, Pavel Sanda a écrit : So it might be that indentation vs completion issue was here always, but for some reason the new patch enables (by default disabled) completion even for users like me who never used it in the text... Now in texted in master, completion is off when there is a selection. Let's go to the next problem now :) I can confirm that the problem is fixed now. I vote for backporting if Riki agrees. If JMarc thinks it is ok. I just backported it. JMarc
Re: [LyX/master] Unbreak completion in text mode
On 07/03/2018 07:18 PM, Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: >> Le 03/07/2018 ?? 15:01, Pavel Sanda a écrit : >>> So it might be that indentation vs completion issue was here always, >>> but for some reason the new patch enables (by default disabled) completion >>> even for users like me who never used it in the text... >> Now in texted in master, completion is off when there is a selection. Let's >> go to the next problem now :) > I can confirm that the problem is fixed now. > I vote for backporting if Riki agrees. If JMarc thinks it is ok. Riki
Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > Le 03/07/2018 ?? 15:01, Pavel Sanda a écrit : >> So it might be that indentation vs completion issue was here always, >> but for some reason the new patch enables (by default disabled) completion >> even for users like me who never used it in the text... > > Now in texted in master, completion is off when there is a selection. Let's > go to the next problem now :) I can confirm that the problem is fixed now. I vote for backporting if Riki agrees. Thanks, Pavel
Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > Are you sure this did not happen in 2.3.0 or 2.2.x? I did more testing now and you are right, the commit in question does not introduce the problem I reported. Not sure where my initial testing went wrong. Pavel
Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > Could you give me a step-by-step example where triangle does not appear > before you switch tab? Super easy, just launch lyx, create new file, write "hel" and no triangle. Open the example with figure+note, edit the note, triangle appears. Go back to tab1, hit enter and write "hel" again. The triangle is there now. Pavel
Re: [LyX/master] Unbreak completion in text mode
Le 03/07/2018 à 15:01, Pavel Sanda a écrit : I have disabled Automatic inline completion for text in Preferences. I create first new document and no completion rtiangle is there. I open different document with that figure+note I used to show the triangle painting problem recently and suddenly the triangle appears. I switch back to the first document and triangle for completion appears as well! Disabling automatic completion does not disable the triangle, only the completion shown in gray. So it is normal that you see the triangle, even though you do not like it. We do not have a way to completely disable completion. The only bug that I see is that the triangle doe snot appear right away. Could you give me a step-by-step example where triangle does not appear before you switch tab? JMarc
Re: [LyX/master] Unbreak completion in text mode
Le 03/07/2018 à 15:01, Pavel Sanda a écrit : So it might be that indentation vs completion issue was here always, but for some reason the new patch enables (by default disabled) completion even for users like me who never used it in the text... Now in texted in master, completion is off when there is a selection. Let's go to the next problem now :) JMarc
Re: [LyX/master] Unbreak completion in text mode
Le 03/07/2018 à 15:01, Pavel Sanda a écrit : I am puzzled by the completion behaviour in the current master. I have disabled Automatic inline completion for text in Preferences. I create first new document and no completion rtiangle is there. I open different document with that figure+note I used to show the triangle painting problem recently and suddenly the triangle appears. I switch back to the first document and triangle for completion appears as well! So it might be that indentation vs completion issue was here always, but for some reason the new patch enables (by default disabled) completion even for users like me who never used it in the text... Rings a bell? It does not ring a bell as in "I know what to do", but at least it makes more sense. Please open two separate tickets. I will have some time during this month and I will try to work through the list of thing to do. JMarc
Re: [LyX/master] Unbreak completion in text mode
On 03/07/2018 12:25, Jean-Marc Lasgouttes wrote: Le 03/07/2018 à 12:24, Daniel a écrit : On 14/06/2018 17:46, Pavel Sanda wrote: Could we disable completion when the cursor stands at the end of selected text, so the lfun for nesting in command-sequence takes priority over completion? The cursor can be at the beginning of a selection and still I would expect it to behave the same as if it would at the end of a selection. So you mean that completion should be disabled if there is a selection? That makes sense. I didn't know which exact feature the discussion was about. I just noted that LyX has a cursor position when text is selected (maybe oddly but as in Libre Office). So my point was just concerning consistency. :) Daniel
Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > Le 03/07/2018 ?? 10:32, Pavel Sanda a écrit : >> Well, this is design question. Should nesting have priority over completion >> or not? I think it's fine if completion wins in case you are in the middle >> of writing some word. But clearly you doing something different when the >> block is selected. > > I can easily do this selection change. However, I am very surprised that this > is related to my recent change. Are you sure this did not happen in 2.3.0 or > 2.2.x? I am puzzled by the completion behaviour in the current master. I have disabled Automatic inline completion for text in Preferences. I create first new document and no completion rtiangle is there. I open different document with that figure+note I used to show the triangle painting problem recently and suddenly the triangle appears. I switch back to the first document and triangle for completion appears as well! So it might be that indentation vs completion issue was here always, but for some reason the new patch enables (by default disabled) completion even for users like me who never used it in the text... Rings a bell? Pavel
Re: [LyX/master] Unbreak completion in text mode
Le 03/07/2018 à 12:24, Daniel a écrit : On 14/06/2018 17:46, Pavel Sanda wrote: Could we disable completion when the cursor stands at the end of selected text, so the lfun for nesting in command-sequence takes priority over completion? The cursor can be at the beginning of a selection and still I would expect it to behave the same as if it would at the end of a selection. So you mean that completion should be disabled if there is a selection? That makes sense. JMarc
Re: [LyX/master] Unbreak completion in text mode
On 14/06/2018 17:46, Pavel Sanda wrote: Could we disable completion when the cursor stands at the end of selected text, so the lfun for nesting in command-sequence takes priority over completion? The cursor can be at the beginning of a selection and still I would expect it to behave the same as if it would at the end of a selection. Daniel
Re: [LyX/master] Unbreak completion in text mode
Le 03/07/2018 à 10:32, Pavel Sanda a écrit : Well, this is design question. Should nesting have priority over completion or not? I think it's fine if completion wins in case you are in the middle of writing some word. But clearly you doing something different when the block is selected. I can easily do this selection change. However, I am very surprised that this is related to my recent change. Are you sure this did not happen in 2.3.0 or 2.2.x? JMarc
Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > Le 02/07/2018 ?? 22:59, Pavel Sanda a écrit : >> Pavel Sanda wrote: >>> Often now when you hit tab completion menu appears instead of nesting >>> which is annoying. Could we disable completion when the cursor stands >>> at the end of selected text, so the lfun for nesting in command-sequence >>> takes priority over completion? >> Should I file it on bugzilla or are you still on the track? > > Please file a bug. Is it really only when there is a selection? Well, this is design question. Should nesting have priority over completion or not? I think it's fine if completion wins in case you are in the middle of writing some word. But clearly you doing something different when the block is selected. Pavel
Re: [LyX/master] Unbreak completion in text mode
Le 02/07/2018 à 22:59, Pavel Sanda a écrit : Pavel Sanda wrote: Often now when you hit tab completion menu appears instead of nesting which is annoying. Could we disable completion when the cursor stands at the end of selected text, so the lfun for nesting in command-sequence takes priority over completion? Should I file it on bugzilla or are you still on the track? Please file a bug. Is it really only when there is a selection? JMarc
Re: [LyX/master] Unbreak completion in text mode
Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: > > commit f1ea7fee5cda3fbbeb9fdbb8bec2bd91c0745e56 > > Author: Jean-Marc Lasgouttes > > Date: Fri Jun 8 10:32:47 2018 +0200 > > > > Unbreak completion in text mode > > > > Completion uses a complicated async scheme based on timers to update > > itself. This is probably not necessary anymore and is fragile to > > event order changes. > > > > This is what happens with the new painting scheme. Therefore the > > asyncHideXXX() methods have to be made more robust and detect whether > > completion state has changed by the time they are triggered. > > I am afraid I see new regression with this code. > > When you select couple itemized paragraphs and hit tab, it used to > add one nesting level so you can easily structure itemized environment. > > Often now when you hit tab completion menu appears instead of nesting > which is annoying. Could we disable completion when the cursor stands > at the end of selected text, so the lfun for nesting in command-sequence > takes priority over completion? Should I file it on bugzilla or are you still on the track? Pavel
Re: [LyX/master] Unbreak completion in text mode
Jean-Marc Lasgouttes wrote: > commit f1ea7fee5cda3fbbeb9fdbb8bec2bd91c0745e56 > Author: Jean-Marc Lasgouttes > Date: Fri Jun 8 10:32:47 2018 +0200 > > Unbreak completion in text mode > > Completion uses a complicated async scheme based on timers to update > itself. This is probably not necessary anymore and is fragile to > event order changes. > > This is what happens with the new painting scheme. Therefore the > asyncHideXXX() methods have to be made more robust and detect whether > completion state has changed by the time they are triggered. I am afraid I see new regression with this code. When you select couple itemized paragraphs and hit tab, it used to add one nesting level so you can easily structure itemized environment. Often now when you hit tab completion menu appears instead of nesting which is annoying. Could we disable completion when the cursor stands at the end of selected text, so the lfun for nesting in command-sequence takes priority over completion? Pavel
