Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-08-07 Thread Scott Kostyshak
On Sat, Aug 06, 2022 at 05:44:06PM +0200, jspi...@gmail.com wrote:
> Am Dienstag, dem 26.07.2022 um 10:25 -0400 schrieb Scott Kostyshak:
> > See the attached example. The text "text part 2" is output as bold in
> > 2.3.x, but is not output as bold in master (although it is displayed
> > as bold in the LyX display).
> 
> Should be fixed at 8ac177f656da9db2 as far as I can tell. But since
> this is so tricky to track, testing would be very welcome.

Thanks, Jürgen. The font switches indeed seem very tricky.

I did a few quick tests and it works well from what I can see. I'll be testing 
master.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-08-06 Thread jspitzm
Am Dienstag, dem 26.07.2022 um 10:25 -0400 schrieb Scott Kostyshak:
> See the attached example. The text "text part 2" is output as bold in
> 2.3.x, but is not output as bold in master (although it is displayed
> as bold in the LyX display).

Should be fixed at 8ac177f656da9db2 as far as I can tell. But since
this is so tricky to track, testing would be very welcome.

Thanks,
Jürgen


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-27 Thread Kornel Benko
Am Wed, 27 Jul 2022 07:16:02 -0400
schrieb Scott Kostyshak :

> On Tue, Jul 26, 2022 at 09:38:21PM +0200, Jean-Marc Lasgouttes wrote:
> > 
> > Le 26/07/2022 à 16:25, Scott Kostyshak a écrit :  
> > > See the attached example. The text "text part 2" is output as bold in 
> > > 2.3.x, but is
> > > not output as bold in master (although it is displayed as bold in the LyX 
> > > display).
> > > 
> > > I can bisect if it would be worth the time.  
> > 
> > Note that it works if a character is inserted before the branch (it will be
> > bold obviously)
> > 
> > A bisect may be useful. It might be that it ends up pointing to 0789f2f2,
> > but I am not sure why (yet).  
> 
> Bisect of this example leads here:
> 
>   commit 28dd7b7de3527638ea8772815ec27439f87fddda
>   Author: Juergen Spitzmueller 
>   Date:   Fri Feb 4 17:24:16 2022 +0100
>   
>   Do not set open_font true if none was open
> 
> I have no idea if that commit just triggered an underlying root issue though.
> 
> Scott

The produced pdf with lyx2.4 is (as it should be) OK, the display in lyx is 
wrong.

The sequence in mwe.23.lyx reads

\series bold
\lang american
Text part 1...

\series default
text part 2
\end_layout

Kornel


pgpYzdWoHpCPb.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-27 Thread Scott Kostyshak
On Tue, Jul 26, 2022 at 09:38:21PM +0200, Jean-Marc Lasgouttes wrote:
> 
> Le 26/07/2022 à 16:25, Scott Kostyshak a écrit :
> > See the attached example. The text "text part 2" is output as bold in 
> > 2.3.x, but is not output as bold in master (although it is displayed as 
> > bold in the LyX display).
> > 
> > I can bisect if it would be worth the time.
> 
> Note that it works if a character is inserted before the branch (it will be
> bold obviously)
> 
> A bisect may be useful. It might be that it ends up pointing to 0789f2f2,
> but I am not sure why (yet).

Bisect of this example leads here:

  commit 28dd7b7de3527638ea8772815ec27439f87fddda
  Author: Juergen Spitzmueller 
  Date:   Fri Feb 4 17:24:16 2022 +0100
  
  Do not set open_font true if none was open

I have no idea if that commit just triggered an underlying root issue though.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-27 Thread Kornel Benko
Am Tue, 26 Jul 2022 21:38:21 +0200
schrieb Jean-Marc Lasgouttes :

> Le 26/07/2022 à 16:25, Scott Kostyshak a écrit :
> > See the attached example. The text "text part 2" is output as bold in 
> > 2.3.x, but is
> > not output as bold in master (although it is displayed as bold in the LyX 
> > display).
> > 
> > I can bisect if it would be worth the time.  
> 
> Note that it works if a character is inserted before the branch (it will 
> be bold obviously)

Works also with empty ERT instead of character.

> A bisect may be useful. It might be that it ends up pointing to 
> 0789f2f2, but I am not sure why (yet).
> 
> JMarc

Kornel


pgpL8IbgEthXf.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-26 Thread Daniel

On 2022-07-26 21:19, Scott Kostyshak wrote:

On Tue, Jul 26, 2022 at 04:31:13PM +0200, Daniel wrote:

On 2022-07-26 16:25, Scott Kostyshak wrote:

See the attached example. The text "text part 2" is output as bold in 2.3.x, 
but is not output as bold in master (although it is displayed as bold in the LyX display).

I can bisect if it would be worth the time.

Scott


For some reason, I cannot open the attached document (neither 2.3 nor 2.4):
".../mwe.23.lyx is not a readable LyX document".


Strange. I wonder if it's an encoding thing.

Scott


I should have looked at the content of the file. It contains the whole 
email as text including the attachment. Somehow Thunderbird is gone 
rogue. I should stop using their beta software. Sorry for the noise.


Daniel



--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-26 Thread Jean-Marc Lasgouttes


Le 26/07/2022 à 16:25, Scott Kostyshak a écrit :

See the attached example. The text "text part 2" is output as bold in 2.3.x, 
but is not output as bold in master (although it is displayed as bold in the LyX display).

I can bisect if it would be worth the time.


Note that it works if a character is inserted before the branch (it will 
be bold obviously)


A bisect may be useful. It might be that it ends up pointing to 
0789f2f2, but I am not sure why (yet).


JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-26 Thread Stephan Witt


> Am 26.07.2022 um 21:19 schrieb Scott Kostyshak :
> 
> On Tue, Jul 26, 2022 at 04:31:13PM +0200, Daniel wrote:
>> On 2022-07-26 16:25, Scott Kostyshak wrote:
>>> See the attached example. The text "text part 2" is output as bold in 
>>> 2.3.x, but is not output as bold in master (although it is displayed as 
>>> bold in the LyX display).
>>> 
>>> I can bisect if it would be worth the time.
>>> 
>>> Scott
>> 
>> For some reason, I cannot open the attached document (neither 2.3 nor 2.4):
>> ".../mwe.23.lyx is not a readable LyX document".
> 
> Strange. I wonder if it's an encoding thing.
> 
> Scott

I have no problem to open it with LyX-2.3.6.1 MacOS version and with 
LyX-2.4.0dev.

I can confirm the different PDF output with TeX Live 2020.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-26 Thread Scott Kostyshak
On Tue, Jul 26, 2022 at 04:31:13PM +0200, Daniel wrote:
> On 2022-07-26 16:25, Scott Kostyshak wrote:
> > See the attached example. The text "text part 2" is output as bold in 
> > 2.3.x, but is not output as bold in master (although it is displayed as 
> > bold in the LyX display).
> > 
> > I can bisect if it would be worth the time.
> > 
> > Scott
> 
> For some reason, I cannot open the attached document (neither 2.3 nor 2.4):
> ".../mwe.23.lyx is not a readable LyX document".

Strange. I wonder if it's an encoding thing.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-26 Thread john kennan
On Tue, Jul 26, 2022 at 7:26 AM Scott Kostyshak  wrote:

> See the attached example. The text "text part 2" is output as bold in
> 2.3.x, but is not output as bold in master (although it is displayed as
> bold in the LyX display).
>
> I can bisect if it would be worth the time.
>
> Scott
>
>
looks ok in 2.4.0-alpha3

John
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Toggled text inside a bold inset is output differently on master than 2.3.x

2022-07-26 Thread Daniel

On 2022-07-26 16:25, Scott Kostyshak wrote:

See the attached example. The text "text part 2" is output as bold in 2.3.x, 
but is not output as bold in master (although it is displayed as bold in the LyX display).

I can bisect if it would be worth the time.

Scott


For some reason, I cannot open the attached document (neither 2.3 nor 
2.4): ".../mwe.23.lyx is not a readable LyX document".


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel