Re: ctest ca/Intro_docbook5 now failing
On Mon, Sep 25, 2023 at 12:57:40AM -0400, Scott Kostyshak wrote: > On Mon, Sep 25, 2023 at 05:27:47AM +0200, Thibaut Cuvelier wrote: > > On Mon, 18 Sept 2023 at 02:43, Thibaut Cuvelier wrote: > > > > > On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak wrote: > > > > > >> On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: > > >> > Recently (I think due to the ca/Intro changes) the following test > > >> started to fail: > > >> > > > >> > export/doc/ca/Intro_docbook5 > > >> > > > >> > Thibaut, can you take a look? I'm guessing the recent changes to that > > >> file just triggered a known issue with DocBook export. Can you confirm so > > >> that we can invert that test? > > >> > > > >> > > >> I just inverted it for now (at eb920502). Take a look whenever you have > > >> time. > > >> > > > > > > I had a look at that failure. It's a specific feature of that document, > > > with an emphasis ending at the end of a footnote (with no character > > > afterwards). Is this expected that someone can enter that? I would naïvely > > > think that LyX would remove that formatting (just like you cannot have two > > > spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the > > > footnote, unlike DocBook. > > > > > > I have the idea for a fix; I'm waiting on your input on whether this is a > > > DocBook bug or unexpected LyX behaviour. > > > > > > > I made up my mind and decided to replicate the same behaviour as LyXHTML > > output: actually, there was some text, indicating a true bug in the > > implementation. The attached patch fixes it locally, making it so that the > > test can be uninverted. (As previously, I cannot push the commit onto the > > Git repository.) > > Thanks for working on it. I'll run the tests overnight with your patch > applied. > > Scott Looks good! It's in at ff9dfa96. Thanks, Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctest ca/Intro_docbook5 now failing
On Mon, Sep 25, 2023 at 05:27:47AM +0200, Thibaut Cuvelier wrote: > On Mon, 18 Sept 2023 at 02:43, Thibaut Cuvelier wrote: > > > On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak wrote: > > > >> On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: > >> > Recently (I think due to the ca/Intro changes) the following test > >> started to fail: > >> > > >> > export/doc/ca/Intro_docbook5 > >> > > >> > Thibaut, can you take a look? I'm guessing the recent changes to that > >> file just triggered a known issue with DocBook export. Can you confirm so > >> that we can invert that test? > >> > > >> > >> I just inverted it for now (at eb920502). Take a look whenever you have > >> time. > >> > > > > I had a look at that failure. It's a specific feature of that document, > > with an emphasis ending at the end of a footnote (with no character > > afterwards). Is this expected that someone can enter that? I would naïvely > > think that LyX would remove that formatting (just like you cannot have two > > spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the > > footnote, unlike DocBook. > > > > I have the idea for a fix; I'm waiting on your input on whether this is a > > DocBook bug or unexpected LyX behaviour. > > > > I made up my mind and decided to replicate the same behaviour as LyXHTML > output: actually, there was some text, indicating a true bug in the > implementation. The attached patch fixes it locally, making it so that the > test can be uninverted. (As previously, I cannot push the commit onto the > Git repository.) Thanks for working on it. I'll run the tests overnight with your patch applied. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctest ca/Intro_docbook5 now failing
On Mon, 18 Sept 2023 at 02:43, Thibaut Cuvelier wrote: > On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak wrote: > >> On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: >> > Recently (I think due to the ca/Intro changes) the following test >> started to fail: >> > >> > export/doc/ca/Intro_docbook5 >> > >> > Thibaut, can you take a look? I'm guessing the recent changes to that >> file just triggered a known issue with DocBook export. Can you confirm so >> that we can invert that test? >> > >> >> I just inverted it for now (at eb920502). Take a look whenever you have >> time. >> > > I had a look at that failure. It's a specific feature of that document, > with an emphasis ending at the end of a footnote (with no character > afterwards). Is this expected that someone can enter that? I would naïvely > think that LyX would remove that formatting (just like you cannot have two > spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the > footnote, unlike DocBook. > > I have the idea for a fix; I'm waiting on your input on whether this is a > DocBook bug or unexpected LyX behaviour. > I made up my mind and decided to replicate the same behaviour as LyXHTML output: actually, there was some text, indicating a true bug in the implementation. The attached patch fixes it locally, making it so that the test can be uninverted. (As previously, I cannot push the commit onto the Git repository.) DocBook__fix_a_bug_when_having_a_space_with_font_at_the_end_of_a_paragraph_.patch Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctest ca/Intro_docbook5 now failing
On Mon, Sep 18, 2023 at 02:43:38AM +0200, Thibaut Cuvelier wrote: > On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak wrote: > > > On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: > > > Recently (I think due to the ca/Intro changes) the following test > > started to fail: > > > > > > export/doc/ca/Intro_docbook5 > > > > > > Thibaut, can you take a look? I'm guessing the recent changes to that > > file just triggered a known issue with DocBook export. Can you confirm so > > that we can invert that test? > > > > > > > I just inverted it for now (at eb920502). Take a look whenever you have > > time. > > > > I had a look at that failure. It's a specific feature of that document, > with an emphasis ending at the end of a footnote (with no character > afterwards). Is this expected that someone can enter that? I would naïvely > think that LyX would remove that formatting (just like you cannot have two > spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the > footnote, unlike DocBook. > > I have the idea for a fix; I'm waiting on your input on whether this is a > DocBook bug or unexpected LyX behaviour. Which footnote is it? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctest ca/Intro_docbook5 now failing
On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak wrote: > On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: > > Recently (I think due to the ca/Intro changes) the following test > started to fail: > > > > export/doc/ca/Intro_docbook5 > > > > Thibaut, can you take a look? I'm guessing the recent changes to that > file just triggered a known issue with DocBook export. Can you confirm so > that we can invert that test? > > > > I just inverted it for now (at eb920502). Take a look whenever you have > time. > I had a look at that failure. It's a specific feature of that document, with an emphasis ending at the end of a footnote (with no character afterwards). Is this expected that someone can enter that? I would naïvely think that LyX would remove that formatting (just like you cannot have two spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the footnote, unlike DocBook. I have the idea for a fix; I'm waiting on your input on whether this is a DocBook bug or unexpected LyX behaviour. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctest ca/Intro_docbook5 now failing
On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: > Recently (I think due to the ca/Intro changes) the following test started to > fail: > > export/doc/ca/Intro_docbook5 > > Thibaut, can you take a look? I'm guessing the recent changes to that file > just triggered a known issue with DocBook export. Can you confirm so that we > can invert that test? > I just inverted it for now (at eb920502). Take a look whenever you have time. Scott -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
