Re: r38018 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui
Am 24.03.2011 um 00:10 schrieb you...@lyx.org:
Author: younes
Date: Thu Mar 24 00:10:12 2011
New Revision: 38018
URL: http://www.lyx.org/trac/changeset/38018
Log:
Cleanup the SpellChecker dialog (fixes #7375 and #7379):
* Transform Spellchecker.ui into a simple QWidget
* Pimpl all we can
* Remove progress bar
* Remove Close button (as for all other dock widgets)
* Allow the dialog to stay even for empty document
When starting the spell checker with empty document LyX
asks you if you want to start over at the beginning...
Would the attached patch be save enough? At least it works here.
Stephan
Index: src/frontends/qt4/GuiSpellchecker.cpp
===
--- src/frontends/qt4/GuiSpellchecker.cpp (Revision 38018)
+++ src/frontends/qt4/GuiSpellchecker.cpp (Arbeitskopie)
@@ -24,6 +24,7 @@
#include BufferView.h
#include buffer_funcs.h
#include Cursor.h
+#include Text.h
#include CutAndPaste.h
#include FuncRequest.h
#include Language.h
@@ -290,7 +291,7 @@
void SpellcheckerWidget::Private::check()
{
BufferView * bv = gv_-documentBufferView();
- if (!bv)
+ if (!bv || bv-buffer().text().empty())
return;
DocIterator from = bv-cursor();
Re: r38018 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui
On 03/24/2011 07:50 AM, Stephan Witt wrote: Am 24.03.2011 um 00:10 schrieb you...@lyx.org: Author: younes Date: Thu Mar 24 00:10:12 2011 New Revision: 38018 URL: http://www.lyx.org/trac/changeset/38018 Log: Cleanup the SpellChecker dialog (fixes #7375 and #7379): * Transform Spellchecker.ui into a simple QWidget * Pimpl all we can * Remove progress bar * Remove Close button (as for all other dock widgets) * Allow the dialog to stay even for empty document When starting the spell checker with empty document LyX asks you if you want to start over at the beginning... Would the attached patch be save enough? At least it works here. Yes. Abdel.
Re: r38018 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui
Am 24.03.2011 um 00:10 schrieb you...@lyx.org:
> Author: younes
> Date: Thu Mar 24 00:10:12 2011
> New Revision: 38018
> URL: http://www.lyx.org/trac/changeset/38018
>
> Log:
> Cleanup the SpellChecker dialog (fixes #7375 and #7379):
> * Transform Spellchecker.ui into a simple QWidget
> * Pimpl all we can
> * Remove progress bar
> * Remove Close button (as for all other dock widgets)
> * Allow the dialog to stay even for empty document
When starting the spell checker with empty document LyX
asks you if you want to start over at the beginning...
Would the attached patch be save enough? At least it works here.
Stephan
Index: src/frontends/qt4/GuiSpellchecker.cpp
===
--- src/frontends/qt4/GuiSpellchecker.cpp (Revision 38018)
+++ src/frontends/qt4/GuiSpellchecker.cpp (Arbeitskopie)
@@ -24,6 +24,7 @@
#include "BufferView.h"
#include "buffer_funcs.h"
#include "Cursor.h"
+#include "Text.h"
#include "CutAndPaste.h"
#include "FuncRequest.h"
#include "Language.h"
@@ -290,7 +291,7 @@
void SpellcheckerWidget::Private::check()
{
BufferView * bv = gv_->documentBufferView();
- if (!bv)
+ if (!bv || bv->buffer().text().empty())
return;
DocIterator from = bv->cursor();
Re: r38018 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui
On 03/24/2011 07:50 AM, Stephan Witt wrote: Am 24.03.2011 um 00:10 schrieb you...@lyx.org: Author: younes Date: Thu Mar 24 00:10:12 2011 New Revision: 38018 URL: http://www.lyx.org/trac/changeset/38018 Log: Cleanup the SpellChecker dialog (fixes #7375 and #7379): * Transform Spellchecker.ui into a simple QWidget * Pimpl all we can * Remove progress bar * Remove Close button (as for all other dock widgets) * Allow the dialog to stay even for empty document When starting the spell checker with empty document LyX asks you if you want to start over at the beginning... Would the attached patch be save enough? At least it works here. Yes. Abdel.
