Re: [LyX/master] Install a new compressor

[Jürgen Spitzmüller]

Am Freitag, den 02.02.2018, 22:55 -0500 schrieb Scott Kostyshak:
> > Yes, you need Jürgen's fix.
> 
> OK.

Done.

Jürgen

signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Add LFUN_DOC_ANONYMIZE, quick fix for #7259.

[Pavel Sanda]

Scott Kostyshak wrote:
> Let's go for 2.3.1.

Ok.

> Are you interested in improving it?

Not really, I just needed quick way how to submit bug examples
without giving confidental material. P

Re: 2.3.0rc2 tar balls have been uploaded

[Jean-Pierre Chrétien]

Le 02/02/2018 à 18:51, Richard Heck a écrit :



You don't need to recompile, but you would need to re-run "make
install". Otherwise,
the old configure.py is still being used from /usr/local/share/lyx/ or
whatever.


How stupid of me :-( Your patch works fine after reinstall.

--
Jean-Pierre

Re: [LyX/master] Add LFUN_DOC_ANONYMIZE, quick fix for #7259.

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 04:21:31PM +, Pavel Sanda wrote:
> Scott Kostyshak wrote:
> > Let's go for 2.3.1.
> 
> Ok.
> 
> > Are you interested in improving it?
> 
> Not really, I just needed quick way how to submit bug examples
> without giving confidental material. P

Makes sense.

Scott


signature.asc
Description: PGP signature

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

Just found that turning off the pixel map caching fixed the math font
problem on 2.3.0rc2. However, 2.2.3 works fine even with pixel map caching
on.

On Sat, Feb 3, 2018 at 1:42 PM, Zhexuan Gong  wrote:

> It could be the macOS version then. I'm using the latest macOS 10.13.3.
> There must be something different with the 2.3.0rc2, because 2.2.3 works
> perfectly.
>
> On Sat, Feb 3, 2018 at 12:31 PM, Joel Kulesza  wrote:
>
>> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong 
>> wrote:
>>
>>> Hi Scott,
>>>
>>> Yes please see attached for a minimum lyx file that produces the math
>>> font issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The
>>> 2.2.3 has no problem with the math font.
>>>
>>> Best,
>>>
>>> Zhexuan
>>>
>>
>> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the
>> issue with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
>> display.  Please see the attached for what I see in LyX and my system
>> properties.
>>
>> - Joel
>>
>
>

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Sat, Feb 3, 2018 at 1:42 PM, Zhexuan Gong  wrote:

> It could be the macOS version then. I'm using the latest macOS 10.13.3.
> There must be something different with the 2.3.0rc2, because 2.2.3 works
> perfectly.
>

I recall there being some other issues with 10.12 (which I'll test tonight;
heading out now).  However, I don't have access to 10.13 currently.

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

Hi Stephan,

The math font problem is not an urgent problem now since one can just turn
off the pixel map caching.

Regarding the blurry image, the problem you mentioned with low resolution
image generated by the Mac built-in image converter engine can be easily
fixed. I added a rule "sips -Z 600 -s format png $$i --out $$o" in the
PDF->PNG converter setting where 600 is dpi that can be further increased.
So I can get a very high resolution image showing on the Lyx workspace.
However, the image is displayed in 2X zoom always and not in a HiDPI mode.
Maybe you can just pass to DPI setting to the Lyx workspace for showing
images?

Best,

Zhexuan

On Sat, Feb 3, 2018 at 3:22 PM, Stephan Witt  wrote:

> Am 03.02.2018 um 20:39 schrieb Scott Kostyshak :
> >
> > On Sat, Feb 03, 2018 at 07:31:15PM +, Joel Kulesza wrote:
> >> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong 
> wrote:
> >>
> >>> Hi Scott,
> >>>
> >>> Yes please see attached for a minimum lyx file that produces the math
> font
> >>> issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The
> 2.2.3
> >>> has no problem with the math font.
> >>>
> >>> Best,
> >>>
> >>> Zhexuan
> >>>
> >>
> >> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the
> issue
> >> with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
> >> display.  Please see the attached for what I see in LyX and my system
> >> properties.
> >>
> >> - Joel
> >
> > The .lyx example file and screenshots are perfect. Thank you, Zhexuan.
> >
> > Stephan, are you able to reproduce? I forget whether you have a retina
> > display. In either case, do you have any intuition on whether the
> > difference between 2.2.3 and 2.3.0rc2 is due to our change of Qt library
> > or a change in our code?
>
> I cannot reproduce it either. Let’s see how it goes with the pixmap cache
> disabled.
>
> > Does anyone have suggestions for especific environment variables that
> > Zhexuan could test to see if it fixes things? e.g., could the
> > environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> > QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> > here:
> >
> >  http://doc.qt.io/qt-5/highdpi.html
> >
> > Joel, did you by chance set one of those environment variables in the
> > past?
>
> I don’t believe it’s useful to set these variables on a Mac. It’s simply
> not needed and should work automatically. Fiddling with the environment
> is not so easy on a Mac - LyX isn’t a terminal application and the
> environment of a desktop app is very basic and not easy to change.
>
> Regarding the blurry image thing - the problem here is the images being
> generated for preview with the wrong (too low) resolution by the preview
> images converter engine, IMHO. Last time I had a look I couldn’t find a
> way to pass the actual screen resolution down to the graphics converters
> in a clean manner. Furthermore the screen resolution on a Mac isn’t static.
> It may change at runtime if you’re working with multiple displays. I think
> this may happen on other platforms too - but I don’t know how this works
> e.g. on Linux.
>
> Stephan

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 08:08:03PM +, Joel Kulesza wrote:

> I don't recall having done so and don't see any QT variables set:
> 
> 9997 jkulesza@tempest[~]> env | grep QT
> 9998 jkulesza@tempest[~]>

OK thanks for checking.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] LFUN_DOC_ANONYMIZE -> LFUN_BUFFER_ANONYMIZE per JMarc's suggestion.

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> You forgot a "doc-" in the description.

Thanks. P

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 07:31:15PM +, Joel Kulesza wrote:
> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong  wrote:
> 
> > Hi Scott,
> >
> > Yes please see attached for a minimum lyx file that produces the math font
> > issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The 2.2.3
> > has no problem with the math font.
> >
> > Best,
> >
> > Zhexuan
> >
> 
> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the issue
> with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
> display.  Please see the attached for what I see in LyX and my system
> properties.
> 
> - Joel

The .lyx example file and screenshots are perfect. Thank you, Zhexuan.

Stephan, are you able to reproduce? I forget whether you have a retina
display. In either case, do you have any intuition on whether the
difference between 2.2.3 and 2.3.0rc2 is due to our change of Qt library
or a change in our code?

Does anyone have suggestions for especific environment variables that
Zhexuan could test to see if it fixes things? e.g., could the
environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
here:

  http://doc.qt.io/qt-5/highdpi.html

Joel, did you by chance set one of those environment variables in the
past?

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:

> I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
> disabled.

+1.

> > Does anyone have suggestions for especific environment variables that
> > Zhexuan could test to see if it fixes things? e.g., could the
> > environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> > QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> > here:
> > 
> >  http://doc.qt.io/qt-5/highdpi.html
> > 
> > Joel, did you by chance set one of those environment variables in the
> > past?
> 
> I don’t believe it’s useful to set these variables on a Mac. It’s simply
> not needed and should work automatically. Fiddling with the environment
> is not so easy on a Mac - LyX isn’t a terminal application and the
> environment of a desktop app is very basic and not easy to change.

Good to know. It seems that using launchctl setenv can be useful [1].

> Regarding the blurry image thing - the problem here is the images being
> generated for preview with the wrong (too low) resolution by the preview
> images converter engine, IMHO. Last time I had a look I couldn’t find a
> way to pass the actual screen resolution down to the graphics converters
> in a clean manner. Furthermore the screen resolution on a Mac isn’t static.
> It may change at runtime if you’re working with multiple displays. I think
> this may happen on other platforms too - but I don’t know how this works
> e.g. on Linux.

OK so nothing we should try for 2.3.0. As for the screen resolution
changing, I guess we would need to hook such changes into regeneration,
like we do when zooming.

Thanks,

Scott


[1] https://stackoverflow.com/a/3756674/1376404


signature.asc
Description: PGP signature

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Sat, Feb 3, 2018 at 12:39 PM, Scott Kostyshak  wrote:

>
> Does anyone have suggestions for especific environment variables that
> Zhexuan could test to see if it fixes things? e.g., could the
> environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> here:
>
>   http://doc.qt.io/qt-5/highdpi.html
>
> Joel, did you by chance set one of those environment variables in the
> past?


I don't recall having done so and don't see any QT variables set:

9997 jkulesza@tempest[~]> env | grep QT
9998 jkulesza@tempest[~]>

- Joel

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

It could be the macOS version then. I'm using the latest macOS 10.13.3.
There must be something different with the 2.3.0rc2, because 2.2.3 works
perfectly.

On Sat, Feb 3, 2018 at 12:31 PM, Joel Kulesza  wrote:

> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong 
> wrote:
>
>> Hi Scott,
>>
>> Yes please see attached for a minimum lyx file that produces the math
>> font issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The
>> 2.2.3 has no problem with the math font.
>>
>> Best,
>>
>> Zhexuan
>>
>
> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the
> issue with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
> display.  Please see the attached for what I see in LyX and my system
> properties.
>
> - Joel
>

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jean-Marc Lasgouttes]

Le 03/02/2018 à 21:45, Zhexuan Gong a écrit :
Just found that turning off the pixel map caching fixed the math font 
problem on 2.3.0rc2. However, 2.2.3 works fine even with pixel map 
caching on.


I might have broken the Pixmap cache, since I have no way to test it on 
linux. I will take a look next week.


BTW, is there a reason why you enabled the pixmap cache? I was thinking 
about removing it, actually.


Concerning your 2.3 screenshot, it is not only the blur that is wrong, 
many letters are not where they are supposed to be. Can you show the 
screenshot of 2.3.0rc2 without pixmap cache?


JMarc

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Stephan Witt]

Am 03.02.2018 um 20:39 schrieb Scott Kostyshak :
> 
> On Sat, Feb 03, 2018 at 07:31:15PM +, Joel Kulesza wrote:
>> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong  wrote:
>> 
>>> Hi Scott,
>>> 
>>> Yes please see attached for a minimum lyx file that produces the math font
>>> issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The 2.2.3
>>> has no problem with the math font.
>>> 
>>> Best,
>>> 
>>> Zhexuan
>>> 
>> 
>> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the issue
>> with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
>> display.  Please see the attached for what I see in LyX and my system
>> properties.
>> 
>> - Joel
> 
> The .lyx example file and screenshots are perfect. Thank you, Zhexuan.
> 
> Stephan, are you able to reproduce? I forget whether you have a retina
> display. In either case, do you have any intuition on whether the
> difference between 2.2.3 and 2.3.0rc2 is due to our change of Qt library
> or a change in our code?

I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
disabled.

> Does anyone have suggestions for especific environment variables that
> Zhexuan could test to see if it fixes things? e.g., could the
> environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> here:
> 
>  http://doc.qt.io/qt-5/highdpi.html
> 
> Joel, did you by chance set one of those environment variables in the
> past?

I don’t believe it’s useful to set these variables on a Mac. It’s simply
not needed and should work automatically. Fiddling with the environment
is not so easy on a Mac - LyX isn’t a terminal application and the
environment of a desktop app is very basic and not easy to change.

Regarding the blurry image thing - the problem here is the images being
generated for preview with the wrong (too low) resolution by the preview
images converter engine, IMHO. Last time I had a look I couldn’t find a
way to pass the actual screen resolution down to the graphics converters
in a clean manner. Furthermore the screen resolution on a Mac isn’t static.
It may change at runtime if you’re working with multiple displays. I think
this may happen on other platforms too - but I don’t know how this works
e.g. on Linux.

Stephan

Re: [LyX/master] Add LFUN_DOC_ANONYMIZE, quick fix for #7259.

[Jean-Marc Lasgouttes]

Le 2 février 2018 23:51:35 GMT+01:00, Pavel Sanda  a écrit :
>Pavel Sanda wrote:
>> commit c19c3899d1b725cb341f6f18e6704a106eb1fc67
>> Author: Pavel Sanda 
>> Date:   Fri Feb 2 23:42:56 2018 +0100
>> 
>> Add LFUN_DOC_ANONYMIZE, quick fix for #7259.
>
>Scott, 2.3.0 or 2.3.1?  Pavel

Isn't this supposed to be named buffer-... ?

We do not use the doc suffix already, do we ?

Re: [LyX/master] LFUN_DOC_ANONYMIZE -> LFUN_BUFFER_ANONYMIZE per JMarc's suggestion.

[Jean-Marc Lasgouttes]

You forgot a "doc-" in the description.

Jmarc