Re: lyx master crashed when converting text to note
On Thursday, February 25, 2021, 9:10:03 PM GMT+2, Jean-Marc Lasgouttes wrote: Le 22/02/2021 à 22:45, Pavel Sanda a écrit : > On Mon, Feb 22, 2021 at 06:31:08PM +, V K wrote: >> Yes, I can recreate crash with anonymized file. I marked line/paragraph part >> of which should be selected before creating note to get a crash with . >> Selection should be from the first line. Selection should encompass one line >> more on the bottom if selecting from the second line from the top. That is >> the minimal length to get a crash. > > Indeed, I can reproduce the problem, generally selecting line starting with > == to the very end of the document and then insert-note is enough to > trigger it. Can I have the file? JMarc Only for me selecting text from beginning of the document till line with triggers crash. Valdemaras example.lyx Description: application/lyx -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users
Re: lyx master crashed when converting text to note
Le 22/02/2021 à 22:45, Pavel Sanda a écrit : On Mon, Feb 22, 2021 at 06:31:08PM +, V K wrote: Yes, I can recreate crash with anonymized file. I marked line/paragraph part of which should be selected before creating note to get a crash with . Selection should be from the first line. Selection should encompass one line more on the bottom if selecting from the second line from the top. That is the minimal length to get a crash. Indeed, I can reproduce the problem, generally selecting line starting with == to the very end of the document and then insert-note is enough to trigger it. Can I have the file? JMarc -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users
Re: lyx master crashed when converting text to note
Le 22 février 2021 22:45:38 GMT+01:00, Pavel Sanda a écrit : >On Mon, Feb 22, 2021 at 06:31:08PM +, V K wrote: >> Yes, I can recreate crash with anonymized file. I marked line/paragraph part >> of which should be selected before creating note to get a crash with . >> Selection should be from the first line. Selection should encompass one line >> more on the bottom if selecting from the second line from the top. That is >> the minimal length to get a crash. > >Indeed, I can reproduce the problem, generally selecting line starting with >== to the very end of the document and then insert-note is enough to >trigger it. > >Bisect leads to: >commit 5a58ca6576a1fa2d6bea8e9e7927d5779943e593 >Author: Jean-Marc Lasgouttes >Date: Sun Feb 14 21:34:43 2021 +0100 > >Fix caret height when inserting new inset Thanks for tracking this. I'll have look next week. JMarc -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users
Re: lyx master crashed when converting text to note
On Monday, February 22, 2021, 12:24:22 PM GMT+2, Pavel Sanda wrote: On Mon, Feb 22, 2021 at 04:43:03AM +, V K wrote: > Hello > > I compiled Lyx master recently, wrote some text in the old document, selected > some text and inserted note onto it. Lyx crashes. I did some tests: Lyx > crashes when I insert note by shortcut or by menu. But it crashes only on > particular text (that is some short lines, one line ??? one paragraph), I > think, that causes word with " " quotes (they are foreign in Lithuanian, I > copied text from mail), but I can make note on line with that word ??? there > should be more lines selected to get a crash. There is no crash when I select > the same text from the bottom and create note. > I can send file, but only privately. Could you try buffer-anonymize LFUN (with perhaps "" quotes left) and reproduce with that version, so we don't need private conversation? Yes, I can recreate crash with anonymized file. I marked line/paragraph part of which should be selected before creating note to get a crash with . Selection should be from the first line. Selection should encompass one line more on the bottom if selecting from the second line from the top. That is the minimal length to get a crash. Valdemaras example.lyx Description: application/lyx -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users
Re: lyx master crashed when converting text to note
On Mon, Feb 22, 2021 at 06:31:08PM +, V K wrote: > Yes, I can recreate crash with anonymized file. I marked line/paragraph part > of which should be selected before creating note to get a crash with . > Selection should be from the first line. Selection should encompass one line > more on the bottom if selecting from the second line from the top. That is > the minimal length to get a crash. Indeed, I can reproduce the problem, generally selecting line starting with == to the very end of the document and then insert-note is enough to trigger it. Bisect leads to: commit 5a58ca6576a1fa2d6bea8e9e7927d5779943e593 Author: Jean-Marc Lasgouttes Date: Sun Feb 14 21:34:43 2021 +0100 Fix caret height when inserting new inset For now, the simplest thing to do it to compute metrics in all cases before calling setCurrentFont(). In 2.5, a better approach will be to add a new virtual function InsetText::setFont that will set correctly TextMetrics::font_ (a cache of the reference font). Fixes bug #12126. Backtrace: #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x76558535 in __GI_abort () at abort.c:79 #2 0x769247bd in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 #3 0x562d6fef in std::__debug::vector<__gnu_debug::_Safe_iterator, std::__debug::list > >, std::allocator<__gnu_debug::_Safe_iterator, std::__debug::list > > > >::operator[] (this=0x7fffec009690, __n=37) at /usr/include/c++/8/debug/vector:417 #4 0x562d4acd in lyx::RandomAccessList::operator[] (this=0x7fffec009660, pos=37) at ./support/RandomAccessList.h:161 #5 0x566295a8 in lyx::TextMetrics::checkInsetHit (this=0x581bdef8, pit=37, x=179, y=6) at TextMetrics.cpp:1491 #6 0x566299ef in lyx::TextMetrics::checkInsetHit (this=0x581bdef8, x=179, y=6) at TextMetrics.cpp:1515 #7 0x5668518a in lyx::BufferView::getCoveringInset (this=0x582f8430, text=..., x=179, y=6) at BufferView.cpp:2303 #8 0x566852b1 in lyx::BufferView::updateHoveredInset (this=0x582f8430) at BufferView.cpp:2334 #9 0x5667ab85 in lyx::BufferView::processUpdateFlags (this=0x582f8430, flags=lyx::Update::SinglePar) at BufferView.cpp:574 #10 0x565ee806 in lyx::Text::dispatch (this=0x7fffec009658, cur=..., cmd=...) at Text3.cpp:2090 #11 0x569958a6 in lyx::InsetText::doDispatch (this=0x7fffec009640, cur=..., cmd=...) at insets/InsetText.cpp:343 #12 0x568260b8 in lyx::Inset::dispatch (this=0x7fffec009640, cur=..., cmd=...) at insets/Inset.cpp:328 #13 0x56407754 in lyx::Cursor::dispatch (this=0x5836a088, cmd0=...) at Cursor.cpp:823 #14 0x56a2e35f in lyx::frontend::GuiView::dispatchToBufferView (this=0x57e02c30, cmd=..., dr=...) at GuiView.cpp:3943 #15 0x56a3307b in lyx::frontend::GuiView::dispatch (this=0x57e02c30, cmd=..., dr=...) at GuiView.cpp:4661 #16 0x569da4be in lyx::frontend::GuiApplication::dispatch (this=0x57424ff0, cmd=..., dr=...) at GuiApplication.cpp:2211 #17 0x569d5dc8 in lyx::frontend::GuiApplication::dispatch (this=0x57424ff0, cmd=...) at GuiApplication.cpp:1500 #18 0x564e9b1f in lyx::dispatch (action=...) at LyX.cpp:1477 #19 0x56a98a82 in lyx::frontend::Action::action (this=0x581cdf90) at Action.cpp:91 #20 0x56a98af8 in lyx::frontend::Action::qt_static_metacall (_o=0x581cdf90, Pavel -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users
Re: lyx master crashed when converting text to note
On Mon, Feb 22, 2021 at 04:43:03AM +, V K wrote: > Hello > > I compiled Lyx master recently, wrote some text in the old document, selected > some text and inserted note onto it. Lyx crashes. I did some tests: Lyx > crashes when I insert note by shortcut or by menu. But it crashes only on > particular text (that is some short lines, one line ??? one paragraph), I > think, that causes word with " " quotes (they are foreign in Lithuanian, I > copied text from mail), but I can make note on line with that word ??? there > should be more lines selected to get a crash. There is no crash when I select > the same text from the bottom and create note. > I can send file, but only privately. Could you try buffer-anonymize LFUN (with perhaps "" quotes left) and reproduce with that version, so we don't need private conversation? Pavel -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users
lyx master crashed when converting text to note
Hello I compiled Lyx master recently, wrote some text in the old document, selected some text and inserted note onto it. Lyx crashes. I did some tests: Lyx crashes when I insert note by shortcut or by menu. But it crashes only on particular text (that is some short lines, one line – one paragraph), I think, that causes word with " " quotes (they are foreign in Lithuanian, I copied text from mail), but I can make note on line with that word – there should be more lines selected to get a crash. There is no crash when I select the same text from the bottom and create note. I can send file, but only privately. Lyx version 2.4.0dev (not released yet) Built from git commit hash 5b9929c9 Qt Version (run-time): 5.15.2 Qt Version (compile-time): 5.15.2 Python detected: python3 -tt Manjaro linux Sway (Wayland) Error mesage from terminal: /usr/include/c++/10.2.0/debug/vector:427: In function: std::__debug::vector<_Tp, _Allocator>::reference std::__debug::vector<_Tp, _Allocator>::operator[](std::__debug::vector<_Tp, _Allocator>::size_type) [with _Tp = __gnu_debug::_Safe_iterator, std::__debug::list >, std::bidirectional_iterator_tag>; _Allocator = std::allocator<__gnu_debug::_Safe_iterator, std::__debug::list >, std::bidirectional_iterator_tag> >; std::__debug::vector<_Tp, _Allocator>::reference = std::allocator_traits, std::__debug::list >, std::bidirectional_iterator_tag> > >::value_type&; std::__debug::vector<_Tp, _Allocator>::size_type = long unsigned int] Error: attempt to subscript container with out-of-bounds index 77, but container only holds 46 elements. Objects involved in the operation: sequence "this" @ 0x0x55b6e38fafb0 { type = std::__debug::vector<__gnu_debug::_Safe_iterator, std::__debug::list >, std::bidirectional_iterator_tag>, std::allocator<__gnu_debug::_Safe_iterator, std::__debug::list >, std::bidirectional_iterator_tag> > >; } Nutraukta (aborted) (core dumped) Valdemaras -- lyx-users mailing list lyx-users@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-users