Re: [MacPorts] #52068: darkice needs pkgconfig dependency

[Ryan Schmidt]

> On Aug 22, 2016, at 9:20 AM, Rainer Müller  wrote:
> 
> On 2016-08-22 12:39, Niels Dettenbach wrote:
>> Hmmm,
>> i'm just wondering how the port worked up to 1.2 - there was no significant 
>> changes within darkice sources done as far as i know from Rafael Diniz 
>> (darkice maintainer) and i see no differences in the configure flag sheme 
>> too.
> 
> If you had the pkgconfig port installed, it just worked because it was
> already available. That is very likely as pkgconfig is a build
> dependency for many other ports.
> 
>> Do i have to correct here something further? In that case i have to dig in 
>> deeper asap (i.e. next weekend) into macports again.
>> 
>> depends_build-append port:pkgconfig
> 
> That would be correct.
> 
>> Could i add this in general anywhere or should place this under any of the 
>> variant sections? In practice, any mac osx user would at least need jack - 
>> and 
>> i don't know if further of the encoders need pkg-config too.
> 
> According to the configure script, the detection for all of them uses
> pkg-config.

Except lame.

> Makes sense to add it as a general dependency.

Agreed.



___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [MacPorts] #52068: darkice needs pkgconfig dependency

[Rainer Müller]

On 2016-08-22 12:39, Niels Dettenbach wrote:
> Hmmm,
> i'm just wondering how the port worked up to 1.2 - there was no significant 
> changes within darkice sources done as far as i know from Rafael Diniz 
> (darkice maintainer) and i see no differences in the configure flag sheme too.

If you had the pkgconfig port installed, it just worked because it was
already available. That is very likely as pkgconfig is a build
dependency for many other ports.

> Do i have to correct here something further? In that case i have to dig in 
> deeper asap (i.e. next weekend) into macports again.
> 
> depends_build-append port:pkgconfig

That would be correct.

> Could i add this in general anywhere or should place this under any of the 
> variant sections? In practice, any mac osx user would at least need jack - 
> and 
> i don't know if further of the encoders need pkg-config too.

According to the configure script, the detection for all of them uses
pkg-config. Makes sense to add it as a general dependency.

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [MacPorts] #52068: darkice needs pkgconfig dependency

[Niels Dettenbach]

Am Samstag, 20. August 2016, 12:13:32 schrieb MacPorts:
>  Alternatively, you may set the environment variables JACK_CFLAGS
>  and JACK_LIBS to avoid the need to call pkg-config.
>  See the pkg-config man page for more details.
> 
>  To get pkg-config, see .
>  See `config.log' for more details
>  }}}
> 
>  Evidently, darkice needs pkgconfig to find jack, so a build dependency on
>  port:pkgconfig should be added to the port somewhere. But where?
> 
>  If only the jack variant needs pkgconfig, then put the dependency in the
>  jack variant.
> 
>  It looks lame was detected without pkgconfig. What about the other
>  variants, which are not default variants? If some of them require
>  pkgconfig, then the pkgconfig dependency should be made in a conditional
>  outside of a variant directive (to avoid each variant declaring the same
>  dependency). For example, if only jack and faac need pkgconfig, you could
>  do:
> 
>  {{{
>  if {[variant_isset faac] || [variant_isset jack]} {
>  depends_build-append port:pkgconfig
>  }
>  }}}

Hmmm,
i'm just wondering how the port worked up to 1.2 - there was no significant 
changes within darkice sources done as far as i know from Rafael Diniz 
(darkice maintainer) and i see no differences in the configure flag sheme too.

Do i have to correct here something further? In that case i have to dig in 
deeper asap (i.e. next weekend) into macports again.

depends_build-append port:pkgconfig

Could i add this in general anywhere or should place this under any of the 
variant sections? In practice, any mac osx user would at least need jack - and 
i don't know if further of the encoders need pkg-config too.

Just to explain a bit:

 - darkice needs one audio i/o framework to work (currently the only available 
under MacOS seems jack - coreaudio is not provided yet)

 - beside this, darklice need at least (!) one of the encoder framworks - but 
could be compiled with any other combination (or even all enc libraries)  as 
well. There is no further dependency between them.

The most "typical" (entry) setup of darkice is jack + lame (mp3) - as defined 
in the default_variants


many thanks.
best regards,


Niels.


-- 
 ---
 Niels Dettenbach
 Syndicat IT & Internet
 http://www.syndicat.com
 PGP: https://syndicat.com/pub_key.asc
 ---
 





signature.asc
Description: This is a digitally signed message part.
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev