Re: [144322] trunk/dports/python/py-keyczar/Portfile
On Jan 7, 2016, at 8:39 AM, Andrew Fernandes wrote:
>> This is not the correct usage of the github portgroup. The correct usage is:
>>
>> github.setupgoogle keyczar 0.715 Python_release_
>
> Ah. Of course. I’m so used to looking and seeing a ‘v’ for a prefix, I
> overlooked the obvious.
>
>> Why must it fetch from git?
>
> Because I couldn’t get it to fetch the tarball; that’s fixed now.
>
>> Once the usage of github.setup is corrected as above, this line should be
>> unnecessary.
>
> Done.
>
>>> +build.cmd cd python && ${python.bin} setup.py --no-user-cfg
>>> +destroot.cmdcd python && ${python.bin} setup.py --no-user-cfg
>>
>> Using "cd" in a build.cmd/destroot.cmd is unusual. Is there a reason why you
>> didn't instead set build.dir?
>
> Yes, because it doesn’t work.
>
> The python code is built in a subdirectory of the tarball, and I looked and
> looked, and that seemed to be the only way to do it.
I tried replacing those two lines with:
build.dir ${worksrcpath}/python
and it seemed to build ok. Does that work for you?
> Committing the fixes as you suggested now.
>
> -A.
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: [144322] trunk/dports/python/py-keyczar/Portfile
> On Jan 6, 2016, at 10:12 AM, adfernan...@macports.org wrote:
>
> Revision
> 144322
> Author
> adfernan...@macports.org
> Date
> 2016-01-06 08:12:47 -0800 (Wed, 06 Jan 2016)
> Log Message
>
> python/py-keyczar: fix portfile for silent failures that only buildbot showed
> (grr)
> Modified Paths
>
> • trunk/dports/python/py-keyczar/Portfile
> Diff
>
> Modified: trunk/dports/python/py-keyczar/Portfile (144321 => 144322)
> +github.setupgoogle keyczar Python_release_0.715
> +
> +regexp {([^_]+)$} ${version} version
This is not the correct usage of the github portgroup. The correct usage is:
github.setupgoogle keyczar 0.715 Python_release_
> +fetch.type git
Why must it fetch from git?
> +worksrcdir python-keyczar-Python_release_${version}
Once the usage of github.setup is corrected as above, this line should be
unnecessary.
> +build.cmd cd python && ${python.bin} setup.py --no-user-cfg
> +destroot.cmdcd python && ${python.bin} setup.py --no-user-cfg
Using "cd" in a build.cmd/destroot.cmd is unusual. Is there a reason why you
didn't instead set build.dir?
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev
