Re: Help needing adapting home-brew formula?

[Rainer Müller]

Hello André,

please keep the mailing list always in CC (use Reply All), so everyone
can read your answers.

On 2016-03-27 03:56, André-John Mas wrote:
> 
>> On 26 Mar, 2016, at 20:58, Rainer Müller > > wrote:
>> So far we are using the shell script included in the tarball for these
>> steps. I am not sure we are passing all required variables there and it
>> is a quite unusual approach.
>>
>> I gave it a quick shot and attached an updated Portfile and patch to the
>> ticket you created. The resulting binary seems to work for me.
>>
>> https://trac.macports.org/ticket/50973
> 
> 
> If it is acceptable we can start with this diff file and then move on to an
> improved approach as another step?

I guess we can use this. It would be the same way to build this software
as is used right now.

I committed my patch:
https://trac.macports.org/changeset/147123

>> However, libmediainfo and libzen are actually standalone libraries. When
>> done properly, they should go into separate ports. That would also solve
>> this problem of running multiple configure/build/destroot steps or using
>> this shell script.
>>
>> In my opinion, separate ports would be the better packaging for
>> mediainfo, although there will probably be no other dependents for
>> libmediainfo or libzen. Nevertheless, this would also remove complexity
>> from the Portfiles as they would use the common configure and make
>> targets.
> 
> The fact these are only used by one project made me hesitate in requesting
> a new port made, but if it is an accepted approach I can open a issue for
> this.

Yes, please open a new ticket for this. Feel free to add me to CC, as I
am the one who suggested this change. Of course anyone is free to take
and work on it, as this would not be complicated and only requires the
common Portfile writing to split this into multiple ports.

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Help needing adapting home-brew formula?

[Ryan Schmidt]

On Mar 26, 2016, at 19:58, Rainer Müller wrote:
> 
>> On 2016-03-27 00:36, André-John Mas wrote:
>> Hi,
>> 
>> I am trying to update the mediainfo port to 0.7.83, though there are
>> changes beyond the
>> version number that need to be made.
>> 
>> Based on suggestion of the application developer I am trying to base the
>> updated Portfile
>> on that recipe, but I am running into some issues. The homebrew file is:
> 
>> [...]
> 
> So far we are using the shell script included in the tarball for these
> steps. I am not sure we are passing all required variables there and it
> is a quite unusual approach.
> 
> I gave it a quick shot and attached an updated Portfile and patch to the
> ticket you created. The resulting binary seems to work for me.
> 
> https://trac.macports.org/ticket/50973
> 
> 
> However, libmediainfo and libzen are actually standalone libraries. When
> done properly, they should go into separate ports. That would also solve
> this problem of running multiple configure/build/destroot steps or using
> this shell script.
> 
> Look for example at the FreeBSD ports...
> 
> https://svnweb.freebsd.org/ports/head/multimedia/mediainfo/Makefile?view=markup
> https://svnweb.freebsd.org/ports/head/multimedia/libmediainfo/Makefile?view=markup
> https://svnweb.freebsd.org/ports/head/multimedia/libzen/Makefile?view=markup
> 
> ...or the ArchLinux packaging:
> 
> https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/mediainfo
> https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/libmediainfo
> https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/libzen
> 
> 
> In my opinion, separate ports would be the better packaging for
> mediainfo, although there will probably be no other dependents for
> libmediainfo or libzen. Nevertheless, this would also remove complexity
> from the Portfiles as they would use the common configure and make targets.
> 
> By setting dist_subdir to the same value in all of these Portfiles, they
> would still share the fetched files to avoid local duplication.

Since they share the same distfile, that makes them good candidates to be 
subports, no?
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Help needing adapting home-brew formula?

[Rainer Müller]

On 2016-03-27 00:36, André-John Mas wrote:
> Hi,
> 
> I am trying to update the mediainfo port to 0.7.83, though there are
> changes beyond the
> version number that need to be made.
> 
> Based on suggestion of the application developer I am trying to base the
> updated Portfile
> on that recipe, but I am running into some issues. The homebrew file is:

> [...]

So far we are using the shell script included in the tarball for these
steps. I am not sure we are passing all required variables there and it
is a quite unusual approach.

I gave it a quick shot and attached an updated Portfile and patch to the
ticket you created. The resulting binary seems to work for me.

https://trac.macports.org/ticket/50973


However, libmediainfo and libzen are actually standalone libraries. When
done properly, they should go into separate ports. That would also solve
this problem of running multiple configure/build/destroot steps or using
this shell script.

Look for example at the FreeBSD ports...

https://svnweb.freebsd.org/ports/head/multimedia/mediainfo/Makefile?view=markup
https://svnweb.freebsd.org/ports/head/multimedia/libmediainfo/Makefile?view=markup
https://svnweb.freebsd.org/ports/head/multimedia/libzen/Makefile?view=markup

...or the ArchLinux packaging:

https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/mediainfo
https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/libmediainfo
https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/libzen


In my opinion, separate ports would be the better packaging for
mediainfo, although there will probably be no other dependents for
libmediainfo or libzen. Nevertheless, this would also remove complexity
from the Portfiles as they would use the common configure and make targets.

By setting dist_subdir to the same value in all of these Portfiles, they
would still share the fetched files to avoid local duplication.

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Help needing adapting home-brew formula?

[Brandon Allbery]

On Sat, Mar 26, 2016 at 7:36 PM, André-John Mas 
wrote:

> I am trying to update the mediainfo port to 0.7.83, though there are
> changes beyond the
> version number that need to be made.
>
> Based on suggestion of the application developer I am trying to base the
> updated Portfile
> on that recipe, but I am running into some issues. The homebrew file is:
>
>
> https://github.com/Homebrew/homebrew/blob/master/Library/Formula/media-info.rb
>
> What I have attempted thus far:
>
> build {
>system cd "${worksrcpath}/ZenLib/Project/GNU/Library"
>

This won't do anything useful; it will change directory in the shell
created by system, which immediately exits. The Tcl script's directory is
not changed at all (and almost certainly shouldn't be).

You probably want to read https://guide.macports.org/#reference, and
possibly a Tcl programming guide.

This thing really wants you to separately configure in two different
directories? Ick. I don't think you'll be able to use MacPorts' built-in
configure support, which will make things even uglier.

-- 
brandon s allbery kf8nh   sine nomine associates
allber...@gmail.com  ballb...@sinenomine.net
unix, openafs, kerberos, infrastructure, xmonadhttp://sinenomine.net
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev