Re: Looking for a portfile review before submitting (rbldnsd)
The extracted dir has a hyphen, not underscore. Looks like your shell
does autocorrection.
- Toby
On Jun 10, 2009, at 19:13, Scott Haneda talkli...@newgeo.com wrote:
Like this?
worksrcdir ${name}_${version}
I did, no change.
If I do this:
distfiles ${name}_${version}${extract.suffix}
extract.suffix .tar.tgz
Works fine, doing this, fails:
distname${name}_${version}
I think I should just go back to my original method, though it may
be messy. I will give it one more go to understand why sitname is
not enough.
On Jun 10, 2009, at 7:07 PM, Toby Peterson wrote:
Looks like you just need to set worksrcdir
- Toby
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
distfiles is this by default:
${distname}${extract.suffix}
distname is this by default:
${name}-${version}
That is, distfiles (defined as the name of the distribution filename,
not including the extract suffix) is
${name}-${version}${extract.suffix}
If that hyphen really is an underscore, you consider changing it in
distname instead of distfiles.
On Jun 10, 2009, at 8:49 PM, Scott Haneda wrote:
distfiles ${name}_${version}${extract.suffix}
smime.p7s
Description: S/MIME cryptographic signature
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 8:49 PM, Scott Haneda wrote:
1) How do I decide the category, can someone show me a list, and
suggest the correct one for this? I see bind9 is in net, perhaps
this should also be in net?
Yes, this would make sense to be in net and then sysutils
2) Do I really need the extract.suffix? I lean on simpler being
better.
See previous email on distfiles versus distname.
3) How do the permissions I chose look in the destroot phase?
Why is the program incapable of installing itself from --prefix=?
4) I want ahead and installed some notes and other misc files that
were in the download, should I even bother? Is this the correct
location to put them?
Eh, echoing Blair's sentiments I don't think you should bother.
5) should I call this rbldnsd-server? It is a server, it does not
include a launchd item due to the nature of how it is started being
so custom.
Bind9 is not considered a server so I don't feel this needs to be
either. There isn't a client component from which you need to
differentiate.
6) If I wanted to include a sample zone file for this, where would
the best place be to store that, and what is the correct suggested
naming convention for the name of that sample file?
rbldnsd.zone.sample?
If it's an example, why not in ${prefix}/share/${name}/ or other
typical Unix path (with prefix in front)?
smime.p7s
Description: S/MIME cryptographic signature
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
Thanks, so I changed it to:
distname${name}_${version}
I believe that is correct. But now it ignores master_sites and I am
timing out on looking for the file on macports servers.
namerbldnsd
version 0.996b
categories sysutils
maintainers hostwizard.com:scott
master_siteshttp://www.corpit.ru/mjt/rbldnsd/
homepagehttp://www.corpit.ru/mjt/rbldnsd.html
distname${name}_${version}
On Jun 10, 2009, at 5:54 PM, Jeremy Lavergne wrote:
distfiles is this by default:
${distname}${extract.suffix}
distname is this by default:
${name}-${version}
That is, distfiles (defined as the name of the distribution
filename, not including the extract suffix) is
${name}-${version}${extract.suffix}
If that hyphen really is an underscore, you consider changing it in
distname instead of distfiles.
On Jun 10, 2009, at 8:49 PM, Scott Haneda wrote:
distfiles ${name}_${version}${extract.suffix}
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 6:01 PM, Blair Zajac wrote:
Scott Haneda wrote:
Hello, I have made a portfile, looking for a quick review, and any
suggestions for cleanup.
pre-destroot {
addgroup _rbldnsd
set gid [existsgroup _rbldnsd]
adduser _rbldnsd gid=${gid} realname=rbldnsd home=${prefix}/
sbin
}
Do we need a new user for this daemon? How about just using nobody?
The app does require a user to run, at least, I had to specify one.
Is nobody a valid user? You mean to add in a user of nobody, or
just let the user run it with no user specified, or specifically chose
nobody?
destroot {
## These perms are obviously wrong, fix them later
# Install binary
xinstall -m 0755 ${worksrcpath}/${name} ${destroot}${prefix}/sbin
# Install man page 'rbldnsd.8'
xinstall -m 0640 ${worksrcpath}/${name}.8 ${destroot}${prefix}/
share/man/man8
# Install misc files
xinstall -d ${prefix}/share/doc/${name}/
Need ${destroot}
Can you elaborate, I am not sure I am following?
xinstall -m 0640 -W ${worksrcpath} \
NEWS README.user TODO \
${prefix}/share/doc/${name}/
Need ${destroot}
Not getting it :(
}
post-activate {
ui_msg
=
=
=
=
${name} has been installed correctly
You can find ${name} at ${prefix}/sbin/${name}
Please see the man page `man ${name}` for detailed setup
instructions.
You will need a launchd plist file to start the server. Please
create
one based on your specific needs.
${name} does not have a configuration file, all configuration
files
are specified as arguments to the startup of ${name}
You can find additional files of interest in:
${prefix}/share/doc/${name}/NEWS
${prefix}/share/doc/${name}/README.user
${prefix}/share/doc/${name}/TODO
See ${homepage} for more information.
=
=
=
=
}
This is redundant information I think, all portfiles behave the same
way, so I don't see why it should be printed.
Mainly, because this was a strange binary to use. There is no make
install, you get a bunch of files, the Web site does not tell you
there is even a man page, and the docs on the Web site I could put in
a ui_messages they are so short. NEWS and TODO were not valuable to
me, but README.user was.
I could lose the files, but the mention of there being a man page was
valuable to me at least. I will nuke the ui_msg though.
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 6:07 PM, Jeremy Lavergne wrote:
On Jun 10, 2009, at 8:49 PM, Scott Haneda wrote:
1) How do I decide the category, can someone show me a list, and
suggest the correct one for this? I see bind9 is in net, perhaps
this should also be in net?
Yes, this would make sense to be in net and then sysutils
Ok, will do. Is there a guideline?
2) Do I really need the extract.suffix? I lean on simpler being
better.
See previous email on distfiles versus distname.
See reply, can not seem to get it to work for some silly reason.
3) How do the permissions I chose look in the destroot phase?
Why is the program incapable of installing itself from --prefix=?
I am not that versed in this stuff. I run ./configure and it works,
if I run ./configure with the --prefix is balks at me...
$./configure -help
configure: configure rbldnsd package.
Usage: ./configure [options]
where options are:
--enable-option, --with-option --
enable the named option/feature
--disable-option, --without-option, --no-option --
disable the named option/feature
--help - print this help and exit
Optional features (all enabled by default if system supports a feature):
ipv6 - enable/disable IP version 6 (IPv6) support
stats - enable/disable runtime statistics
master-dump - enable/disable master-format (bind) dump support (-d
option)
zlib - zlib support
dso - dynamic extensions (using shared objects) -- disabled by
default
$./configure --prefix=/foo
configure: unknown option `--prefix=/foo'
4) I want ahead and installed some notes and other misc files that
were in the download, should I even bother? Is this the correct
location to put them?
Eh, echoing Blair's sentiments I don't think you should bother.
Ok, will nuke them, was a good exercise anyway though, xinstall
through me for a loop a few times, I know better now.
5) should I call this rbldnsd-server? It is a server, it does not
include a launchd item due to the nature of how it is started being
so custom.
Bind9 is not considered a server so I don't feel this needs to be
either. There isn't a client component from which you need to
differentiate.
Got it.
6) If I wanted to include a sample zone file for this, where would
the best place be to store that, and what is the correct suggested
naming convention for the name of that sample file?
rbldnsd.zone.sample?
If it's an example, why not in ${prefix}/share/${name}/ or other
typical Unix path (with prefix in front)?
Sounds good to me, I was genuinely just asking what a good place would
be. I am not aware of a guideline on where things go, and from unix
to unix, people do things a little different all over the place. I am
trying to conform to the macports way as much as possible. Thanks for
the path, I will look at using that, if I get around to including a
plist at all.
Thanks for the pointers.
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
If you run these commands, what is the URL it ends up using?
sudo port clean --all rbldnsd
sudo port -d fetch rbldnsd
On Jun 10, 2009, at 9:08 PM, Scott Haneda wrote:
Thanks, so I changed it to:
distname${name}_${version}
I believe that is correct. But now it ignores master_sites and I am
timing out on looking for the file on macports servers.
namerbldnsd
version 0.996b
categories sysutils
maintainers hostwizard.com:scott
master_siteshttp://www.corpit.ru/mjt/rbldnsd/
homepagehttp://www.corpit.ru/mjt/rbldnsd.html
distname${name}_${version}
smime.p7s
Description: S/MIME cryptographic signature
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
In the destroot phase, all paths should be prefaced by ${destroot}
On Jun 10, 2009, at 9:14 PM, Scott Haneda wrote:
destroot {
## These perms are obviously wrong, fix them later
# Install binary
xinstall -m 0755 ${worksrcpath}/${name} ${destroot}${prefix}/sbin
# Install man page 'rbldnsd.8'
xinstall -m 0640 ${worksrcpath}/${name}.8 ${destroot}${prefix}/
share/man/man8
# Install misc files
xinstall -d ${prefix}/share/doc/${name}/
Need ${destroot}
Can you elaborate, I am not sure I am following?
xinstall -m 0640 -W ${worksrcpath} \
NEWS README.user TODO \
${prefix}/share/doc/${name}/
Need ${destroot}
Not getting it :(
smime.p7s
Description: S/MIME cryptographic signature
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
3) How do the permissions I chose look in the destroot phase?
Why is the program incapable of installing itself from --prefix=?
I am not that versed in this stuff. I run ./configure and it works,
if I run ./configure with the --prefix is balks at me...
$./configure -help
configure: configure rbldnsd package.
Usage: ./configure [options]
where options are:
--enable-option, --with-option --
enable the named option/feature
--disable-option, --without-option, --no-option --
disable the named option/feature
--help - print this help and exit
Optional features (all enabled by default if system supports a
feature):
ipv6 - enable/disable IP version 6 (IPv6) support
stats - enable/disable runtime statistics
master-dump - enable/disable master-format (bind) dump support (-d
option)
zlib - zlib support
dso - dynamic extensions (using shared objects) -- disabled by
default
$./configure --prefix=/foo
configure: unknown option `--prefix=/foo'
Wow. Hand-spun configure file.
Yea, you have it right then. We cannot use --prefix on configure, and
since i believe you said there is no makefile previously we'll likely
need to do the xinstalls like you're doing.
However, make sure those ${destroot} get added to the install paths
that are missing them.
smime.p7s
Description: S/MIME cryptographic signature
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 6:21 PM, Jeremy Lavergne wrote:
If you run these commands, what is the URL it ends up using?
sudo port clean --all rbldnsd
sudo port -d fetch rbldnsd
Seems to be working now with
distname${name}_${version}
Seems to take a lot longer, since it now has to time out on
--- Attempting to fetch rbldnsd_0.996b.tar.gz from
http://distfiles.macports.org/rbldnsd
Instead of going right to the source as I had it before. Is the idea
macports will cache this file at some point or something?
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 6:24 PM, Jeremy Lavergne wrote:
However, make sure those ${destroot} get added to the install paths
that are missing them.
I am not getting this, every effort I made, I get an error.
destroot {
# Install binary
xinstall -m 0755 ${worksrcpath}/${name} ${destroot}${prefix}/sbin
# Install man page 'rbldnsd.8'
xinstall -m 0640 ${worksrcpath}/${name}.8 ${destroot}${prefix}/
share/man/man8
}
That is how I have it, it works. Are you saying this I need to set
destroot to the source of the target, I have it set in the target
now. I looked at my original email to be sure I did not copy and
paste the wrong file.
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 6:36 PM, Jeremy Lavergne wrote:
However, make sure those ${destroot} get added to the install
paths that are missing them.
I am not getting this, every effort I made, I get an error.
destroot {
# Install binary
xinstall -m 0755 ${worksrcpath}/${name} ${destroot}${prefix}/sbin
# Install man page 'rbldnsd.8'
xinstall -m 0640 ${worksrcpath}/${name}.8 ${destroot}${prefix}/
share/man/man8
}
That is how I have it, it works. Are you saying this I need to set
destroot to the source of the target, I have it set in the target
now. I looked at my original email to be sure I did not copy and
paste the wrong file.
On a previous email where you received Need destroot one of the
destinations did not begin with ${destroot}. It seems those are
fixed or gone, from the above.
What are the errors you're now receiving?
Here is the portfile, below is the error, which seems to be false, as
the path does indeed exist:
* I moved it into net, and changed category to net, then ran portindex
again.
# $Id$
PortSystem 1.0
namerbldnsd
version 0.996b
categories net
maintainers hostwizard.com:scott
master_siteshttp://www.corpit.ru/mjt/rbldnsd/
homepagehttp://www.corpit.ru/mjt/rbldnsd.html
distname${name}_${version}
description rbldnsd is a small and fast DNS daemon which \
is especially made to serve DNSBL zone
long_description The daemon can serve both IP-based (ordb.org,
dsbl.org etc) \
and name-based (rfc-ignorant.org) blocklists.
Unlike DJB's \
rbldns, it has ability to specify individual
values for every \
entry, can serve as many zones on a single IP
address as you \
wish, and, finally, it is a real nameserver: it
can reply to \
DNS metadata requests. The daemon keeps all zones
in memory \
for faster operations, but its memory usage is
very efficient, \
especially for repeated TXT values which are
stored only once.
checksums md5 9a0f26f3b33764c325a96bd4c61b26fa \
sha19cfe6cf01c54088cecc3a02902c721ee714f1c28 \
rmd160 15be588fb4051f0526084425b586ea7986b6493a
configure.pre_args-delete --prefix=${prefix}
pre-destroot {
# Add user and group, these are the users rbldnsd will start as
addgroup _rbldnsd
set gid [existsgroup _rbldnsd]
adduser _rbldnsd gid=${gid} realname=rbldnsd home=${prefix}/
sbin
}
destroot {
# Install binary
xinstall -m 0755 ${worksrcpath}/${name} ${destroot}${prefix}/sbin
# Install man page 'rbldnsd.8'
xinstall -m 0640 ${worksrcpath}/${name}.8 ${destroot}${prefix}/
share/man/man8
}
$sudo port -d install
DEBUG: Changing to port directory: /Users/haneda/macports/net/rbldnsd
DEBUG: setting option os.universal_supported to yes
DEBUG: org.macports.load registered provides 'load', a pre-existing
procedure. Target override will not be provided
DEBUG: org.macports.distfiles registered provides 'distfiles', a pre-
existing procedure. Target override will not be provided
DEBUG: adding the default universal variant
DEBUG: Requested variant darwin is not provided by port rbldnsd.
DEBUG: Requested variant i386 is not provided by port rbldnsd.
DEBUG: Requested variant macosx is not provided by port rbldnsd.
DEBUG: Changing to port directory: /Users/haneda/macports/net/rbldnsd
DEBUG: setting option os.universal_supported to yes
DEBUG: org.macports.load registered provides 'load', a pre-existing
procedure. Target override will not be provided
DEBUG: org.macports.distfiles registered provides 'distfiles', a pre-
existing procedure. Target override will not be provided
DEBUG: adding the default universal variant
DEBUG: Requested variant darwin is not provided by port rbldnsd.
DEBUG: Requested variant i386 is not provided by port rbldnsd.
DEBUG: Requested variant macosx is not provided by port rbldnsd.
DEBUG: Executing org.macports.main (rbldnsd)
DEBUG: Skipping completed org.macports.fetch (rbldnsd)
DEBUG: Skipping completed org.macports.checksum (rbldnsd)
DEBUG: Skipping completed org.macports.extract (rbldnsd)
DEBUG: Skipping completed org.macports.patch (rbldnsd)
--- Configuring rbldnsd
DEBUG: Using compiler 'Mac OS X gcc 4.0'
DEBUG: Executing org.macports.configure (rbldnsd)
DEBUG: Environment: CFLAGS='-O2' CPPFLAGS='-I/opt/local/include'
CXXFLAGS='-O2' MACOSX_DEPLOYMENT_TARGET='10.5' CPP='/usr/bin/cpp-4.0'
CXX='/usr/bin/g++-4.0' F90FLAGS='-O2' LDFLAGS='-L/opt/local/lib'
FCFLAGS='-O2' OBJC='/usr/bin/gcc-4.0' INSTALL='/usr/bin/install -c'
OBJCFLAGS='-O2' FFLAGS='-O2' CC='/usr/bin/gcc-4.0'
DEBUG: Assembled command: 'cd /opt/local/var/macports/build/
_Users_haneda_macports_net_rbldnsd/work/rbldnsd_0.996b ./configure'
sh: line 0: cd:
Re: Looking for a portfile review before submitting (rbldnsd)
Yes. Call me officially frustrated... can someone see if this installs for them, or if they see anything obvious, as I am not: http://dl.getdropbox.com/u/340087/Drops/06.10.09/net-d93a2d96-185819.zip $sudo port -d install DEBUG: Changing to port directory: /Users/haneda/macports/net/rbldnsd DEBUG: setting option os.universal_supported to yes DEBUG: org.macports.load registered provides 'load', a pre-existing procedure. Target override will not be provided DEBUG: org.macports.distfiles registered provides 'distfiles', a pre- existing procedure. Target override will not be provided DEBUG: adding the default universal variant DEBUG: Requested variant darwin is not provided by port rbldnsd. DEBUG: Requested variant i386 is not provided by port rbldnsd. DEBUG: Requested variant macosx is not provided by port rbldnsd. DEBUG: Changing to port directory: /Users/haneda/macports/net/rbldnsd DEBUG: setting option os.universal_supported to yes DEBUG: org.macports.load registered provides 'load', a pre-existing procedure. Target override will not be provided DEBUG: org.macports.distfiles registered provides 'distfiles', a pre- existing procedure. Target override will not be provided DEBUG: adding the default universal variant DEBUG: Requested variant darwin is not provided by port rbldnsd. DEBUG: Requested variant i386 is not provided by port rbldnsd. DEBUG: Requested variant macosx is not provided by port rbldnsd. DEBUG: Executing org.macports.main (rbldnsd) DEBUG: Skipping completed org.macports.fetch (rbldnsd) DEBUG: Skipping completed org.macports.checksum (rbldnsd) DEBUG: Skipping completed org.macports.extract (rbldnsd) DEBUG: Skipping completed org.macports.patch (rbldnsd) --- Configuring rbldnsd DEBUG: Using compiler 'Mac OS X gcc 4.0' DEBUG: Executing org.macports.configure (rbldnsd) DEBUG: Environment: CFLAGS='-O2' CPPFLAGS='-I/opt/local/include' CXXFLAGS='-O2' MACOSX_DEPLOYMENT_TARGET='10.5' CPP='/usr/bin/cpp-4.0' CXX='/usr/bin/g++-4.0' F90FLAGS='-O2' LDFLAGS='-L/opt/local/lib' FCFLAGS='-O2' OBJC='/usr/bin/gcc-4.0' INSTALL='/usr/bin/install -c' OBJCFLAGS='-O2' FFLAGS='-O2' CC='/usr/bin/gcc-4.0' DEBUG: Assembled command: 'cd /opt/local/var/macports/build/ _Users_haneda_macports_net_rbldnsd/work/rbldnsd_0.996b ./configure' sh: line 0: cd: /opt/local/var/macports/build/ _Users_haneda_macports_net_rbldnsd/work/rbldnsd_0.996b: No such file or directory Error: Target org.macports.configure returned: configure failure: shell command cd /opt/local/var/macports/build/ _Users_haneda_macports_net_rbldnsd/work/rbldnsd_0.996b ./configure returned error 1 Command output: sh: line 0: cd: /opt/local/var/macports/build/ _Users_haneda_macports_net_rbldnsd/work/rbldnsd_0.996b: No such file or directory Warning: the following items did not execute (for rbldnsd): org.macports.activate org.macports.configure org.macports.build org.macports.destroot org.macports.install Error: Status 1 encountered during processing. Here is now I know it is not being truthful: $cd /opt/local/var/macports/build/_Users_haneda_macports_net_rbldnsd/ work/rbldnsd_0.996b /opt/local/var/macports/build/_Users_haneda_macports_net_rbldnsd/work/ rbldnsd-0.996b han...@macbook rbldnsd-0.996b $ls -la total 824 drwxrwxr-x 45 root admin 1530 Mar 29 2008 . drwxr-xr-x 4 root admin136 Jun 10 18:54 .. -rw-rw-r-- 1 root admin124 Jul 27 2006 .cvsignore -rw-rw-r-- 1 root admin 6500 Apr 4 2003 CHANGES-0.81 -rw-rw-r-- 1 root admin 5343 Sep 17 2006 Makefile.in -rw-rw-r-- 1 root admin 29052 Mar 29 2008 NEWS -rw-rw-r-- 1 root admin 1736 Jul 29 2004 README.user -rw-rw-r-- 1 root admin 1777 Sep 17 2006 TODO -rwxrwxr-x 1 root admin 7296 Mar 29 2008 configure -rw-rw-r-- 1 root admin 5514 Mar 15 2006 configure.lib drwxrwxr-x 9 root admin306 Mar 29 2008 debian -rw-rw-r-- 1 root admin 5150 Mar 9 2005 dns.h -rw-rw-r-- 1 root admin447 May 29 2003 dns_dnequ.c -rw-rw-r-- 1 root admin271 Apr 3 2003 dns_dnlabels.c -rw-rw-r-- 1 root admin348 May 4 2003 dns_dnlen.c -rw-rw-r-- 1 root admin795 May 4 2003 dns_dnreverse.c -rw-rw-r-- 1 root admin385 Apr 3 2003 dns_dntol.c -rw-rw-r-- 1 root admin 1199 Apr 3 2003 dns_dntop.c -rw-rw-r-- 1 root admin660 Apr 28 2003 dns_findname.c -rw-rw-r-- 1 root admin919 May 8 2003 dns_maketab.awk -rw-rw-r-- 1 root admin 1776 Apr 3 2003 dns_ptodn.c -rw-rw-r-- 1 root admin 1895 Sep 17 2006 hooks.c -rw-rw-r-- 1 root admin 1589 Dec 19 2005 ip4addr.h -rw-rw-r-- 1 root admin715 Apr 3 2003 ip4atos.c -rw-rw-r-- 1 root admin721 May 27 2003 ip4mask.c -rw-rw-r-- 1 root admin 5844 Jun 27 2004 ip4parse.c -rw-rw-r-- 1 root admin 9913 Oct 7 2007 istream.c -rw-rw-r-- 1 root admin 1436 Jun 12 2006 istream.h -rw-rw-r-- 1 root admin 3763 Oct 7 2007 mempool.c -rw-rw-r-- 1 root admin Jun 12 2006 mempool.h -rw-rw-r--
Re: Looking for a portfile review before submitting (rbldnsd)
Like this?
worksrcdir ${name}_${version}
I did, no change.
If I do this:
distfiles ${name}_${version}${extract.suffix}
extract.suffix .tar.tgz
Works fine, doing this, fails:
distname${name}_${version}
I think I should just go back to my original method, though it may be
messy. I will give it one more go to understand why sitname is not
enough.
On Jun 10, 2009, at 7:07 PM, Toby Peterson wrote:
Looks like you just need to set worksrcdir
- Toby
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Wed, Jun 10, 2009 at 07:13:46PM -0700, Scott Haneda said:
Like this?
worksrcdir ${name}_${version}
No, when you set distname, worksrcdir takes on the same value, which is this
case appears to be wrong (the distname uses an underscore, but the extracted
directory uses a dash). So if you keep your old distname (remove distfiles
and extract.suffix), then add
worksrcdir ${name}-${version}
it should see the right dir. Unfortunately some authors like to vary naming
like this...
Bryan
I did, no change.
If I do this:
distfiles ${name}_${version}${extract.suffix}
extract.suffix .tar.tgz
Works fine, doing this, fails:
distname${name}_${version}
I think I should just go back to my original method, though it may be
messy. I will give it one more go to understand why sitname is not
enough.
On Jun 10, 2009, at 7:07 PM, Toby Peterson wrote:
Looks like you just need to set worksrcdir
- Toby
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
On Jun 10, 2009, at 7:22 PM, Bryan Blackburn wrote:
On Wed, Jun 10, 2009 at 07:13:46PM -0700, Scott Haneda said:
Like this?
worksrcdir ${name}_${version}
No, when you set distname, worksrcdir takes on the same value, which
is this
case appears to be wrong (the distname uses an underscore, but the
extracted
directory uses a dash). So if you keep your old distname (remove
distfiles
and extract.suffix), then add
worksrcdir ${name}-${version}
it should see the right dir. Unfortunately some authors like to
vary naming
like this...
Ah ha, makes sense now. I hate the underscore today :)
$sudo port install rbldnsd
--- Fetching rbldnsd
--- Verifying checksum(s) for rbldnsd
--- Extracting rbldnsd
--- Configuring rbldnsd
--- Building rbldnsd
--- Staging rbldnsd into destroot
--- Installing rbldnsd @0.996b_0
--- Activating rbldnsd @0.996b_0
--- Cleaning rbldnsd
I will submit it to trac, down to 40 lines or so now. Thanks all.
--
Scott * If you contact me off list replace talklists@ with scott@ *
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
Scott Haneda wrote:
Hello, I have made a portfile, looking for a quick review, and any
suggestions for cleanup.
1) How do I decide the category, can someone show me a list, and suggest
the correct one for this? I see bind9 is in net, perhaps this should
also be in net?
2) Do I really need the extract.suffix? I lean on simpler being better.
3) How do the permissions I chose look in the destroot phase?
4) I want ahead and installed some notes and other misc files that were
in the download, should I even bother? Is this the correct location to
put them?
Yes, do install them into ${prefix}/share/doc/${name}
5) should I call this rbldnsd-server? It is a server, it does not
include a launchd item due to the nature of how it is started being so
custom.
6) If I wanted to include a sample zone file for this, where would the
best place be to store that, and what is the correct suggested naming
convention for the name of that sample file? rbldnsd.zone.sample?
The bind9 port installs base files you can use as *.dist. But it would be a
real file and not a sample one that contains a lot of local examples.
I suggest installing the bind9 port and seeing how it's done there.
Regards,
Blair
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
Re: Looking for a portfile review before submitting (rbldnsd)
Jeremy Lavergne wrote:
On Jun 10, 2009, at 8:49 PM, Scott Haneda wrote:
1) How do I decide the category, can someone show me a list, and
suggest the correct one for this? I see bind9 is in net, perhaps
this should also be in net?
Yes, this would make sense to be in net and then sysutils
2) Do I really need the extract.suffix? I lean on simpler being better.
See previous email on distfiles versus distname.
3) How do the permissions I chose look in the destroot phase?
Why is the program incapable of installing itself from --prefix=?
4) I want ahead and installed some notes and other misc files that
were in the download, should I even bother? Is this the correct
location to put them?
Eh, echoing Blair's sentiments I don't think you should bother.
To be clear, I think any doc files should be installed in
${prefix}/share/doc/${name} to make use of this simple. Just don't include the
ui_msg.
Blair
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
