Re: New ocaml category?

2017-12-19 Thread Ryan Schmidt

On Dec 16, 2017, at 19:36, Perry E. Metzger wrote:

> There are currently over 300 ocaml packages in devel/
> 
> I would like to create a new "ocaml" category and move them all into
> a top level "ocaml" directory.
> 
> Questions:
> 
> 0) If I am not mistaken, all that needs to be done to create the new
> category is to create the "ocaml" directory. Is there any file
> etc. that needs updating?

Right, you only need to create the directory, move the portfile directories 
into it, and update the categories line in those portfile. There is no separate 
file that lists categories.

> 1) I believe it would be appropriate to do the move with a single git
> commit. Is this correct?

Yes, a single commit would be good.

> 2) Should I explicitly add the "ocaml" category to the categories line
> of all these packages at the same time? Or should that be a distinct
> commit?

I would do it in the same commit.

> 3) Many of the packages list themselves as being in an "ml"
> category. Given that OCaml really isn't standard ML at all, I'm
> thinking of removing that category from them. Is that okay?

Needs someone with knowledge of these ports to make that decision. Sounds like 
you're that person! So go ahead with what you think is best.




Re: New ocaml category?

2017-12-17 Thread Zero King

On Sat, Dec 16, 2017 at 08:36:06PM -0500, Perry E. Metzger wrote:

There are currently over 300 ocaml packages in devel/

I would like to create a new "ocaml" category and move them all into
a top level "ocaml" directory.

Questions:

0) If I am not mistaken, all that needs to be done to create the new
category is to create the "ocaml" directory. Is there any file
etc. that needs updating?


Yes, but Git ignores empty directories, so just move Portfiles over and
modify the categories lines.


1) I believe it would be appropriate to do the move with a single git
commit. Is this correct?

2) Should I explicitly add the "ocaml" category to the categories line
of all these packages at the same time? Or should that be a distinct
commit?


Yes, or else `port lint` will throw an error. e.g.
Error: Portfile parent directory mail does not match primary category net


3) Many of the packages list themselves as being in an "ml"
category. Given that OCaml really isn't standard ML at all, I'm
thinking of removing that category from them. Is that okay?

Note that a lot of these packages are crusty/old/don't build any more,
but I'll be fixing that over a long period of time.

Perry
--
Perry E. Metzgerpe...@piermont.com


--
Best regards,
Zero King


smime.p7s
Description: S/MIME cryptographic signature


New ocaml category?

2017-12-16 Thread Perry E. Metzger
There are currently over 300 ocaml packages in devel/

I would like to create a new "ocaml" category and move them all into
a top level "ocaml" directory.

Questions:

0) If I am not mistaken, all that needs to be done to create the new
category is to create the "ocaml" directory. Is there any file
etc. that needs updating?

1) I believe it would be appropriate to do the move with a single git
commit. Is this correct?

2) Should I explicitly add the "ocaml" category to the categories line
of all these packages at the same time? Or should that be a distinct
commit?

3) Many of the packages list themselves as being in an "ml"
category. Given that OCaml really isn't standard ML at all, I'm
thinking of removing that category from them. Is that okay?

Note that a lot of these packages are crusty/old/don't build any more,
but I'll be fixing that over a long period of time.

Perry
-- 
Perry E. Metzgerpe...@piermont.com