Workflows and best practices for pull requests?

[Kevin Horton]

I'm new to working with a team of committers, and I'm a very basic git user, so 
I'm struggling to figure out workflows and best practices when making a pull 
request and reviewing comments on a pull request.

Questions:
1. One of the checkboxes when making a pull request is "squashed and minimized 
your commits".  I tend to make many small commits when working on my personal 
projects.  What is the best way to squash those commits before making the pull 
request?  Google seems to suggest an interactive rebase is the way to go.  
Comments?

2. I'm completely baffled by the GitHub interface for dealing with comments on 
a pull request.  Assuming I have made and testing the changes suggested by 
reviewers, what is my next action?  Make a new pull request?  Is there a way to 
modify the existing pull request?  

Thanks,

Kevin

Re: python and gtk3 and gdk-pixbuf and maybe big sur

[Langer, Stephen A. (Fed) via macports-users]

On 7/12/21, 9:52 PM, "macports-users on behalf of Langer, Stephen A. (Fed) via 
macports-users" 
mailto:macports-users-boun...@lists.macports.org>
 on behalf of 
macports-users@lists.macports.org> 
wrote:






On 7/12/21, 8:34 PM, "Ryan Schmidt"  wrote:



On Jul 12, 2021, at 10:40, Langer, Stephen A. (Fed) wrote:

>

> Hi --

>

> Since upgrading to Big Sur and reinstalling all ports, I can't run gtk3 
with either python37 or python38.  Running this:

>

> % python

 import gi

 gi.require_version("Gtk", "3.0")

 from gi.repository import Gtk

>

> Leads to this:

>

> ** (process:3291): WARNING **: 11:18:57.866: Failed to load shared 
library './gdk-pixbuf/libgdk_pixbuf-2.0.0.dylib' referenced by the typelib: 
dlopen(./gdk-pixbuf/libgdk_pixbuf-2.0.0.dylib, 9): image not found

>

> using either python27 or python38.  The gdk-pixbuf2 port is installed.

>

> I have two MacPorts installations, one for the default variants and one 
that uses quartz instead of x11, so both are built from source and use a 
non-standard installation prefix.  This didn’t cause a problem before the Big 
Sur upgrade.  Both have the same problem now.

>

> Can someone tell me if this problem exists on a normal MacPorts 
installation?  Am I doing something wrong?  I've tried the fixes suggested in 
https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrac.macports.org%2Fticket%2F61699data=04%7C01%7Cstephen.langer%40nist.gov%7C4dca606d006f4e75dad208d945960583%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637617332906884800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=%2B9RNpGISzc4bbqR7MixWiP5MsPAbLMlOcC6Mb%2BPcHNc%3Dreserved=0.

>

> I don't know for sure if the problem is due to the Big Sur upgrade.



You didn't say whether you were on Intel or Apple Silicon so I downloaded 
both




https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpackages.macports.org%2Fgdk-pixbuf2%2Fgdk-pixbuf2-2.42.2_2%252Bx11.darwin_20.x86_64.tbz2data=04%7C01%7Cstephen.langer%40nist.gov%7C4dca606d006f4e75dad208d945960583%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637617332906884800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=NpfVAyOtQI0MdQXTml5Jfx1IB%2BuhmRqJgeO64fLAMHw%3Dreserved=0



and




https://gcc02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpackages.macports.org%2Fgdk-pixbuf2%2Fgdk-pixbuf2-2.42.2_2%252Bx11.darwin_20.arm64.tbz2data=04%7C01%7Cstephen.langer%40nist.gov%7C4dca606d006f4e75dad208d945960583%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637617332906884800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=Q1y0oU4sMgjr8p62Ny%2BM9UinouOsepTeHm4WY2CEGCU%3Dreserved=0



and extracted the contents. In both of those, the files 
opt/local/share/gir-1.0/GdkPixbuf-2.0.gir and 
opt/local/share/gir-1.0/GdkPixdata-2.0.gir have the correct (absolute path) 
library reference:



 shared-library="/opt/local/lib/libgdk_pixbuf-2.0.0.dylib"



which is as I would have expected since gobject-introspection and 
gdk-pixbuf2 (and atk) were rev-bumped 6 months ago to fix this problem 
(https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrac.macports.org%2Fticket%2F61699%23comment%3A19data=04%7C01%7Cstephen.langer%40nist.gov%7C4dca606d006f4e75dad208d945960583%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637617332906884800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=Z6dOvDfUwZ%2F6Q0%2FlL6tPKGn%2FIJUezGdai7ujzlUomv4%3Dreserved=0).
 Since you use nonstandard MacPorts prefixes you won't have received those 
archives but will have built from source, but we would expect the result to be 
comparable.



Can you show us the output of this command on your system (from 
https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrac.macports.org%2Fticket%2F61699%23comment%3A14data=04%7C01%7Cstephen.langer%40nist.gov%7C4dca606d006f4e75dad208d945960583%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637617332906884800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=FNXwYlzyHdFKuSf6dF63DEdFkZwzB7I101oQNswQIJY%3Dreserved=0):



grep "shared-library" /opt/local/share/gir-1.0/*.gir | grep -v 
/opt/local/lib



(replacing both occurrences of /opt/local with whatever your MacPorts 
prefix is).











Here is the output:



iolanthe 505>> grep "shared-library" 
/opt/local/stow/ports-quartz/share/gir-1.0/*.gir | grep -v 
/opt/local/stow/ports-quartz/lib

/opt/local/stow/ports-quartz/share/gir-1.0/AppStreamGlib-1.0.gir: 
shared-library="./libappstream-glib/libappstream-glib.8.dylib"

/opt/local/stow/ports-quartz/share/gir-1.0/Atk-1.0.gir:  

Re: [dc desk calculator]

[raf via macports-users]

On Mon, Jul 12, 2021 at 08:04:19PM -0400, "Richard L. Hamilton" 
 wrote:

> > On Jul 12, 2021, at 19:27, raf via macports-users 
> >  wrote:
> > 
> > On Mon, Jul 12, 2021 at 06:06:47PM +0300, Maxim Abalenkov 
> >  wrote:
> > 
> >> Dear all,
> >> 
> >> How are you? I hope all is well with you. Would you please tell me, if the 
> >> dc (desk calculator) is available via MacPorts:
> >> 
> >>  https://en.wikipedia.org/wiki/Dc_%28computer_program%29 
> >> 
> >> 
> >> I wasn’t able to find via the `port search` command. On the other hand, I 
> >> wasn’t able to find `dc` in source code either. If you have any hints or 
> >> pointers, please let me know. Thank you and have a wonderful day ahead!
> >> 
> >> —
> >> Best wishes,
> >> Maxim
> > 
> > /usr/bin/dc is already present.
> > 
> >> dc --version
> > dc (GNU bc 1.06) 1.3
> > 
> > Copyright 1994, 1997, 1998, 2000 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions.  There is NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
> > to the extent permitted by law.
> 
> The bc port includes dc.

bc is also already on the system: /usr/bin/bc.

Re: [dc desk calculator]

[Maxim Abalenkov]

Hello everybody,

Thank you very much for all of your comments and suggestions. Learning the 
"rare RPN" is exactly the reason behind my interest in `dc`. Thank you and have 
a great day ahead!

—
Best wishes,
Maxim

Maxim Abalenkov \\ maxim.abalen...@gmail.com
+44 7 486 486 505 \\ http://mabalenk.gitlab.io

> On 13 Jul 2021, at 03:11, Richard L. Hamilton  wrote:
> 
> This might be true (that bc and dc are together) for historical reasons. 
> Commercial Unix source has bc as a front end to dc; only the rare RPN fan 
> used dc directly. The GNU version does not do that, their bc is not dependent 
> on dc.
> 
>> On Jul 12, 2021, at 20:04, Richard L. Hamilton  wrote:
>> 
>> The bc port includes dc.
>> 
>>> On Jul 12, 2021, at 19:27, raf via macports-users 
>>>  wrote:
>>> 
>>> On Mon, Jul 12, 2021 at 06:06:47PM +0300, Maxim Abalenkov 
>>>  wrote:
>>> 
 Dear all,
 
 How are you? I hope all is well with you. Would you please tell me, if the 
 dc (desk calculator) is available via MacPorts:
 
 https://en.wikipedia.org/wiki/Dc_%28computer_program%29 
 
 
 I wasn’t able to find via the `port search` command. On the other hand, I 
 wasn’t able to find `dc` in source code either. If you have any hints or 
 pointers, please let me know. Thank you and have a wonderful day ahead!
 
 —
 Best wishes,
 Maxim
>>> 
>>> /usr/bin/dc is already present.
>>> 
 dc --version
>>> dc (GNU bc 1.06) 1.3
>>> 
>>> Copyright 1994, 1997, 1998, 2000 Free Software Foundation, Inc.
>>> This is free software; see the source for copying conditions.  There is NO
>>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
>>> to the extent permitted by law.
>>> 
>> 
>> 
> 

Re: New portfile writer looking for help with ConvertAll

[Mojca Miklavec]

On Tue, 13 Jul 2021 at 05:15, Kevin Horton wrote:
>
> I assume that I would submit this via Trac to see it possibly someday show up 
> in MacPorts.

While this is perfectly OK, a lot more people are watching pull requests:
https://github.com/macports/macports-ports/pulls
By submitting a pull request, it will be seen by multiple developers
multiple times which is not necessarily true for Trac (which is
perfectly suitable for bug reports, in particular when ports have
maintainers, but it gets attention from far less people).

> I dig into the docs a bit more first to see if there are any other Portfile 
> fields I should populate, or if I can find any best practices that I have 
> violated.

GitHub is also much better than Trac to get this kind of feedback.

Mojca