Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
On Wed, Sep 5, 2012 at 1:35 AM, Romain d'Alverny wrote: > On Wed, Sep 5, 2012 at 10:03 AM, Colin Guthrie wrote: >> 'Twas brillig, and Pascal Terjan at 04/09/12 17:57 did gyre and gimble: >>> On Tue, Sep 4, 2012 at 9:52 AM, Romain d'Alverny >>> wrote: >>> By the way, there are some builds that get a strangely reported build duration (15588 days; always the same value when it occurs). I didn't investigate yet. >> >> So 15588 would be days since epoch. I guess it's the same as Pascal's >> comment. If it was submitted over 2 days ago we might not read the >> submit time and it ends up getting a timestamp of 0 and thus 15588 days >> to build. > > Ok. So at this point (where we do a find to get the files), what's the > good approach: just leave the package/build out of the list if we > can't get its name (that's the new behaviour in my pending new index > page) or fix the find to get all? I'd say the former. Yes that's fine > Two others things that are aside this very point: > > * we could gain more insight over the whole submission/build process > if we could store data about way past builds (not necessarily the full > details of each build, at least not right now, but at least the > basics: when, who, what package, how long it took on which host, what > was the result). One way to do it would be to have a database in which > we can push and update info about each submission, as it happens > (today, everything is only in the filesystem). What control points > would need to be modified to push information into such a database? Ulri would probably be enough expect for upload, so maybe ulri + emi But then it would be better to instead use that as reference in ulri/emi instead of looking through the filesystem :) > * today, submissions are shown simply by src package. Should we show > submission results per arch? (what if i586 passes and x86_64 fails for > instance). It can not happen unless there is a bug, they are submitted together
Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
On Wed, Sep 5, 2012 at 10:03 AM, Colin Guthrie wrote: > 'Twas brillig, and Pascal Terjan at 04/09/12 17:57 did gyre and gimble: >> On Tue, Sep 4, 2012 at 9:52 AM, Romain d'Alverny wrote: >> >>> By the way, there are some builds that get a strangely reported build >>> duration (15588 days; always the same value when it occurs). I didn't >>> investigate yet. > > So 15588 would be days since epoch. I guess it's the same as Pascal's > comment. If it was submitted over 2 days ago we might not read the > submit time and it ends up getting a timestamp of 0 and thus 15588 days > to build. Ok. So at this point (where we do a find to get the files), what's the good approach: just leave the package/build out of the list if we can't get its name (that's the new behaviour in my pending new index page) or fix the find to get all? I'd say the former. Two others things that are aside this very point: * we could gain more insight over the whole submission/build process if we could store data about way past builds (not necessarily the full details of each build, at least not right now, but at least the basics: when, who, what package, how long it took on which host, what was the result). One way to do it would be to have a database in which we can push and update info about each submission, as it happens (today, everything is only in the filesystem). What control points would need to be modified to push information into such a database? * today, submissions are shown simply by src package. Should we show submission results per arch? (what if i586 passes and x86_64 fails for instance).
Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
'Twas brillig, and Pascal Terjan at 04/09/12 17:57 did gyre and gimble: > On Tue, Sep 4, 2012 at 9:52 AM, Romain d'Alverny wrote: >> On Tue, Sep 4, 2012 at 4:56 PM, Thierry Vignaud >> wrote: >>> On 4 September 2012 16:11, wrote: Revision 5642 Author rda Date 2012-09-04 16:11:36 +0200 (Tue, 04 Sep 2012) Log Message skip packages with no name >>> >>> Is that possible? >> >> Well, I am guilty of not having checked further why, but it happens >> that at the end of the list of packages being built, we used to have >> all the info, except the package name. So it may be that it was >> mis-parsed, but why on these specific occurrences? is it related to >> the fact that it's "old packages" (submitted about 48 hours before) >> and that some parts of the related files were already removed? > > It is related, files are not removed but to get information we do a > find of files with a limit on mtime, so we are missing some > information if they were submitted over 2 days ago but built less than > 2 days ago > >> By the way, there are some builds that get a strangely reported build >> duration (15588 days; always the same value when it occurs). I didn't >> investigate yet. So 15588 would be days since epoch. I guess it's the same as Pascal's comment. If it was submitted over 2 days ago we might not read the submit time and it ends up getting a timestamp of 0 and thus 15588 days to build. Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
On Tuesday 04 September 2012 18:52, Romain d'Alverny wrote: > By the way, there are some builds that get a strangely reported build > duration (15588 days) $ LC_ALL=C date --date '-15588 days' Wed Dec 31 18:25:48 CET 1969 Now That would be a loong build time, it it weren't wrong. :-)= -- Johnny A. Solbu PGP key ID: 0xFA687324 signature.asc Description: This is a digitally signed message part.
Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
On Tue, Sep 4, 2012 at 9:52 AM, Romain d'Alverny wrote: > On Tue, Sep 4, 2012 at 4:56 PM, Thierry Vignaud > wrote: >> On 4 September 2012 16:11, wrote: >>> Revision 5642 Author rda Date 2012-09-04 16:11:36 +0200 (Tue, 04 Sep 2012) >>> >>> Log Message >>> >>> skip packages with no name >> >> Is that possible? > > Well, I am guilty of not having checked further why, but it happens > that at the end of the list of packages being built, we used to have > all the info, except the package name. So it may be that it was > mis-parsed, but why on these specific occurrences? is it related to > the fact that it's "old packages" (submitted about 48 hours before) > and that some parts of the related files were already removed? It is related, files are not removed but to get information we do a find of files with a limit on mtime, so we are missing some information if they were submitted over 2 days ago but built less than 2 days ago > By the way, there are some builds that get a strangely reported build > duration (15588 days; always the same value when it occurs). I didn't > investigate yet.
Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
On Tue, Sep 4, 2012 at 4:56 PM, Thierry Vignaud wrote: > On 4 September 2012 16:11, wrote: >> Revision 5642 Author rda Date 2012-09-04 16:11:36 +0200 (Tue, 04 Sep 2012) >> >> Log Message >> >> skip packages with no name > > Is that possible? Well, I am guilty of not having checked further why, but it happens that at the end of the list of packages being built, we used to have all the info, except the package name. So it may be that it was mis-parsed, but why on these specific occurrences? is it related to the fact that it's "old packages" (submitted about 48 hours before) and that some parts of the related files were already removed? By the way, there are some builds that get a strangely reported build duration (15588 days; always the same value when it occurs). I didn't investigate yet.
Re: [Mageia-dev] [soft-commits] [5642] skip packages with no name
On 4 September 2012 16:11, wrote:
> Revision 5642 Author rda Date 2012-09-04 16:11:36 +0200 (Tue, 04 Sep 2012)
>
> Log Message
>
> skip packages with no name
Is that possible?
> Modified: build_system/web/test_index.php
> ===
> --- build_system/web/test_index.php 2012-09-04 14:02:39 UTC (rev 5641)
> +++ build_system/web/test_index.php 2012-09-04 14:11:36 UTC (rev 5642)
> @@ -33,7 +33,7 @@
> if (!is_dir($upload_dir)) {
> $msg = "$upload_dir does not exist on this system. Please check your
> config.";
> error_log($msg);
> -//die($msg);
> +die($msg);
> }
>
> $g_user = isset($_GET['user']) ? htmlentities(strip_tags($_GET['user'])) :
> null;
> @@ -281,6 +281,10 @@
>
> if ($total > 0) {
> foreach ($pkgs as $key => $p) {
> +if (trim($p['package']) == '') {
> +continue;
> +}
> +
> $s .= sprintf($tmpl,
> $p['type'],
> timediff(key2timestamp($key)) . ' ago',
> @@ -346,7 +350,7 @@
>
> $s .= 'Stats. colspan="2">StatusCount%';
> foreach ($stats as $k => $v) {
> -$s .= sprintf(' class="number">%s%d%d%%',
> +$s .= sprintf(' class="number">%s%d class="percent">%d%%',
> $k, $k, $v, round($v/$total*100));
