[Mahara-contributors] [Bug 1211621] Re: Correct license info in file headers

2013-09-16 Thread Kristina Hoeppner
Sounds good to me.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1211621

Title:
  Correct license info in file headers

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  The license info currently reads:

  
  * This program is free software: you can redistribute it and/or modify
   * it under the terms of the GNU General Public License as published by
   * the Free Software Foundation, either version 3 of the License, or
   * (at your option) any later version.
  

  To avoid any confusion, it should be corrected to read

  
  * This program is free software: you can redistribute it and/or modify
   * it under the terms of the GNU General Public License as published by
   * the Free Software Foundation, either version 3 or later of the License.
  -

  The text appears as comment in probably pretty much every file in
  Mahara but also on the installation screen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1211621/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1222350] Re: Friendship request throws error

2013-09-16 Thread Kristina Hoeppner
Indeed, I've got PHP 5.4.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1222350

Title:
  Friendship request throws error

Status in Mahara ePortfolio:
  Triaged

Bug description:
  on latest 1.8.0dev:

  When I request friendship with another user, I get the following
  warning:

  [WAR] c1 (user/requestfriendship.php:105) Creating default object from empty 
value
  Call stack (most recent first):

  log_message(Creating default object from empty value, 8, true, true, 
/home/kristina/code/mahara/htdocs/user/requestfrie..., 105) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:446
  error(2, Creating default object from empty value, 
/home/kristina/code/mahara/htdocs/user/requestfrie..., 105, array(size 12)) 
at /home/kristina/code/mahara/htdocs/user/requestfriendship.php:105
  requestfriendship_submit(object(Pieform), array(size 3)) at Unknown:0
  call_user_func_array(requestfriendship_submit, array(size 2)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:528
  Pieform-__construct(array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:170
  Pieform::process(array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 3)) at 
/home/kristina/code/mahara/htdocs/user/requestfriendship.php:80

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1222350/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1223069] Re: Site files accessible in Links and resources sidebar

2013-09-16 Thread Adrian Schlegel
The sub folders feature should apply to both files in 'public' and files in 
folders other than 'public'. Of course the same restrictions should still 
apply, meaning that users can still only use the files in 'public' and its sub 
folders to re-use them in their portfolios.
And I think it's a bug fix and not a feature since administrators can currently 
link files in the 'link and resources' menu that are in a sub folder and users 
still cannot access these files :-)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1223069

Title:
  Site files accessible in Links and resources sidebar

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  According to the Site Files documentation, files uploaded into the
  site files section are meant to be accessible to all logged-in users
  (via the Site Files tab on any file selector). The one exception to
  this is files in the hard-coded Public folder, which are meant to
  also be accessible to users who aren't logged in.

  A user on the #mahara irc channel reported that Site Files sitting in
  a subdirectory, however, are not accessible to normal users. I
  verified this behavior in 1.8dev.

  To reproduce:

  1. Log in as an admin user
  2. Go to the Site Files page
  3. Create a subdirectory
  4. Upload a file into that subdirectory
  5. Log in as a non-admin user
  6. Add a files to download block to a page
  7. In the block's file selector, go to the site files page
  8. You will not see the subdirectory you created in step 4, or be able to 
access its files.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1223069/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1220517] Re: Flexible layout feature causes Leap2a export warnings

2013-09-16 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress = Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1220517

Title:
  Flexible layout feature causes Leap2a export warnings

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Version: 1.8
  Platform: all
  Browsers: all

  Exporting pages/collections to Leap2A files causes warnings:

  Here is from the  log file:

  log_message(Undefined variable: widths, 8, true, true, 
/home/sonn/code/mahara/htdocs/export/leap/lib.php, 291) at 
/home/sonn/code/mahara/htdocs/lib/errors.php:446, referer: 
http://192.168.2.47/export/index.php
  [Wed Sep 04 16:22:33 2013] [error] [client 192.168.2.47]   * error(8, 
Undefined variable: widths, 
/home/sonn/code/mahara/htdocs/export/leap/lib.php, 291, array(size 13)) at 
/home/sonn/code/mahara/htdocs/export/leap/lib.php:291, referer: 
http://192.168.2.47/export/index.php
  [Wed Sep 04 16:22:33 2013] [error] [client 192.168.2.47]   * 
PluginExportLeap-export_views() at 
/home/sonn/code/mahara/htdocs/export/leap/lib.php:134, referer: 
http://192.168.2.47/export/index.php
  [Wed Sep 04 16:22:33 2013] [error] [client 192.168.2.47]   * 
PluginExportLeap-export() at 
/home/sonn/code/mahara/htdocs/export/download.php:108, referer: 
http://192.168.2.47/export/index.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1220517/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1158086] Re: Forum: error after deleting a post that is the child of another deleted post

2013-09-16 Thread Robert Lyon
Hmm, now when I delete a forum post where the parent still is there I
get an error:

Post deleted successfully
[WAR] d2 (lib/errors.php:749) Failed to get a recordset: postgres7 error: [-1: 
ERROR:  bind message supplies 3 parameters, but prepared statement  requires 
1] in EXECUTE(SELECT id, deleted, parent FROM interaction_forum_post  WHERE 
id = ?  LIMIT 2)
Command was: SELECT id, deleted, parent FROM interaction_forum_post  WHERE 
id = ?  and values was (7,,)
Call stack (most recent first):

log_message(Failed to get a recordset: postgres7 error: [-1: E..., 8, 
true, true) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:109
log_warn(Failed to get a recordset: postgres7 error: [-1: E...) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:749
SQLException-__construct(Failed to get a recordset: postgres7 error: [-1: 
E...) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:492
get_recordset_sql(SELECT id, deleted, parent FROM interaction_forum..., 
array(size 3), 0, 2) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:333
get_record_sql(SELECT id, deleted, parent FROM interaction_forum..., 
array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:310
get_record(interaction_forum_post, id, 7, , , , , id, 
deleted, parent) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/interaction/forum/deletepost.php:123
deletepost_submit(object(Pieform), array(size 5)) at Unknown:0
call_user_func_array(deletepost_submit, array(size 2)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:528
Pieform-__construct(array(size 4)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:170
Pieform::process(array(size 4)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 4)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/interaction/forum/deletepost.php:108

I've added a fix here:
https://reviews.mahara.org/#/c/2502/

** Changed in: mahara
   Status: Fix Committed = In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1158086

Title:
  Forum: error after deleting a post that is the child of another
  deleted post

Status in Mahara ePortfolio:
  In Progress

Bug description:
  If you delete the child of a deleted post, it deletes successfully but
  then you're sent to a page that says Not found. The page you are
  looking for could not be found. The post with ID '21' is not found or
  deleted!'

  It appears that what's happening is that after you delete a post it
  tries to send you to the URL for that post's parent. If the post's
  parent is deleted, then you get this error.

  To replicate:

  1. Create a forum topic
  2. In that topic, post a reply A
  3. Then post a reply to A, called B
  4. Delete A
  5. Delete B

  Expected result: You should delete B, and then see the forum with A 
  B deleted

  Actual result: You successfully delete B, but then you see a Not
  found error page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1158086/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp