[Mahara-contributors] [Bug 1270110] Re: Unable to add new user from uploaded Leap2A file
Thanks Aaron. The alternative for this particular case could also be to rely on the file extension. If it ends with .zip then the importer should try and extract the file. If it fails, or if the file does not end with .zip, it would simply fall back to copying the whole file. I know it's pretty lame but ... -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1270110 Title: Unable to add new user from uploaded Leap2A file Status in Mahara ePortfolio: Confirmed Bug description: I am experiencing same problems as reported in (now closed) bug #746079 * I have exported all my portfolio at mahara.org and have the ZIP file * When trying to create new user at my local mahara installation (mahara 1.8.2testing, commit hash 67d9f6), the import fails with the following error = [WAR] c2 (import/leap/lib.php:126) simplexml_load_file(): /path/to/maharadata/mahara18/temp/import/username-1389955022/extract/mahara_org_username.leap.zip:1: parser error : Start tag expected, '' not found Call stack (most recent first): log_message(simplexml_load_file(): /path/to/maharadata/m..., 8, true, true, /path/to/the/mahara18/htdocs/import/..., 126) at /path/to/the/mahara18/htdocs/lib/errors.php:430 error(2, simplexml_load_file(): /path/to/maharadata/m..., /path/to/the/mahara18/htdocs/import/..., 126, array(size 2)) at Unknown:0 simplexml_load_file(/path/to/maharadata/mahara18/temp/import/mud..., SimpleXMLElement, 67584) at /path/to/the/mahara18/htdocs/import/leap/lib.php:126 PluginImportLeap-read_leap2a_xml_file() at /path/to/the/mahara18/htdocs/import/leap/lib.php:147 PluginImportLeap-build_default_load_mapping() at /path/to/the/mahara18/htdocs/import/leap/lib.php:158 PluginImportLeap-process() at /path/to/the/mahara18/htdocs/admin/users/add.php:329 adduser_submit(object(Pieform), array(size 21)) at Unknown:0 call_user_func_array(adduser_submit, array(size 2)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:528 Pieform-__construct(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:170 Pieform::process(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 7)) at /path/to/the/mahara18/htdocs/admin/users/add.php:148 [WAR] c2 (import/leap/lib.php:126) simplexml_load_file(): PK Call stack (most recent first): log_message(simplexml_load_file(): PK, 8, true, true, /path/to/the/mahara18/htdocs/import/..., 126) at /path/to/the/mahara18/htdocs/lib/errors.php:430 error(2, simplexml_load_file(): PK, /path/to/the/mahara18/htdocs/import/..., 126, array(size 2)) at Unknown:0 simplexml_load_file(/path/to/maharadata/mahara18/temp/import/mud..., SimpleXMLElement, 67584) at /path/to/the/mahara18/htdocs/import/leap/lib.php:126 PluginImportLeap-read_leap2a_xml_file() at /path/to/the/mahara18/htdocs/import/leap/lib.php:147 PluginImportLeap-build_default_load_mapping() at /path/to/the/mahara18/htdocs/import/leap/lib.php:158 PluginImportLeap-process() at /path/to/the/mahara18/htdocs/admin/users/add.php:329 adduser_submit(object(Pieform), array(size 21)) at Unknown:0 call_user_func_array(adduser_submit, array(size 2)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:528 Pieform-__construct(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:170 Pieform::process(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 7)) at /path/to/the/mahara18/htdocs/admin/users/add.php:148 [WAR] c2 (import/leap/lib.php:126) simplexml_load_file(): ^ Call stack (most recent first): log_message(simplexml_load_file(): ^, 8, true, true, /path/to/the/mahara18/htdocs/import/..., 126) at /path/to/the/mahara18/htdocs/lib/errors.php:430 error(2, simplexml_load_file(): ^, /path/to/the/mahara18/htdocs/import/..., 126, array(size 2)) at Unknown:0 simplexml_load_file(/path/to/maharadata/mahara18/temp/import/mud..., SimpleXMLElement, 67584) at /path/to/the/mahara18/htdocs/import/leap/lib.php:126 PluginImportLeap-read_leap2a_xml_file() at /path/to/the/mahara18/htdocs/import/leap/lib.php:147 PluginImportLeap-build_default_load_mapping() at /path/to/the/mahara18/htdocs/import/leap/lib.php:158 PluginImportLeap-process() at /path/to/the/mahara18/htdocs/admin/users/add.php:329 adduser_submit(object(Pieform), array(size 21)) at Unknown:0 call_user_func_array(adduser_submit, array(size 2)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:528 Pieform-__construct(array(size 7)) at
[Mahara-contributors] [Bug 1271301] A patch has been submitted for review
Patch for master branch: https://reviews.mahara.org/2947 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271301 Title: Search and filter forms need labels Status in Mahara ePortfolio: In Progress Bug description: In most filter forms, the combobox used to filter does not have an associated label. Also, in some cases the search box doesn't have a label. This is confusing for screen reader users since it's unclear what each of these elements does. This affects the following pages (latest master) - Portfolio - Pages - Portfolio - Skins - Groups - My groups - Groups - Find groups - Groups - (group) - Pages - Groups - (group) - Members - Inbox (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271301/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271301] [NEW] Search and filter forms need labels
Public bug reported: In most filter forms, the combobox used to filter does not have an associated label. Also, in some cases the search box doesn't have a label. This is confusing for screen reader users since it's unclear what each of these elements does. This affects the following pages (latest master) - Portfolio - Pages - Portfolio - Skins - Groups - My groups - Groups - Find groups - Groups - (group) - Pages - Groups - (group) - Members - Inbox (WCAG Level A) ** Affects: mahara Importance: High Assignee: Jono Mingard (mingard) Status: In Progress ** Tags: accessibility ** Changed in: mahara Status: New = In Progress ** Changed in: mahara Assignee: (unassigned) = Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271301 Title: Search and filter forms need labels Status in Mahara ePortfolio: In Progress Bug description: In most filter forms, the combobox used to filter does not have an associated label. Also, in some cases the search box doesn't have a label. This is confusing for screen reader users since it's unclear what each of these elements does. This affects the following pages (latest master) - Portfolio - Pages - Portfolio - Skins - Groups - My groups - Groups - Find groups - Groups - (group) - Pages - Groups - (group) - Members - Inbox (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271301/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1259756] Re: Not all form elements have labels
Spun off Bug #1271301 for search and filter forms ** Description changed: For people using screen readers, having a label for every form input is essential as they have no other (easy) way of knowing what the input is for. Currently there are various form fields in Mahara which do not have labels, so either existing labels need to be linked to these inputs or new (hidden) ones need to be created. - Upload file in Content - Profile - Files - New folder name input in Content - Profile - Files - All Attach file labels in Content - Resume need to be associated with their respective file inputs - - Filter select boxes in Portfolio - Skins, Groups - My Groups, Groups - Find Friends - Collection and page checkboxes when editing permissions for a group - Cookie consent - Types of cookies checkboxes Affects latest master (WCAG Level A) ** Description changed: For people using screen readers, having a label for every form input is essential as they have no other (easy) way of knowing what the input is for. Currently there are various form fields in Mahara which do not have labels, so either existing labels need to be linked to these inputs or new (hidden) ones need to be created. - - Upload file in Content - Profile - Files - - New folder name input in Content - Profile - Files + - Upload file in Content - Profile - Files [DONE] + - New folder name input in Content - Profile - Files [DONE] - All Attach file labels in Content - Resume need to be associated with their respective file inputs - Collection and page checkboxes when editing permissions for a group - Cookie consent - Types of cookies checkboxes Affects latest master (WCAG Level A) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259756 Title: Not all form elements have labels Status in Mahara ePortfolio: New Bug description: For people using screen readers, having a label for every form input is essential as they have no other (easy) way of knowing what the input is for. Currently there are various form fields in Mahara which do not have labels, so either existing labels need to be linked to these inputs or new (hidden) ones need to be created. - Upload file in Content - Profile - Files [DONE] - New folder name input in Content - Profile - Files [DONE] - All Attach file labels in Content - Resume need to be associated with their respective file inputs - Collection and page checkboxes when editing permissions for a group - Cookie consent - Types of cookies checkboxes Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259756/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1259764] A change has been merged
Reviewed: https://reviews.mahara.org/2890 Committed: http://gitorious.org/mahara/mahara/commit/65e0743218cf3d53a11b4d90d7698636abfb7dc3 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 65e0743218cf3d53a11b4d90d7698636abfb7dc3 Author: Jono Mingard jo...@catalyst.net.nz Date: Wed Jan 8 14:24:19 2014 +1300 Use focus management in Feedback form (Bug #1259764) Place feedback button should now focus the Message input of the Feedback form. Also, if the Feedback block is used on a page, the feedback form is moved so that it's under the Place feedback button in the HTML - this means that the document stays in a logical order for screen reader users. Change-Id: Ieeb71bc7b25e48b7b69683173c01cf1659e4144d Signed-off-by: Jono Mingard jo...@catalyst.net.nz -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259764 Title: Feedback form should use focus management Status in Mahara ePortfolio: In Progress Bug description: When placing feedback on a page, the feedback form appears without reloading the page. For screen reader users this can be confusing, so the 'Message' text box should be explicitly focused when the Place feedback link is activated. Related: If feedback is a block on the page, the feedback form is still added to the footer (rather than to the block). Adding it after the Place feedback link would make the page order more logical to screen reader users. Affects latest master (using Orca 3.4.2) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259764/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 993676] Re: Members did not show up in second search if the first search found no results
=== Bug #993676 Members did not show up in second search if the first search found no results === === Prerequisites === as admin create a group (group 1) and populate group with members and admins (cherri pitts - member of group) (cherri Carstens - member of group) (Fiona - not a member of group) (chandra - admin of group) === How to test === == Part 1 == 1. log in as admin(owner of Group) and open group 1 (multiple members in group) 2. search for Fiona 3. confirm that no results are found 4. search for cherri 5. confirm that 2 results are returned == Part 2 == 1. log in as chandra (admin of group) 2. search for Fiona 3. confirm that no results are found 4. search for cherri 5. confirm that 2 result are returned == Part 2 == 1. log in as cherri (member of group) 2. search for Fiona 3. confirm that no results are found 4. search for chandra 5. confirm that 2 results are returned === Test Results === == Part 1 == 3. confirmed that no results are found ✔ 5. confirmed that 2 results are returned ✔ == Part 2 == 3. confirmed that no results are found ✔ 5. confirmed that 2 results are returned ✔ == Part 3 == 3. confirmed that no results are found ✔ 5. confirmed that 2 results are returned ✔ == Note == could not replicate this bug before adding the patch in chrome or firefox Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/993676 Title: Members did not show up in second search if the first search found no results Status in Mahara ePortfolio: Fix Released Bug description: Version: master Browser: Chromium Assumption + logged user is member of one or several groups Actions 1. Open a group from My groups 2. Search member of this group with a keyword so that no member is found 3. Search member again with another keyword so that more than one member are found Results - Empty list of members with number of results is not 0 (see attached file) - The list of member won't be displayed till I refresh the page. Expected results - List of members. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/993676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1270110] Re: Unable to add new user from uploaded Leap2A file
Hi David, Inspecting the file extension is actually step #2 on my list of steps to take to fix that bug. :) That's what Moodle does, it has an array of file extensions which it maps to mime types. The only thing better than that approach, is to use the Magic database ( http://www.magicdb.org/ ), which can actually inspect the file's contents and make a more informed decision about its format. That's what the PHP fileinfo extension does, but there's currently some issues that are preventing that from working properly. Ultimately what I want to do is have a series of fallbacks, where we try fileinfo first, then if that doesn't work we try the Moodle mimetype array, and then if that doesn't work, we call it a generic application /octet-stream. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1270110 Title: Unable to add new user from uploaded Leap2A file Status in Mahara ePortfolio: Confirmed Bug description: I am experiencing same problems as reported in (now closed) bug #746079 * I have exported all my portfolio at mahara.org and have the ZIP file * When trying to create new user at my local mahara installation (mahara 1.8.2testing, commit hash 67d9f6), the import fails with the following error = [WAR] c2 (import/leap/lib.php:126) simplexml_load_file(): /path/to/maharadata/mahara18/temp/import/username-1389955022/extract/mahara_org_username.leap.zip:1: parser error : Start tag expected, '' not found Call stack (most recent first): log_message(simplexml_load_file(): /path/to/maharadata/m..., 8, true, true, /path/to/the/mahara18/htdocs/import/..., 126) at /path/to/the/mahara18/htdocs/lib/errors.php:430 error(2, simplexml_load_file(): /path/to/maharadata/m..., /path/to/the/mahara18/htdocs/import/..., 126, array(size 2)) at Unknown:0 simplexml_load_file(/path/to/maharadata/mahara18/temp/import/mud..., SimpleXMLElement, 67584) at /path/to/the/mahara18/htdocs/import/leap/lib.php:126 PluginImportLeap-read_leap2a_xml_file() at /path/to/the/mahara18/htdocs/import/leap/lib.php:147 PluginImportLeap-build_default_load_mapping() at /path/to/the/mahara18/htdocs/import/leap/lib.php:158 PluginImportLeap-process() at /path/to/the/mahara18/htdocs/admin/users/add.php:329 adduser_submit(object(Pieform), array(size 21)) at Unknown:0 call_user_func_array(adduser_submit, array(size 2)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:528 Pieform-__construct(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:170 Pieform::process(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 7)) at /path/to/the/mahara18/htdocs/admin/users/add.php:148 [WAR] c2 (import/leap/lib.php:126) simplexml_load_file(): PK Call stack (most recent first): log_message(simplexml_load_file(): PK, 8, true, true, /path/to/the/mahara18/htdocs/import/..., 126) at /path/to/the/mahara18/htdocs/lib/errors.php:430 error(2, simplexml_load_file(): PK, /path/to/the/mahara18/htdocs/import/..., 126, array(size 2)) at Unknown:0 simplexml_load_file(/path/to/maharadata/mahara18/temp/import/mud..., SimpleXMLElement, 67584) at /path/to/the/mahara18/htdocs/import/leap/lib.php:126 PluginImportLeap-read_leap2a_xml_file() at /path/to/the/mahara18/htdocs/import/leap/lib.php:147 PluginImportLeap-build_default_load_mapping() at /path/to/the/mahara18/htdocs/import/leap/lib.php:158 PluginImportLeap-process() at /path/to/the/mahara18/htdocs/admin/users/add.php:329 adduser_submit(object(Pieform), array(size 21)) at Unknown:0 call_user_func_array(adduser_submit, array(size 2)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:528 Pieform-__construct(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:170 Pieform::process(array(size 7)) at /path/to/the/mahara18/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 7)) at /path/to/the/mahara18/htdocs/admin/users/add.php:148 [WAR] c2 (import/leap/lib.php:126) simplexml_load_file(): ^ Call stack (most recent first): log_message(simplexml_load_file(): ^, 8, true, true, /path/to/the/mahara18/htdocs/import/..., 126) at /path/to/the/mahara18/htdocs/lib/errors.php:430 error(2, simplexml_load_file(): ^, /path/to/the/mahara18/htdocs/import/..., 126, array(size 2)) at Unknown:0 simplexml_load_file(/path/to/maharadata/mahara18/temp/import/mud..., SimpleXMLElement, 67584) at /path/to/the/mahara18/htdocs/import/leap/lib.php:126 PluginImportLeap-read_leap2a_xml_file() at /path/to/the/mahara18/htdocs/import/leap/lib.php:147
[Mahara-contributors] [Bug 1259756] Re: Not all form elements have labels
** Changed in: mahara Assignee: (unassigned) = Jono Mingard (mingard) ** Changed in: mahara Status: New = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259756 Title: Not all form elements have labels Status in Mahara ePortfolio: In Progress Bug description: For people using screen readers, having a label for every form input is essential as they have no other (easy) way of knowing what the input is for. Currently there are various form fields in Mahara which do not have labels, so either existing labels need to be linked to these inputs or new (hidden) ones need to be created. - Upload file in Content - Profile - Files [DONE] - New folder name input in Content - Profile - Files [DONE] - All Attach file labels in Content - Resume need to be associated with their respective file inputs - Collection and page checkboxes when editing permissions for a group - Cookie consent - Types of cookies checkboxes Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259756/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1270987] Re: Modal dialogs are not accessible
=== Bug #1270987 Modal dialogues are not accessible to screen readers === == How to test == 1. create or edit any profile page 2. insert any type of block content 3. confirm that the edit and delete icons in the top right hand corner of the block are displayed == Test Results == 3. confirmed that the edit and delete icons in the top right hand corner of the block are displayed ✔ Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1270987 Title: Modal dialogs are not accessible Status in Mahara ePortfolio: In Progress Bug description: The dialog boxes that appear when editing a block on a page are not accessible to screen reader/keyboard users for various reasons - They are inserted below all other elements and focus is not set to them - Even if the user finds the dialog in the tabbing order they can freely tab in and out of it (even though the rest of the page is greyed out), which is confusing - The close button's alt text is 'X' My preferred solution is to set focus to the close button and add aria-hidden to the page content to lock focus to the dialog. Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1270987/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1262933] Re: Drag-and-drop page editor is not keyboard-accessible
** Changed in: mahara Assignee: (unassigned) = Jono Mingard (mingard) ** Changed in: mahara Status: New = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1262933 Title: Drag-and-drop page editor is not keyboard-accessible Status in Mahara ePortfolio: In Progress Bug description: Currently the drag and drop page editor cannot be used with the keyboard. This is a major accessibility problem for people who rely on the keyboard and are unable to use a mouse easily. There are two options for making this accessible: Implement keyboard drag-and-drop using ARIA and Javascript or display the non-js editor for screen reader users (and make that accessible) It seems that ARIA drag-and-drop attributes are not well supported among most screen readers but a mostly-JS approach (like in http://dev.opera.com/articles/view/accessible-drag-and-drop/) can work well. Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1262933/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265086] Re: Completed column for tasks is unclear for screen reader users
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265086 Title: Completed column for tasks is unclear for screen reader users Status in Mahara ePortfolio: Fix Committed Bug description: When editing a plan in /artefact/plans/plan.php the Completed column currently has no text if the task is incomplete or a tick if the task is complete. However, this is not obvious to people using screen readers since the tick icon has null alt text. To make this more accessible, hidden Incomplete or No text should be present in the column if the task is incomplete, and the tick icon used when the task is complete should have descriptive alt text. Affects latest master (using Orca 3.10.1) (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265086/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1259764] Re: Feedback form should use focus management
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259764 Title: Feedback form should use focus management Status in Mahara ePortfolio: Fix Committed Bug description: When placing feedback on a page, the feedback form appears without reloading the page. For screen reader users this can be confusing, so the 'Message' text box should be explicitly focused when the Place feedback link is activated. Related: If feedback is a block on the page, the feedback form is still added to the footer (rather than to the block). Adding it after the Place feedback link would make the page order more logical to screen reader users. Affects latest master (using Orca 3.4.2) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259764/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271383] [NEW] Add NetBeans files to .gitignore
Public bug reported: The .gitignore in the Mahara repo includes the appropriate files for an Eclipse project sitting in the /htdocs and /test directory. It would be good to add ones for a Netbeans project as well. Based on this patch ( https://reviews.mahara.org/#/c/2946/1/.gitignore ) I think we just need to add: htdocs/netbeans/ test/netbeans/ ** Affects: mahara Importance: Low Assignee: Aaron Wells (u-aaronw) Status: Confirmed ** Tags: devtools git netbeans -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271383 Title: Add NetBeans files to .gitignore Status in Mahara ePortfolio: Confirmed Bug description: The .gitignore in the Mahara repo includes the appropriate files for an Eclipse project sitting in the /htdocs and /test directory. It would be good to add ones for a Netbeans project as well. Based on this patch ( https://reviews.mahara.org/#/c/2946/1/.gitignore ) I think we just need to add: htdocs/netbeans/ test/netbeans/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271383/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1266923] Re: Focus should be set to search results if they are loaded with AJAX
=== Bug #1266923 Focus should be set to search results if they are loaded with AJAX === == How to test == 1. Browse to the following pages and conduct a search a. Find Group members http://steven.wgtn.cat-it.co.nz/group/members.php?id=1 b. Find Groups http://steven.wgtn.cat-it.co.nz/group/find.php?filter=all c. Find Friends http://steven.wgtn.cat-it.co.nz/user/find.php 2. Confirm that the functionality of the search is working and results are displayed == Test Results == 2. Confirmed that the functionality of the search is working and results are displayed ✔ Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1266923 Title: Focus should be set to search results if they are loaded with AJAX Status in Mahara ePortfolio: In Progress Bug description: When searching for content in Mahara, most of the time the search results are loaded with Javascript, so to a screen reader user it seems like nothing happens when pressing the search button. Examples include - Elasticsearch (sitewide search) - Groups - Group Members tab - Groups - Find friends When the search button is pressed, focus should be set to the first search result (or somewhere else logical, like the results heading). Affects latest master To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1266923/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1187212] A change has been merged
Reviewed: https://reviews.mahara.org/2257
Committed:
http://gitorious.org/mahara/mahara/commit/ae9f8fdc8daef19e4ae959c93174b6010546582c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit ae9f8fdc8daef19e4ae959c93174b6010546582c
Author: Craig Miskell cr...@catalyst.net.nz
Date: Tue Jun 4 14:28:20 2013 +1200
Allow database server timezone override
Bug#1187212
Change-Id: If268ee5144eed83f8ec6ce3610b7488bb1dc9edd
Signed-off-by: Aaron Wells aar...@catalyst.net.nz
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1187212
Title:
Handle timezone mismatch between webserver and DB (MySQL) server
Status in Mahara ePortfolio:
Fix Committed
Bug description:
If the timezone of the MySQL DB server doesn't match the timezone of
the webserver (e.g. you're in AWS, where the DB server is always
unchangeably UTC, and you want the webserver to be in a reasonable
timezone for your users), then you get odd offset issues in, for
example, the timestamps on forum posts.
The webserver takes now in it's local timezone, formatted as a
date/time (text), and puts it into the INSERT statement. The DB sees
that, interprets it as the formatted date/time, but in it's time zone
(UTC), which is some number of hours offset from the actual time. It
stores that as a unix epoch time (seconds from 00:00:00 1-1-1970).
When this is sent back to the client, the epoch time is converted back
to the local timezone, and it displays as some number of hours offset.
The simplest solution is to set the timezone on the MySQL connection, forcing
the text date/time values to be interpreted as being in that timezone; they are
stored correctly in epoch format, which will then display properly on viewing.
It's a simple patch:
--- lib/dml.php.orig 2013-05-22 22:33:27.229452915 -0400
+++ lib/dml.php 2013-05-22 22:35:44.403280333 -0400
@@ -1474,6 +1474,9 @@
if (is_mysql()) {
$db-Execute(SET SQL_MODE='POSTGRESQL');
+if(!empty($CFG-dbtimezone)) {
+ $db-Execute(SET time_zone='$CFG-dbtimezone');
+}
}
It requires you to set dbtimezone in config.php, to the timezone of
the server (so maybe it's a poorly named option; I'm open to
alternative suggsions).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1187212/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1187212] Re: Handle timezone mismatch between webserver and DB (MySQL) server
Congrats, Craig! After 7 months, this one's finally made it into
upstream. :)
** Changed in: mahara
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1187212
Title:
Handle timezone mismatch between webserver and DB (MySQL) server
Status in Mahara ePortfolio:
Fix Committed
Bug description:
If the timezone of the MySQL DB server doesn't match the timezone of
the webserver (e.g. you're in AWS, where the DB server is always
unchangeably UTC, and you want the webserver to be in a reasonable
timezone for your users), then you get odd offset issues in, for
example, the timestamps on forum posts.
The webserver takes now in it's local timezone, formatted as a
date/time (text), and puts it into the INSERT statement. The DB sees
that, interprets it as the formatted date/time, but in it's time zone
(UTC), which is some number of hours offset from the actual time. It
stores that as a unix epoch time (seconds from 00:00:00 1-1-1970).
When this is sent back to the client, the epoch time is converted back
to the local timezone, and it displays as some number of hours offset.
The simplest solution is to set the timezone on the MySQL connection, forcing
the text date/time values to be interpreted as being in that timezone; they are
stored correctly in epoch format, which will then display properly on viewing.
It's a simple patch:
--- lib/dml.php.orig 2013-05-22 22:33:27.229452915 -0400
+++ lib/dml.php 2013-05-22 22:35:44.403280333 -0400
@@ -1474,6 +1474,9 @@
if (is_mysql()) {
$db-Execute(SET SQL_MODE='POSTGRESQL');
+if(!empty($CFG-dbtimezone)) {
+ $db-Execute(SET time_zone='$CFG-dbtimezone');
+}
}
It requires you to set dbtimezone in config.php, to the timezone of
the server (so maybe it's a poorly named option; I'm open to
alternative suggsions).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1187212/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1259394] A change has been merged
Reviewed: https://reviews.mahara.org/2948 Committed: http://gitorious.org/mahara/mahara/commit/99109004a8492c5e8314b3d43c712a4e20679aa5 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 99109004a8492c5e8314b3d43c712a4e20679aa5 Author: Jono Mingard jo...@catalyst.net.nz Date: Wed Jan 22 12:24:54 2014 +1300 Fixed help message positioning (Bug #1259394) Now uses jQuery to compute the position of the help box. Combining .position() and .offset() means that relatively positioned elements in the help box's ancestry don't affect its final position. For very small screens, the help box now resizes to fit the screen. For larger screens it's capped at 500px (rather than using percentage widths as before) to avoid the width being dependent on parent elements. Change-Id: Ib65b9795ac25789d653fd20cbe2b2cd46d2d8c75 Signed-off-by: Jono Mingard jo...@catalyst.net.nz -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259394 Title: Help links in forms are not keyboard-accessible Status in Mahara ePortfolio: In Progress Bug description: Currently, users of screen readers can see help links (the blue icons in forms) and can activate them but cannot easily interact with the popup that appears since it's inserted into the HTML in a different place from the link. A possible way to do this is - Add tabindex=-1 to the popup title - Focus the title using JS when the popup is loaded - Lock keyboard focus to the popup while it is open using ARIA attributes Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259394/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1259394] Re: Help links in forms are not keyboard-accessible
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259394 Title: Help links in forms are not keyboard-accessible Status in Mahara ePortfolio: Fix Committed Bug description: Currently, users of screen readers can see help links (the blue icons in forms) and can activate them but cannot easily interact with the popup that appears since it's inserted into the HTML in a different place from the link. A possible way to do this is - Add tabindex=-1 to the popup title - Focus the title using JS when the popup is loaded - Lock keyboard focus to the popup while it is open using ARIA attributes Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259394/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1270846] A change has been merged
Reviewed: https://reviews.mahara.org/2944 Committed: http://gitorious.org/mahara/mahara/commit/1a5d395cdb87a7e2ae14f251a562315f5ace87c6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 1a5d395cdb87a7e2ae14f251a562315f5ace87c6 Author: Aaron Wells aar...@catalyst.net.nz Date: Tue Jan 21 14:39:42 2014 +1300 Revert Add class JavascriptDetector for checking if javascript is enabled This reverts commit 1cdc0486e956fbc4e2e1a10f50818156aece16ce. The JSDetector class has caused three regressions so far (Bug 1270846, Bug 1261610, and Bug 1268788). Since it's been buggy and it's not actively in use anywhere in the site, I think we should revert it. Change-Id: If32d5adf8733ce3f455aab09a5d138c7707ae95d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1270846 Title: no message when incorrect username entered Status in Mahara ePortfolio: Confirmed Status in Mahara 1.9 series: Confirmed Bug description: When a nonexistent username is entered in the login form, the 'loginfailed' string is not displayed; unlike the expected behaviour when an existent username with an incorrect password is entered. Current version: Mahara version 1.9.0dev (2014010800) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1270846/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1268788] A change has been merged
Reviewed: https://reviews.mahara.org/2944
Committed:
http://gitorious.org/mahara/mahara/commit/1a5d395cdb87a7e2ae14f251a562315f5ace87c6
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit 1a5d395cdb87a7e2ae14f251a562315f5ace87c6
Author: Aaron Wells aar...@catalyst.net.nz
Date: Tue Jan 21 14:39:42 2014 +1300
Revert Add class JavascriptDetector for checking if javascript is
enabled
This reverts commit 1cdc0486e956fbc4e2e1a10f50818156aece16ce.
The JSDetector class has caused three regressions so far (Bug 1270846,
Bug 1261610, and Bug 1268788). Since it's been buggy and it's not
actively in use anywhere in the site, I think we should revert it.
Change-Id: If32d5adf8733ce3f455aab09a5d138c7707ae95d
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1268788
Title:
mobile_api_json_reply sends extra stuff at the top, making it invalid
json
Status in Mahara ePortfolio:
Fix Committed
Bug description:
An example is this, using the wrong api token
D/RestClient( 2917): Response = form name=jsdetector_form
id=jsdetector_form method=post
D/RestClient( 2917): input name=javascriptenabled type=hidden
value=true /
D/RestClient( 2917): script type=text/javascript
D/RestClient( 2917): document.jsdetector_form.submit();
D/RestClient( 2917): /script
D/RestClient( 2917): /form{fail:Sorry that mobile upload token was
not found. Please check your site and mobile application settings.}
Stolen from a maharadroid with a patch to log the responses, but that
can be obtained with easier ways.
Just need to find the jsdectector stuff and make sure it isn't done in
a part of mahara that has json reply in it. This may actually break
some of the json stuff as well? or the /api/mobile/sync.php needs a
define of JSON at the top.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1268788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1261610] A change has been merged
Reviewed: https://reviews.mahara.org/2944 Committed: http://gitorious.org/mahara/mahara/commit/1a5d395cdb87a7e2ae14f251a562315f5ace87c6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 1a5d395cdb87a7e2ae14f251a562315f5ace87c6 Author: Aaron Wells aar...@catalyst.net.nz Date: Tue Jan 21 14:39:42 2014 +1300 Revert Add class JavascriptDetector for checking if javascript is enabled This reverts commit 1cdc0486e956fbc4e2e1a10f50818156aece16ce. The JSDetector class has caused three regressions so far (Bug 1270846, Bug 1261610, and Bug 1268788). Since it's been buggy and it's not actively in use anywhere in the site, I think we should revert it. Change-Id: If32d5adf8733ce3f455aab09a5d138c7707ae95d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1261610 Title: JSDetector adds output to command-line scripts Status in Mahara ePortfolio: Fix Committed Bug description: In Mahara 1.9dev, every time I run the command-line installer, I see this at the start of the output: form name=jsdetector_form id=jsdetector_form method=post input name=javascriptenabled type=hidden value=true / script type=text/javascript document.jsdetector_form.submit(); /script /form[INF] d4 (admin/cli/install.php:68) Installing Mahara I suspect this is from the JSDetector class that we added. We should disable that, because it's not needed when you're running at the command-line. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1261610/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1270846] Re: no message when incorrect username entered
** Changed in: mahara/1.9 Status: Confirmed = Fix Committed ** Changed in: mahara/1.9 Status: Fix Committed = Fix Released ** Changed in: mahara/1.9 Milestone: None = 1.9.0 ** Changed in: mahara/1.9 Status: Fix Released = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1270846 Title: no message when incorrect username entered Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.9 series: Fix Committed Bug description: When a nonexistent username is entered in the login form, the 'loginfailed' string is not displayed; unlike the expected behaviour when an existent username with an incorrect password is entered. Current version: Mahara version 1.9.0dev (2014010800) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1270846/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271392] [NEW] focus on help box close button in chromium has gap
Public bug reported: There is a gap at bottom of close button and the focus outline in chromium - see the attached image The problem is the a tag 'sits' lower than the img tag and so gives the gap. It needs to have vertical-align: top set on the a tag so both the a and img are aligned at top ** Affects: mahara Importance: Low Assignee: Robert Lyon (robertl-9) Status: In Progress ** Attachment added: problem1.jpg https://bugs.launchpad.net/bugs/1271392/+attachment/3953994/+files/problem1.jpg -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271392 Title: focus on help box close button in chromium has gap Status in Mahara ePortfolio: In Progress Bug description: There is a gap at bottom of close button and the focus outline in chromium - see the attached image The problem is the a tag 'sits' lower than the img tag and so gives the gap. It needs to have vertical-align: top set on the a tag so both the a and img are aligned at top To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271392/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271392] A patch has been submitted for review
Patch for master branch: https://reviews.mahara.org/2949 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271392 Title: focus on help box close button in chromium has gap Status in Mahara ePortfolio: In Progress Bug description: There is a gap at bottom of close button and the focus outline in chromium - see the attached image The problem is the a tag 'sits' lower than the img tag and so gives the gap. It needs to have vertical-align: top set on the a tag so both the a and img are aligned at top To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271392/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1259395] A change has been merged
Reviewed: https://reviews.mahara.org/2834 Committed: http://gitorious.org/mahara/mahara/commit/a5a642970d33ce8a241812034bb9461440195e2d Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit a5a642970d33ce8a241812034bb9461440195e2d Author: Jono Mingard reason.k...@gmail.com Date: Fri Dec 20 16:01:17 2013 +1300 Added lang attribute to all front-facing files (Bug #1259395) Changed header templates to include the HTML lang attribute, the value of which is calculated in htdocs/lib/web.php Change-Id: I7b5c3b4169585d8d11bd64762f7a82a603324a50 Signed-off-by: Jono Mingard reason.k...@gmail.com Signed-off-by: Jono Mingard jo...@catalyst.net.nz -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1259395 Title: HTML lang attribute is not specified Status in Mahara ePortfolio: In Progress Bug description: For screen readers it's important to specify the lang attribute in the top-level html element. The attribute should be set to the primary language of the document (so the screen reader can read it in the right language) Affects latest master (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1259395/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271301] A change has been merged
Reviewed: https://reviews.mahara.org/2947 Committed: http://gitorious.org/mahara/mahara/commit/8f0f68be37629800d4880ec1165b32ad66cdc504 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 8f0f68be37629800d4880ec1165b32ad66cdc504 Author: Jono Mingard jo...@catalyst.net.nz Date: Wed Jan 22 08:56:25 2014 +1300 Added labels to search and filter forms (Bug #1271301) Using hidden labels when appropriate so the appearance is not modified. Please see bug report for a list of affected pages. Change-Id: Id1c1078acc741f219990708b2f99f80ae6818a7e Signed-off-by: Jono Mingard jo...@catalyst.net.nz -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271301 Title: Search and filter forms need labels Status in Mahara ePortfolio: In Progress Bug description: In most filter forms, the combobox used to filter does not have an associated label. Also, in some cases the search box doesn't have a label. This is confusing for screen reader users since it's unclear what each of these elements does. This affects the following pages (latest master) - Portfolio - Pages - Portfolio - Skins - Groups - My groups - Groups - Find groups - Groups - (group) - Pages - Groups - (group) - Members - Inbox (WCAG Level A) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271301/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265061] Re: detecting which language to use for tinymce not correct
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265061 Title: Add support for regional languages to TinyMCE language detection Status in Mahara ePortfolio: Fix Committed Bug description: Taking just the fist 2 letters of the current language to select which language file to use with tinymce will not work correctly for some languages dialects. eg Chinese, traditional is represented with 'zh_tw' in mahara language packs (http://langpacks.mahara.org/) - note the underscore and is represented as zh-tw.js for the tinymce language pack - note the hyphen. And is different to the tinymce language pack zh-cn.js To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265061/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265061] A change has been merged
Reviewed: https://reviews.mahara.org/2853 Committed: http://gitorious.org/mahara/mahara/commit/0bff3169c44aa605713244376098166a0167 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 0bff3169c44aa605713244376098166a0167 Author: Robert Lyon robe...@catalyst.net.nz Date: Tue Dec 31 10:08:50 2013 +1300 Detecting language for tinymce more robustly (Bug #1265061) Allowing for language dialects like zh_TW vs zh_CN vs zh_HK As we have a tinymce zh-tw.js language pack we should use it when the mahara language pack is zh_TW.utf8 Change-Id: Ie29a2b1cd89cb092ee646f43d0df011774d289c4 Signed-off-by: Robert Lyon robe...@catalyst.net.nz -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265061 Title: Add support for regional languages to TinyMCE language detection Status in Mahara ePortfolio: Fix Committed Bug description: Taking just the fist 2 letters of the current language to select which language file to use with tinymce will not work correctly for some languages dialects. eg Chinese, traditional is represented with 'zh_tw' in mahara language packs (http://langpacks.mahara.org/) - note the underscore and is represented as zh-tw.js for the tinymce language pack - note the hyphen. And is different to the tinymce language pack zh-cn.js To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265061/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265061] Re: Add support for regional languages to TinyMCE language detection
** Summary changed: - detecting which language to use for tinymce not correct + Add support for regional languages to TinyMCE language detection ** Tags added: tinymce translations -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265061 Title: Add support for regional languages to TinyMCE language detection Status in Mahara ePortfolio: Fix Committed Bug description: Taking just the fist 2 letters of the current language to select which language file to use with tinymce will not work correctly for some languages dialects. eg Chinese, traditional is represented with 'zh_tw' in mahara language packs (http://langpacks.mahara.org/) - note the underscore and is represented as zh-tw.js for the tinymce language pack - note the hyphen. And is different to the tinymce language pack zh-cn.js To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265061/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265049] Re: forum post notifications have escaped br in message in inbox
This is a fairly recent regression. It happens in 1.8_STABLE but not in 1.8.0_RELEASE. We should find out what caused it and fix that, specifically. ** Also affects: mahara/1.8 Importance: Undecided Status: New ** Also affects: mahara/1.9 Importance: Low Assignee: Robert Lyon (robertl-9) Status: In Progress ** Changed in: mahara/1.8 Milestone: None = 1.8.2 ** Changed in: mahara/1.8 Assignee: (unassigned) = Aaron Wells (u-aaronw) ** Changed in: mahara/1.8 Importance: Undecided = High ** Changed in: mahara/1.9 Importance: Low = High ** Changed in: mahara/1.8 Status: New = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265049 Title: forum post notifications have escaped br in message in inbox Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Status in Mahara 1.9 series: In Progress Bug description: For some of the notifications in the inbox (account/activity/index.php) the message has escaped br tags. For example a new forum post notification has output to the screen like: Re: Topic1 Top of the morning to you!br / br / How is the weather today?br / br / Raining still :( where the br / is actually lt;br /gt; in the html code. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265049/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265049] Re: forum post notifications have escaped br in message in inbox
Using git bisect, I traced it to the patch for bug 1075760: https://reviews.mahara.org/2685 https://reviews.mahara.org/2820 ** Tags added: regression -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265049 Title: forum post notifications have escaped br in message in inbox Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Status in Mahara 1.9 series: In Progress Bug description: For some of the notifications in the inbox (account/activity/index.php) the message has escaped br tags. For example a new forum post notification has output to the screen like: Re: Topic1 Top of the morning to you!br / br / How is the weather today?br / br / Raining still :( where the br / is actually lt;br /gt; in the html code. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265049/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1265049] A patch has been submitted for review
Patch for master branch: https://reviews.mahara.org/2952 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1265049 Title: forum post notifications have escaped br in message in inbox Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Status in Mahara 1.9 series: In Progress Bug description: For some of the notifications in the inbox (account/activity/index.php) the message has escaped br tags. For example a new forum post notification has output to the screen like: Re: Topic1 Top of the morning to you!br / br / How is the weather today?br / br / Raining still :( where the br / is actually lt;br /gt; in the html code. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1265049/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271420] [NEW] Duplicate newlines in forum post notifications if you turn off the HTML editor
Public bug reported: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. ** Affects: mahara Importance: Low Status: Confirmed ** Tags: forums notifications ** Tags added: forums notifications ** Changed in: mahara Milestone: None = 1.9.0 ** Changed in: mahara Importance: Undecided = Low ** Changed in: mahara Status: New = Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271420 Title: Duplicate newlines in forum post notifications if you turn off the HTML editor Status in Mahara ePortfolio: Confirmed Bug description: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271420/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
