[Mahara-contributors] [Bug 1600665] Re: Google calendar URLs no longer work in Google Apps block

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1588613] Re: Mahara not respecting session lifetime setting from admin config page

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588613

Title:
  Mahara not respecting session lifetime setting from admin config page

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  It seems that after the last round of session fixing bugs, Mahara no
  longer respects the session lifetime setting that the admin can set on
  the site configuration page.

  This setting is stored in the database config table as
  "session_timeout". It's then retrieved from the database during
  session setup, and loaded into the "session.gc_maxlifetime" ini value.

  The problem is, we are now initiating the session *before* we launch
  the database connection. So when we are setting
  session.gc_maxlifetime, session_timeout isn't available, and instead
  we use the default value of 1440 seconds = 24 minutes.

  The quick workaround is to add your session_timeout setting to your
  config.php:

  $cfg->session_timeout = 14400; // session timeout of 4 hours

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588613/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1588091] Re: StudentID not displayed in content

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588091

Title:
  StudentID not displayed in content

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The Portfolio content isn't able to show the author's name in all
  formats - Choosing the 'ID Number' format causes a php error.

  To reproduce:
  - Allocate a studentID to the current user
  - Go to Portfolio -> Pages -> Create Page
   - Put some content on the page
   - Select a 'Name display format' of 'ID Number'
   - Save the page
  - Click on the 'Display page' button

  Expected results:
  - The page will be displayed, showing the student ID as the auther

  Actual results:
  - The page is displayed, but it doesn't show the Student id
  - If $cfg->productionmode = false; a php error is shown on the screen

  I am running:
  - Mahara 16.04
  - Ubuntu 14.04
  - Postgres 9.3.11

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588091/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1582039] Re: Submitted portfolios don't appear in group pages block automatically

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582039

Title:
  Submitted portfolios don't appear in group pages block automatically

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Similar to bug #1558246

  To test

  1. Set up a group and allow submissions.
  2. As a regular group member, submit a page or portfolio.
  3. 
  - Expected result: When logged in as admin, you should see the submitted 
portfolio on the group homepage. 
  - Actual result: That part of the group pages block is not displayed. You 
need to go into the block config and click the "Save" button (without making 
any changes as submitted portfolios is already on "Yes" per default) and 
suddenly they appear.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582039/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1578995] Re: In the skin module the background position of the image cannot be translated

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1578995

Title:
  In the skin module the background position of the image cannot be
  translated

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Go to Portfolio > Skins
  Click on the Edit button to edit a skin
  Click on Background tab

  The position for the background image are in English with the French
  langpack

  Top left, Left, Bottom left, etc.

  -dajan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1578995/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1545375] Re: Button border missing when no second button in web services application connections

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1545375

Title:
  Button border missing when no second button in web services
  application connections

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 15.10+

  When there is no Delete button available next to the "Generate" button
  in the web services application connections, the right border on the
  "Generate" button is missing (see screenshot).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1545375/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1558246] Re: Shared collections in a group don't display for the admins

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1558246

Title:
  Shared collections in a group don't display for the admins

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released

Bug description:
  Hi guys!

  I don't know if this is a regression from 1.10, but we found a major
  bug in our 15.04.5 Mahara. In short, when members in a group submit
  their collections, the admins of that group cannot see them. I
  attached a screenshot for you to see. I also tested in a vanilla
  15.04.5 installation in order to be sure and I was still able to
  reproduce the bug.

  So, here are the steps to make it happen:

  *This test requires you to have an evaluation group with at least one
  member, at least 1 collection.

  1. Go into the group as admin
  2. Submit a collection
  3. Check if the collection appears under the "Collections shared with this 
group" title
  4. Now, with a member of that same group, follow the same steps.

  Result: The collections are never listed under the "Collections shared
  with this group".

  
  As always, thanks for your help!

  Melvin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1558246/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1354222] Re: Files within a group aren't deleted after deleting the group

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1354222

Title:
  Files within a group aren't deleted after deleting the group

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If you create a group that contains any files (e.g. image, file) and
  then delete that group you should see a warning message. In addition,
  the files are not deleted although the group is (or marked as deleted)

  To reproduce (Mahara master):

  1.- Click on the 'Group' tab and create a group
  2.- Click on the 'Files' tab and add a file or image
  3.- Delete the group and you should see the warning. To check that the added 
files/images weren't deleted you can check out the 'artefact_file_files' table.

  Is this a bug or is it an intended behaviour? If it is a bug I could
  provide a patch for review.

  
  Cheers,
  Moises

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1354222/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1582934] Re: Navigation not entirely / not visible on iPad

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582934

Title:
  Navigation not entirely / not visible on iPad

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Tested on iPad iOS 9.3.1 with latest Safari

  When in landscape mode, the top part of the main navigation is cut off
  (about 1.5 mm).

  When in portrait mode, the entire navigation is invisble and it is
  impossible to choose elements as there is no hamburger either. When
  you drag the page down, you can see the navigation, but it always
  autoscrolls behind the static header.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582934/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577258] Re: More PHP7 compatibility problems with function parameters

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577258

Title:
  More  PHP7 compatibility problems with function parameters

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Some places that were missed for bug 1575955

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577258/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1578512] Re: Escape filenames with quotes in them, in Content-Disposition:attachment headers

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1578512

Title:
  Escape filenames with quotes in them, in Content-
  Disposition:attachment headers

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If you give a file in Mahara a name that has doublequotes in it and
  try to download it, your browser will name the download "download.php"
  instead of the correct file name. This is because we're not properly
  escaping the double quotes in the filenames in the "Content-
  Disposition" header.

  In fact, in the relevant code in htdocs/lib/file.php, there's a note
  from 2007: "@todo possibly need addslashes on the filename, but I'm
  unsure on exactly how the browsers will handle it."

  Well, I tracked it down to the RFCs recently to find out the right
  format for this. The Content-Disposition header's usage in HTTP
  headers is defined in RFC 6266:
  https://tools.ietf.org/html/rfc6266#section-4.1 . The filename there
  is defined to be a "quoted-string". The format of quoted-string is
  defined in RFC2616: https://tools.ietf.org/html/rfc2616#section-2.2
  There, it says that if your quoted string contains double quotes, you
  can escape them with a single backslash.

  So there you go. We just need to replace any " in the filename with \"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1578512/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1548522] Re: Avatars overlap in friends block

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1548522

Title:
  Avatars overlap in friends block

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Reported by Patric Lougheed on the forum:
  
https://mahara.org/interaction/forum/topic.php?id=7524=0=10#post30271

  In 15.10.1 all avatars that are portrait shaped are overlapping with
  the names of the avatar above and below them. I checked in all the
  themes and this occurs. This does not happen when you are in edit mode
  though.

  It would be great to have the option that the avatar is forced to be
  square like in Moodle.

  Cheers,

  Patric

  UPDATE: It seems each div goes from "position: absolute" in edit mode
  to "position: relative" in view mode. This problem is also happening
  in the image gallery block. All the thumbnails are overlapping on each
  other.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1548522/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1579628] Re: Modern theme: disappearing password label

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1579628

Title:
  Modern theme: disappearing password label

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara: 16.04
  os: Linux
  DB: Postgres
  Browser: FF, Chrome

  When the theme is Modern and the user types in the wrong username /
  password credentials on the login screen, the label for the password
  appears as white on white. It looks like the label is no longer there.

  Please refer to the attached image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1579628/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1582472] Re: No moving of long blocks

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582472

Title:
  No moving of long blocks

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  from Jacqui at https://mahara.org/interaction/forum/topic.php?id=7600

  We are using Mahara 15.10, when placing a new block on a page that
  extends beyond one screen, the page auto-scrolls to allow correct
  placement of a new block. However, when taking an existing block, from
  either the top or the bottom of a long page, and attempting to
  relocate it to an off screen area, the page does not automatically
  scroll and the block can only be placed on the visible portion of the
  screen.

  There are workarounds
  1. For those with scroll wheels, the mouse button needs to be held whilst the 
while is rotated to scroll the screen
  2. whilst holding the mouse button to keep the block selected the user can 
utilise the keyboard arrows to scroll the screen

  but is this something that could be looked at in a future release?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582472/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1582967] Re: Comment deletion forms & buttons with non-unique IDs

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582967

Title:
  Comment deletion forms & buttons with non-unique IDs

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  While working on Bug 1580499, I noticed that the forms and buttons for
  comment deletion all have the same ID. This specifically gets in the
  way of me using their IDs for some workarounds in the Behat tests, but
  also it's just bad HTML. According to the HTML spec, the "ID"
  attribute is meant to be unique in the whole page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582967/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1583435] Re: Make it easier to run one specific feature file

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1583435

Title:
  Make it easier to run one specific feature file

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Currently if automated tests fail and I want to re-run just one
  specific feature file, I have to manually edit the file, add "@debug"
  to it, and then tell our mahara_behat.sh script to look for that
  @debug tag. This is kind of annoying, and there's a tendency to
  accidentally leave those @debug tags there when committing.

  There's an easier way! The underlying behat command script,
  external/vendor/bin/behat, will accept a filename and only run the
  tests under that file. We can adapt our utility script to use that
  *or* a tag.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1583435/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1581227] Re: PHP Fatal error: Call to undefined function log_()

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1581227

Title:
  PHP Fatal error:  Call to undefined function log_()

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If we don't have the behat config vars set we end up with this error

  PHP Fatal error:  Call to undefined function log_()

  It should be using a log_debug() for the message - I'll fix up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1581227/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1587474] Re: No indents forum reply fails when the last post has been deleted

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1587474

Title:
  No indents forum reply fails when the last post has been deleted

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  When a 'Forum indent mode' is set to 'No indents', the 'Reply' button tries 
to create a reply to the last post and it fails when the last post has been 
deleted
  (see screenshots attached)

  Tested on Mahara 1.10 and 16.04

  Probably related to https://bugs.launchpad.net/mahara/+bug/1328388
  where the individual reply buttons for posts have been removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1587474/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1530702] Re: New messages in inbox aren't displayed in bold in "Inbox" block

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1530702

Title:
  New messages in inbox aren't displayed in bold in "Inbox" block

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 15.10+

  Prior to Mahara 15.10, unread messages were displayed in bold in the
  Inbox block. See
  http://manual.mahara.org/en/15.04/blocks/general.html#inbox

  I don't think we have to change the icon for unread messages. However,
  having the message displayed in bold that hasn't been read yet would
  be good. That would also make it more consistent with the display in
  the actual inbox. Messages that haven't been read yet are displayed in
  bold.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1530702/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1579999] Re: PHP Fatal error: Class 'Session' not found

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/157

Title:
  PHP Fatal error:  Class 'Session' not found

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I get this error PHP Fatal error:  Class 'Session' not found in
  htdocs/lib/errors.php on line 128

  I believe it is due the the require_once not pointing to the correct
  file

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/157/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1582778] Re: Japanese text jumbled when submitted with image

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582778

Title:
  Japanese text jumbled when submitted with image

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  When a Japanese user writes Japanese text in the editor and posts it,
  it is typically fine. However, adding an image causes any Japanese
  text to be jumbled (just appears as a string of ).

  Server
  Mahara version 16.04.1
  Apache on Linux with Postgres

  Tested on Clients
  Windows 10 + Chrome
  Ubuntu 16.04 + Chromium and Firefox

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582778/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1582989] Re: Make top line on "Edit" button more visible on certain pages

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582989

Title:
  Make top line on "Edit" button more visible on certain pages

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The line at the top of the "Edit dashboard" button is hardly visible
  whereas it's easily visible on a regular page. The same is true for
  the profile page.

  All these lines that touch buttons like that should have the same
  color. Please use the color as on a regular page (see attached
  screenshot).

  I target it to be backported as well because it is for better
  usability since people don't wonder what happened to the top line of
  the button.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582989/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1592276] Re: Still SSRF vulnerability in external feed

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1592276

Title:
  Still SSRF vulnerability in external feed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  While taking another look at Bug 1397736 (SafeCURL) and Bug 1394820
  (SSRF in external feed) I realized there are some problems with the
  patch https://reviews.mahara.org/4029 that I filed for the SSRF bug.

  As a refresher here, the idea is that an attacker can do this:

  1. Log in to Mahara
  2. Create a page
  3. Put an "External Feed" block on the page
  4. Set the "Feed location" to "localhost:389"

  Expected result: This meaningless URL does nothing, and the block
  config harmlessly errors out and asks them for a valid URL.

  Actual result: They see an error message that tells them whether the
  web server has port 389 (unencrypted LDAP) open or not. If the error
  they see ends with "Recv failure: Connection reset by peer", they know
  the web server has a process listening on 389. If they see "Failed to
  connect to... Connection refused" they know it is not.

  It's called an SSRF (Server Side Request Forgery) attack (
  http://www.acunetix.com/blog/articles/server-side-request-forgery-
  vulnerability/ ). As Hugh pointed out on that bug, the biggest problem
  with this vulnerability is that a user can use it to scan the network
  the web server is on, checking for machine names, IP addresses, and
  port numbers.

  My patch 4029 was to add the "CURLOPT_PROTOCOLS" option to our Curl
  requests. This has the main effect of preventing an attacker from
  using an HTTP redirect to make Curl send a request to a non-HTTP
  protocol. But it doesn't at all mitigate all the information-gathering
  attacks, because it only limits the protocol section of the URL (i.e.
  "https://;) and the structure of the request Curl makes. Crucially, it
  does not limit the port of the URL, you can still enter
  "http://localhost:389;.

  As such, it didn't mitigate any of those information-gathering
  attacks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1592276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1577259] Re: PHP7 fixing dwoo dynamic property references

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577259

Title:
  PHP7 fixing dwoo dynamic property references

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Where dynamic property references have changed in php7 - you need to
  enclose the variable reference name in {} completely.  eg: $data =
  $data->$m[2][$k] has become $data = $data->{$m[2][$k]}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599958] Re: Embedly content will not display on profile page

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599958

Title:
  Embedly content will not display on profile page

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  Content in External Media block from Embedly does not appear on user
  profile page but will work on other pages created. Displays fine in
  edit mode but disappears in display mode. Tested with Dropbox and
  Soundcloud links.

  Tested on my 16.04.01 dev (Ubuntu 14.04, Apache 2.4, Postgres) and the
  Mahara demo site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1598974] Re: Mahara as MNet IDP breaks because of longer session ids

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1598974

Title:
  Mahara as MNet IDP breaks because of longer session ids

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  When you use Mahara as the MNet identity provider, it tries to store
  the user's session id in the "sso_session.sessionid" database column.
  This column is 40 characters, because we were previously using SHA-1
  based sessionids, which are 40 characters. When we switched to
  SHA-256, the sessionids expanded to 64 characters, which causes it to
  crash.

  To replicate:

  1. Set up MNet between Moodle and Mahara, with Mahara as the identity 
provider.
  2. Log in to Mahara.
  3. In the sideblock, click on the link to roam over to Moodle

  Expected result: You roam over to Moodle
  Actual result: It crashes with this error message:

  [WAR] d8 (lib/errors.php:796) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  value too long for type character varying(40)] in EXECUTE("INSERT 
INTO "sso_session" ("userid", "instanceid", "username", "useragent", "token", 
"confirmtimeout", "expires", "sessionid") VALUES (?, ?, ?, ?, ?, ?, ?, ?)")
  Command was: INSERT INTO "sso_session" ("userid", "instanceid", "username", 
"useragent", "token", "confirmtimeout", "expires", "sessionid") VALUES (?, ?, 
?, ?, ?, ?, ?, ?) and values was 
(userid:1,instanceid:2,username:admin,useragent:3628ed27e34fdc54e674d6a3b4a24c71208a600d,token:9d1b2dcf6adf3ab284b3940113ef76f0513eca93,confirmtimeout:1467678764,expires:1467765149,sessionid:a63792d82ed3538d731018873581817c7214a7ea94e4379316161a0b8c773a7c)
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/aaronw/www/mahara/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/home/aaronw/www/mahara/htdocs/lib/errors.php:796
  SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-1: E...") at /home/aaronw/www/mahara/htdocs/lib/dml.php:1088
  insert_record("sso_session", object(stdClass)) at 
/home/aaronw/www/mahara/htdocs/api/xmlrpc/lib.php:93
  start_jump_session(object(Peer), "2", "") at 
/home/aaronw/www/mahara/htdocs/auth/xmlrpc/jump.php:53

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1598974/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1508684] Re: Unserialize untrusted data when importing skins

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1588599] Re: PHP 7 unrecoverable errors in 16.04

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588599

Title:
  PHP 7 unrecoverable errors in 16.04

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I am porting my working instance of mahara 16.04 (debian, php 5.5) to
  a new server (ubuntu 16.04, php 7.04, using git for installation).
  Just by chance I stumble upon some crashes which seem to be related to
  using deprecated PHP functions. At this time I found (and easily
  repaired) the following files needing fixing for PHP 7:

  root@QSKW001:/var/www/mahara# git status
  On branch 16.04_STABLE
  Your branch is up-to-date with 'origin/16.04_STABLE'.
  Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

modified:   htdocs/lib/antispam/SimpleSpamTrap.php
modified:   htdocs/module/multirecipientnotification/inbox.php
modified:   
htdocs/module/multirecipientnotification/lib/activityextend.php
modified:   htdocs/module/multirecipientnotification/outbox.php

  the first one needing preg_match instead of eregi

  diff lib/antispam/SimpleSpamTrap.php 
../../mahara-16.04.0/htdocs/lib/antispam/SimpleSpamTrap.php
  25c25
  < if (preg_match("/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i", 
$email)) {
  ---
  > if (eregi("^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$", $email)) {

  while the other ones simply needed explode instead of split, e.g.:

  root@QSKW001:/var/www/mahara# diff 
htdocs/module/multirecipientnotification/inbox.php 
../mahara-16.04.0/htdocs/module/multirecipientnotification/inbox.php
  78c78
  < explode(',', $type),
  ---
  > split(',', $type),
  179c179
  < $types = explode(',', preg_replace('/[^a-z,]+/', '', $type));
  ---
  > $types = split(',', preg_replace('/[^a-z,]+/', '', $type));

  These are just quick hacks by me working up to now.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588599/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1595789] Re: "$cfg->urlsecret = null; " doesn't work during installation

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1595789

Title:
  "$cfg->urlsecret = null;" doesn't work during installation

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  According to config-defaults.php, if you set $CFG->urlsecret to null,
  you should be able to access the installer and upgrader without
  needing to add a urlsecret param to your URL. This is a useful feature
  for development environments.

  However, it currently doesn't work on the latest HEAD in master.

  To replicate:

  1. Add "$cfg->urlsecret = null;" to your config.php file
  2. Try to do a new install of Mahara through the web browser

  Expected result: Installation runs through
  Actual result: You get this message:

  Mahara: Invalid Parameter
  A required parameter is missing or malformed

  The 'urlsecret' parameter contains invalid characters

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1595789/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1555410] Re: unread email icon in the banner display wrong

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1555410

Title:
  unread email icon in the banner display wrong

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In the banner of Mahara webpage, there is a email icon and a number
  next to it, which means the number of unread mails. However, the
  number is below the email icon in Safari browser, while it should be
  on the right hand side of the email icon. I test it on Safari 7.0.6
  and 8.0.4 as well as on an iPad and an iPhone running iOS 9.2.1. All
  of them have the same problem.

  It becomes a big problems when access Mahara through small screen,
  such as mobile phone. The number is half cut off in the banner in a
  small screen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1555410/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1576643] Re: TinyMCE is not available on the iPad

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576643

Title:
  TinyMCE is not available on the iPad

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Version of Mahara  is 15.10.1.
  Server operating system is Linux
  Databaseis  Postgres
  Browser is Safari

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1591782] Re: Default theme breaks with skin background

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1591782

Title:
  Default theme breaks with skin background

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Default theme with a skin background: The background also shows
  underneath the main navigation rendering it unreadable. All other
  themes are fine.

  See attachment

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1591782/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1591759] Re: Importing leap2a textbox giving error when textbox is empty

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1591759

Title:
  Importing leap2a textbox giving error when textbox is empty

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  When one imports a page containing an empty text box (ie, one that
  doesn't have anything set for 'config' it gives a warning

  
  [WAR] fc (blocktype/text/lib.php:129) Undefined index: text
  Call stack (most recent first):

  We just need to ignore fixing embedded links for a textbox that has no
  config

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1591759/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1234615] Re: Not checking artefact permissions before exporting

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234615

Title:
  Not checking artefact permissions before exporting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In https://bugs.launchpad.net/bugs/1211758 , the reporter mentioned
  that in addition to embedding other users' artefacts in your pages,
  you could export them to view their full content:

  #3: Export function allows arbitrary file download
  Using the technique above you can get a 1024x1024 'thumbnail' of any users 
arbitrary file. Simply use the export function on a page like the one above 
where other users images are embedded. Make sure the embedded images max-size 
is set to 1024 and it will appear within /files/extra.

  There is an obvious fix for this issue, of checking
  $USER->can_publish_artefac()t or $USER->can_view_artefact() on each
  artefact before exporting it. But when Robert tested this fix, he
  found that it was too resource-intensive (as part of the already
  resource-intensive export process) for it to work while exporting an
  average-sized portfolio.

  Since fixing the embedding of other users' data mitigates the risk
  from this issue and was easier to accomplish, I've released that fix
  and spun this one off into a separate bug to fix when we're able.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234615/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1592213] Re: Render issue with Masonry on Skins page

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1592213

Title:
  Render issue with Masonry on Skins page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  On the page skin/index.php, when you create more than 3 skins, masonry
  fails to calculate the content and positions a skin box in the wrong
  position.

  This always happens on page load when the function 
initUserThumbnailsMasonry() fires (theme.js).
  From what i can see, when the function is called, content is not loaded, 
therefore creating a wrong dimension. Not 100% sure but if you follow the steps 
bellow maybe it will help determine the cause.

  1. go to /skins/index.php.
  2. create 4 new skin. Skin boxes will all align correctly.
  3. Refresh the browser.
  4. Notice the 4th skin box absolute positioning is incorrect and overlaps box 
3.
  5. Open up browser developer tools, navigate to view the raw js "theme.js".
  6. Scroll to line 129 and add a break-point and refresh the browser.
  7. Click through the break-point and the Skins will load correctly.
  or
  7. Click on a navigation link to open a new page eg "Shared with me" then go 
page to skins page via the link.
  8. If you have the break-point set on the js, it will load correctly. If not, 
it will break.

  I have tested this a bit and it doesn't always work :) Sometime if you
  refresh the page, it works. Other times it doesn't.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1592213/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1597549] Re: Share access for site wide Profile page error

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597549

Title:
  Share access for site wide Profile page error

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara: master
  OS: Linux
  Browser: Firefox
  DB: Postgres

  
  When trying to access the Profile page access for the site (Administration > 
Configure site > Share > Profile page > Edit access), an error is generated:

  
  [WAR] 33 (lib/errors.php:508) An exception was thrown of class 
InvalidArgumentException.
  THIS IS BAD and should be changed to something extending MaharaException,
  unless the exception is from a third party library.
  Original trace follows
  [WAR] 33 (lib/user.php:1770) couldn't load institutions, no user id specified
  Call stack (most recent first):

  load_user_institutions(null) at 
/var/www/maharacode/mahara/htdocs/lib/view.php:1484
  View->add_owner_institution_access() at 
/var/www/maharacode/mahara/htdocs/view/access.php:142

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597549/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1591304] Re: Can't edit pages if "Users can choose page themes" is enabled.

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1591304

Title:
  Can't edit pages if "Users can choose page themes" is enabled.

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Updated from 15.04.5 to 16.04.2 and ran into this issue when editing
  any page:

  [Fri Jun 10 10:57:51 2016] [error] [client  ] [WAR] c3 (lib/view.php:5999) 
Undefined variable: view, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] Call stack (most recent 
first):, referer: http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ]   * log_message("Undefined 
variable: view", 8, true, true, "/var/www/html/mahara1604/lib/view.php", 5999) 
at /var/www/html/mahara1604/lib/errors.php:489, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ]   * error(8, "Undefined 
variable: view", "/var/www/html/mahara1604/lib/view.php", 5999, array(size 1)) 
at /var/www/html/mahara1604/lib/view.php:5999, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ]   * View->is_themeable() at 
/var/www/html/mahara1604/view/blocks.php:271, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] , referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] [WAR] c3 (lib/errors.php:508) 
An exception was thrown of class Error. , referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] [WAR] c3 (lib/errors.php:508) 
THIS IS BAD and should be changed to something extending MaharaException,, 
referer: http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] [WAR] c3 (lib/errors.php:508) 
unless the exception is from a third party library., referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] [WAR] c3 (lib/errors.php:508) 
Original trace follows, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] [WAR] c3 (lib/view.php:5999) 
Call to a member function get() on null, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] Call stack (most recent 
first):, referer: http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ]   * View->is_themeable() at 
/var/www/html/mahara1604/view/blocks.php:271, referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php
  [Fri Jun 10 10:57:51 2016] [error] [client  ] , referer: 
http://learningdev.campus.up.edu/mahara1604/view/index.php

  Before I got this error, I got a message about a user's theme not
  being available and it asked me to switch to a different one. After
  switching, this is the error that occurred. It seems to be happening
  on any page I try to edit and any new page I attempt to create.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1591304/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1592236] Re: Sessions: constantly asked to log in to access the Users Admin screen

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1592236

Title:
  Sessions: constantly asked to log in to access the Users Admin screen

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara: 16.04.1
  DB: Postgres
  OS: Linux
  Browser: Firefox

  
  I think there may be something funny with sessions happening. When the 
session times out (it's currently set to 2 hours) and I'm on the 
/admin/users/search.php, I think it doesn't correctly update the session once I 
log in again.

  This is what I think the steps are to reproduce it:
  1. leave screen on /admin/users/search.php

  2. have the session time out

  3. try to do something on the screen (i.e. search for a user)

  4. It will redirect to the login screen.

  5. Login correctly

  6. user search screen is displayed.

  7. click on the Configure Site menu link

  8. Click back on the Users menu link

  9. It will ask you to log back in again.

  
  It seems to only happen on the Users (and Group - I think) menu links.

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1592236/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599404] Re: The function "get_mahara_install_subdirectory" doesn't correctly handle a URL with a missing trailing slash

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599404

Title:
  The function "get_mahara_install_subdirectory" doesn't correctly
  handle a URL with a missing trailing slash

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  One of the causes of Bug 1592236 was that
  get_mahara_install_subdirectory() doesn't correctly handle a wwwroot
  with a missing trailing slash. If you set your wwwroot to e.g.
  "http://www.example.com;, it will return "www.example.com".

  This rarely affects anything because fairly early in init.php we
  rectify $CFG->wwwroot to add the missing trailing slash if it's
  missing. But if we need to call it before that point it can cause
  subtle problems, so we may as well fix it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599404/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599305] Re: $USER->get('grouproles') returning values for deleted groups

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599305

Title:
   $USER->get('grouproles') returning values for deleted groups

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  To test:

  1) Have a Mahara site with production mode set to off

  2) Create a new user and login as that user

  3) Create a group then delete the group

  4) Create a page and add an image block to the page

  5) Select the 'group files' tab  - there should be nothing to select

  6) Click the 'remove' link for the configuration form

  7) Navigate away and you should see these errors:

  [WAR] 33 (lib/form/elements/filebrowser.php:380) Undefined offset: 0
  [WAR] 33 (lib/form/elements/filebrowser.php:380) Trying to get property of 
non-object

  The reason for this is the $USER->get('grouproles') still holds the
  role to the deleted group even if you log out and back in again.

  We should only populate the grouproles with roles to non-deleted
  groups.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599305/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1596755] Re: Ocean theme - tabbing through unselected sub-menu items

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1596755

Title:
  Ocean theme - tabbing through unselected sub-menu items

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara: master
  Browser: Chrome
  DB: Postgres
  OS: Linux

  When tabbing through the unselected sub-menu items in the Ocean theme,
  the text disappears because it's blue on blue.

  Please refer to the attached image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1596755/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1563143] Re: Breakage around dropzone error hander callbacks

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1563143

Title:
  Breakage around dropzone error hander callbacks

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Triaged
Status in Mahara 16.10 series:
  Triaged

Bug description:
  Catalyst received a bug report from a customer who is using recent
  Mahara (15.10.1).

  The initial bug report is that if "Require agreement" is enabled in
  
admin/extensions/pluginconfig.php?plugintype=artefact=file=file
  and a user attempts to upload a file without first ticking the
  agreement box, they get a message saying the box needs to be ticked
  but the preview of the file also has a green tick (implying it was
  actually uploaded).

  In my investigation of the issue, I found multiple issues:

  1) Dropzone's internal handling puts the green tick there on the basis of the 
server status. Setting the http response code to 403 (Forbidden) fixed that.
  2) Dropzone's internal handling assumes that any text returned when an error 
occurs is an HTML (not JSON) description of the error, and therefore puts the 
raw HTML in 'tooltip' for the red X. The raw HTML also ends up being displayed 
in the files_filebrowser_upload_messages div because the JSON.parse doesn't get 
called in the error handler function.

  I have prepared a patch that addresses both these issues, but I don't
  think it's the entire solution. I'd also suggest that beginning the
  upload should be rejected if the box hasn't been ticked. This would
  avoid the scenario wherein a user attempts to upload a large file on a
  slow connection, only to be told after the file has been sent that
  it's not been saved only because they didn't tick the box.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1563143/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1084336] Re: mnet: mahara doesn't implement kill_child which results in not being logged out when logged out from a remote IdP over mnet

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1084336

Title:
  mnet: mahara doesn't implement kill_child which results in not being
  logged out when logged out from a remote IdP over mnet

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  When Mahara is doing SSO via MNet, with a remote IdP, it ought to log
  you out of Mahara when you log out of the IdP. MNet allows for this
  via the "kill_child" API method, which the IdP will call for each
  connected service provider to tell it to log a user out.

  Mahara never implemented this method, so it doesn't log you out
  properly when you log out of the IdP.

  To replicate:

  1. Set up MNet between a Moodle & Mahara site, with Moodle as the identity 
provider (i.e. users log in to Moodle and then roam over to Mahara)
  2. Log in to Moodle
  3. Roam over to Mahara
  4. Open up Moodle in another tab.
  5. Log out of Moodle.
  6. Go back to the tab with Mahara and try to navigate around in the site.

  Expected result: You can't navigate around because you're logged out
  of Mahara

  Actual result: You are not logged out of Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1084336/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1580399] Re: Users can login to suspended institutions via external auth under some circumstances

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1580399

Title:
  Users can login to suspended institutions via external auth under some
  circumstances

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  The problem is this:

  The code that checks if the user's authinstance is from a suspended
  institution, is in LiveUser->login(). This is the method used by the
  username/password login box.

  But if you login with an auth method that doesn't use the login box,
  say SAML, XMLRPC, Shibboleth, you don't hit that check.

  
  We need to move the check into the "ensure_user_account_is_active()" method 
in auth/lib.php which is already called at the start of 
LiveUser->authenticate() so we should update that to make sure it checks that 
their auth institution isn't suspended and (maybe) remove the redundant code 
from LiveUser->login()

  
  See also https://bugs.launchpad.net/mahara/+bug/903534 for some more 
information about this issue
  That bug report is public but I'll mark this as private as it mentions the 
attack vector

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1580399/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1565198] Re: "Recent journal entries" block should mention journal context in config

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1565198

Title:
  "Recent journal entries" block should mention journal context in
  config

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  When you use the "Recent journal entries" block on a personal page,
  you also see group, institution and site journals. However, it is not
  mentioned that these are group, institution and site journals making
  it potentially confusing for people to know why they see them. It
  would be good to display the context, e.g. the group name or "Site
  journal" next to the title of the journal like is done for notes (see
  attachment).

  There are two related bugs that should be addressed at the same time:

  1. Bug #1565197: Selecting "Site journal" in "Recent journal entries" block 
in a group just spins
  2. Bug #1565199: Journals that you can't add entries to appear in drop-down 
for "Add new entry" in "Recent journal entries" block

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1565198/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1590626] Re: Field with error is not highlighted on profile wall

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1590626

Title:
  Field with error is not highlighted on profile wall

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Steps to replicate:

  * Login as a user
  * Navigate to Portfolio > Profile Page
  * Post more than 1500 symbols to the wall message.

  Issue 1: Expected: error is displayed on the fly before the massage
  submitted

  * Click Post button
  * See the message "There was an error with submitting this form. Please check 
the marked fields and try again."

  Issue 2: But the field is not highlighted. And it's not clear what is
  wrong.

  See attached screenshot.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1590626/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599373] Re: Don't print "share page" link when viewing site template pages

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599373

Title:
  Don't print "share page" link when viewing site template pages

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Currently when you edit the Profile site template, or the Page site
  template, you confusingly see a "share page" link on them. This link
  shouldn't be there, because site template pages aren't meant to be
  shared and seen by people like normal pages. They're only there to
  define the default blocks that are present in new pages of their
  pagetype.

  To replicate:

  1. Log in to Mahara
  2. Go to Administration -> Configure site -> Pages
  3. Click the edit link for "Page template"

  Expected result: You see the page template in edit mode, but with no "Share 
page" link
  Actual result: You see the page template in edit mode, *with* a "Share page" 
link

  The same happens for the Profile template.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599373/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599375] Re: Hide default portfolio page site template from site pages sharing list

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599375

Title:
  Hide default portfolio page site template from site pages sharing list

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is like Bug 1597549, except for the Page template instead of the
  Profile template. The problem is that the the Page site template shows
  up in the list of shareable site pages. It shouldn't, because it's not
  meant to be viewed and used by users like a normal page; it's only
  meant to be used to set up the default blocks on a newly created
  portfolio page.

  To replicate:

  0. Clean install of Mahara
  1. Log in to Mahara as an admin
  2. Go to Administration -> Configure site -> Pages
  3. Create a new page called "Page A"
  4. Click the "Share page" link for Page A
  5. On the "Edit access" screen, click in the "Pages" select2 box.

  Expected result: The only option in the select2 box is "Page A".

  Actual result: In the select2 box you see "Page A" and "Untitled"
  (which is the title of the default page template)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599375/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600069] Re: See other's profile images one is not meant to

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600069

Title:
  See other's profile images one is not meant to

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  As part of the follow on from this bug:
  https://bugs.launchpad.net/mahara/+bug/1211758

  I notice that it is possible to see profile images of other users that
  one isn't meant to.

  Demo:
  Login as User A and upload two profile icons - set one to be default
  make note of the artefact id's

  Login as User B then go to the url:

  thumb.php?type=profileiconbyid=150=[id from above]

  You should only be allowed to see the icon that is set to the default
  icon but you can see both

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600069/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] Re: Google drive folders no longer work in Google Apps block

[Robert Lyon]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

** Changed in: mahara/16.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1508684] Re: Unserialize untrusted data when importing skins

[Aaron Wells]

** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6709
Committed: 
https://git.mahara.org/mahara/mahara/commit/0e48b3bd6af018b6812f98b98f293596dbb21ae1
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1
Author: Aaron Wells 
Date:   Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6712
Committed: 
https://git.mahara.org/mahara/mahara/commit/34aeb9bd6f2b99f3b5471cf64b2a7bfb2b2ce685
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 34aeb9bd6f2b99f3b5471cf64b2a7bfb2b2ce685
Author: Aaron Wells 
Date:   Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1)
(cherry picked from commit 784bafb4624f458289d8ccd936c07bdf3a7a7f15)
(cherry picked from commit 6b7af633b5de4a422896f47e2a0d0753f4c878bc)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6710

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6710
Committed: 
https://git.mahara.org/mahara/mahara/commit/784bafb4624f458289d8ccd936c07bdf3a7a7f15
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 784bafb4624f458289d8ccd936c07bdf3a7a7f15
Author: Aaron Wells 
Date:   Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6711
Committed: 
https://git.mahara.org/mahara/mahara/commit/6b7af633b5de4a422896f47e2a0d0753f4c878bc
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 6b7af633b5de4a422896f47e2a0d0753f4c878bc
Author: Aaron Wells 
Date:   Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1)
(cherry picked from commit 784bafb4624f458289d8ccd936c07bdf3a7a7f15)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] Re: Google drive folders no longer work in Google Apps block

[Robert Lyon]

** Changed in: mahara
   Status: New => Fix Committed

** Changed in: mahara
Milestone: None => 16.10.0

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Changed in: mahara/15.04
   Status: New => Fix Committed

** Changed in: mahara/15.10
   Status: New => Fix Committed

** Changed in: mahara/16.04
   Status: New => Fix Committed

** Changed in: mahara/15.04
Milestone: None => 15.04.8

** Changed in: mahara/15.10
Milestone: None => 15.10.4

** Changed in: mahara/16.04
Milestone: None => 16.04.2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A patch has been submitted for review

[Mahara Bot]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6712

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/6709

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  New

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600668] [NEW] Google drive folders no longer work in Google Apps block

[Aaron Wells]

Public bug reported:

Related to Bug 1600665, while testing out all the different Google media
in the Google Apps block, I noticed that Google "collections" no longer
work.

Based on context, and comments in the code, I assume the "Google
collections" referred to in the Mahara manual (
http://manual.mahara.org/en/16.04/blocks/external.html#google-apps ) are
actually Google Docs/Drive folders, and *not* Google Plus collections.
This was a stumbling block at first, because the Docs/Drive folders are
now called folders, rather than collections. And, from the code, it
appears we've never supported embedding Google Plus collections.

Anyway, to replicate:

1. Create a Google Drive folder, like so:

1a. Log in to drive.google.com

1b. Click "New" and then "Folder" to create a new folder.

1c. It will now navigate you into the new folder, so in the nav bar
underneath the search bar, you should see "My Drive > Untitled folder"
or whatever you named your folder.

1d. In that nav bar, click the little triangle next to your folder's
name on "My Drive > Untitled folder". This will open up a menu of
options. Select "Get shareable link", and you should get a URL like
this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

1e. Alternately, click the little triangle and select "Share", and copy
the link there, which will be like this:
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

2. Log in to Mahara

3. Put a Google Apps block into a page

4. Paste the link from Google Drive into the block.

Expected result: The block displays a folder icon, which if clicked, is
a link to the folder.

Actual result: You see this error message in the block: "Unable to parse
embedded code or URL:
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
"

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600668

Title:
  Google drive folders no longer work in Google Apps  block

Status in Mahara:
  New

Bug description:
  Related to Bug 1600665, while testing out all the different Google
  media in the Google Apps block, I noticed that Google "collections" no
  longer work.

  Based on context, and comments in the code, I assume the "Google
  collections" referred to in the Mahara manual (
  http://manual.mahara.org/en/16.04/blocks/external.html#google-apps )
  are actually Google Docs/Drive folders, and *not* Google Plus
  collections. This was a stumbling block at first, because the
  Docs/Drive folders are now called folders, rather than collections.
  And, from the code, it appears we've never supported embedding Google
  Plus collections.

  Anyway, to replicate:

  1. Create a Google Drive folder, like so:

  1a. Log in to drive.google.com

  1b. Click "New" and then "Folder" to create a new folder.

  1c. It will now navigate you into the new folder, so in the nav bar
  underneath the search bar, you should see "My Drive > Untitled folder"
  or whatever you named your folder.

  1d. In that nav bar, click the little triangle next to your folder's
  name on "My Drive > Untitled folder". This will open up a menu of
  options. Select "Get shareable link", and you should get a URL like
  this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

  1e. Alternately, click the little triangle and select "Share", and
  copy the link there, which will be like this:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing

  2. Log in to Mahara

  3. Put a Google Apps block into a page

  4. Paste the link from Google Drive into the block.

  Expected result: The block displays a folder icon, which if clicked,
  is a link to the folder.

  Actual result: You see this error message in the block: "Unable to
  parse embedded code or URL:
  
https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA=sharing
  "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600668/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1560329] Re: The block config's "cancel" button breaks after a Pieform validation failure

[Robert Lyon]

** Changed in: mahara/15.10
Milestone: 15.10.4 => 15.10.5

** Changed in: mahara/16.04
Milestone: 16.04.2 => 16.04.3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560329

Title:
  The block config's "cancel" button breaks after a Pieform validation
  failure

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  To replicate:

  1. Drag a new "external media" block into your page.
  2. In the block config modal that opens up, hit "submit" without filling in 
the required "URL or embed code" field
  3. Press "Submit"
  4. Wait for the form to reload and display the warning message telling you 
about the required field
  5. Once that loads up, press the "Cancel" or "Remove" button/link next to the 
"Submit" button.

  Expected result: The block config modal window closes, and the new
  external media block is no longer on your page

  Actual result: The screen reloads, and you now have an empty "external
  media" block on your page

  The reason this is happening, is because the Pieforms "cancel" button
  by default just reloads the form's action URL, or the cancel button's
  "goto" URL. When we load up the block config modal, we use Javascript
  code to rewire the cancel button so that it instead closes the modal
  and, if the block is new, deletes the block.

  However, when Pieforms fails validation, Pieforms actually removes the
  current form displayed on the page, and replaces it with a new form
  that contains the validation errors. Because this is a completely
  different form object, the "rewiring" that we did when we opened the
  modal no longer applies.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1598962] Re: choose template .tpl needs styling

[Robert Lyon]

** Changed in: mahara/15.10
Milestone: 15.10.4 => 15.10.5

** Changed in: mahara/16.04
Milestone: 16.04.2 => 16.04.3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1598962

Title:
  choose template .tpl needs styling

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  To test:

  1) On an installed site go to a page's edit screen, and make note if the id 
in the url eg id=50
  2) Via database set that view's theme to something non-existant, eg:

   UPDATE view SET theme = 'thundercats' WHERE id = 50;

  3) Reload the page - you should be taken to a 'choose theme' page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1598962/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1234615] Re: Not checking artefact permissions before exporting

[Robert Lyon]

** Changed in: mahara/15.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/15.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/16.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Information type changed from Private Security to Public Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234615

Title:
  Not checking artefact permissions before exporting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In https://bugs.launchpad.net/bugs/1211758 , the reporter mentioned
  that in addition to embedding other users' artefacts in your pages,
  you could export them to view their full content:

  #3: Export function allows arbitrary file download
  Using the technique above you can get a 1024x1024 'thumbnail' of any users 
arbitrary file. Simply use the export function on a page like the one above 
where other users images are embedded. Make sure the embedded images max-size 
is set to 1024 and it will appear within /files/extra.

  There is an obvious fix for this issue, of checking
  $USER->can_publish_artefac()t or $USER->can_view_artefact() on each
  artefact before exporting it. But when Robert tested this fix, he
  found that it was too resource-intensive (as part of the already
  resource-intensive export process) for it to work while exporting an
  average-sized portfolio.

  Since fixing the embedding of other users' data mitigates the risk
  from this issue and was easier to accomplish, I've released that fix
  and spun this one off into a separate bug to fix when we're able.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234615/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1489274] Re: Full copy of blog block with embedded images still causing problems

[Robert Lyon]

** Changed in: mahara/15.10
Milestone: 15.10.4 => 15.10.5

** Changed in: mahara/16.04
Milestone: 16.04.2 => 16.04.3

** Changed in: mahara/15.04
Milestone: 15.04.8 => 15.04.9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1489274

Title:
  Full copy of blog block with embedded images still causing problems

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Bug 1476059 fixed some problems with copies of blogs that have
  embedded images. But, it didn't do a database update, so blog entries
  created before that bug fix will still cause problems.

  Here's how to replicate:

  1. Install Mahara 15.04.2
  2. Create a blog entry.
  3. Use the TinyMCE "image" button to embed an image in the blog entry
  4. Create a page
  5. Put a blog entry block on the page.
  6. Select the blog entry you created
  7. Set the block's copy permission to "Others will get their own copy of your 
journal"
  8. Share the page with registered users
  9. Set the page to allow copying
  10. Upgrade site to Mahara 15.04.3
  11. Log in as a second user
  12. Copy the page

  Expected result: You should see the image from the blog entry, on your copy 
of the page
  Actual result: The blog entry shows "undefined" where the image should be

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1489274/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1576643] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6688
Committed: 
https://git.mahara.org/mahara/mahara/commit/73f51de41227553449c1ec7bb7a4f2affe2e880a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 73f51de41227553449c1ec7bb7a4f2affe2e880a
Author: Pat Kira 
Date:   Fri Jun 24 11:31:21 2016 +1200

Bug 1576643 - Enabled tinyMCE on mobile devices

behatnotneeded: Can't test mobile
Change-Id: Ic0ba811d66a6f52468517108fffd331956262748
(cherry picked from commit 4616ac02c706c2e74929d6a9fa9ed339b3c2afc2)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576643

Title:
  TinyMCE is not available on the iPad

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Version of Mahara  is 15.10.1.
  Server operating system is Linux
  Databaseis  Postgres
  Browser is Safari

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1431659] Re: Problems importing Annotations via Leap2a

[Robert Lyon]

** Changed in: mahara/15.04
Milestone: 15.04.8 => 15.04.9

** Changed in: mahara/15.10
Milestone: 15.10.4 => 15.10.5

** Changed in: mahara/16.04
Milestone: 16.04.2 => 16.04.3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1431659

Title:
  Problems importing Annotations via Leap2a

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  As reported on https://reviews.mahara.org/#/c/4123/:

  "When I import a Leap2A (a collection with two pages; one with a text
  and 2 annotation blocks and the other with an image block and an
  annotation block), I get "[INF] 83 (import/index.php:301) Leap2A
  import failed: Cannot find reflection entry for annotation." The text
  block does not have an embedded image. Just plain text."

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1234615] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6672
Committed: 
https://git.mahara.org/mahara/mahara/commit/aa31ba590f15010b6b27d9cec66a9f1ce8d62c7e
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit aa31ba590f15010b6b27d9cec66a9f1ce8d62c7e
Author: Robert Lyon 
Date:   Fri Jul 8 11:02:22 2016 +1200

Bug 1234615: Check that resized image files are viewable by user

When exporting via Html export process - if not then ignore the file

To test:

1) Add an image block/file to a page and set a width value

2) Go into db block_instance table and change the artefactid to an
image that is owned by another user

3) Reload the page - you should see the image block but not the
attached image

4) Export the page as HTML, either as full or standalone

Before patch - you will end up with image file in the files/extra/
directory

After patch - you should not get the image in the files/extra/
directory and you should get an info warning 'Unable to copy artefact
file ***' on export page.

behatnotneeded

Change-Id: Iaeb9404b3329c4eb3eac59354801b598f7cd5ba8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234615

Title:
  Not checking artefact permissions before exporting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In https://bugs.launchpad.net/bugs/1211758 , the reporter mentioned
  that in addition to embedding other users' artefacts in your pages,
  you could export them to view their full content:

  #3: Export function allows arbitrary file download
  Using the technique above you can get a 1024x1024 'thumbnail' of any users 
arbitrary file. Simply use the export function on a page like the one above 
where other users images are embedded. Make sure the embedded images max-size 
is set to 1024 and it will appear within /files/extra.

  There is an obvious fix for this issue, of checking
  $USER->can_publish_artefac()t or $USER->can_view_artefact() on each
  artefact before exporting it. But when Robert tested this fix, he
  found that it was too resource-intensive (as part of the already
  resource-intensive export process) for it to work while exporting an
  average-sized portfolio.

  Since fixing the embedding of other users' data mitigates the risk
  from this issue and was easier to accomplish, I've released that fix
  and spun this one off into a separate bug to fix when we're able.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234615/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1597536] Re: import_entry_requests table needs a ctime so we can clean up old partial requests

[Robert Lyon]

** Changed in: mahara/15.04
Milestone: 15.04.8 => 15.04.9

** Changed in: mahara/15.10
Milestone: 15.10.4 => 15.10.5

** Changed in: mahara/16.04
Milestone: 16.04.2 => 16.04.3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597536

Title:
  import_entry_requests table needs a ctime so we can clean up old
  partial requests

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  A ctime will allow us to clean up the old entries via a new (or
  possibly existing) cronjob

  And we need to make the stored path to the files be relative to
  dataroot rather than full path from '/' on server as we shouldn't be
  recording that info in the db.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597536/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600069] Re: See other's profile images one is not meant to

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

** Information type changed from Private Security to Public Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600069

Title:
  See other's profile images one is not meant to

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  As part of the follow on from this bug:
  https://bugs.launchpad.net/mahara/+bug/1211758

  I notice that it is possible to see profile images of other users that
  one isn't meant to.

  Demo:
  Login as User A and upload two profile icons - set one to be default
  make note of the artefact id's

  Login as User B then go to the url:

  thumb.php?type=profileiconbyid=150=[id from above]

  You should only be allowed to see the icon that is set to the default
  icon but you can see both

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600069/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1576643] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6689
Committed: 
https://git.mahara.org/mahara/mahara/commit/74684cd0c0fbeffd3c6861e003e3d86356d0380f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 74684cd0c0fbeffd3c6861e003e3d86356d0380f
Author: Pat Kira 
Date:   Fri Jun 24 11:31:21 2016 +1200

Bug 1576643 - Enabled tinyMCE on mobile devices

behatnotneeded: Can't test mobile
Change-Id: Ic0ba811d66a6f52468517108fffd331956262748
(cherry picked from commit 4616ac02c706c2e74929d6a9fa9ed339b3c2afc2)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576643

Title:
  TinyMCE is not available on the iPad

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Version of Mahara  is 15.10.1.
  Server operating system is Linux
  Databaseis  Postgres
  Browser is Safari

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1576643] Re: TinyMCE is not available on the iPad

[Robert Lyon]

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576643

Title:
  TinyMCE is not available on the iPad

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Version of Mahara  is 15.10.1.
  Server operating system is Linux
  Databaseis  Postgres
  Browser is Safari

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1234615] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6694
Committed: 
https://git.mahara.org/mahara/mahara/commit/32b65c72762f50dbddfda20a5c9b74c66cbb5343
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 32b65c72762f50dbddfda20a5c9b74c66cbb5343
Author: Robert Lyon 
Date:   Fri Jul 8 11:02:22 2016 +1200

Bug 1234615: Check that resized image files are viewable by user

When exporting via Html export process - if not then ignore the file

To test:

1) Add an image block/file to a page and set a width value

2) Go into db block_instance table and change the artefactid to an
image that is owned by another user

3) Reload the page - you should see the image block but not the
attached image

4) Export the page as HTML, either as full or standalone

Before patch - you will end up with image file in the files/extra/
directory

After patch - you should not get the image in the files/extra/
directory and you should get an info warning 'Unable to copy artefact
file ***' on export page.

behatnotneeded

Change-Id: Iaeb9404b3329c4eb3eac59354801b598f7cd5ba8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234615

Title:
  Not checking artefact permissions before exporting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In https://bugs.launchpad.net/bugs/1211758 , the reporter mentioned
  that in addition to embedding other users' artefacts in your pages,
  you could export them to view their full content:

  #3: Export function allows arbitrary file download
  Using the technique above you can get a 1024x1024 'thumbnail' of any users 
arbitrary file. Simply use the export function on a page like the one above 
where other users images are embedded. Make sure the embedded images max-size 
is set to 1024 and it will appear within /files/extra.

  There is an obvious fix for this issue, of checking
  $USER->can_publish_artefac()t or $USER->can_view_artefact() on each
  artefact before exporting it. But when Robert tested this fix, he
  found that it was too resource-intensive (as part of the already
  resource-intensive export process) for it to work while exporting an
  average-sized portfolio.

  Since fixing the embedding of other users' data mitigates the risk
  from this issue and was easier to accomplish, I've released that fix
  and spun this one off into a separate bug to fix when we're able.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234615/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1234615] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6692
Committed: 
https://git.mahara.org/mahara/mahara/commit/36ab4bffb02b1a4f43ed1a5fd20dccad4a18d642
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 36ab4bffb02b1a4f43ed1a5fd20dccad4a18d642
Author: Robert Lyon 
Date:   Fri Jul 8 11:02:22 2016 +1200

Bug 1234615: Check that resized image files are viewable by user

When exporting via Html export process - if not then ignore the file

To test:

1) Add an image block/file to a page and set a width value

2) Go into db block_instance table and change the artefactid to an
image that is owned by another user

3) Reload the page - you should see the image block but not the
attached image

4) Export the page as HTML, either as full or standalone

Before patch - you will end up with image file in the files/extra/
directory

After patch - you should not get the image in the files/extra/
directory and you should get an info warning 'Unable to copy artefact
file ***' on export page.

behatnotneeded

Change-Id: Iaeb9404b3329c4eb3eac59354801b598f7cd5ba8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234615

Title:
  Not checking artefact permissions before exporting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In https://bugs.launchpad.net/bugs/1211758 , the reporter mentioned
  that in addition to embedding other users' artefacts in your pages,
  you could export them to view their full content:

  #3: Export function allows arbitrary file download
  Using the technique above you can get a 1024x1024 'thumbnail' of any users 
arbitrary file. Simply use the export function on a page like the one above 
where other users images are embedded. Make sure the embedded images max-size 
is set to 1024 and it will appear within /files/extra.

  There is an obvious fix for this issue, of checking
  $USER->can_publish_artefac()t or $USER->can_view_artefact() on each
  artefact before exporting it. But when Robert tested this fix, he
  found that it was too resource-intensive (as part of the already
  resource-intensive export process) for it to work while exporting an
  average-sized portfolio.

  Since fixing the embedding of other users' data mitigates the risk
  from this issue and was easier to accomplish, I've released that fix
  and spun this one off into a separate bug to fix when we're able.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234615/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1234615] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6693
Committed: 
https://git.mahara.org/mahara/mahara/commit/d6399ee68eddf53a46bb046f77656bb4fb3044b8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit d6399ee68eddf53a46bb046f77656bb4fb3044b8
Author: Robert Lyon 
Date:   Fri Jul 8 11:02:22 2016 +1200

Bug 1234615: Check that resized image files are viewable by user

When exporting via Html export process - if not then ignore the file

To test:

1) Add an image block/file to a page and set a width value

2) Go into db block_instance table and change the artefactid to an
image that is owned by another user

3) Reload the page - you should see the image block but not the
attached image

4) Export the page as HTML, either as full or standalone

Before patch - you will end up with image file in the files/extra/
directory

After patch - you should not get the image in the files/extra/
directory and you should get an info warning 'Unable to copy artefact
file ***' on export page.

behatnotneeded

Change-Id: Iaeb9404b3329c4eb3eac59354801b598f7cd5ba8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234615

Title:
  Not checking artefact permissions before exporting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In https://bugs.launchpad.net/bugs/1211758 , the reporter mentioned
  that in addition to embedding other users' artefacts in your pages,
  you could export them to view their full content:

  #3: Export function allows arbitrary file download
  Using the technique above you can get a 1024x1024 'thumbnail' of any users 
arbitrary file. Simply use the export function on a page like the one above 
where other users images are embedded. Make sure the embedded images max-size 
is set to 1024 and it will appear within /files/extra.

  There is an obvious fix for this issue, of checking
  $USER->can_publish_artefac()t or $USER->can_view_artefact() on each
  artefact before exporting it. But when Robert tested this fix, he
  found that it was too resource-intensive (as part of the already
  resource-intensive export process) for it to work while exporting an
  average-sized portfolio.

  Since fixing the embedding of other users' data mitigates the risk
  from this issue and was easier to accomplish, I've released that fix
  and spun this one off into a separate bug to fix when we're able.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234615/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6706
Committed: 
https://git.mahara.org/mahara/mahara/commit/6150804f758f4c7ddaba82b7e907bac053cf992f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 6150804f758f4c7ddaba82b7e907bac053cf992f
Author: Aaron Wells 
Date:   Mon Jul 11 15:38:53 2016 +1200

Bug 1600665: Support for new Google Calendar embed URL

Change-Id: I8318010bb02d4e464490bc5447cf58d2a15ad949
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit d767340d58f4a505c56bb2acde4b8b180e0fd83d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1580399] Re: Users can login to suspended institutions via external auth under some circumstances

[Robert Lyon]

** Information type changed from Private Security to Public Security

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1580399

Title:
  Users can login to suspended institutions via external auth under some
  circumstances

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  The problem is this:

  The code that checks if the user's authinstance is from a suspended
  institution, is in LiveUser->login(). This is the method used by the
  username/password login box.

  But if you login with an auth method that doesn't use the login box,
  say SAML, XMLRPC, Shibboleth, you don't hit that check.

  
  We need to move the check into the "ensure_user_account_is_active()" method 
in auth/lib.php which is already called at the start of 
LiveUser->authenticate() so we should update that to make sure it checks that 
their auth institution isn't suspended and (maybe) remove the redundant code 
from LiveUser->login()

  
  See also https://bugs.launchpad.net/mahara/+bug/903534 for some more 
information about this issue
  That bug report is public but I'll mark this as private as it mentions the 
attack vector

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1580399/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1084336] Re: mnet: mahara doesn't implement kill_child which results in not being logged out when logged out from a remote IdP over mnet

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

** Information type changed from Private Security to Public Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1084336

Title:
  mnet: mahara doesn't implement kill_child which results in not being
  logged out when logged out from a remote IdP over mnet

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  When Mahara is doing SSO via MNet, with a remote IdP, it ought to log
  you out of Mahara when you log out of the IdP. MNet allows for this
  via the "kill_child" API method, which the IdP will call for each
  connected service provider to tell it to log a user out.

  Mahara never implemented this method, so it doesn't log you out
  properly when you log out of the IdP.

  To replicate:

  1. Set up MNet between a Moodle & Mahara site, with Moodle as the identity 
provider (i.e. users log in to Moodle and then roam over to Mahara)
  2. Log in to Moodle
  3. Roam over to Mahara
  4. Open up Moodle in another tab.
  5. Log out of Moodle.
  6. Go back to the tab with Mahara and try to navigate around in the site.

  Expected result: You can't navigate around because you're logged out
  of Mahara

  Actual result: You are not logged out of Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1084336/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6705
Committed: 
https://git.mahara.org/mahara/mahara/commit/d767340d58f4a505c56bb2acde4b8b180e0fd83d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit d767340d58f4a505c56bb2acde4b8b180e0fd83d
Author: Aaron Wells 
Date:   Mon Jul 11 15:38:53 2016 +1200

Bug 1600665: Support for new Google Calendar embed URL

Change-Id: I8318010bb02d4e464490bc5447cf58d2a15ad949
behatnotneeded: Can't test Google embeds in Behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1508684] Re: Unserialize untrusted data when importing skins

[Robert Lyon]

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

** Information type changed from Private Security to Public Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A patch has been submitted for review

[Mahara Bot]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6708

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1084336] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6698
Committed: 
https://git.mahara.org/mahara/mahara/commit/8654c56dcbe0cd325b9bea4ed914dc869c6ee949
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 8654c56dcbe0cd325b9bea4ed914dc869c6ee949
Author: Aaron Wells 
Date:   Tue Jul 5 12:19:42 2016 +1200

Bug 1084336: Implement MNet "kill child"

If you're logged in to Mahara via a remote IdP,
when you log out on the IdP it will try to invoke
this method to log you out of Mahara.

Change-Id: Ia11250b408ba594aaa179478cd67d5499cd1e2c8
behatnotneeded: Can't test Mnet in Behat yet

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1084336

Title:
  mnet: mahara doesn't implement kill_child which results in not being
  logged out when logged out from a remote IdP over mnet

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  When Mahara is doing SSO via MNet, with a remote IdP, it ought to log
  you out of Mahara when you log out of the IdP. MNet allows for this
  via the "kill_child" API method, which the IdP will call for each
  connected service provider to tell it to log a user out.

  Mahara never implemented this method, so it doesn't log you out
  properly when you log out of the IdP.

  To replicate:

  1. Set up MNet between a Moodle & Mahara site, with Moodle as the identity 
provider (i.e. users log in to Moodle and then roam over to Mahara)
  2. Log in to Moodle
  3. Roam over to Mahara
  4. Open up Moodle in another tab.
  5. Log out of Moodle.
  6. Go back to the tab with Mahara and try to navigate around in the site.

  Expected result: You can't navigate around because you're logged out
  of Mahara

  Actual result: You are not logged out of Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1084336/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1084336] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6700
Committed: 
https://git.mahara.org/mahara/mahara/commit/4aab3a18cb0b261a4a8074e34b642f18fef91012
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 4aab3a18cb0b261a4a8074e34b642f18fef91012
Author: Aaron Wells 
Date:   Tue Jul 5 12:19:42 2016 +1200

Bug 1084336: Implement MNet "kill child"

If you're logged in to Mahara via a remote IdP,
when you log out on the IdP it will try to invoke
this method to log you out of Mahara.

Change-Id: Ia11250b408ba594aaa179478cd67d5499cd1e2c8
behatnotneeded: Can't test Mnet in Behat yet

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1084336

Title:
  mnet: mahara doesn't implement kill_child which results in not being
  logged out when logged out from a remote IdP over mnet

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  When Mahara is doing SSO via MNet, with a remote IdP, it ought to log
  you out of Mahara when you log out of the IdP. MNet allows for this
  via the "kill_child" API method, which the IdP will call for each
  connected service provider to tell it to log a user out.

  Mahara never implemented this method, so it doesn't log you out
  properly when you log out of the IdP.

  To replicate:

  1. Set up MNet between a Moodle & Mahara site, with Moodle as the identity 
provider (i.e. users log in to Moodle and then roam over to Mahara)
  2. Log in to Moodle
  3. Roam over to Mahara
  4. Open up Moodle in another tab.
  5. Log out of Moodle.
  6. Go back to the tab with Mahara and try to navigate around in the site.

  Expected result: You can't navigate around because you're logged out
  of Mahara

  Actual result: You are not logged out of Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1084336/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6706

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1084336] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6647
Committed: 
https://git.mahara.org/mahara/mahara/commit/2837542d07b07e1e43fd1841166af0e7edd7cc0d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 2837542d07b07e1e43fd1841166af0e7edd7cc0d
Author: Aaron Wells 
Date:   Tue Jul 5 12:19:42 2016 +1200

Bug 1084336: Implement MNet "kill child"

If you're logged in to Mahara via a remote IdP,
when you log out on the IdP it will try to invoke
this method to log you out of Mahara.

Change-Id: Ia11250b408ba594aaa179478cd67d5499cd1e2c8
behatnotneeded: Can't test Mnet in Behat yet

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1084336

Title:
  mnet: mahara doesn't implement kill_child which results in not being
  logged out when logged out from a remote IdP over mnet

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  When Mahara is doing SSO via MNet, with a remote IdP, it ought to log
  you out of Mahara when you log out of the IdP. MNet allows for this
  via the "kill_child" API method, which the IdP will call for each
  connected service provider to tell it to log a user out.

  Mahara never implemented this method, so it doesn't log you out
  properly when you log out of the IdP.

  To replicate:

  1. Set up MNet between a Moodle & Mahara site, with Moodle as the identity 
provider (i.e. users log in to Moodle and then roam over to Mahara)
  2. Log in to Moodle
  3. Roam over to Mahara
  4. Open up Moodle in another tab.
  5. Log out of Moodle.
  6. Go back to the tab with Mahara and try to navigate around in the site.

  Expected result: You can't navigate around because you're logged out
  of Mahara

  Actual result: You are not logged out of Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1084336/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6707
Committed: 
https://git.mahara.org/mahara/mahara/commit/953cc50b9c50d6d2e166eb00f227ec19284ebe8e
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 953cc50b9c50d6d2e166eb00f227ec19284ebe8e
Author: Aaron Wells 
Date:   Mon Jul 11 15:38:53 2016 +1200

Bug 1600665: Support for new Google Calendar embed URL

Change-Id: I8318010bb02d4e464490bc5447cf58d2a15ad949
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit d767340d58f4a505c56bb2acde4b8b180e0fd83d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1084336] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6699
Committed: 
https://git.mahara.org/mahara/mahara/commit/c6a72f8145a72d8d20955769c42325da6bffbb3e
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit c6a72f8145a72d8d20955769c42325da6bffbb3e
Author: Aaron Wells 
Date:   Tue Jul 5 12:19:42 2016 +1200

Bug 1084336: Implement MNet "kill child"

If you're logged in to Mahara via a remote IdP,
when you log out on the IdP it will try to invoke
this method to log you out of Mahara.

Change-Id: Ia11250b408ba594aaa179478cd67d5499cd1e2c8
behatnotneeded: Can't test Mnet in Behat yet

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1084336

Title:
  mnet: mahara doesn't implement kill_child which results in not being
  logged out when logged out from a remote IdP over mnet

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  When Mahara is doing SSO via MNet, with a remote IdP, it ought to log
  you out of Mahara when you log out of the IdP. MNet allows for this
  via the "kill_child" API method, which the IdP will call for each
  connected service provider to tell it to log a user out.

  Mahara never implemented this method, so it doesn't log you out
  properly when you log out of the IdP.

  To replicate:

  1. Set up MNet between a Moodle & Mahara site, with Moodle as the identity 
provider (i.e. users log in to Moodle and then roam over to Mahara)
  2. Log in to Moodle
  3. Roam over to Mahara
  4. Open up Moodle in another tab.
  5. Log out of Moodle.
  6. Go back to the tab with Mahara and try to navigate around in the site.

  Expected result: You can't navigate around because you're logged out
  of Mahara

  Actual result: You are not logged out of Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1084336/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A patch has been submitted for review

[Mahara Bot]

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6707

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1508684] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6678
Committed: 
https://git.mahara.org/mahara/mahara/commit/3f9514bdaa9b70457a404cd1b9aa502c261aeef2
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 3f9514bdaa9b70457a404cd1b9aa502c261aeef2
Author: Son Nguyen 
Date:   Thu Oct 22 10:55:40 2015 +1300

Make sure imported custom skin xml entries are clean. Bug 1508684

behatnotneeded

Change-Id: I2e597d5931391e731baefa46d5f9d9ca2059ee10

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1508684] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6677
Committed: 
https://git.mahara.org/mahara/mahara/commit/1f299954f3ffbc26c69e27f000daf8f0e97de457
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 1f299954f3ffbc26c69e27f000daf8f0e97de457
Author: Son Nguyen 
Date:   Thu Oct 22 10:55:40 2015 +1300

Make sure imported custom skin xml entries are clean. Bug 1508684

behatnotneeded

Change-Id: I2e597d5931391e731baefa46d5f9d9ca2059ee10

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1508684] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6679
Committed: 
https://git.mahara.org/mahara/mahara/commit/9d7701e80b24bdbaccb77ae7730ae9c504d1143b
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 9d7701e80b24bdbaccb77ae7730ae9c504d1143b
Author: Son Nguyen 
Date:   Thu Oct 22 10:55:40 2015 +1300

Make sure imported custom skin xml entries are clean. Bug 1508684

behatnotneeded

Change-Id: I2e597d5931391e731baefa46d5f9d9ca2059ee10

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1580399] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6696
Committed: 
https://git.mahara.org/mahara/mahara/commit/792fb47bdc4dbbb058a2b5e6ac7dc9483cb4be34
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 792fb47bdc4dbbb058a2b5e6ac7dc9483cb4be34
Author: Robert Lyon 
Date:   Fri Jul 8 09:05:53 2016 +1200

Bug 1580399: Stop users logging in to suspended/expired institutions

Moving the code from LiveUser->login() to
ensure_user_account_is_active() so that internal and external logins
can use the same code. This means the check now will fall after
LiveUser->authenticate() so a user's lastlogin values will be updated.
but that should be ok as the login was successful, it's just they
can't go any further as their institution is not active.

behatnotneeded

Change-Id: Ie78a60978d5936f78af5a962ca3efdcdee148b93
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1580399

Title:
  Users can login to suspended institutions via external auth under some
  circumstances

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  The problem is this:

  The code that checks if the user's authinstance is from a suspended
  institution, is in LiveUser->login(). This is the method used by the
  username/password login box.

  But if you login with an auth method that doesn't use the login box,
  say SAML, XMLRPC, Shibboleth, you don't hit that check.

  
  We need to move the check into the "ensure_user_account_is_active()" method 
in auth/lib.php which is already called at the start of 
LiveUser->authenticate() so we should update that to make sure it checks that 
their auth institution isn't suspended and (maybe) remove the redundant code 
from LiveUser->login()

  
  See also https://bugs.launchpad.net/mahara/+bug/903534 for some more 
information about this issue
  That bug report is public but I'll mark this as private as it mentions the 
attack vector

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1580399/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6708
Committed: 
https://git.mahara.org/mahara/mahara/commit/38e997b77014345904378931c95a6912a46338ae
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 38e997b77014345904378931c95a6912a46338ae
Author: Aaron Wells 
Date:   Mon Jul 11 15:38:53 2016 +1200

Bug 1600665: Support for new Google Calendar embed URL

Change-Id: I8318010bb02d4e464490bc5447cf58d2a15ad949
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit d767340d58f4a505c56bb2acde4b8b180e0fd83d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] Re: Google calendar URLs no longer work in Google Apps block

[Robert Lyon]

** Changed in: mahara/15.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/15.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/16.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/16.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599958] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6690
Committed: 
https://git.mahara.org/mahara/mahara/commit/134cfd9ed7b8949d7798a5e1a49f5135b2c4f1bf
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 134cfd9ed7b8949d7798a5e1a49f5135b2c4f1bf
Author: Robert Lyon 
Date:   Mon Jul 11 12:15:17 2016 +1200

Bug 1599958: Allowing profile page to display embedly correctly

Same fix as the portfolio page

behatnotneeded

Change-Id: I0ba3dda00239fb0c6472360dcac6ccf4952b29fb
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599958

Title:
  Embedly content will not display on profile page

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Content in External Media block from Embedly does not appear on user
  profile page but will work on other pages created. Displays fine in
  edit mode but disappears in display mode. Tested with Dropbox and
  Soundcloud links.

  Tested on my 16.04.01 dev (Ubuntu 14.04, Apache 2.4, Postgres) and the
  Mahara demo site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599958] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6704

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599958

Title:
  Embedly content will not display on profile page

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Content in External Media block from Embedly does not appear on user
  profile page but will work on other pages created. Displays fine in
  edit mode but disappears in display mode. Tested with Dropbox and
  Soundcloud links.

  Tested on my 16.04.01 dev (Ubuntu 14.04, Apache 2.4, Postgres) and the
  Mahara demo site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599958] Re: Embedly content will not display on profile page

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599958

Title:
  Embedly content will not display on profile page

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Content in External Media block from Embedly does not appear on user
  profile page but will work on other pages created. Displays fine in
  edit mode but disappears in display mode. Tested with Dropbox and
  Soundcloud links.

  Tested on my 16.04.01 dev (Ubuntu 14.04, Apache 2.4, Postgres) and the
  Mahara demo site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599958] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/6704
Committed: 
https://git.mahara.org/mahara/mahara/commit/e5b0530a0a72efa80056f4456ab36e54491d524f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit e5b0530a0a72efa80056f4456ab36e54491d524f
Author: Robert Lyon 
Date:   Mon Jul 11 12:15:17 2016 +1200

Bug 1599958: Allowing profile page to display embedly correctly

Same fix as the portfolio page

behatnotneeded

Change-Id: I0ba3dda00239fb0c6472360dcac6ccf4952b29fb
Signed-off-by: Robert Lyon 
(cherry picked from commit 134cfd9ed7b8949d7798a5e1a49f5135b2c4f1bf)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599958

Title:
  Embedly content will not display on profile page

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Content in External Media block from Embedly does not appear on user
  profile page but will work on other pages created. Displays fine in
  edit mode but disappears in display mode. Tested with Dropbox and
  Soundcloud links.

  Tested on my 16.04.01 dev (Ubuntu 14.04, Apache 2.4, Postgres) and the
  Mahara demo site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1600665] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/6705

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600665

Title:
  Google calendar URLs no longer work in Google Apps block

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7649

  I'm guessing that Google has changed the URLs for their embed strings
  again, because the iframe embed snippet from Google Calendars no
  longer works in the Google Apps block.

  To replicate:

  1. Get the "Embed this calendar" iframe snippet for a Google Calendar.
  (See http://manual.mahara.org/en/16.04/blocks/external.html#google-
  apps for details on how to do that)

  2. Create a Mahara page with a Google Apps block

  3. Past the embed code into the Google Apps block

  Expected result: The calendar is displayed, embedded into the page.

  Actual result: You see this error message in the block:

  "Unable to parse embedded code or URL: https://calendar.google.com/calendar/embed?src=example%40gmail.com=Pacific/Auckland;
  style="border: 0" width="800" height="600" frameborder="0"
  scrolling="no">"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1599958] Re: Embedly content will not display on profile page

[Robert Lyon]

** Changed in: mahara/16.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599958

Title:
  Embedly content will not display on profile page

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Content in External Media block from Embedly does not appear on user
  profile page but will work on other pages created. Displays fine in
  edit mode but disappears in display mode. Tested with Dropbox and
  Soundcloud links.

  Tested on my 16.04.01 dev (Ubuntu 14.04, Apache 2.4, Postgres) and the
  Mahara demo site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1588599] Re: PHP 7 unrecoverable errors in 16.04

[Robert Lyon]

** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588599

Title:
  PHP 7 unrecoverable errors in 16.04

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I am porting my working instance of mahara 16.04 (debian, php 5.5) to
  a new server (ubuntu 16.04, php 7.04, using git for installation).
  Just by chance I stumble upon some crashes which seem to be related to
  using deprecated PHP functions. At this time I found (and easily
  repaired) the following files needing fixing for PHP 7:

  root@QSKW001:/var/www/mahara# git status
  On branch 16.04_STABLE
  Your branch is up-to-date with 'origin/16.04_STABLE'.
  Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

modified:   htdocs/lib/antispam/SimpleSpamTrap.php
modified:   htdocs/module/multirecipientnotification/inbox.php
modified:   
htdocs/module/multirecipientnotification/lib/activityextend.php
modified:   htdocs/module/multirecipientnotification/outbox.php

  the first one needing preg_match instead of eregi

  diff lib/antispam/SimpleSpamTrap.php 
../../mahara-16.04.0/htdocs/lib/antispam/SimpleSpamTrap.php
  25c25
  < if (preg_match("/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i", 
$email)) {
  ---
  > if (eregi("^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$", $email)) {

  while the other ones simply needed explode instead of split, e.g.:

  root@QSKW001:/var/www/mahara# diff 
htdocs/module/multirecipientnotification/inbox.php 
../mahara-16.04.0/htdocs/module/multirecipientnotification/inbox.php
  78c78
  < explode(',', $type),
  ---
  > split(',', $type),
  179c179
  < $types = explode(',', preg_replace('/[^a-z,]+/', '', $type));
  ---
  > $types = split(',', preg_replace('/[^a-z,]+/', '', $type));

  These are just quick hacks by me working up to now.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588599/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp