[Mahara-contributors] [Bug 1609142] A change has been merged

2016-08-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/6787
Committed: 
https://git.mahara.org/mahara/mahara/commit/db34349feef29ce01604d0bdb276248bb854bc3c
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit db34349feef29ce01604d0bdb276248bb854bc3c
Author: Son Nguyen 
Date:   Wed Aug 3 10:15:35 2016 +1200

Bug 1609142: Fix click event handler for contextual help

behatnotneeded

Change-Id: I7675dbc105cf73a9eb3960529c582acffb8aad26

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609142

Title:
  Closing help options with 'X' causes cancel of form

Status in Mahara:
  Fix Committed

Bug description:
  If I open the admin user edit page and change a field then click on
  help icon then click on the 'X' to close it I get the 'This page is
  asking you to confirm that you want to leave - data you have entered
  may not be saved.' message indicating to me that it is trying to
  submit the form.

  If I don't change a form value the clicking on 'X' looks to reload the
  page, so looks to be doing the form 'cancel' option.

  If I do this on the Institution edit page (where I first noticed it)
  it cancels the form and takes me to the institution list page.

  I note that if I click on a help icon then click outside the help box
  it disappears and nothing bad happens, so this issue is only if the
  'X' is clicked

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609142/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609142] Re: Closing help options with 'X' causes cancel of form

2016-08-03 Thread Aaron Wells 
This is a regression introduced during the removal of MochiKit from
mahara.js.

** Tags added: regression

** Changed in: mahara
 Assignee: (unassigned) => Son Nguyen (ngson2000)

** Changed in: mahara
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609142

Title:
  Closing help options with 'X' causes cancel of form

Status in Mahara:
  Fix Committed

Bug description:
  If I open the admin user edit page and change a field then click on
  help icon then click on the 'X' to close it I get the 'This page is
  asking you to confirm that you want to leave - data you have entered
  may not be saved.' message indicating to me that it is trying to
  submit the form.

  If I don't change a form value the clicking on 'X' looks to reload the
  page, so looks to be doing the form 'cancel' option.

  If I do this on the Institution edit page (where I first noticed it)
  it cancels the form and takes me to the institution list page.

  I note that if I click on a help icon then click outside the help box
  it disappears and nothing bad happens, so this issue is only if the
  'X' is clicked

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609142/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] Re: Display something more error-like when an AJAX block errors out

2016-08-03 Thread Aaron Wells 
** Changed in: mahara/15.10
   Status: New => In Progress

** Changed in: mahara/15.04
   Status: New => In Progress

** Changed in: mahara/15.04
   Importance: Undecided => Medium

** Changed in: mahara/15.10
   Importance: Undecided => Medium

** Changed in: mahara/16.04
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.10
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.04
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/16.04
Milestone: None => 16.04.3

** Changed in: mahara/15.10
Milestone: None => 15.10.5

** Changed in: mahara/15.04
Milestone: None => 15.04.9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] A patch has been submitted for review

2016-08-03 Thread Mahara Bot 
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6795

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] A patch has been submitted for review

2016-08-03 Thread Mahara Bot 
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6796

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] Re: Display something more error-like when an AJAX block errors out

2016-08-03 Thread Aaron Wells 
** Also affects: mahara/16.10
   Importance: Medium
 Assignee: Aaron Wells (u-aaronw)
   Status: In Progress

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Importance: Undecided => Medium

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Changed in: mahara/16.04
   Status: New => Fix Committed

** Changed in: mahara/16.04
   Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] A patch has been submitted for review

2016-08-03 Thread Mahara Bot 
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6794

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605071] A change has been merged

2016-08-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/6055
Committed: 
https://git.mahara.org/mahara/mahara/commit/0e7c6ff5d291ea5f8427c4380b3646be4d1b49cc
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 0e7c6ff5d291ea5f8427c4380b3646be4d1b49cc
Author: Aaron Wells 
Date:   Thu Feb 11 18:34:17 2016 +1300

Bug 1605071: Display JSON-style errors for ajax blocks

If an Ajax block errors out, it will looks less broken
to display the JSON code there than to display error.tpl
(which tries to wedge a whole copy of the Mahara header and
footer and everything, into the space for a block.)

It would be even better to change block.js so that it actually
expects a JSON response.

behatnotneeded: Can't test error state via Behat

Change-Id: If5cc9ed2bbb3ce453a5cb413cbecdab0205fb3b5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605071

Title:
  Display something more error-like when an AJAX block errors out

Status in Mahara:
  In Progress

Bug description:
  Spinning this bug off from Bug 1544424 (Endless JS loop if there's an
  uncaught exception in an ajax block) since patch
  https://reviews.mahara.org/6055 has taken much longer than
  https://reviews.mahara.org/6054 to get merged.

  We no longer get an endless loop when an Ajax block errors out, but it
  still looks pretty bad. See the attached screenshot. Because the file
  "blocktype.ajax.php" doesn't have the "JSON" header at its top, when
  it errors out, Mahara tries to print the full error page with the
  navigation headers and the message "Mahara: Site unavailable", and
  then ajaxblocks.js tries to display it in the little iframe reserved
  for that block.

  This looks confusing to the user, and it can spill over out of that
  block's space and cover up adjacent blocks. It would be better if we
  printed something that more obviously indicates that just this one
  block is broken, and that doesn't break the display of other blocks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605071/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609538] A patch has been submitted for review

2016-08-03 Thread Mahara Bot 
Patch for "master" branch: https://reviews.mahara.org/6790

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609538

Title:
  Block edit screen has empy success (green) messages boxes

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  In Progress

Bug description:
  When I add an block (eg an image block) I get a green box at top of
  page but no message in it.

  When I add an image and then save and then reload page and then delete
  the block I get the green box again but still no message in it

  It looks like the 'message' part of the ajax response is not set

  Need to get the message set so it can appear

  It looks like it's a problem in 15.10+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609538/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609538] Re: Block edit screen has empy success (green) messages boxes

2016-08-03 Thread Son Nguyen 
** Changed in: mahara/16.10
   Status: Confirmed => In Progress

** Changed in: mahara/16.10
 Assignee: (unassigned) => Son Nguyen (ngson2000)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609538

Title:
  Block edit screen has empy success (green) messages boxes

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  In Progress

Bug description:
  When I add an block (eg an image block) I get a green box at top of
  page but no message in it.

  When I add an image and then save and then reload page and then delete
  the block I get the green box again but still no message in it

  It looks like the 'message' part of the ajax response is not set

  Need to get the message set so it can appear

  It looks like it's a problem in 15.10+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609538/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1609538] [NEW] Block edit screen has empy success (green) messages boxes

2016-08-03 Thread Robert Lyon 
Public bug reported:

When I add an block (eg an image block) I get a green box at top of page
but no message in it.

When I add an image and then save and then reload page and then delete
the block I get the green box again but still no message in it

It looks like the 'message' part of the ajax response is not set

Need to get the message set so it can appear

It looks like it's a problem in 15.10+

** Affects: mahara
 Importance: Medium
 Status: Confirmed

** Affects: mahara/15.10
 Importance: Medium
 Status: Confirmed

** Affects: mahara/16.04
 Importance: Medium
 Status: Confirmed

** Affects: mahara/16.10
 Importance: Medium
 Status: Confirmed

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Also affects: mahara/16.10
   Importance: Medium
   Status: Confirmed

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Changed in: mahara/16.04
   Status: New => Confirmed

** Changed in: mahara/15.10
   Status: New => Confirmed

** Changed in: mahara/16.04
   Importance: Undecided => Medium

** Changed in: mahara/15.10
   Importance: Undecided => Medium

** Changed in: mahara/15.10
Milestone: None => 15.10.5

** Changed in: mahara/16.04
Milestone: None => 16.04.3

** Changed in: mahara/16.10
Milestone: None => 16.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609538

Title:
  Block edit screen has empy success (green) messages boxes

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  When I add an block (eg an image block) I get a green box at top of
  page but no message in it.

  When I add an image and then save and then reload page and then delete
  the block I get the green box again but still no message in it

  It looks like the 'message' part of the ajax response is not set

  Need to get the message set so it can appear

  It looks like it's a problem in 15.10+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609538/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1527031] A change has been merged

2016-08-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/6784
Committed: 
https://git.mahara.org/mahara/mahara/commit/2f925bdcfe3e68d8e4a63ed9862d45fe09d2f7c7
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 2f925bdcfe3e68d8e4a63ed9862d45fe09d2f7c7
Author: Aaron Wells 
Date:   Thu Dec 17 16:05:15 2015 +1300

Bug 1527031: Adjusting the view_search() for finding editable views

Improving speed of sql query by using 'EXISTS' to check against group
views

behatnotneeded

Change-Id: I0546092c5715a582ad6079f875aeac54a9dd0255
Signed-off-by: Robert Lyon 
(cherry picked from commit f53afd689e79bc0efb6ccc73e29b0e390a743512)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1527031

Title:
  Performance improvement for view_search() when finding copyable views

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Adjusting the sql from using IN() to use EXISTS()

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1527031/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1527031] Re: Performance improvement for view_search() when finding copyable views

2016-08-03 Thread Robert Lyon 
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1527031

Title:
  Performance improvement for view_search() when finding copyable views

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Adjusting the sql from using IN() to use EXISTS()

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1527031/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1269411] Re: Feature Request: Group artefact permissions management tool

2016-08-03 Thread Gordon McLeod 
Hello Kristina,

Sadly I've neither funds, nor time (chronic shortage) to develop this. Would it 
help if we argued that it's a bug rather than just a feature request :) - 
justification logical practice case might be 
Step 1) Develop template pages you want students to use as basis for an 
exercise 
Step 2) Add those resources to a group (or develop them in the group)
Step 3) Add students to group
Step 4) Make group editable by students

Expected Result) Students can edit the template resources
Actual Result) Students can't edit resources because they only have view 
permission on things created before group permissions were changed

Workaround) Admin goes through the tedious job of updating permissions for 
every individual artefact (assuming they know how to find that hidden setting).
Better Solution) Changing group permissions gives a prompt "do you want to 
apply this change to all existing group artefacts?  Yes/No" - if yes then 
updates existing editing rights to all group/page artefacts.

Regards, Gordon.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1269411

Title:
  Feature Request: Group artefact permissions management tool

Status in Mahara:
  Confirmed

Bug description:
  As described in the comments below, there are situations when it would
  be useful for a group admin to be able to change the permissions for
  all artefacts in their group, all at once. (Sort of like doing "chmod
  -R".) Currently, permissions on artefacts have to be edited
  individually, which can pose problems if the "Create and edit pages"
  permission dropdown is changed after a group has already been around
  for a while.

  ORIGINAL DESCRIPTION:

  Hi,
  As everyone assigned as a group admin on Mahara gets notifications when 
people request group membership we've tried switching staff to the tutor role 
in course groups, with the permission set 'everyone except ordinary members can 
edit'
  The staff are seeing the edit buttons, but when they click on artefacts to 
edit they are unable to make changes - eg to amend an existing text box. The 
text box opens but displays oddly and says 'the text you have selected is not 
editable' (see screenshot attachment). (Mahara version 1.63, LAMP environment).

  Thanks, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1269411/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1608299] Re: Manage and Delete buttons are aligned (manage button is on top of delete button)

2016-08-03 Thread Kristina Hoeppner 
Hi Pat,

Is there a way of dealing with that? I thought this is due to the space
available in the columns when we shrink the screen. This may come up
more pronounced on the new Admin -> Groups -> Administer groups screen
where we have four buttons.

Cheers
Kristina


** Changed in: mahara
   Status: New => Incomplete

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1608299

Title:
  Manage and Delete buttons are aligned  (manage button is on top of
  delete button)

Status in Mahara:
  Incomplete

Bug description:
  Mahara:16.10
  Browser: Safari 9
  OS: X El Capitan

  Test step: 
  From Admin >Groups> Administer Group
  Manage and Delete buttons are displayed on the right side of the screen

  Result: Manage and Delete buttons are aligned where manage button is
  on top of delete button.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1608299/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1269411] Re: Feature Request: Group artefact permissions management tool

2016-08-03 Thread Kristina Hoeppner 
Hello Gordon,

We haven't made any progress on this. It's a wishlist item / feature
enhancement. If you want to tackle this or have funding to tackle it, it
would be bumped higher.

Cheers
Kristina

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1269411

Title:
  Feature Request: Group artefact permissions management tool

Status in Mahara:
  Confirmed

Bug description:
  As described in the comments below, there are situations when it would
  be useful for a group admin to be able to change the permissions for
  all artefacts in their group, all at once. (Sort of like doing "chmod
  -R".) Currently, permissions on artefacts have to be edited
  individually, which can pose problems if the "Create and edit pages"
  permission dropdown is changed after a group has already been around
  for a while.

  ORIGINAL DESCRIPTION:

  Hi,
  As everyone assigned as a group admin on Mahara gets notifications when 
people request group membership we've tried switching staff to the tutor role 
in course groups, with the permission set 'everyone except ordinary members can 
edit'
  The staff are seeing the edit buttons, but when they click on artefacts to 
edit they are unable to make changes - eg to amend an existing text box. The 
text box opens but displays oddly and says 'the text you have selected is not 
editable' (see screenshot attachment). (Mahara version 1.63, LAMP environment).

  Thanks, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1269411/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1269411] Re: Feature Request: Group artefact permissions management tool

2016-08-03 Thread Gordon McLeod 
Hi,
Any progress on this issue being resolved?
I've just had to fix this on a Mahara 16.04.3 site as a member of staff created 
a group with admin-only rights and added some template pages for students to 
collaboratively edit - but when I updated the group to allow students to edit 
content the text boxes were still locked to admin only. Just as well I knew 
there was a workaround!
Regards, Gordon.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1269411

Title:
  Feature Request: Group artefact permissions management tool

Status in Mahara:
  Confirmed

Bug description:
  As described in the comments below, there are situations when it would
  be useful for a group admin to be able to change the permissions for
  all artefacts in their group, all at once. (Sort of like doing "chmod
  -R".) Currently, permissions on artefacts have to be edited
  individually, which can pose problems if the "Create and edit pages"
  permission dropdown is changed after a group has already been around
  for a while.

  ORIGINAL DESCRIPTION:

  Hi,
  As everyone assigned as a group admin on Mahara gets notifications when 
people request group membership we've tried switching staff to the tutor role 
in course groups, with the permission set 'everyone except ordinary members can 
edit'
  The staff are seeing the edit buttons, but when they click on artefacts to 
edit they are unable to make changes - eg to amend an existing text box. The 
text box opens but displays oddly and says 'the text you have selected is not 
editable' (see screenshot attachment). (Mahara version 1.63, LAMP environment).

  Thanks, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1269411/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1603294] Re: Licenses: Once you've selected a license, you can't go back to "None"

2016-08-03 Thread Kristina Hoeppner 
Hi Aaron,

I did have "Require license info" set to "Yes". Since now the "All
rights reserved" appears in the list alphabetically, I am expecting to
be able to select it. In the past that was not the case because it was
"None selected". Maybe the easiest would be to make "Copyright" a
regular license and still keep the "None selected" as empty placeholder
so as not to assume too much in the way of which license had been
chosen.

Cheers
Kristina

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603294

Title:
  Licenses: Once you've selected a license, you can't go back to "None"

Status in Mahara:
  In Progress

Bug description:
  While testing out Bug 1279526, I noticed that you can't change an
  uploaded file from a particular license to "No License". This may have
  been by design, with the idea that "No License" was a temporary thing
  until you pick a license. But with Bug 1279526 we're changing the
  wording of "No License" to make it clear that if you're not choosing a
  particular license, then the default copyright rules apply, so it
  becomes more necessary to be able to switch to that.

  To replicate:

  1. Go to "Administration -> Configure Site -> General Settings", and
  enable "License metadata"

  2. Go to "Content -> Files" and upload a file.

  3. Once the file is uploaded, click the pencil "edit" button to open
  its editing form. It should be at "No license" or the equivalent.
  Change it to "Creative Commons Attribution 4.0"

  4. Click "Save changes"

  5. Now click the pencil "edit" button again. Change the License back
  to "No license" or the equivalent.

  6. Again click "Save changes"

  7. Again click the pencil "edit" button.

  Expected result: You see "No license" or the equivalent as the license
  selection.

  Actual result: You see "Creative Commons Attribution 4.0" as the
  license selection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603294/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1323920] Re: Eliminate Mochikit

2016-08-03 Thread Kristina Hoeppner 
** Changed in: mahara
Milestone: None => 16.10.0

** Changed in: mahara
   Status: In Progress => Fix Committed

** Summary changed:

- Eliminate Mochikit
+ Eliminate Mochikit from mahara.js

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1323920

Title:
  Eliminate Mochikit from mahara.js

Status in Mahara:
  Fix Committed

Bug description:
  Mahara currently includes MochiKit and JQuery. Annoyingly, they both
  use the $() function quite a bit, and this inevitably causes us
  problems.

  Mochkit is old, and everything it does can also be done by jQuery, so
  we should try to refactor it away to save us future development
  headaches.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1323920/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, update_url() in lib/activity.php

2016-08-03 Thread Kristina Hoeppner 
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, update_url() in lib/activity.php

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp