[Mahara-contributors] [Bug 1594642] A change has been merged

2016-08-30 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/6886
Committed: 
https://git.mahara.org/mahara/mahara/commit/5455e881e84543c02da50571ef57c1029fa5a691
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 5455e881e84543c02da50571ef57c1029fa5a691
Author: Robert Lyon 
Date:   Tue Jun 21 14:14:44 2016 +1200

Bug 1594642: Problem where global $sessionpath not set

When I tried closing my site I got DirectoryIterator error

behatnotneeded - the patch 6609 will test this

Change-Id: I35024f8e6a558ee9d009e7c2754a0026e8042b2f
Signed-off-by: Robert Lyon 
(cherry picked from commit 4a4ba6944c94d6dac448460b3a07c8d5f697ab63)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594642

Title:
  missing sessionpath

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  On latest master: commit 522312544d6a7e44ce83b37394db817df3c7d070

  I get this error when I try and close the site

  [WAR] 2c (lib/errors.php:508) An exception was thrown of class 
RuntimeException.
  THIS IS BAD and should be changed to something extending MaharaException,
  unless the exception is from a third party library.
  Original trace follows
  [WAR] 2c (auth/session.php:552) Directory name must not be empty.
  Call stack (most recent first):

  RecursiveDirectoryIterator->__construct("") at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/session.php:552
  remove_all_sessions() at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:106
  close_site_submit(object(Pieform), array(size 3)) at Unknown:0
  call_user_func_array("close_site_submit", array(size 2)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:540
  Pieform->__construct(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:161
  Pieform::process(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/mahara.php:4494
  pieform(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:61

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1594642/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1594642] Re: missing sessionpath

2016-08-30 Thread Robert Lyon 
** Changed in: mahara/15.04
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594642

Title:
  missing sessionpath

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  On latest master: commit 522312544d6a7e44ce83b37394db817df3c7d070

  I get this error when I try and close the site

  [WAR] 2c (lib/errors.php:508) An exception was thrown of class 
RuntimeException.
  THIS IS BAD and should be changed to something extending MaharaException,
  unless the exception is from a third party library.
  Original trace follows
  [WAR] 2c (auth/session.php:552) Directory name must not be empty.
  Call stack (most recent first):

  RecursiveDirectoryIterator->__construct("") at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/session.php:552
  remove_all_sessions() at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:106
  close_site_submit(object(Pieform), array(size 3)) at Unknown:0
  call_user_func_array("close_site_submit", array(size 2)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:540
  Pieform->__construct(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:161
  Pieform::process(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/mahara.php:4494
  pieform(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:61

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1594642/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1575512] Re: Behat tests are failing due to not waiting for Javascript to finish

2016-08-30 Thread Son Nguyen 
** Changed in: mahara
 Assignee: (unassigned) => Son Nguyen (ngson2000)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1575512

Title:
  Behat tests are failing due to not waiting for Javascript to finish

Status in Mahara:
  In Progress

Bug description:
  We're seeing an annoying number of Behat tests that are failing due to
  a race condition between Behat and the Javascript in the browser.
  Here's an example: http://test.mahara.org/job/mahara-
  gerrit/5558/console

  In that case, the test is failing in this part:

  1. I press "Create folder"
  2. And I follow "Folder1"

  The failure happens because Behat can't find a link named "Follow1"
  when it tries to carry out that step. The way it *should* work, is
  basically like this:

  1. Behat step: I press "Create folder"
  2. Behat web driver locates and presses the "Create folder" button.
  3. The button press triggers a Pieform javascript method, which fires off an 
Ajax request to submit the form for creating a new folder.
  4. The Ajax request is handled by a PHP script, which creates the artefact 
and sends back a success response, including updated HTML for what the file 
area should look like now.
  5. Pieform Javascript receives the response from the Ajax script, and swaps 
the new HTML in place of the old HTML. The new HTML contains the link to the 
new folder.
  6. Behat step: I follow "Folder1"
  7. Behat web driver locates and clicks the link with text "Folder1".

  The race condition seems to happen because when you do the "I press"
  step (defined in \Behat\MinkExtension\Context\MinkContext) waits for
  the conclusion of any HTTP requests caused by the button press, but it
  doesn't wait for the Pieform callback to finish.

  The quick workaround for these is to add a "And I wait "1" seconds"
  step on affected tests. But it would be better to get a systemic fix
  to it. I think maybe the best thing to do, would be to change all the
  underlying "find" methods into spin functions, which, if they don't
  find the element, will wait up to 5 seconds to find it. Behat's
  inheritance structure for steps may make that tricky to do, though.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1575512/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1618317] Re: JS error when click 'Edit image' in TinyMCE editor

2016-08-30 Thread Son Nguyen 
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1618317

Title:
  JS error when click 'Edit image' in TinyMCE editor

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  New

Bug description:
  Version: master(16.10)

  I got the following javascript error when edit an external image link
  via TinyMCE

  plugin.js?v=9174:37 Uncaught TypeError: Cannot read property '0' of
  null

  Steps

  1. Login as an user
  2. In the Prodfile/Introduction, click 'Insert/edit image' button in TinyMCE 
editor
  3. Add a link to an image: 
https://mahara.org/theme/mahara-org/static/images/site-logo.png
  4. Click Submit
  5. Select the image
  6. Click 'Insert/edit image' button

  Expected result: you should see the pop-up 'Insert or select an image'

  Actual
   - you see the above error in browser console
   - No pop-up appears
   - The browser scroll bar disappears

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1618317/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1618317] A patch has been submitted for review

2016-08-30 Thread Mahara Bot 
Patch for "master" branch: https://reviews.mahara.org/6905

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1618317

Title:
  JS error when click 'Edit image' in TinyMCE editor

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  New

Bug description:
  Version: master(16.10)

  I got the following javascript error when edit an external image link
  via TinyMCE

  plugin.js?v=9174:37 Uncaught TypeError: Cannot read property '0' of
  null

  Steps

  1. Login as an user
  2. In the Prodfile/Introduction, click 'Insert/edit image' button in TinyMCE 
editor
  3. Add a link to an image: 
https://mahara.org/theme/mahara-org/static/images/site-logo.png
  4. Click Submit
  5. Select the image
  6. Click 'Insert/edit image' button

  Expected result: you should see the pop-up 'Insert or select an image'

  Actual
   - you see the above error in browser console
   - No pop-up appears
   - The browser scroll bar disappears

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1618317/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1618317] Re: JS error when click 'Edit image' in TinyMCE editor

2016-08-30 Thread Son Nguyen 
This bug also happens in 16.04

** Changed in: mahara
Milestone: None => 16.10.0

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Changed in: mahara/16.04
Milestone: None => 16.04.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1618317

Title:
  JS error when click 'Edit image' in TinyMCE editor

Status in Mahara:
  Confirmed
Status in Mahara 16.04 series:
  New

Bug description:
  Version: master(16.10)

  I got the following javascript error when edit an external image link
  via TinyMCE

  plugin.js?v=9174:37 Uncaught TypeError: Cannot read property '0' of
  null

  Steps

  1. Login as an user
  2. In the Prodfile/Introduction, click 'Insert/edit image' button in TinyMCE 
editor
  3. Add a link to an image: 
https://mahara.org/theme/mahara-org/static/images/site-logo.png
  4. Click Submit
  5. Select the image
  6. Click 'Insert/edit image' button

  Expected result: you should see the pop-up 'Insert or select an image'

  Actual
   - you see the above error in browser console
   - No pop-up appears
   - The browser scroll bar disappears

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1618317/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp