[Mahara-contributors] [Bug 1663436] Re: Configurable theme logo incorrect

[Liam]

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1663436

Title:
  Configurable theme logo incorrect

Status in Mahara:
  In Progress

Bug description:
  The logo used on the configurable theme is not up to date.

  Since the colours can be changed by the users, it would be good if the
  logo could change between and dark and light version depending on the
  background colour

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1663436/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1663436] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7454

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1663436

Title:
  Configurable theme logo incorrect

Status in Mahara:
  In Progress

Bug description:
  The logo used on the configurable theme is not up to date.

  Since the colours can be changed by the users, it would be good if the
  logo could change between and dark and light version depending on the
  background colour

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1663436/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1660808] Re: Remove MochiKit Libraries from Mahara

[Kristina Hoeppner]

** Changed in: mahara
Milestone: None => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1660808

Title:
  Remove MochiKit Libraries from Mahara

Status in Mahara:
  In Progress

Bug description:
  Remove MochiKit libraries, references to it plus small fixes in places
  where still mochikit code is used

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1660808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1661139] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7437
Committed: 
https://git.mahara.org/mahara/mahara/commit/d2987e633098d9b16442453f0b668264095d46cb
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit d2987e633098d9b16442453f0b668264095d46cb
Author: Cecilia Vela Gurovic 
Date:   Tue Feb 7 12:01:03 2017 +1300

Bug 1661139: add delete option in view screen

option to delete page is enable for:
- Normal user in its own pages
- For group pages
To admin user
To other roles if they have Create and Edit permission
in group setting and page is not locked
- For institution, to site admin

behatnotneeded

Change-Id: I424c8a103e55d46178d779b77ebfb79db2d504f3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1661139

Title:
  Page screen should show "..." button with option to delete page

Status in Mahara:
  Fix Committed

Bug description:
  In the screen for pages we own, we should see the "..." button similar
  to the one we see for pages shared with us.

  In this button we should only have the option to delete the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1661139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1661139] Re: Page screen should show "..." button with option to delete page

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1661139

Title:
  Page screen should show "..." button with option to delete page

Status in Mahara:
  Fix Committed

Bug description:
  In the screen for pages we own, we should see the "..." button similar
  to the one we see for pages shared with us.

  In this button we should only have the option to delete the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1661139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1664061] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7452

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1664061

Title:
  Dropzone success messages out of sync

Status in Mahara:
  In Progress

Bug description:
  This occurs when one adds files via the 'files' browse field then adds
  files via drag/drop

  The upload file could gets out of sync and blue uploading messages are
  not replaced by the green success ones

  This was fixed in the past for 3x version of DropZone but the way it
  was fixed is not compatible with the 4x version as the 'selectedfiles'
  hook is no longer present.

  Will fix again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1664061/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1664061] [NEW] Dropzone success messages out of sync

[Robert Lyon]

Public bug reported:

This occurs when one adds files via the 'files' browse field then adds
files via drag/drop

The upload file could gets out of sync and blue uploading messages are
not replaced by the green success ones

This was fixed in the past for 3x version of DropZone but the way it was
fixed is not compatible with the 4x version as the 'selectedfiles' hook
is no longer present.

Will fix again

** Affects: mahara
 Importance: Medium
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
Milestone: None => 17.04.0

** Changed in: mahara
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1664061

Title:
  Dropzone success messages out of sync

Status in Mahara:
  In Progress

Bug description:
  This occurs when one adds files via the 'files' browse field then adds
  files via drag/drop

  The upload file could gets out of sync and blue uploading messages are
  not replaced by the green success ones

  This was fixed in the past for 3x version of DropZone but the way it
  was fixed is not compatible with the 4x version as the 'selectedfiles'
  hook is no longer present.

  Will fix again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1664061/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1663436] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7451

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1663436

Title:
  Configurable theme logo incorrect

Status in Mahara:
  Confirmed

Bug description:
  The logo used on the configurable theme is not up to date.

  Since the colours can be changed by the users, it would be good if the
  logo could change between and dark and light version depending on the
  background colour

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1663436/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1653030] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7450
Committed: 
https://git.mahara.org/mahara/mahara/commit/dac4903fe20e9d52a282ec14785b0f86346b7bc4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit dac4903fe20e9d52a282ec14785b0f86346b7bc4
Author: Robert Lyon 
Date:   Mon Feb 13 07:33:58 2017 +1300

Bug 1653030: Using safe require auth saml

To make sure all dependent classes are included as well

behatnotneeded

Change-Id: Ib93776b163193849938619cbe9bbb7e073df7a02
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1653030

Title:
  PluginAuthSaml error after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  When I upgrade 15.10, 16.04 or 16.10 to 17.04dev I get the following
  warning:

  [WAR] f9 (lib/errors.php:536) [Error]: Class 'PluginAuthSaml' not found
  Call stack (most recent first):

  exception(object(Error)) at Unknown:0

  That's just on a plain fresh database.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1653030/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1653030] A patch has been submitted for review

[Mahara Bot]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7450

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1653030

Title:
  PluginAuthSaml error after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  When I upgrade 15.10, 16.04 or 16.10 to 17.04dev I get the following
  warning:

  [WAR] f9 (lib/errors.php:536) [Error]: Class 'PluginAuthSaml' not found
  Call stack (most recent first):

  exception(object(Error)) at Unknown:0

  That's just on a plain fresh database.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1653030/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1653030] Re: PluginAuthSaml error after upgrade

[Robert Lyon]

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1653030

Title:
  PluginAuthSaml error after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  When I upgrade 15.10, 16.04 or 16.10 to 17.04dev I get the following
  warning:

  [WAR] f9 (lib/errors.php:536) [Error]: Class 'PluginAuthSaml' not found
  Call stack (most recent first):

  exception(object(Error)) at Unknown:0

  That's just on a plain fresh database.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1653030/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1653030] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7449

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1653030

Title:
  PluginAuthSaml error after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  When I upgrade 15.10, 16.04 or 16.10 to 17.04dev I get the following
  warning:

  [WAR] f9 (lib/errors.php:536) [Error]: Class 'PluginAuthSaml' not found
  Call stack (most recent first):

  exception(object(Error)) at Unknown:0

  That's just on a plain fresh database.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1653030/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1653030] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7449
Committed: 
https://git.mahara.org/mahara/mahara/commit/bc353c69b02e4f6543e974598191b24d8d91f68e
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit bc353c69b02e4f6543e974598191b24d8d91f68e
Author: Robert Lyon 
Date:   Mon Feb 13 07:33:58 2017 +1300

Bug 1653030: Using safe require auth saml

To make sure all dependent classes are included as well

behatnotneeded

Change-Id: Ib93776b163193849938619cbe9bbb7e073df7a02
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1653030

Title:
  PluginAuthSaml error after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  When I upgrade 15.10, 16.04 or 16.10 to 17.04dev I get the following
  warning:

  [WAR] f9 (lib/errors.php:536) [Error]: Class 'PluginAuthSaml' not found
  Call stack (most recent first):

  exception(object(Error)) at Unknown:0

  That's just on a plain fresh database.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1653030/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1653030] Re: PluginAuthSaml error after upgrade

[Robert Lyon]

** Also affects: mahara/16.10
   Importance: Undecided
   Status: New

** Also affects: mahara/17.04
   Importance: High
 Assignee: Cecilia Vela Gurovic (ceciliavg)
   Status: Fix Committed

** Changed in: mahara/16.10
   Status: New => In Progress

** Changed in: mahara/16.10
   Importance: Undecided => High

** Changed in: mahara/16.10
Milestone: None => 16.10.3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1653030

Title:
  PluginAuthSaml error after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  When I upgrade 15.10, 16.04 or 16.10 to 17.04dev I get the following
  warning:

  [WAR] f9 (lib/errors.php:536) [Error]: Class 'PluginAuthSaml' not found
  Call stack (most recent first):

  exception(object(Error)) at Unknown:0

  That's just on a plain fresh database.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1653030/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1655456] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7428
Committed: 
https://git.mahara.org/mahara/mahara/commit/1a1d193d9542a0dee37ff2ef4db384c4126f2fb8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 1a1d193d9542a0dee37ff2ef4db384c4126f2fb8
Author: Cecilia Vela Gurovic 
Date:   Tue Jan 24 11:46:38 2017 +1300

Bug 1655456: fix shared collection not displaying

Collection shared to a group was not displaying
in group page and shared with me page
after first page of collection was deleted.
Fixed by resetting the order when deleting a view.

behatnotneeded

Change-Id: I096114ecf50b7a3af6d1393b387073676a984006

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1655456

Title:
  Sharing collection with a group not showing on group homepage list

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Sometimes when a user shares a collection with a group they belong to
  that collection doesn't show in the list for 'Collections shared with
  this group' in the Group pages block.

  The reason for this is because the sql for the list only fetches the
  collection_view page with displayorder = 0

  This is so it fetches the first page so can get the url for collection
  and also limit the results to once per collection.

  The problem occurs when one deletes the first page from a collection
  via the edit collections views page.

  It doesn't reset the collection views display order and so there is no
  displayorder = 0

  A workaround for this could be to change the line in lib/view.php for
  get_sharedcollections_data()

  from
  AND (cv.displayorder = 0 OR cv.displayorder IS NULL)
  to
  AND (cv.displayorder = (SELECT MIN(displayorder) FROM 
collection_view WHERE collection = c.id) OR cv.displayorder IS NULL)

  where it fetches the minimum display order value

  Or fix up the deletion of views from collection so that the
  displayorder is reset correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1655456] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7427
Committed: 
https://git.mahara.org/mahara/mahara/commit/08408a7be7655b39df530cda91207c01c4961fcb
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 08408a7be7655b39df530cda91207c01c4961fcb
Author: Cecilia Vela Gurovic 
Date:   Tue Jan 24 11:46:38 2017 +1300

Bug 1655456: fix shared collection not displaying

Collection shared to a group was not displaying
in group page and shared with me page
after first page of collection was deleted.
Fixed by resetting the order when deleting a view.

behatnotneeded

Change-Id: I096114ecf50b7a3af6d1393b387073676a984006

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1655456

Title:
  Sharing collection with a group not showing on group homepage list

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Sometimes when a user shares a collection with a group they belong to
  that collection doesn't show in the list for 'Collections shared with
  this group' in the Group pages block.

  The reason for this is because the sql for the list only fetches the
  collection_view page with displayorder = 0

  This is so it fetches the first page so can get the url for collection
  and also limit the results to once per collection.

  The problem occurs when one deletes the first page from a collection
  via the edit collections views page.

  It doesn't reset the collection views display order and so there is no
  displayorder = 0

  A workaround for this could be to change the line in lib/view.php for
  get_sharedcollections_data()

  from
  AND (cv.displayorder = 0 OR cv.displayorder IS NULL)
  to
  AND (cv.displayorder = (SELECT MIN(displayorder) FROM 
collection_view WHERE collection = c.id) OR cv.displayorder IS NULL)

  where it fetches the minimum display order value

  Or fix up the deletion of views from collection so that the
  displayorder is reset correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1655456] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7426
Committed: 
https://git.mahara.org/mahara/mahara/commit/d6b12ca0910e72944ef499870b390746ff5cba62
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit d6b12ca0910e72944ef499870b390746ff5cba62
Author: Cecilia Vela Gurovic 
Date:   Tue Jan 24 11:46:38 2017 +1300

Bug 1655456: fix shared collection not displaying

Collection shared to a group was not displaying
in group page and shared with me page
after first page of collection was deleted.
Fixed by resetting the order when deleting a view.

behatnotneeded

Change-Id: I096114ecf50b7a3af6d1393b387073676a984006

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1655456

Title:
  Sharing collection with a group not showing on group homepage list

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Sometimes when a user shares a collection with a group they belong to
  that collection doesn't show in the list for 'Collections shared with
  this group' in the Group pages block.

  The reason for this is because the sql for the list only fetches the
  collection_view page with displayorder = 0

  This is so it fetches the first page so can get the url for collection
  and also limit the results to once per collection.

  The problem occurs when one deletes the first page from a collection
  via the edit collections views page.

  It doesn't reset the collection views display order and so there is no
  displayorder = 0

  A workaround for this could be to change the line in lib/view.php for
  get_sharedcollections_data()

  from
  AND (cv.displayorder = 0 OR cv.displayorder IS NULL)
  to
  AND (cv.displayorder = (SELECT MIN(displayorder) FROM 
collection_view WHERE collection = c.id) OR cv.displayorder IS NULL)

  where it fetches the minimum display order value

  Or fix up the deletion of views from collection so that the
  displayorder is reset correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp