[Mahara-contributors] [Bug 1711998] Re: make behat test data uniform so we know what to expect

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
Milestone: None => 17.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711998

Title:
  make behat test data uniform so we know what to expect

Status in Mahara:
  Fix Committed

Bug description:
  In addition to changing all the domains to example.org so they will
  all be pointing to a reserved domain, look at standardising the other
  test data, e.g. user names, page names, groups...etc so that all tests
  are using the same data set and we can look at creating a generic set-
  up step that will work for most tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711998/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711998] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7942
Committed: 
https://git.mahara.org/mahara/mahara/commit/d246f592add7c91de75c02177bca211c84ea9bf2
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit d246f592add7c91de75c02177bca211c84ea9bf2
Author: Rebecca Blundell 
Date:   Wed Aug 23 16:20:33 2017 +1200

Bug 1711998 - Standardise test data

Done:
-standardised data for background created
users
groups
institutions
pages
collections

Not done:
-looked at user roles

Change-Id: Ibbdd62dda105192381e0785ed7b9d1f32604bbd3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711998

Title:
  make behat test data uniform so we know what to expect

Status in Mahara:
  Fix Committed

Bug description:
  In addition to changing all the domains to example.org so they will
  all be pointing to a reserved domain, look at standardising the other
  test data, e.g. user names, page names, groups...etc so that all tests
  are using the same data set and we can look at creating a generic set-
  up step that will work for most tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711998/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1718562] Re: New 'handle event' events break upgrade

2017-09-20 Thread Robert Lyon 
To Test: Try upgrading from 15.04 site to 17.10

Without patch - will fail as some db structure is missing

With patch - should upgrade fine

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718562

Title:
  New 'handle event' events break upgrade

Status in Mahara:
  In Progress

Bug description:
  We need to wrap some bits in  if(!defined('INSTALLER')) {  ... }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718562/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1718562] [NEW] New 'handle event' events break upgrade

2017-09-20 Thread Robert Lyon 
Public bug reported:

We need to wrap some bits in  if(!defined('INSTALLER')) {  ... }

** Affects: mahara
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Changed in: mahara
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718562

Title:
  New 'handle event' events break upgrade

Status in Mahara:
  In Progress

Bug description:
  We need to wrap some bits in  if(!defined('INSTALLER')) {  ... }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718562/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1718562] A patch has been submitted for review

2017-09-20 Thread Mahara Bot 
Patch for "master" branch: https://reviews.mahara.org/8044

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718562

Title:
  New 'handle event' events break upgrade

Status in Mahara:
  In Progress

Bug description:
  We need to wrap some bits in  if(!defined('INSTALLER')) {  ... }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718562/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1560739] Re: Can't build CSS if you have npm gulp-bless version 3.1.0

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
Milestone: 17.10.0 => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560739

Title:
  Can't build CSS if you have npm gulp-bless version 3.1.0

Status in Mahara:
  In Progress

Bug description:
  If you have the npm package "gulp-bless" at version 3.1.0 (which
  requires the "bless" package at 4.0.0), then Mahara's SASS compilation
  (make css) will error out.

  To replicate:

  1. Clone a new Mahara repository, or in an existing Mahara repo rename your 
"node_modules" directory to "node_modules.bak"
  2. Run "npm install" in this repo
  3. Run "make css"

  
  Expected result:
  Successfully builds the CSS, with this output.

  (master)aaronw@vegas:~/www/mahara$ make css
  npm install
  npm WARN package.json mahara-themes@1.0.0 No repository field.
  npm WARN package.json gulp-minify-css@1.2.4 No repository field.
  Building CSS...
  [13:21:16] Using gulpfile ~/www/mahara/gulpfile.js
  [13:21:16] Starting 'css'...
  Compiling CSS for htdocs/theme/custom
  Compiling CSS for htdocs/theme/default
  Compiling CSS for htdocs/theme/modern
  Compiling CSS for htdocs/theme/ocean
  Compiling CSS for htdocs/theme/primaryschool
  Compiling CSS for htdocs/theme/raw
  Compiling CSS for htdocs/theme/subthemestarter
  [13:21:21] Finished 'css' after 5.72 s
  Done!

  
  Actual result:
  Errors out with this output.

  (master)aaronw@vegas:~/www/mahara-test$ make css
  npm install
  npm WARN package.json mahara-themes@1.0.0 No repository field.
  npm WARN package.json gulp-minify-css@1.2.4 No repository field.
  Building CSS...
  [13:22:42] Using gulpfile ~/www/mahara-test/gulpfile.js
  [13:22:42] Starting 'css'...
  Compiling CSS for htdocs/theme/custom
  Compiling CSS for htdocs/theme/default
  Compiling CSS for htdocs/theme/modern
  Compiling CSS for htdocs/theme/ocean
  Compiling CSS for htdocs/theme/primaryschool
  Compiling CSS for htdocs/theme/raw
  Compiling CSS for htdocs/theme/subthemestarter

  events.js:72
  throw er; // Unhandled 'error' event
^
  TypeError: Cannot call method 'reduce' of undefined
  at countRules 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:26:18)
  at count 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:44:14)
  at chunks$ 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:52:46)
  at tryCatch 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:72:40)
  at GeneratorFunctionPrototype.invoke [as _invoke] 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:334:22)
  at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:105:21)
  at chunk 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:98:113)
  at Object.chunk 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/index.js:34:33)
  at Transform._transform 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/index.js:33:36)
  at Transform._read 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
  npm WARN package.json mahara-themes@1.0.0 No repository field.
  npm WARN package.json gulp-minify-css@1.2.4 No repository field.
  [13:22:46] Using gulpfile ~/www/mahara-test/gulpfile.js
  [13:22:46] Starting 'css'...
  Compiling CSS for htdocs/theme/custom
  Compiling CSS for htdocs/theme/default
  Compiling CSS for htdocs/theme/modern
  Compiling CSS for htdocs/theme/ocean
  Compiling CSS for htdocs/theme/primaryschool
  Compiling CSS for htdocs/theme/raw
  Compiling CSS for htdocs/theme/subthemestarter

  events.js:72
  throw er; // Unhandled 'error' event
^
  TypeError: Cannot call method 'reduce' of undefined
  at countRules 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:26:18)
  at count 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:44:14)
  at chunks$ 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:52:46)
  at tryCatch 
(/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:72:40)
  at GeneratorFunctionPrototype.invoke [as _invoke]

[Mahara-contributors] [Bug 1572825] Re: voki externalmedia embed code changed

2017-09-20 Thread Robert Lyon 
** Changed in: mahara/17.10
Milestone: 17.10.0 => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1572825

Title:
  voki externalmedia embed code changed

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  A recent support post on the Mahara forums has highlighted that the
  externalmedia flags the voki URL invalid:

  
https://mahara.org/interaction/forum/topic.php?id=4007=0=10#post30536

  It appears that the links have changed and will require an update in
  Mahara.

  Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1698251] Re: Improving gulp packages

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
Milestone: 17.10.0 => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1698251

Title:
  Improving gulp packages

Status in Mahara:
  In Progress

Bug description:
  Update NPM packages in package.json, it was last updated in
  https://bugs.launchpad.net/mahara/+bug/1617143

  Investigate whether we still need blesscss, the reason that we added
  blesscss is because IE9 would only read up to certain number of
  selectors. Since we are officially support IE11+, we could possibly
  remove blesscss. If removal is sensible we can close
  https://bugs.launchpad.net/mahara/+bug/1560739 (?)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1698251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1692385] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7775
Committed: 
https://git.mahara.org/mahara/mahara/commit/ebd928b11e79c0054133b284c2a49bb8a86d3a2f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit ebd928b11e79c0054133b284c2a49bb8a86d3a2f
Author: Robert Lyon 
Date:   Tue May 23 12:55:41 2017 +1200

Bug 1692385: Adjusting the event_log table

Add 5 new new columns to event_log table make searching over the
data easier and also record the id of any parent/related info as well

Eg, if one deletes an image block from a page we now record:
id - the event id
resourceid - the block id
resourcetype - the blocktype, eg image
parentresourceid - the id of the parent, eg view id
parentresourcetype - the type of parent, eg 'view'

Because we would not be able to find related view info from just the
block id anymore.

Also added the ability to index and search over event information in
elasticsearch search type event_log

Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692385

Title:
  Adjust the event_log table to facilitate logging of more chronological
  information

Status in Mahara:
  Fix Committed

Bug description:
  Currently for a number of things we only record the creation time
  (ctime) and last time they were interacted with (mtime). For views we
  also record last accessed time (atime).

  It would be better if we recorded the changes over time for things.

  So will add some _logging tables to record this info

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1697248] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8030
Committed: 
https://git.mahara.org/mahara/mahara/commit/9a4834d0cd5377ad7e03dbbda2cd30eca477243d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 9a4834d0cd5377ad7e03dbbda2cd30eca477243d
Author: Kristina D.C. Hoeppner 
Date:   Tue Sep 19 17:10:07 2017 +1000

Bug 1697248: Lang string updates

for the reporting section

Change-Id: I40c5e1038827a04666db98fbdad36a1915865d1a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1697248

Title:
  Change navigation through reports / statistics

Status in Mahara:
  Fix Committed

Bug description:
  In bug #1691910 the site and institution statistics pages were
  combined to be shown in one area. This wishlist item extends that
  functionality to introduce a new reports navigation bar in order to
  allow selecting the type of report that is to be displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1697248/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1697248] Re: Change navigation through reports / statistics

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1697248

Title:
  Change navigation through reports / statistics

Status in Mahara:
  Fix Committed

Bug description:
  In bug #1691910 the site and institution statistics pages were
  combined to be shown in one area. This wishlist item extends that
  functionality to introduce a new reports navigation bar in order to
  allow selecting the type of report that is to be displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1697248/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1710710] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7926
Committed: 
https://git.mahara.org/mahara/mahara/commit/408dcdfb45aa39873a3611f1b4f8604b277544f9
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 408dcdfb45aa39873a3611f1b4f8604b277544f9
Author: Robert Lyon 
Date:   Tue Aug 15 08:13:27 2017 +1200

Bug 1710710: Placement of public search box vs language selector

When we have $cfg->publicsearchallowed = true;
and are viewing the site when logged out and have langpacks installed
we get an overlap of the language selector and searc box.

When we don't have langpacks installed the search box doesn't align to
the right.

This patch tries to align things up correctly

behatnotneeded

Change-Id: I6f2175af0aa9e164f4c4302f4c1e7012423d1235
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1710710

Title:
  The public search box overlaps the language selector box

Status in Mahara:
  Fix Committed

Bug description:
  When you are logged out and have $cfg->publicsearchallowed = true; in
  your config and also have other langpacks installed you see the search
  box overlaps the language selector.

  Need to add some css to position the logged out search box for when
  langpacks exists and when they don't

  And not affect the logged in positioning of things

  see attachment

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1710710/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1710710] Re: The public search box overlaps the language selector box

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1710710

Title:
  The public search box overlaps the language selector box

Status in Mahara:
  Fix Committed

Bug description:
  When you are logged out and have $cfg->publicsearchallowed = true; in
  your config and also have other langpacks installed you see the search
  box overlaps the language selector.

  Need to add some css to position the logged out search box for when
  langpacks exists and when they don't

  And not affect the logged in positioning of things

  see attachment

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1710710/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1692385] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7939
Committed: 
https://git.mahara.org/mahara/mahara/commit/a3d904e16bb0dbf8621842dafdd0feb9c3c0f9b8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit a3d904e16bb0dbf8621842dafdd0feb9c3c0f9b8
Author: Robert Lyon 
Date:   Mon Aug 21 11:18:15 2017 +1200

Bug 1692385: Adjusting the handle event for 'updateviewaccess'

We want to record things like so:

resourceid = view_access.id
resourcetype = what type the view_access row is for, eg 'token',
'user', 'loggedin' etc
parentresourceid = the id if the view the access is for
parentresourcetype = 'view';
ownerid = the id of the owning resource, eg usr.id / group.id / institution.name
ownertype = what owns the resource, eg user / group / institution

Also this patch adjusts how we index things into elasticsearch

behatnotneeded

Change-Id: I079a42ded2fefaab64a6e49fc26e8aad303c9e8a
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692385

Title:
  Adjust the event_log table to facilitate logging of more chronological
  information

Status in Mahara:
  Fix Committed

Bug description:
  Currently for a number of things we only record the creation time
  (ctime) and last time they were interacted with (mtime). For views we
  also record last accessed time (atime).

  It would be better if we recorded the changes over time for things.

  So will add some _logging tables to record this info

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711958] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7938
Committed: 
https://git.mahara.org/mahara/mahara/commit/d73a4a9e6a35a369cbda31ab2e6ffedd2d2b2cd6
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit d73a4a9e6a35a369cbda31ab2e6ffedd2d2b2cd6
Author: Robert Lyon 
Date:   Mon Aug 21 09:34:46 2017 +1200

Bug 1711958: Allow update_record to return id of record updated

By supplying $primarykey and $returnpk parameters to the update_record
function

behatnotneeded

Change-Id: Ib2078384cf2d48e4cea1b08f804ea01dc8e9b1d4
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711958

Title:
  Allow the lib/dml update_record() function to return the id of the
  record updated

Status in Mahara:
  Fix Committed

Bug description:
  We do this for insert_record() and for ensure_record_exists() but not
  for update_record()

  Normally we pass in the primary key when updating a record so it's
  already known but some times we update a record via a non primary key
  column  and it would be nice to know the primary key of the row
  updated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1692385] Re: Adjust the event_log table to facilitate logging of more chronological information

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692385

Title:
  Adjust the event_log table to facilitate logging of more chronological
  information

Status in Mahara:
  Fix Committed

Bug description:
  Currently for a number of things we only record the creation time
  (ctime) and last time they were interacted with (mtime). For views we
  also record last accessed time (atime).

  It would be better if we recorded the changes over time for things.

  So will add some _logging tables to record this info

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711958] Re: Allow the lib/dml update_record() function to return the id of the record updated

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711958

Title:
  Allow the lib/dml update_record() function to return the id of the
  record updated

Status in Mahara:
  Fix Committed

Bug description:
  We do this for insert_record() and for ensure_record_exists() but not
  for update_record()

  Normally we pass in the primary key when updating a record so it's
  already known but some times we update a record via a non primary key
  column  and it would be nice to know the primary key of the row
  updated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1714100] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7959
Committed: 
https://git.mahara.org/mahara/mahara/commit/b186169809f984b25addef9b455bb6fe8fee8fe4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit b186169809f984b25addef9b455bb6fe8fee8fe4
Author: Robert Lyon 
Date:   Thu Aug 31 10:12:53 2017 +1200

Bug 1714100: Check the status of current elasticsearch index

Because the cluster can be giving a 'yellow' warning but the index
this particular site uses might be 'green' and therefore working as
expected

behatnotneeded

Change-Id: I9d38a4696cee777d4c20f368be917f22c3dde3d8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1714100

Title:
  When checking elasticsearch status we need to check on a specified
  index

Status in Mahara:
  In Progress

Bug description:
  As the elasticsearch server can have some indexes all fine (green) and
  some not fine (yellow)

  The check that we do via elasticsearch_server('shardallocation') needs
  to take into consideration which index we want to check

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1714100/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1697248] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7818
Committed: 
https://git.mahara.org/mahara/mahara/commit/8c08b88b0af1fcd0379757eebd328a00f6af1028
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 8c08b88b0af1fcd0379757eebd328a00f6af1028
Author: Robert Lyon 
Date:   Fri Jun 9 12:51:45 2017 +1200

Bug 1697248: Update report navigation and reports

Introduce a new navigation bar to allow going through the different
types of reports:

- Change the page title according to the selected report section and
report
- Decide which columns to display in a report
- Configure reports via the "Configure reports" button

Add existing reports into the new interface.

Create new and expand existing reports:

- User activity
- Page activity
- Collaboration

Sponsored by the AAIM project with funding from University of
Sussex and Dublin City University.

Change-Id: I1eb6920890af27c34c902fe22ff5ce3591b73cb0
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1697248

Title:
  Change navigation through reports / statistics

Status in Mahara:
  Fix Committed

Bug description:
  In bug #1691910 the site and institution statistics pages were
  combined to be shown in one area. This wishlist item extends that
  functionality to introduce a new reports navigation bar in order to
  allow selecting the type of report that is to be displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1697248/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1697248] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7896
Committed: 
https://git.mahara.org/mahara/mahara/commit/c3d9acba53e74453a6c4e412c7ecb9dd3d47cdbb
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit c3d9acba53e74453a6c4e412c7ecb9dd3d47cdbb
Author: Robert Lyon 
Date:   Wed Jul 26 12:25:35 2017 +1200

Bug 1697248: More updates for report navigation and reports

This patch will contain the fixes for:

- Navigation placement
- Collaboration report
- CSV's of reports
- Overview page for the graphs
- Making Institution selector a select2 field
- Moving all configs for reports into the modal and combine 3rd level
menu with submenu choices in select2 field
- Ignore non logged in users from user activity report
- Move more variables for reports into sticky (session) vars
- Allow results to be fetched from elasticsearch

Change-Id: I725b7615ac3cd6b1d9b6352bae9f6be0d5161e1b
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1697248

Title:
  Change navigation through reports / statistics

Status in Mahara:
  Fix Committed

Bug description:
  In bug #1691910 the site and institution statistics pages were
  combined to be shown in one area. This wishlist item extends that
  functionality to introduce a new reports navigation bar in order to
  allow selecting the type of report that is to be displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1697248/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1718538] A patch has been submitted for review

2017-09-20 Thread Mahara Bot 
Patch for "master" branch: https://reviews.mahara.org/8043

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718538

Title:
  Page edit screen 'settings' button has wrong title

Status in Mahara:
  In Progress

Bug description:
  It still says 'Edit layout' rather than 'Edit settings'

  I noticed this because a behat test had 'When I follow "Edit layout"'
  and I was surprised it worked as there was no edit layout button any
  more

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718538/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1718538] [NEW] Page edit screen 'settings' button has wrong title

2017-09-20 Thread Robert Lyon 
Public bug reported:

It still says 'Edit layout' rather than 'Edit settings'

I noticed this because a behat test had 'When I follow "Edit layout"'
and I was surprised it worked as there was no edit layout button any
more

** Affects: mahara
 Importance: Medium
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress

** Attachment added: "wrong-help-text.png"
   
https://bugs.launchpad.net/bugs/1718538/+attachment/4954018/+files/wrong-help-text.png

** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara
Milestone: None => 17.10.0

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718538

Title:
  Page edit screen 'settings' button has wrong title

Status in Mahara:
  In Progress

Bug description:
  It still says 'Edit layout' rather than 'Edit settings'

  I noticed this because a behat test had 'When I follow "Edit layout"'
  and I was surprised it worked as there was no edit layout button any
  more

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718538/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1717819] Re: Alter the minimum version to upgrade from

2017-09-20 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1717819

Title:
  Alter the minimum version to upgrade  from

Status in Mahara:
  Fix Committed

Bug description:
  We are meant to move up the minimum upgrade from version each time we
  do a release.

  But as the older versions are not compatible with PHP7 we should make
  our min upgrade from to be v15.04

  With a note saying if you need to upgrade from older version you will
  need to do:

  version 'X' -> 15.04 upgrade

  then

  do any upgrading of php / sql server

  then

  version 15.04 -> 'Y' upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1717819/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1717819] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8017
Committed: 
https://git.mahara.org/mahara/mahara/commit/a37471416b20d523236d3d91191797290708166c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit a37471416b20d523236d3d91191797290708166c
Author: Robert Lyon 
Date:   Fri Sep 15 10:14:13 2017 +1200

Bug 1717819: Change the min upgrade from to 15.04

behatnotneeded
Change-Id: Icae9cab6f9050982a061f3b31680a5bbd9c5b89a
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1717819

Title:
  Alter the minimum version to upgrade  from

Status in Mahara:
  Fix Committed

Bug description:
  We are meant to move up the minimum upgrade from version each time we
  do a release.

  But as the older versions are not compatible with PHP7 we should make
  our min upgrade from to be v15.04

  With a note saying if you need to upgrade from older version you will
  need to do:

  version 'X' -> 15.04 upgrade

  then

  do any upgrading of php / sql server

  then

  version 15.04 -> 'Y' upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1717819/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8041
Committed: 
https://git.mahara.org/mahara/mahara/commit/84b9c399688f9638a51c462ddfb4447eee91ce2d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 84b9c399688f9638a51c462ddfb4447eee91ce2d
Author: Robert Lyon 
Date:   Mon Sep 18 13:46:55 2017 +1200

Bug 1546769: Stop 'none' auth being allowed to work on production site

behatnotneeded

Change-Id: I80432042b06f00f0e84d0bdf2d7327233c4f2ba9
Signed-off-by: Robert Lyon 
(cherry picked from commit 3cc09ae5a9e8f9356946d2bc15164db148572692)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] Re: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions

2017-09-20 Thread Robert Lyon 
** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8040
Committed: 
https://git.mahara.org/mahara/mahara/commit/a1da6ea10b5f7eb33883b58bcc801922fc1ab8be
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit a1da6ea10b5f7eb33883b58bcc801922fc1ab8be
Author: Robert Lyon 
Date:   Mon Sep 18 13:46:55 2017 +1200

Bug 1546769: Stop 'none' auth being allowed to work on production site

behatnotneeded

Change-Id: I80432042b06f00f0e84d0bdf2d7327233c4f2ba9
Signed-off-by: Robert Lyon 
(cherry picked from commit 3cc09ae5a9e8f9356946d2bc15164db148572692)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8022
Committed: 
https://git.mahara.org/mahara/mahara/commit/cb2f9130a09ba83cc90b3070a59c82f85594b68a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit cb2f9130a09ba83cc90b3070a59c82f85594b68a
Author: Robert Lyon 
Date:   Mon Sep 18 13:46:55 2017 +1200

Bug 1546769: Stop 'none' auth being allowed to work on production site

behatnotneeded

Change-Id: I80432042b06f00f0e84d0bdf2d7327233c4f2ba9
Signed-off-by: Robert Lyon 
(cherry picked from commit 3cc09ae5a9e8f9356946d2bc15164db148572692)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A change has been merged

2017-09-20 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8023
Committed: 
https://git.mahara.org/mahara/mahara/commit/3cc09ae5a9e8f9356946d2bc15164db148572692
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 3cc09ae5a9e8f9356946d2bc15164db148572692
Author: Robert Lyon 
Date:   Mon Sep 18 13:46:55 2017 +1200

Bug 1546769: Stop 'none' auth being allowed to work on production site

behatnotneeded

Change-Id: I80432042b06f00f0e84d0bdf2d7327233c4f2ba9
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A patch has been submitted for review

2017-09-20 Thread Mahara Bot 
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/8041

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] Re: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions

2017-09-20 Thread Robert Lyon 
** Changed in: mahara/17.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A patch has been submitted for review

2017-09-20 Thread Mahara Bot 
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8040

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] A patch has been submitted for review

2017-09-20 Thread Mahara Bot 
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/8042

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1718480] [NEW] Allow modules to extend group menu items

2017-09-20 Thread Stacey Walker 
Public bug reported:

Similar to the interaction plugin types allow modules to add/edit/remove
items within group instance navigations.

This is a useful extension for adding contributed modules.

** Affects: mahara
 Importance: Undecided
 Assignee: Stacey Walker (stacey)
 Status: New

** Changed in: mahara
 Assignee: (unassigned) => Stacey Walker (stacey)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718480

Title:
  Allow modules to extend group menu items

Status in Mahara:
  New

Bug description:
  Similar to the interaction plugin types allow modules to
  add/edit/remove items within group instance navigations.

  This is a useful extension for adding contributed modules.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718480/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1716474] Re: Webservice Group functions don't respect submitpages

2017-09-20 Thread Stacey Walker 
** Changed in: mahara
 Assignee: (unassigned) => Stacey Walker (stacey)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1716474

Title:
  Webservice Group functions don't respect submitpages

Status in Mahara:
  New

Bug description:
  When creating or update groups with the webservices they still use
  'submitpages' which needs to be changed to 'submittableto' in order
  for the group to be created with the correct settings.

  Similar to the group CSV upload which has been adjusted for this
  already.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1716474/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp