[Mahara-contributors] [Bug 1757330] [NEW] Export file Session Data not saved in PHP 7.1+

2018-03-20 Thread Kevin Dibble
Public bug reported:

Mahara 17.10.3 (alo occurs on Mahara 17.10.0)
Operating system: Ubuntu, apache2, PHP 7.1.8 (also occurs on PHP 7.1.15 and PHP 
7.1.3)
Database; MySQL
Browser: Chrome.

Exporting files in Mahara
/export/index.php

Export Either LEAP file or Standalone HTML
click Generate Export
in the iframe - the /export/download.php redirects back to the export/index.php 
file and nothing is downloaded - the progress iframe now shows the 
/export/index.php page.

Possible Cause:
Download.php (export/download.php) as this located at the bottom of the page (~ 
line 106)
$SESSION->set('exportfile', $exporter->get('exportdir') . $zipfile);

At the top of the page it checks to see if this session data exists - and if so 
- to force the download of the file.
line 17: 
if ($exportfile = $SESSION->get('exportfile')) {
$SESSION->set('exportdata', '');
$SESSION->set('exportfile', '');
require_once('file.php');
serve_file($exportfile, basename($exportfile), 'application/x-zip', 
array('lifetime' => 0, 'forcedownload' => true));
exit;
}

In PHP 7.1.3 and higher - the $SESSION->get('exportfile') is empty when
the JS redirect calls this page (from the print_export_footer function)
and the session data set at the bottom of the page is not present when
the page is being loaded to get the file. (loading the /export/index.php
again will empty the exportfile data).

The export works as expected in PHP 7, but fails in PHP 7.1+.

Is Mahara 7.1+ ready?

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757330

Title:
  Export file Session Data not saved in PHP 7.1+

Status in Mahara:
  New

Bug description:
  Mahara 17.10.3 (alo occurs on Mahara 17.10.0)
  Operating system: Ubuntu, apache2, PHP 7.1.8 (also occurs on PHP 7.1.15 and 
PHP 7.1.3)
  Database; MySQL
  Browser: Chrome.

  Exporting files in Mahara
  /export/index.php

  Export Either LEAP file or Standalone HTML
  click Generate Export
  in the iframe - the /export/download.php redirects back to the 
export/index.php file and nothing is downloaded - the progress iframe now shows 
the /export/index.php page.

  Possible Cause:
  Download.php (export/download.php) as this located at the bottom of the page 
(~ line 106)
  $SESSION->set('exportfile', $exporter->get('exportdir') . $zipfile);

  At the top of the page it checks to see if this session data exists - and if 
so - to force the download of the file.
  line 17: 
  if ($exportfile = $SESSION->get('exportfile')) {
  $SESSION->set('exportdata', '');
  $SESSION->set('exportfile', '');
  require_once('file.php');
  serve_file($exportfile, basename($exportfile), 'application/x-zip', 
array('lifetime' => 0, 'forcedownload' => true));
  exit;
  }

  In PHP 7.1.3 and higher - the $SESSION->get('exportfile') is empty
  when the JS redirect calls this page (from the print_export_footer
  function) and the session data set at the bottom of the page is not
  present when the page is being loaded to get the file. (loading the
  /export/index.php again will empty the exportfile data).

  The export works as expected in PHP 7, but fails in PHP 7.1+.

  Is Mahara 7.1+ ready?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757330/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] Re: Not showing username to users when "never display usernames" is set to no

2018-03-20 Thread Robert Lyon
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/17.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8660
Committed: 
https://git.mahara.org/mahara/mahara/commit/6c08a5b7b2a7e55ad73caccb885d9495772800fa
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit 6c08a5b7b2a7e55ad73caccb885d9495772800fa
Author: Alexander Del Ponte 
Date:   Mon Mar 19 16:38:56 2018 +1300

Bug 1749834: Users can now see usernames for other users in share page

behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8675
Committed: 
https://git.mahara.org/mahara/mahara/commit/05ba4eb93a553bd6611664191f7eb261946388ed
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.10_STABLE

commit 05ba4eb93a553bd6611664191f7eb261946388ed
Author: Robert Lyon 
Date:   Mon Mar 19 16:38:56 2018 +1300

Bug 1749834: Users can now see usernames for other users in share page

behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc
(cherry picked from commit 02cbb9ed2d953365ee39d0fb265bb0ccb19f44e0)
(cherry picked from commit 1bbff55952a932935520377e2950a56c2e94267d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8674
Committed: 
https://git.mahara.org/mahara/mahara/commit/1bbff55952a932935520377e2950a56c2e94267d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 1bbff55952a932935520377e2950a56c2e94267d
Author: Robert Lyon 
Date:   Mon Mar 19 16:38:56 2018 +1300

Bug 1749834: Users can now see usernames for other users in share page

behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc
(cherry picked from commit 02cbb9ed2d953365ee39d0fb265bb0ccb19f44e0)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8674

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8675

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8662
Committed: 
https://git.mahara.org/mahara/mahara/commit/02cbb9ed2d953365ee39d0fb265bb0ccb19f44e0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 02cbb9ed2d953365ee39d0fb265bb0ccb19f44e0
Author: Robert Lyon 
Date:   Mon Mar 19 16:38:56 2018 +1300

Bug 1749834: Users can now see usernames for other users in share page

behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757283] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8673

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757283

Title:
  The views.js file uses the javascript 'includes' function but this is
  not available to IE11

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress

Bug description:
  We have:
   if (embedjs.includes("AC_Voki_Embed")) {

  We need:
   if (embedjs.indexOf("AC_Voki_Embed") !== -1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757283/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757283] [NEW] The views.js file uses the javascript 'includes' function but this is not available to IE11

2018-03-20 Thread Robert Lyon
Public bug reported:

We have:
 if (embedjs.includes("AC_Voki_Embed")) {

We need:
 if (embedjs.indexOf("AC_Voki_Embed") !== -1) {

** Affects: mahara
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Affects: mahara/17.10
 Importance: High
 Status: In Progress

** Affects: mahara/18.04
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Affects: mahara/18.10
 Importance: High
 Status: In Progress

** Changed in: mahara
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Also affects: mahara/17.10
   Importance: Undecided
   Status: New

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Also affects: mahara/18.04
   Importance: High
 Assignee: Robert Lyon (robertl-9)
   Status: In Progress

** Changed in: mahara/18.10
   Status: New => In Progress

** Changed in: mahara/17.10
   Status: New => In Progress

** Changed in: mahara/17.10
   Importance: Undecided => High

** Changed in: mahara/18.10
   Importance: Undecided => High

** Changed in: mahara/18.04
Milestone: 18.10.0 => 18.04.0

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/17.10
Milestone: None => 17.10.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757283

Title:
  The views.js file uses the javascript 'includes' function but this is
  not available to IE11

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress

Bug description:
  We have:
   if (embedjs.includes("AC_Voki_Embed")) {

  We need:
   if (embedjs.indexOf("AC_Voki_Embed") !== -1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757283/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756213] Re: MS Edge - drag & drop functionality not working

2018-03-20 Thread Steven
Environment tested: Master
Browser tested: MS Edge (Virtualbox)
Mahara version: 18.04 and 17.10 

===
Manual Test Script
===

1) Log in as any user 
2) browse to  Main menu > Portfolio > Pages and collections
3) create or edit an existing page - with a 3 column layout
4) in the edit mode add a text block to the left column of page 
5) User then try to drag the text block you just created to the furthest right 
column

Actual Result: user is unable to drag the block to anywhere on the page,
the only way to move the block is to delete block and recreate in
desired location

Expected Result: user is able to drag any block to another column

Catalyst QA

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756213

Title:
  MS Edge - drag & drop functionality not working

Status in Mahara:
  New

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)

  ===
  Manual Test Script
  ===

  Test Steps:
    1) user browse to Main menu > User Content  > Files
    2) user use drag & drop functionality
    3) user opens local file directory

  Actual Result: User cannot change the size or move the local directory
  to be able to see the Drag & drop area of the page.

  Expected Result: User can move the local directory or change size so
  that user can see the Drag & drop area to drop the files in.

  NOTE: user can use the browse button to select and upload a file (this
  is working)

  Also tested on IE 11 on Win 7 = Drag & drop file but download was
  hanging. never finished - Browse for file worked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756213/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756904] Re: UTF8 character encoding problem in HTML export

2018-03-20 Thread Kristina Hoeppner
I don't think that this is an issue because the special characters are
still displayed properly when looking at the HTML page in the browser,
and the links go to the correct places.

** Changed in: mahara
   Status: New => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756904

Title:
  UTF8 character encoding problem in HTML export

Status in Mahara:
  Invalid

Bug description:
  - Tested in demo.mahara.org
  - Client Os : Windows
  - Chrome 64.0.3282.186, Firefox 58.0.2, Microsoft Edge 41.16299.248.0

  Steps to reproduce

  - Create a Portfolio page with UTF8 accents in Title.
  - Export to HTML with "All my data"
  - Url to the page in index.html contains accents
  - Look in the archive /views/ and the folder's page name contains undefined 
characters (Windows)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756904/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756904] Re: UTF8 character encoding problem in HTML export

2018-03-20 Thread Kristina Hoeppner
** Attachment added: "Macrons_and Folder_colon_21_03_18_10:28:03.png"
   
https://bugs.launchpad.net/mahara/+bug/1756904/+attachment/5085428/+files/Macrons_and%20Folder_colon_21_03_18_10%3A28%3A03.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756904

Title:
  UTF8 character encoding problem in HTML export

Status in Mahara:
  Invalid

Bug description:
  - Tested in demo.mahara.org
  - Client Os : Windows
  - Chrome 64.0.3282.186, Firefox 58.0.2, Microsoft Edge 41.16299.248.0

  Steps to reproduce

  - Create a Portfolio page with UTF8 accents in Title.
  - Export to HTML with "All my data"
  - Url to the page in index.html contains accents
  - Look in the archive /views/ and the folder's page name contains undefined 
characters (Windows)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756904/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] Re: The page "more" link menu sometimes looks broken

2018-03-20 Thread Robert Lyon
Looks to have been broken in commit

8d796e7ca04b6df776b5deeb07cf38b9c7b037c0

I suspect the datapicker css changes broke this as there is a bunch of css in 
bottom of 
https://reviews.mahara.org/#/c/8469/15/htdocs/theme/raw/sass/components/_datepicker.scss
that look to override things that are meant to be set via variables


** Changed in: mahara
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  Confirmed

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1708959] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8672
Committed: 
https://git.mahara.org/mahara/mahara/commit/16808ebdb0191639e2ec2d64b5e397652e8b918d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 16808ebdb0191639e2ec2d64b5e397652e8b918d
Author: Robert Lyon 
Date:   Fri Aug 25 16:29:05 2017 +1200

Bug 1708959: mahara_user_get_users() function to accept params

The params being offset limit sortdir

And return offset, limit, totalcount, and array of users

behatnotneeded

Change-Id: I08f7fbfa59c4c129fb8efcc380f69738f4da624d
Signed-off-by: Robert Lyon 
(cherry picked from commit 416d477a1b6eda21e1f1d8f586d335cd05513586)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708959

Title:
  Webservice create group missing some settings

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  The mahara_group_create_groups function is missing some options

  Including
  - Hide group
  - Hide membership
  - Hide membership from members
  - Participation report
  - Comment notifications

  Also the Shared page notifications option is boolean yet there are 4
  valid states for this option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708959/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1708959] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7949
Committed: 
https://git.mahara.org/mahara/mahara/commit/416d477a1b6eda21e1f1d8f586d335cd05513586
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 416d477a1b6eda21e1f1d8f586d335cd05513586
Author: Robert Lyon 
Date:   Fri Aug 25 16:29:05 2017 +1200

Bug 1708959: mahara_user_get_users() function to accept params

The params being offset limit sortdir

And return offset, limit, totalcount, and array of users

behatnotneeded

Change-Id: I08f7fbfa59c4c129fb8efcc380f69738f4da624d
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708959

Title:
  Webservice create group missing some settings

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  The mahara_group_create_groups function is missing some options

  Including
  - Hide group
  - Hide membership
  - Hide membership from members
  - Participation report
  - Comment notifications

  Also the Shared page notifications option is boolean yet there are 4
  valid states for this option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708959/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1708959] Re: Webservice create group missing some settings

2018-03-20 Thread Robert Lyon
** Also affects: mahara/18.04
   Importance: Medium
   Status: Fix Released

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.04
Milestone: 17.10.0 => 18.04.0

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/18.10
   Status: New => Fix Committed

** Changed in: mahara/18.04
   Status: Fix Released => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708959

Title:
  Webservice create group missing some settings

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  The mahara_group_create_groups function is missing some options

  Including
  - Hide group
  - Hide membership
  - Hide membership from members
  - Participation report
  - Comment notifications

  Also the Shared page notifications option is boolean yet there are 4
  valid states for this option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708959/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1708959] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8672

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708959

Title:
  Webservice create group missing some settings

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  The mahara_group_create_groups function is missing some options

  Including
  - Hide group
  - Hide membership
  - Hide membership from members
  - Participation report
  - Comment notifications

  Also the Shared page notifications option is boolean yet there are 4
  valid states for this option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708959/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] Re: Unable to remove users from group when pagination is used

2018-03-20 Thread Robert Lyon
** Changed in: mahara/17.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/17.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8670
Committed: 
https://git.mahara.org/mahara/mahara/commit/c872b0cc48c2130a69896d39e50545a788ba5a49
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit c872b0cc48c2130a69896d39e50545a788ba5a49
Author: Cecilia Vela Gurovic 
Date:   Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604d3f18bbf4e265ce523c017664dc94df3)
(cherry picked from commit 08ff7cf6f6d4077593f8e303ff63868e3e3abb18)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749402] Re: Views and collection list (in group) throws MySQL error

2018-03-20 Thread Robert Lyon
Steps to test:

1) Make a group that is 'Open' and is also 'Publicly viewable group'
2) make some pages in the group and add all of them to a collection
3) share the collection to the group and to registered users

4) find the ID of the collection and then make sure there is no view
with same ID in database

Visit the group's 'Pages and collections' tab as a logged in user that
is not a member of the group

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749402

Title:
  Views and collection list (in group) throws MySQL error

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  If a normal group member tries to visit views and collections of the
  group, following warning/error is thrown under some conditions which
  are mentioned below:

  SQL:
  [WAR] 93 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("dp-dev-master-ep"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" 
FOREIGN KEY ("view") REFERENCES "view" ("id"))] in EXECUTE("INSERT INTO 
"view_rows_columns" ("view", "row", "columns") VALUES ('46', '1', '3')")Command 
was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, 
?) and values was (view:46,row:1,columns:3)

  PHP:
  Call stack (most recent first):
  log_message("Failed to get a recordset: mysqli error: [1452: Ca...", 8, true, 
true) at /var/www/mahara/master/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: mysqli error: [1452: Ca...") at 
/var/www/mahara/master/htdocs/lib/errors.php:859
  SQLException->__construct("Failed to get a recordset: mysqli error: [1452: 
Ca...") at /var/www/mahara/master/htdocs/lib/dml.php:1105
  insert_record("view_rows_columns", object(stdClass), false, false) at 
/var/www/mahara/master/htdocs/lib/dml.php:1192
  ensure_record_exists("view_rows_columns", object(stdClass), object(stdClass)) 
at /var/www/mahara/master/htdocs/lib/view.php:356
  View->__construct(0array(size 25)) at 
/var/www/mahara/master/htdocs/lib/view.php:5581
  View::get_extra_view_info(array(size 2), false) at 
/var/www/mahara/master/htdocs/view/groupviews.php:52

  This happens if the group views and collections are readonly to
  members, a group collection exisits with at least one view inside and
  in the DB there is no view which has the same id as this collection.

  I didn't went too deep inside the code, but it seems that this issue
  is somehow connected to the bug #1514608.

  It further seems that Mahara interprets a collection as a view trying
  to get/set view related data using a collection id to avoid having no
  DB entry in table view_rows_columns for this erroneously supposed view
  so the actually error should be found in functions calling this code
  areas (get_extra_view_info).

  Reproduce error:
  Create a group in which views and collections are only editable by others 
that normal group members.
  Create a view and a collection inside this group and assign the view to the 
collection.
  Make sure, that in the DB there are no entries referring to a view which has 
the same id as the above created collection (e. g. by deleting a possibly 
existing view with this id inside Mahara).
  As a normal group member call the tab views and collection of the group.

  Greetings
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749402/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8669
Committed: 
https://git.mahara.org/mahara/mahara/commit/12dc894f6047280ff00aa0936d554f92799661da
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.10_STABLE

commit 12dc894f6047280ff00aa0936d554f92799661da
Author: Cecilia Vela Gurovic 
Date:   Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604d3f18bbf4e265ce523c017664dc94df3)
(cherry picked from commit 08ff7cf6f6d4077593f8e303ff63868e3e3abb18)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] Re: The page "more" link menu sometimes looks broken

2018-03-20 Thread Kristina Hoeppner
** Tags added: front-end

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  New

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] [NEW] The page "more" link menu sometimes looks broken

2018-03-20 Thread Robert Lyon
Public bug reported:

When I view the page as myself things look fine and also when a logged
out user

But when viewing as another logged in user things look broken

See attached image

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: front-end

** Attachment added: "bad_more.png"
   
https://bugs.launchpad.net/bugs/1757254/+attachment/5085340/+files/bad_more.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  New

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756631] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8671
Committed: 
https://git.mahara.org/mahara/mahara/commit/b78ce5707c78fc0c6bdc1c1f1d1c740e1325e67c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit b78ce5707c78fc0c6bdc1c1f1d1c740e1325e67c
Author: Robert Lyon 
Date:   Mon Mar 19 14:06:13 2018 +1300

Bug 1756631: Create group with relevant default institution set

If the user is in one or more true institutions they need the default
option set as that and not 'mahara'

behatnotneeded

Change-Id: If295f76c3dac0c1ae5d3dd1ec2346511b0645150
Signed-off-by: Robert Lyon 
(cherry picked from commit cdea3ba4a4ff2d09d3d7f12e8c687fbb8917ed9f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756631

Title:
  Setting up group when user is in 2 institutions and not site admin
  brings error

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  master (18.04RC1)

  When user is in two institutions but not the site admin, the following
  error message is displayed when she wants to set up a group:

  [WAR] 3e (lib/pieforms/pieform.php:1343) Invalid value for select 
"institution"
  Call stack (most recent first):

  log_message(string(size 38), integer, true, true, string(size 58), 
integer) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
  error(integer, string(size 38), string(size 58), integer, array(size 2)) 
at Unknown:0
  trigger_error(string(size 38), integer) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1343
  Pieform::info(string(size 38)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:151
  pieform_element_select(object(Pieform), array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1509
  Pieform->build_element_html(array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:725
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 4)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5077
  pieform(array(size 4)) at 
/home/kristina/code/mahara/htdocs/group/edit.php:424

  There is no error message when the user is in only one institution.

  To replicate:

  1. Make a user a member in 2 or more institutions.
  2. Go to Main menu -> Groups -> My groups.
  3. Click the "Create group" button.
  Expected result: No error message.
  Actual result: Above error message is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756631/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756631] Re: Setting up group when user is in 2 institutions and not site admin brings error

2018-03-20 Thread Robert Lyon
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756631

Title:
  Setting up group when user is in 2 institutions and not site admin
  brings error

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  master (18.04RC1)

  When user is in two institutions but not the site admin, the following
  error message is displayed when she wants to set up a group:

  [WAR] 3e (lib/pieforms/pieform.php:1343) Invalid value for select 
"institution"
  Call stack (most recent first):

  log_message(string(size 38), integer, true, true, string(size 58), 
integer) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
  error(integer, string(size 38), string(size 58), integer, array(size 2)) 
at Unknown:0
  trigger_error(string(size 38), integer) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1343
  Pieform::info(string(size 38)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:151
  pieform_element_select(object(Pieform), array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1509
  Pieform->build_element_html(array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:725
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 4)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5077
  pieform(array(size 4)) at 
/home/kristina/code/mahara/htdocs/group/edit.php:424

  There is no error message when the user is in only one institution.

  To replicate:

  1. Make a user a member in 2 or more institutions.
  2. Go to Main menu -> Groups -> My groups.
  3. Click the "Create group" button.
  Expected result: No error message.
  Actual result: Above error message is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756631/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756631] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8671

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756631

Title:
  Setting up group when user is in 2 institutions and not site admin
  brings error

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  master (18.04RC1)

  When user is in two institutions but not the site admin, the following
  error message is displayed when she wants to set up a group:

  [WAR] 3e (lib/pieforms/pieform.php:1343) Invalid value for select 
"institution"
  Call stack (most recent first):

  log_message(string(size 38), integer, true, true, string(size 58), 
integer) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
  error(integer, string(size 38), string(size 58), integer, array(size 2)) 
at Unknown:0
  trigger_error(string(size 38), integer) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1343
  Pieform::info(string(size 38)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:151
  pieform_element_select(object(Pieform), array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1509
  Pieform->build_element_html(array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:725
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 4)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5077
  pieform(array(size 4)) at 
/home/kristina/code/mahara/htdocs/group/edit.php:424

  There is no error message when the user is in only one institution.

  To replicate:

  1. Make a user a member in 2 or more institutions.
  2. Go to Main menu -> Groups -> My groups.
  3. Click the "Create group" button.
  Expected result: No error message.
  Actual result: Above error message is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756631/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756631] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8658
Committed: 
https://git.mahara.org/mahara/mahara/commit/cdea3ba4a4ff2d09d3d7f12e8c687fbb8917ed9f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit cdea3ba4a4ff2d09d3d7f12e8c687fbb8917ed9f
Author: Robert Lyon 
Date:   Mon Mar 19 14:06:13 2018 +1300

Bug 1756631: Create group with relevant default institution set

If the user is in one or more true institutions they need the default
option set as that and not 'mahara'

behatnotneeded

Change-Id: If295f76c3dac0c1ae5d3dd1ec2346511b0645150
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756631

Title:
  Setting up group when user is in 2 institutions and not site admin
  brings error

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  master (18.04RC1)

  When user is in two institutions but not the site admin, the following
  error message is displayed when she wants to set up a group:

  [WAR] 3e (lib/pieforms/pieform.php:1343) Invalid value for select 
"institution"
  Call stack (most recent first):

  log_message(string(size 38), integer, true, true, string(size 58), 
integer) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
  error(integer, string(size 38), string(size 58), integer, array(size 2)) 
at Unknown:0
  trigger_error(string(size 38), integer) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1343
  Pieform::info(string(size 38)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:151
  pieform_element_select(object(Pieform), array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1509
  Pieform->build_element_html(array(size 10)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:725
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 4)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5077
  pieform(array(size 4)) at 
/home/kristina/code/mahara/htdocs/group/edit.php:424

  There is no error message when the user is in only one institution.

  To replicate:

  1. Make a user a member in 2 or more institutions.
  2. Go to Main menu -> Groups -> My groups.
  3. Click the "Create group" button.
  Expected result: No error message.
  Actual result: Above error message is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756631/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8668

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8669

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8668
Committed: 
https://git.mahara.org/mahara/mahara/commit/08ff7cf6f6d4077593f8e303ff63868e3e3abb18
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 08ff7cf6f6d4077593f8e303ff63868e3e3abb18
Author: Cecilia Vela Gurovic 
Date:   Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604d3f18bbf4e265ce523c017664dc94df3)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A patch has been submitted for review

2018-03-20 Thread Mahara Bot
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8670

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] A change has been merged

2018-03-20 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8667
Committed: 
https://git.mahara.org/mahara/mahara/commit/49ef1604d3f18bbf4e265ce523c017664dc94df3
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 49ef1604d3f18bbf4e265ce523c017664dc94df3
Author: Cecilia Vela Gurovic 
Date:   Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] Re: Unable to remove users from group when pagination is used

2018-03-20 Thread Robert Lyon
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755331] Re: Cannot copy group pages when pagination is used

2018-03-20 Thread Robert Lyon
** Changed in: mahara/18.10
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara/18.04
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/18.04
 Assignee: Robert Lyon (robertl-9) => (unassigned)

** Changed in: mahara/18.04
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755331

Title:
  Cannot copy group pages when pagination is used

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed

Bug description:
  Version: Mahara Version 17.10.0
  OS: Linux (Ubuntu)
  Database: MySQL
  Browser: Chrome

  Issue:
  Group pages are created that can be copied by group members

  Pages for users to copy that require they navigation to page 2 or higher of a 
shared list 
  (using the pagination at the bottom)
  Clicking Copy Reloads the page (the page is not copied)

  Page 1 is unaffected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755331/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1702748] Re: View ID appended at download URL from another Mahara site

2018-03-20 Thread Robert Lyon
** Also affects: mahara/18.04
   Importance: Medium
   Status: Confirmed

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/18.10
   Status: New => Confirmed

** Changed in: mahara/18.10
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/18.04
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1702748

Title:
  View ID appended at download URL from another Mahara site

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed

Bug description:
  Checked in 16.10 -> 17.04

  When you have a public file on one Mahara site, link that for example
  in a journal entry on another Mahara site and make the page public,
  the file gets the viewID of that page appended even though there is no
  reason for it. It seems that Mahara only checks that
  /artefact/file/download.php?file= is present no matter the domain and
  then simply appends the viewID.

  To replicate:

  1. Log into Mahara instance 1.
  2. Upload a file into Admin menu -> Configure site -> Files -> Public.
  3. Add the file to the public menu (to ensure that you are copying the 
correct download link that is available to people when not logged in): Admin 
menu -> Configure site -> Menus -> Public...
  4. Copy the file's location. It should look something like 
http://domain.tld/artefact/file/download.php?file=
  5. Log out of Mahara instance 1.
  6. Log into Mahara instance 2.
  7. Write a journal entry and link some text to the file. Save the entry.
  8. Add your journal to a page and make it public.
  9. View the page and hover over the link.

  Expected result: The link looks exactly the same as before and you can reach 
the file as it is a public one.
  Actual result: The link has a viewID appended, e.g. 
http://domain.tld/artefact/file/download.php?file==YYY and if you are 
not logged into Mahara instance 1, you can't view it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1702748/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] Re: Make SmartEvidence strings for statuses configurable

2018-03-20 Thread Robert Lyon
** Changed in: mahara/18.10
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/18.04
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] Re: Not showing username to users when "never display usernames" is set to no

2018-03-20 Thread Robert Lyon
** Changed in: mahara/18.10
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara/18.04
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756642] Re: Problems embedding YouTube video in 17.04

2018-03-20 Thread Ulises Martínez Miralles
Hi Kristina,

Thanks for the explanation.

The users are creating HTML blocks and copying the '' code.
Using the External - External media worked fine in the export as standalone 
HTML.

But the 'substitution' in the HTML code is still a problem. There is any
filter applied in the export method? There is a difference between http
and https iframe-videos. Https are respected, and http replaced.

Thanks

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756642

Title:
  Problems embedding YouTube video in 17.04

Status in Mahara:
  Incomplete

Bug description:
  Reported at https://bugs.launchpad.net/mahara/+bug/548308/comments/6

  
  I'm using Mahara 17.04.3.
  If we embed Youtube videos with 'https://' it is exported and shows correctly.
  If we embed them with 'http://' the URLs are changed to start with '//'.
  So if we embed the 'https://www.youtube.com/embed/' it is shown correctly.
  If we embed the 'http://www.youtube.com/embed/' it is replaced with the 
'//www.youtube.com/embed/'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756642/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp