[Mahara-contributors] [Bug 1758226] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8711

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758226

Title:
  Group edit homepage "Settings" button shows wrong message with skins
  enabled

Status in Mahara:
  In Progress

Bug description:
  To replicate:

  Create a group and edit the homepage. 
  If we have skins enabled ($cfg->skins = true), we will see there is a 
"Settings" button. If skins is disabled then we see "Edit layout" button 
instead.
  When we hover over the button a box is displayed.

  Expected result: The message in the box has the same text as the
  button.

  Actual result: The box shows "Edit layout" in both cases.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758226/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758226] [NEW] Group edit homepage "Settings" button shows wrong message with skins enabled

2018-03-22 Thread Cecilia Vela Gurovic
Public bug reported:

To replicate:

Create a group and edit the homepage. 
If we have skins enabled ($cfg->skins = true), we will see there is a 
"Settings" button. If skins is disabled then we see "Edit layout" button 
instead.
When we hover over the button a box is displayed.

Expected result: The message in the box has the same text as the button.

Actual result: The box shows "Edit layout" in both cases.

** Affects: mahara
 Importance: Low
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758226

Title:
  Group edit homepage "Settings" button shows wrong message with skins
  enabled

Status in Mahara:
  In Progress

Bug description:
  To replicate:

  Create a group and edit the homepage. 
  If we have skins enabled ($cfg->skins = true), we will see there is a 
"Settings" button. If skins is disabled then we see "Edit layout" button 
instead.
  When we hover over the button a box is displayed.

  Expected result: The message in the box has the same text as the
  button.

  Actual result: The box shows "Edit layout" in both cases.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758226/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1743286] Re: styling changes for behat html report

2018-03-22 Thread Robert Lyon
** Also affects: mahara/18.04
   Importance: Medium
 Assignee: Liam (liam-sharpe)
   Status: In Progress

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.04
   Status: In Progress => Fix Committed

** Changed in: mahara/18.10
   Status: New => Fix Committed

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/18.10
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1743286

Title:
  styling changes for behat html report

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  making it look nicer and display the information we need fully.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1743286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8709

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  Fix Committed

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8681
Committed: 
https://git.mahara.org/mahara/mahara/commit/878245e154316dddb71767f7db03102400d9bd54
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 878245e154316dddb71767f7db03102400d9bd54
Author: Liam 
Date:   Thu Mar 22 09:45:07 2018 +1300

Bug #1744191 - datepicker accessibility

-Changed keyboard shortcuts
-Added aria label to input block
-Changed help text
-Added application roles

Also updated datepicker so that picker time works in 24hr format

behatnotneeded

Change-Id: I73015ec689cd0947d4498b8bad014df79b7d4384

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  Fix Committed

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8709
Committed: 
https://git.mahara.org/mahara/mahara/commit/e5efbafbb45fe182870b39052701669f1c07ce9a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit e5efbafbb45fe182870b39052701669f1c07ce9a
Author: Liam 
Date:   Thu Mar 22 09:45:07 2018 +1300

Bug #1744191 - datepicker accessibility

-Changed keyboard shortcuts
-Added aria label to input block
-Changed help text
-Added application roles

Also updated datepicker so that picker time works in 24hr format

behatnotneeded

Change-Id: I73015ec689cd0947d4498b8bad014df79b7d4384
(cherry picked from commit 878245e154316dddb71767f7db03102400d9bd54)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  Fix Committed

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758153] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8700
Committed: 
https://git.mahara.org/mahara/mahara/commit/7e54caf997fb5bb2d2ab058dc44dcb4e5d30e089
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 7e54caf997fb5bb2d2ab058dc44dcb4e5d30e089
Author: Robert Lyon 
Date:   Fri Mar 23 10:20:40 2018 +1300

Bug 1758153: Translating aria-label values where we can

Mostly translating the 'Close' label on modals

behatnotneeded

Change-Id: I8f450fa3b8ae935c73a0120370163171d00624e0
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758153

Title:
  There are 'aria-label' values that are not being translated

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  For accessibility we use 'aria-label' in some places but we've
  hardcoded the values in English

  We should also allow these values to be translated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758153/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758153] Re: There are 'aria-label' values that are not being translated

2018-03-22 Thread Robert Lyon
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758153

Title:
  There are 'aria-label' values that are not being translated

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  For accessibility we use 'aria-label' in some places but we've
  hardcoded the values in English

  We should also allow these values to be translated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758153/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758153] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8710
Committed: 
https://git.mahara.org/mahara/mahara/commit/4a816930e7b408d7ce11f7538cd6a550e18eeeb2
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 4a816930e7b408d7ce11f7538cd6a550e18eeeb2
Author: Robert Lyon 
Date:   Fri Mar 23 10:20:40 2018 +1300

Bug 1758153: Translating aria-label values where we can

Mostly translating the 'Close' label on modals

behatnotneeded

Change-Id: I8f450fa3b8ae935c73a0120370163171d00624e0
Signed-off-by: Robert Lyon 
(cherry picked from commit 7e54caf997fb5bb2d2ab058dc44dcb4e5d30e089)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758153

Title:
  There are 'aria-label' values that are not being translated

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  For accessibility we use 'aria-label' in some places but we've
  hardcoded the values in English

  We should also allow these values to be translated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758153/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758153] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8710

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758153

Title:
  There are 'aria-label' values that are not being translated

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  For accessibility we use 'aria-label' in some places but we've
  hardcoded the values in English

  We should also allow these values to be translated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758153/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1743286] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8708

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1743286

Title:
  styling changes for behat html report

Status in Mahara:
  In Progress

Bug description:
  making it look nicer and display the information we need fully.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1743286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1743286] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8448
Committed: 
https://git.mahara.org/mahara/mahara/commit/8eaabc835e4d1f9c35ffb036a4b58454eacddc8b
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 8eaabc835e4d1f9c35ffb036a4b58454eacddc8b
Author: Liam 
Date:   Tue Jan 16 17:03:43 2018 +1300

Bug #1743286: styling changes for behat html report

- moved custom styling files to
htdocs/testing/frameworks/behat/html-formatter
- added code to copy files to formatter after composer updates
- added Behat2Renderer

behatnotneeded

Change-Id: Ifa5bea8477d1e55b147d58bb509d2b33b69f643b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1743286

Title:
  styling changes for behat html report

Status in Mahara:
  In Progress

Bug description:
  making it look nicer and display the information we need fully.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1743286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1743286] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8708
Committed: 
https://git.mahara.org/mahara/mahara/commit/a0f1ac933c1e21adf0e5dff2a9c3f920e7dc3d40
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit a0f1ac933c1e21adf0e5dff2a9c3f920e7dc3d40
Author: Liam 
Date:   Tue Jan 16 17:03:43 2018 +1300

Bug #1743286: styling changes for behat html report

- moved custom styling files to
htdocs/testing/frameworks/behat/html-formatter
- added code to copy files to formatter after composer updates
- added Behat2Renderer

behatnotneeded

Change-Id: Ifa5bea8477d1e55b147d58bb509d2b33b69f643b
(cherry picked from commit 8eaabc835e4d1f9c35ffb036a4b58454eacddc8b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1743286

Title:
  styling changes for behat html report

Status in Mahara:
  In Progress

Bug description:
  making it look nicer and display the information we need fully.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1743286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756154] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8707
Committed: 
https://git.mahara.org/mahara/mahara/commit/52217820c93e0fad5f8bd8a8260b5c38030d6737
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 52217820c93e0fad5f8bd8a8260b5c38030d6737
Author: Liam 
Date:   Thu Mar 22 17:18:26 2018 +1300

Bug #1756154: Fix link color in Primary School and Ocean themes for
"Notifications"

Made the notifications style the default style

behatnotneeded

Change-Id: I1da5f02918f75a6eb59cb059ff8f9941b78cc023
(cherry picked from commit 57e9c6b1045bc843fa0bb5514e1b6d3e564138c5)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756154

Title:
  Fix link color in Primary School and Ocean themes for "Notifications"

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When you have the Primary School or Ocean theme on your site, the
  navigation bar in the inbox
  (/module/multirecipientnotification/inbox.php) does not show the links
  in the nav bar in the correct colors. In Ocean it is only the active
  link that is a problem, in Primary School it is both Inbox and Sent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756764] Re: share/edit access cancel button not working

2018-03-22 Thread Robert Lyon
** Also affects: mahara/18.04
   Importance: Medium
   Status: Fix Committed

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/18.04
Milestone: 18.10.0 => 18.04.0

** Changed in: mahara/18.10
Milestone: None => 18.04.0

** Changed in: mahara/18.10
Milestone: 18.04.0 => 18.10.0

** Changed in: mahara/18.10
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756764

Title:
  share/edit access cancel button not working

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)  | Chrome Linux 

  ===
  Manual Test Script
  ===

  Preconditions:
  1) user has portfolio page to share
  2) User has no friends but 1 friend request 

  Test Steps:
  1) user is on the "Share | Edit access" page for the page they want to share
  2) user selects "Friends" under the search for section of the "SHARED WITH" 
drop down field
  3) a search field is now displayed but returns no results, because user has 
not friends yet

  Actual result: 
  User tries to click Cancel to get out of page but nothing happens, there is 
no error message describing what he has done wrong.  User must delete the field 
before the cancel button works, returning user to "Share" 

  Expected result:
  1) Save button should not work because I have search friends field open and 
no friend selected 
  2) Cancel button should work and take user back to previous page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756154] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8707

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756154

Title:
  Fix link color in Primary School and Ocean themes for "Notifications"

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When you have the Primary School or Ocean theme on your site, the
  navigation bar in the inbox
  (/module/multirecipientnotification/inbox.php) does not show the links
  in the nav bar in the correct colors. In Ocean it is only the active
  link that is a problem, in Primary School it is both Inbox and Sent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756154] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8693
Committed: 
https://git.mahara.org/mahara/mahara/commit/57e9c6b1045bc843fa0bb5514e1b6d3e564138c5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 57e9c6b1045bc843fa0bb5514e1b6d3e564138c5
Author: Liam 
Date:   Thu Mar 22 17:18:26 2018 +1300

Bug #1756154: Fix link color in Primary School and Ocean themes for
"Notifications"

Made the notifications style the default style

behatnotneeded

Change-Id: I1da5f02918f75a6eb59cb059ff8f9941b78cc023

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756154

Title:
  Fix link color in Primary School and Ocean themes for "Notifications"

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When you have the Primary School or Ocean theme on your site, the
  navigation bar in the inbox
  (/module/multirecipientnotification/inbox.php) does not show the links
  in the nav bar in the correct colors. In Ocean it is only the active
  link that is a problem, in Primary School it is both Inbox and Sent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756764] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8683
Committed: 
https://git.mahara.org/mahara/mahara/commit/55c50c1cd0f0260cb0c7f0997a62e6e8e4494205
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 55c50c1cd0f0260cb0c7f0997a62e6e8e4494205
Author: Robert Lyon 
Date:   Thu Mar 22 10:21:06 2018 +1300

Bug 1756764: Alert user if shared with rules 2nd option empty

This is for the 'Search for...' Friends / Groups / Users

Currently we don't allow the submission / cancel of the form if any of
these 3 options are selected but the second select2 box is empty

But we also don't tell the user why.

I've added an alert to mention why the form will not submit / cancel

behatnotneeded

Change-Id: I71827647fd7a2f8177c336bdb91f6ce8b9b23df8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756764

Title:
  share/edit access cancel button not working

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)  | Chrome Linux 

  ===
  Manual Test Script
  ===

  Preconditions:
  1) user has portfolio page to share
  2) User has no friends but 1 friend request 

  Test Steps:
  1) user is on the "Share | Edit access" page for the page they want to share
  2) user selects "Friends" under the search for section of the "SHARED WITH" 
drop down field
  3) a search field is now displayed but returns no results, because user has 
not friends yet

  Actual result: 
  User tries to click Cancel to get out of page but nothing happens, there is 
no error message describing what he has done wrong.  User must delete the field 
before the cancel button works, returning user to "Share" 

  Expected result:
  1) Save button should not work because I have search friends field open and 
no friend selected 
  2) Cancel button should work and take user back to previous page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756764] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8706
Committed: 
https://git.mahara.org/mahara/mahara/commit/d5d67ffe4f3ed1607623a0c2bcae8f79b325468b
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit d5d67ffe4f3ed1607623a0c2bcae8f79b325468b
Author: Robert Lyon 
Date:   Thu Mar 22 10:21:06 2018 +1300

Bug 1756764: Alert user if shared with rules 2nd option empty

This is for the 'Search for...' Friends / Groups / Users

Currently we don't allow the submission / cancel of the form if any of
these 3 options are selected but the second select2 box is empty

But we also don't tell the user why.

I've added an alert to mention why the form will not submit / cancel

behatnotneeded

Change-Id: I71827647fd7a2f8177c336bdb91f6ce8b9b23df8
Signed-off-by: Robert Lyon 
(cherry picked from commit 55c50c1cd0f0260cb0c7f0997a62e6e8e4494205)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756764

Title:
  share/edit access cancel button not working

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)  | Chrome Linux 

  ===
  Manual Test Script
  ===

  Preconditions:
  1) user has portfolio page to share
  2) User has no friends but 1 friend request 

  Test Steps:
  1) user is on the "Share | Edit access" page for the page they want to share
  2) user selects "Friends" under the search for section of the "SHARED WITH" 
drop down field
  3) a search field is now displayed but returns no results, because user has 
not friends yet

  Actual result: 
  User tries to click Cancel to get out of page but nothing happens, there is 
no error message describing what he has done wrong.  User must delete the field 
before the cancel button works, returning user to "Share" 

  Expected result:
  1) Save button should not work because I have search friends field open and 
no friend selected 
  2) Cancel button should work and take user back to previous page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756764] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8706

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756764

Title:
  share/edit access cancel button not working

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)  | Chrome Linux 

  ===
  Manual Test Script
  ===

  Preconditions:
  1) user has portfolio page to share
  2) User has no friends but 1 friend request 

  Test Steps:
  1) user is on the "Share | Edit access" page for the page they want to share
  2) user selects "Friends" under the search for section of the "SHARED WITH" 
drop down field
  3) a search field is now displayed but returns no results, because user has 
not friends yet

  Actual result: 
  User tries to click Cancel to get out of page but nothing happens, there is 
no error message describing what he has done wrong.  User must delete the field 
before the cancel button works, returning user to "Share" 

  Expected result:
  1) Save button should not work because I have search friends field open and 
no friend selected 
  2) Cancel button should work and take user back to previous page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756764] Re: share/edit access cancel button not working

2018-03-22 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756764

Title:
  share/edit access cancel button not working

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)  | Chrome Linux 

  ===
  Manual Test Script
  ===

  Preconditions:
  1) user has portfolio page to share
  2) User has no friends but 1 friend request 

  Test Steps:
  1) user is on the "Share | Edit access" page for the page they want to share
  2) user selects "Friends" under the search for section of the "SHARED WITH" 
drop down field
  3) a search field is now displayed but returns no results, because user has 
not friends yet

  Actual result: 
  User tries to click Cancel to get out of page but nothing happens, there is 
no error message describing what he has done wrong.  User must delete the field 
before the cancel button works, returning user to "Share" 

  Expected result:
  1) Save button should not work because I have search friends field open and 
no friend selected 
  2) Cancel button should work and take user back to previous page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8705
Committed: 
https://git.mahara.org/mahara/mahara/commit/06678effc62921a8b31e9227a9802913b21f51ee
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 06678effc62921a8b31e9227a9802913b21f51ee
Author: Robert Lyon 
Date:   Thu Mar 22 09:32:59 2018 +1300

Bug 1757254: Target the datepicker styles more directly

To avoid them overriding the same styles being used elsewhere

behatnotneeded

Change-Id: I092d841224a811b8a1f398b9fe2bf76e5e9a143d
Signed-off-by: Robert Lyon 
(cherry picked from commit 3927b6967fb95ddc0866feaa40833365ed7e8b31)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8705

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8679
Committed: 
https://git.mahara.org/mahara/mahara/commit/3927b6967fb95ddc0866feaa40833365ed7e8b31
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 3927b6967fb95ddc0866feaa40833365ed7e8b31
Author: Robert Lyon 
Date:   Thu Mar 22 09:32:59 2018 +1300

Bug 1757254: Target the datepicker styles more directly

To avoid them overriding the same styles being used elsewhere

behatnotneeded

Change-Id: I092d841224a811b8a1f398b9fe2bf76e5e9a143d
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757254] Re: The page "more" link menu sometimes looks broken

2018-03-22 Thread Robert Lyon
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757254

Title:
  The page "more" link menu sometimes looks broken

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When I view the page as myself things look fine and also when a logged
  out user

  But when viewing as another logged in user things look broken

  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8704
Committed: 
https://git.mahara.org/mahara/mahara/commit/cc3a72945b4f68a3b9ffedca26c877619e348b1f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit cc3a72945b4f68a3b9ffedca26c877619e348b1f
Author: Robert Lyon 
Date:   Thu Mar 8 10:02:57 2018 +1300

Bug 1422492: Make user enter current password if changing their username

As the change username option only appears on account index page for
those users that have an auth method allowing it we should make the
user also supply their current password when changign username

We hide the confirm password box for username change until they try to
change it

behatnotneeded

Change-Id: Ic05d3c258d331305ae5c07b952ea2a561a8badf1
Signed-off-by: Robert Lyon 
(cherry picked from commit 8ad4343d97be9d248088bc64ceaa510d213e1151)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] Re: Mahara doesn't ask you for your password before deleting your account or changing your username

2018-03-22 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] Re: Mahara doesn't ask you for your password before deleting your account or changing your username

2018-03-22 Thread Cecilia Vela Gurovic
** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/18.10
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8704

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8589
Committed: 
https://git.mahara.org/mahara/mahara/commit/8ad4343d97be9d248088bc64ceaa510d213e1151
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 8ad4343d97be9d248088bc64ceaa510d213e1151
Author: Robert Lyon 
Date:   Thu Mar 8 10:02:57 2018 +1300

Bug 1422492: Make user enter current password if changing their username

As the change username option only appears on account index page for
those users that have an auth method allowing it we should make the
user also supply their current password when changign username

We hide the confirm password box for username change until they try to
change it

behatnotneeded

Change-Id: Ic05d3c258d331305ae5c07b952ea2a561a8badf1
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  In Progress

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758135] Re: Long block titles overflow block title area when dragging

2018-03-22 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758135

Title:
  Long block titles overflow block title area when dragging

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When a block title is very long, e.g. the Creative Commons block, then
  the text overflows the boundary of the drag area. This is a fix for it
  so that the text stays within the boundaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] Re: Set password policy explicitly during install

2018-03-22 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8702
Committed: 
https://git.mahara.org/mahara/mahara/commit/c81d02ab8dda239880e223799fbb66d35f3dcb8d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit c81d02ab8dda239880e223799fbb66d35f3dcb8d
Author: Robert Lyon 
Date:   Fri Mar 23 08:21:12 2018 +1300

Bug 1758139: Set password policy explicitly during install

behatnotneeded

Change-Id: I4e173da5a289ba0106c29fed3dff234d92dfb175
Signed-off-by: Robert Lyon 
(cherry picked from commit 24a98bdc620c291f5ee390c89886bf0cabccb68b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758135] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8701
Committed: 
https://git.mahara.org/mahara/mahara/commit/4b86fb169f4b129bba4c2a7e5504f513d9f77154
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 4b86fb169f4b129bba4c2a7e5504f513d9f77154
Author: Robert Lyon 
Date:   Thu Mar 22 18:59:45 2018 +1300

Bug 1758135: Avoid overflow when dragging block choice

This happens for long named blocks, eg creative commons license

behatnotneeded

Change-Id: Ib980431e505857393acb5540e3b998893759eba7
Signed-off-by: Robert Lyon 
(cherry picked from commit 7e85d7ff613a9ecc014440d81319e8fbf1f732eb)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758135

Title:
  Long block titles overflow block title area when dragging

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When a block title is very long, e.g. the Creative Commons block, then
  the text overflows the boundary of the drag area. This is a fix for it
  so that the text stays within the boundaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756736] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8703

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756736

Title:
  Primary button colour error TinyMCE link

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed

Bug description:
  Environment tested: Master
  Browser tested: MS Edge
  Theme: Primary school

  ===
  Manual Test Script
  ===

  Test Steps:
  1) Any user logged in 
  2) user create page for my portfolio
  3) user add link in page description tiny MCE field by clicking the link icon 
when setting up page.

  Actual result: "Insert link" Modal window displays "Ok" button colour
  is light green colour - clicking the "Ok" button turns the button
  colour to dark blue colour as expected for "Primary school" theme

  Expected result: Primary button colour should be light blue colour
  #0162a7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756736/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] Re: Make SmartEvidence strings for statuses configurable

2018-03-22 Thread Cecilia Vela Gurovic
** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8699
Committed: 
https://git.mahara.org/mahara/mahara/commit/8d4c658d338978e2324ae4c34aa61d30df12a5a1
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:18.04_STABLE

commit 8d4c658d338978e2324ae4c34aa61d30df12a5a1
Author: Robert Lyon 
Date:   Fri Mar 16 13:24:25 2018 +1300

Bug 1754207: Allowing the actual assessment title for screenreader text

That is supplied by the matrix file

behatnotneeded

Change-Id: Ie5ee81a4f71d89bb7c891d6e2a318b70e0047b3b
Signed-off-by: Robert Lyon 
(cherry picked from commit 69f086dcc8bf65430f93b2696ddb0d836bf6348f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] Re: Set password policy explicitly during install

2018-03-22 Thread Cecilia Vela Gurovic
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8702

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8698
Committed: 
https://git.mahara.org/mahara/mahara/commit/24a98bdc620c291f5ee390c89886bf0cabccb68b
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 24a98bdc620c291f5ee390c89886bf0cabccb68b
Author: Robert Lyon 
Date:   Fri Mar 23 08:21:12 2018 +1300

Bug 1758139: Set password policy explicitly during install

behatnotneeded

Change-Id: I4e173da5a289ba0106c29fed3dff234d92dfb175
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758135] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8697
Committed: 
https://git.mahara.org/mahara/mahara/commit/7e85d7ff613a9ecc014440d81319e8fbf1f732eb
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 7e85d7ff613a9ecc014440d81319e8fbf1f732eb
Author: Robert Lyon 
Date:   Thu Mar 22 18:59:45 2018 +1300

Bug 1758135: Avoid overflow when dragging block choice

This happens for long named blocks, eg creative commons license

behatnotneeded

Change-Id: Ib980431e505857393acb5540e3b998893759eba7
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758135

Title:
  Long block titles overflow block title area when dragging

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When a block title is very long, e.g. the Creative Commons block, then
  the text overflows the boundary of the drag area. This is a fix for it
  so that the text stays within the boundaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758135] Re: Long block titles overflow block title area when dragging

2018-03-22 Thread Cecilia Vela Gurovic
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758135

Title:
  Long block titles overflow block title area when dragging

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When a block title is very long, e.g. the Creative Commons block, then
  the text overflows the boundary of the drag area. This is a fix for it
  so that the text stays within the boundaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758135] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8701

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758135

Title:
  Long block titles overflow block title area when dragging

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When a block title is very long, e.g. the Creative Commons block, then
  the text overflows the boundary of the drag area. This is a fix for it
  so that the text stays within the boundaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758181] [NEW] resume details page displays extra div field

2018-03-22 Thread Steven
Public bug reported:

Environment tested: Master
Browser tested: MS Edge (Virtualbox)

===
Manual Test Script
===

1) user has a portfolio page with one resume field block that is set to retract 
on it 
2) user views Page displayed 
3) user clicks the details link just below the one resume field block
4) user is redirected to a page only showing the one resume field block

Actual result: Page is displayed with the one resume field block and is
retracted.✔ Just under the block area is a very light grey background
section on the page ✘


Expected result: Light grey background section should not be displayed because 
this artefact cannot have a comment.

NOTE: 
- this also happens when you have a page that does not allow comments. (could 
be any page without comments)
- this is visible in themes that have a background for the comment area 

Catalyst QA

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: front-end

** Attachment added: "Extra footer container_23_03_18_10:15:46.png"
   
https://bugs.launchpad.net/bugs/1758181/+attachment/5087569/+files/Extra%20footer%20container_23_03_18_10%3A15%3A46.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758181

Title:
  resume details page displays extra div field

Status in Mahara:
  New

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)

  ===
  Manual Test Script
  ===

  1) user has a portfolio page with one resume field block that is set to 
retract on it 
  2) user views Page displayed 
  3) user clicks the details link just below the one resume field block
  4) user is redirected to a page only showing the one resume field block

  Actual result: Page is displayed with the one resume field block and
  is retracted.✔ Just under the block area is a very light grey
  background section on the page ✘

  
  Expected result: Light grey background section should not be displayed 
because this artefact cannot have a comment.

  NOTE: 
  - this also happens when you have a page that does not allow comments. (could 
be any page without comments)
  - this is visible in themes that have a background for the comment area 

  Catalyst QA

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758181/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758153] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8700

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758153

Title:
  There are 'aria-label' values that are not being translated

Status in Mahara:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress

Bug description:
  For accessibility we use 'aria-label' in some places but we've
  hardcoded the values in English

  We should also allow these values to be translated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758153/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758153] [NEW] There are 'aria-label' values that are not being translated

2018-03-22 Thread Robert Lyon
Public bug reported:

For accessibility we use 'aria-label' in some places but we've hardcoded
the values in English

We should also allow these values to be translated

** Affects: mahara
 Importance: Medium
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Affects: mahara/18.04
 Importance: Medium
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Affects: mahara/18.10
 Importance: Medium
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Also affects: mahara/18.04
   Importance: Undecided
   Status: New

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.10
   Status: New => In Progress

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/18.04
   Importance: Undecided => Medium

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/18.04
Milestone: None => 18.04.0

** Changed in: mahara/18.04
   Status: New => In Progress

** Changed in: mahara/18.04
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/18.10
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758153

Title:
  There are 'aria-label' values that are not being translated

Status in Mahara:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress

Bug description:
  For accessibility we use 'aria-label' in some places but we've
  hardcoded the values in English

  We should also allow these values to be translated

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758153/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] Re: Make SmartEvidence strings for statuses configurable

2018-03-22 Thread Cecilia Vela Gurovic
** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] A change has been merged

2018-03-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8637
Committed: 
https://git.mahara.org/mahara/mahara/commit/69f086dcc8bf65430f93b2696ddb0d836bf6348f
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 69f086dcc8bf65430f93b2696ddb0d836bf6348f
Author: Robert Lyon 
Date:   Fri Mar 16 13:24:25 2018 +1300

Bug 1754207: Allowing the actual assessment title for screenreader text

That is supplied by the matrix file

behatnotneeded

Change-Id: Ie5ee81a4f71d89bb7c891d6e2a318b70e0047b3b
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8699

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] Re: Set password policy explicitly during install

2018-03-22 Thread Robert Lyon
** Summary changed:

- Set password policy explicitely during install
+ Set password policy explicitly during install

** Changed in: mahara/18.10
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] A patch has been submitted for review

2018-03-22 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8698

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758139] [NEW] Set password policy explicitly during install

2018-03-22 Thread Kristina Hoeppner
Public bug reported:

In https://reviews.mahara.org/#/c/8685/ we only run the password reset
if no policy has been set. This needs to be expanded to explicitly set a
password policy during the installation to avoid password resets after
an ugprade.

How I came across this:
1. Created new empty database.
2. Checked out https://reviews.mahara.org/8693
3. Set new admin login and password.
4. Checked out https://reviews.mahara.org/8697
5. Right after login, I was asked to change the admin password again.

** Affects: mahara
 Importance: High
 Status: Confirmed

** Affects: mahara/18.04
 Importance: High
 Status: Confirmed

** Affects: mahara/18.10
 Importance: High
 Status: In Progress

** Also affects: mahara/18.04
   Importance: Undecided
   Status: New

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.10
   Status: New => Confirmed

** Changed in: mahara/18.04
   Status: New => Confirmed

** Changed in: mahara/18.10
   Importance: Undecided => High

** Changed in: mahara/18.04
   Importance: Undecided => High

** Changed in: mahara/18.10
Milestone: None => 18.10.0

** Changed in: mahara/18.04
Milestone: None => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758139

Title:
  Set password policy explicitly during install

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  In https://reviews.mahara.org/#/c/8685/ we only run the password reset
  if no policy has been set. This needs to be expanded to explicitly set
  a password policy during the installation to avoid password resets
  after an ugprade.

  How I came across this:
  1. Created new empty database.
  2. Checked out https://reviews.mahara.org/8693
  3. Set new admin login and password.
  4. Checked out https://reviews.mahara.org/8697
  5. Right after login, I was asked to change the admin password again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758139/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758135] [NEW] Long block titles overflow block title area when dragging

2018-03-22 Thread Kristina Hoeppner
Public bug reported:

When a block title is very long, e.g. the Creative Commons block, then
the text overflows the boundary of the drag area. This is a fix for it
so that the text stays within the boundaries.

** Affects: mahara
 Importance: Medium
 Status: Confirmed

** Affects: mahara/18.04
 Importance: Medium
 Status: Confirmed

** Affects: mahara/18.10
 Importance: Medium
 Status: In Progress

** Also affects: mahara/18.04
   Importance: Undecided
   Status: New

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.04
   Status: New => Confirmed

** Changed in: mahara/18.10
   Status: New => In Progress

** Changed in: mahara/18.04
   Importance: Undecided => Medium

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/18.04
Milestone: None => 18.04.0

** Changed in: mahara/18.10
Milestone: None => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758135

Title:
  Long block titles overflow block title area when dragging

Status in Mahara:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  When a block title is very long, e.g. the Creative Commons block, then
  the text overflows the boundary of the drag area. This is a fix for it
  so that the text stays within the boundaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754237] Re: SimpleSAML_Logger is deprecated warning

2018-03-22 Thread Kristina Hoeppner
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754237

Title:
  SimpleSAML_Logger is deprecated warning

Status in Mahara:
  In Progress

Bug description:
  There is a warning about:
  ssphp- WARNING [CL05234431] The class or interface 'SimpleSAML_Logger' is now 
using namespaces, please use 'SimpleSAML\Logger'.

  We need to update the config etc to use the new style of calling the
  logger

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754237/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758122] [NEW] Assign access to SmartEvidence framework from admin area

2018-03-22 Thread Kristina Hoeppner
Public bug reported:

At the moment, you need to assign an institution to a SmartEvidence framework 
if you want to restrict access to a certain group of people. This is inflexible 
because
- you can only assign one institution
- this cannot be changed
- setting up people in separate institutions may not always be possible

It would be better if it were possible to
- assign access to a SmartEvidence framework in the admin area
- give access to more than one institution
- give access to specific groups as well in institutions that don't have full 
access so that for example 1st year nursing students at a large university can 
gain access to one framework and 2nd year nursing students at the same 
university to another while engineering students see yet another framework.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed


** Tags: smartevidence

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758122

Title:
  Assign access to SmartEvidence framework from admin area

Status in Mahara:
  Confirmed

Bug description:
  At the moment, you need to assign an institution to a SmartEvidence framework 
if you want to restrict access to a certain group of people. This is inflexible 
because
  - you can only assign one institution
  - this cannot be changed
  - setting up people in separate institutions may not always be possible

  It would be better if it were possible to
  - assign access to a SmartEvidence framework in the admin area
  - give access to more than one institution
  - give access to specific groups as well in institutions that don't have full 
access so that for example 1st year nursing students at a large university can 
gain access to one framework and 2nd year nursing students at the same 
university to another while engineering students see yet another framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749402] Re: Views and collection list (in group) throws MySQL error

2018-03-22 Thread Alexander Del Ponte
Hi Kristina and Robert,

I had a look at the code and the warning is caused by trying to access
an object property on an array as the error message implies.

For my issue everything is working fine when supressing the on screen
display of warning messages, but I wonder, if the overall functionality
of this code part will be given.

When there is an 'id' field in the array, $v['id'] will have a value,
but $v->id won't and the loop will just continue with the next item.

However, thank you very much for your fast response and solution - Many 
greetings
Alex

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749402

Title:
  Views and collection list (in group) throws MySQL error

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  If a normal group member tries to visit views and collections of the
  group, following warning/error is thrown under some conditions which
  are mentioned below:

  SQL:
  [WAR] 93 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("dp-dev-master-ep"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" 
FOREIGN KEY ("view") REFERENCES "view" ("id"))] in EXECUTE("INSERT INTO 
"view_rows_columns" ("view", "row", "columns") VALUES ('46', '1', '3')")Command 
was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, 
?) and values was (view:46,row:1,columns:3)

  PHP:
  Call stack (most recent first):
  log_message("Failed to get a recordset: mysqli error: [1452: Ca...", 8, true, 
true) at /var/www/mahara/master/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: mysqli error: [1452: Ca...") at 
/var/www/mahara/master/htdocs/lib/errors.php:859
  SQLException->__construct("Failed to get a recordset: mysqli error: [1452: 
Ca...") at /var/www/mahara/master/htdocs/lib/dml.php:1105
  insert_record("view_rows_columns", object(stdClass), false, false) at 
/var/www/mahara/master/htdocs/lib/dml.php:1192
  ensure_record_exists("view_rows_columns", object(stdClass), object(stdClass)) 
at /var/www/mahara/master/htdocs/lib/view.php:356
  View->__construct(0array(size 25)) at 
/var/www/mahara/master/htdocs/lib/view.php:5581
  View::get_extra_view_info(array(size 2), false) at 
/var/www/mahara/master/htdocs/view/groupviews.php:52

  This happens if the group views and collections are readonly to
  members, a group collection exisits with at least one view inside and
  in the DB there is no view which has the same id as this collection.

  I didn't went too deep inside the code, but it seems that this issue
  is somehow connected to the bug #1514608.

  It further seems that Mahara interprets a collection as a view trying
  to get/set view related data using a collection id to avoid having no
  DB entry in table view_rows_columns for this erroneously supposed view
  so the actually error should be found in functions calling this code
  areas (get_extra_view_info).

  Reproduce error:
  Create a group in which views and collections are only editable by others 
that normal group members.
  Create a view and a collection inside this group and assign the view to the 
collection.
  Make sure, that in the DB there are no entries referring to a view which has 
the same id as the above created collection (e. g. by deleting a possibly 
existing view with this id inside Mahara).
  As a normal group member call the tab views and collection of the group.

  Greetings
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749402/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749403] Re: Code correction in function find_key_name of lib/ddl.php

2018-03-22 Thread Alexander Del Ponte
This bug also affects 17.10 and earlier.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749403

Title:
  Code correction in function find_key_name of lib/ddl.php

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In line 523 the existing code

  if (!$field == $col->column_name) {

  should be replaced with

  if ($field !== $col->column_name) {

  
  Greetings
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749403/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp