[Mahara-contributors] [Bug 1677068] Re: Move from X-Frame-Options to Content-Security-Policy

2018-04-16 Thread Cecilia Vela Gurovic
** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1677068

Title:
  Move from X-Frame-Options to Content-Security-Policy

Status in Mahara:
  Confirmed

Bug description:
  Currently one cannot embed Mahara within an iframe on third party site

  This is due to:
  X-Frame-Options = SAMEORIGIN
  (see: 
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options)

  And we can't allow specific external sites to embed mahara in an
  iframe (well at least not for all major browsers)

  But good news there is: Content-Security-Policy 
  (see: https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP)

  Where we can specify which domains are allowed to show which things

  But bad news - to get it to work we'd need to do bad things in relation to 
inline javascript
  (see: 
https://www.html5rocks.com/en/tutorials/security/content-security-policy/)

  Also we'd need to detect that we are in an external iframe before the
  page loads so we can set the headers to allow the correct external
  site (via init.php)

  Currently we set the headers after $session starts and before we enable the 
$USER object
  So we'd need to add something to detect that we are in an iframe on an 
external site and that site is allowed to do this.

  NOTE: some of our pages load in iframes themselves (via pieform
  submission)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1677068/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1763581] A patch has been submitted for review

2018-04-16 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8804

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1763581

Title:
  Capitalisation of username / email address issue with LTI

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed

Bug description:
  Mahara respects the capitalisation of usernames and email addresses
  when an external authentication source like LDAP, Active Directory, or
  a SAML IdP is connected. However, when accounts come from Canvas, they
  are all lowercase causing problems. Catalyst will fix this issue so
  that users are put into the same account no matter whether they come
  from an external authentication method of from Canvas via LTI.

  This is an issue because double accounts are set up otherwise.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1763581/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1762627] A change has been merged

2018-04-16 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8796
Committed: 
https://git.mahara.org/mahara/mahara/commit/417bb1866f316747cb98094a34c06a960edca18a
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 417bb1866f316747cb98094a34c06a960edca18a
Author: Robert Lyon 
Date:   Wed Apr 11 12:54:03 2018 +1200

Bug 1762627: Fix up the lang string for cli script

Make it more obvious what is happening and give examples of valid input

behatnotneeded

Change-Id: Ifb38faf2b4e113d39321b9f1d63e545260892364
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1762627

Title:
  Confusing  description on cli bulk user deletion (Bug 1760767)

Status in Mahara:
  Fix Committed

Bug description:
  I guess it's better to change the description for the cli bulk user
  deletion (Bug 1760767) as below.

  String ID: cli_deleteinactiveusers_beforedate

  String before:
  Delete users that have not logged in after this date

  String after:
  Delete users that have not logged in before this date

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1762627/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1762627] Re: Confusing description on cli bulk user deletion (Bug 1760767)

2018-04-16 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1762627

Title:
  Confusing  description on cli bulk user deletion (Bug 1760767)

Status in Mahara:
  Fix Committed

Bug description:
  I guess it's better to change the description for the cli bulk user
  deletion (Bug 1760767) as below.

  String ID: cli_deleteinactiveusers_beforedate

  String before:
  Delete users that have not logged in after this date

  String after:
  Delete users that have not logged in before this date

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1762627/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1763517] Re: Comments can't be deleted when work is submitted for marking

2018-04-16 Thread Kevin Dibble
Thanks Kristina,

My email address is: kevin.dib...@learningworks.co.nz

Cheers team,

Kevin

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1763517

Title:
  Comments can't be deleted when work is submitted for marking

Status in Mahara:
  In Progress

Bug description:
  Version:  Mahara 18.04.0
  Os: Mac
  Database: mysql
  Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

  Issue:
  When work is submitted for Marking, all comments and feedback during the 
marking process can be deleted by the user.

  Possible solution:
  While work is locked, to hide the delete comment form for annotation comments 
(Smart evidence feedback) and to check if work is in a submitted state before 
deleting page comments.

  Users can still show/hide comments from public as needed. Creators of
  comments can still edit them (during the edit timeframe), but will not
  be able to delete them while the page is under review.

  Attached is a patch with this possible solution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1763517/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749396] Re: Finnish translation pack missing strings

2018-04-16 Thread Urpo Karhula
I cannot translate strings that doesn't exist in;


https://translations.launchpad.net/mahara-lang/

These strings are missing from finnish language pack so I cannot
translate them;

$string['Blogs'] = 'Journals';
$string['Blog'] = 'Journal';

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749396

Title:
  Finnish translation pack missing strings

Status in Mahara:
  Invalid

Bug description:
  Hello,

  Finnish mahara translation packs (16.10 & 17.10 at);

  http://langpacks.mahara.org/

  are missing a translation strings

  $string['Blogs'] = 'Journals';
  $string['Blog'] = 'Journal';
   
  and by so Blogs doesn't translate at all. In the english language pack you 
have four of them 

  $string['Blogs'] = 'Journals';
  $string['blogs'] = 'journals';
  $string['Blogs'] = 'Journals';
  $string['blogs'] = 'journals';

  The ones with the capital B in the string name area the ones that
  affect the translation seen on the screen so could someone add them to
  the finnish language packs? I wonder why this have been done in such a
  weird way in the first place.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749396/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749396] Re: Finnish translation pack missing strings

2018-04-16 Thread Urpo Karhula
Hello,

In my opinion you can only translate existing strings in
https://translations.launchpad.net/mahara-lang/ but you cannot add whole
strings to the language packs, please check this again.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749396

Title:
  Finnish translation pack missing strings

Status in Mahara:
  Invalid

Bug description:
  Hello,

  Finnish mahara translation packs (16.10 & 17.10 at);

  http://langpacks.mahara.org/

  are missing a translation strings

  $string['Blogs'] = 'Journals';
  $string['Blog'] = 'Journal';
   
  and by so Blogs doesn't translate at all. In the english language pack you 
have four of them 

  $string['Blogs'] = 'Journals';
  $string['blogs'] = 'journals';
  $string['Blogs'] = 'Journals';
  $string['blogs'] = 'journals';

  The ones with the capital B in the string name area the ones that
  affect the translation seen on the screen so could someone add them to
  the finnish language packs? I wonder why this have been done in such a
  weird way in the first place.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749396/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp