[Mahara-contributors] [Bug 1723961] A change has been merged
Reviewed: https://reviews.mahara.org/8581 Committed: https://git.mahara.org/mahara/mahara/commit/c788dcc0f8a7f9160d1e6e207c507be956d0f73b Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit c788dcc0f8a7f9160d1e6e207c507be956d0f73b Author: Maria Sorica Date: Tue Mar 6 11:58:41 2018 + Bug 1723961: Allow user to edit tasks from blocktype 1. Each tasks has an edit, delete icon group. 2. Tasks can be marked as complete from the blocktype when the view is in edit mode. behatnotneeded Change-Id: If35431aa438802c3e299af05c84bf3c45cc8a8ac -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723961 Title: Edit plans more easily from a page Status in Mahara: Fix Committed Bug description: We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience. Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type. Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience: 1. a link to edit a plan instance (description, title, tags etc) 2. a link to add a new task to a plan instance 3. the ability to edit a task instance (description, title, tags, completion date etc) 4. the ability to mark a task as complete or incomplete from Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages. All editing functionality will only be available to the page owner and when in the editing page mode. In addition they have also requested the following functionality: - the ability to select more than one plan instance per blocktype to reduce the unique number of blocktypes required on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1723961] A change has been merged
Reviewed: https://reviews.mahara.org/8567 Committed: https://git.mahara.org/mahara/mahara/commit/bc40a45fe9befad860128f3b0785c8d2f90727e5 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit bc40a45fe9befad860128f3b0785c8d2f90727e5 Author: Maria Sorica Date: Mon Mar 5 15:34:07 2018 + Bug 1723961: Allow plan blocktypes to display more than one plan 1. Added a details link for each plan in the blocktype as well. 2. On site update, the existing plan blocktypes will be updated to be able to contain more than plan. 3. Made task pagination work on blocktypes with multiple plans. behatnotneeded Change-Id: I4b462f447489eb16d43fd40cfa552825c5178a47 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723961 Title: Edit plans more easily from a page Status in Mahara: Fix Committed Bug description: We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience. Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type. Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience: 1. a link to edit a plan instance (description, title, tags etc) 2. a link to add a new task to a plan instance 3. the ability to edit a task instance (description, title, tags, completion date etc) 4. the ability to mark a task as complete or incomplete from Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages. All editing functionality will only be available to the page owner and when in the editing page mode. In addition they have also requested the following functionality: - the ability to select more than one plan instance per blocktype to reduce the unique number of blocktypes required on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1723961] A change has been merged
Reviewed: https://reviews.mahara.org/8569 Committed: https://git.mahara.org/mahara/mahara/commit/01e988c2b61ac9fca23025ed3e5d832f67e2cf7a Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 01e988c2b61ac9fca23025ed3e5d832f67e2cf7a Author: Maria Sorica Date: Mon Mar 5 16:38:18 2018 + Bug 1723961: Add edit links for each plan in a block instance Each plan in a block instance will have a set of edit, delete and add task links to make the plan editing easier. behatnotneeded Change-Id: If4c9362906d894f4e4e6e0e9a2d59c640ede0506 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723961 Title: Edit plans more easily from a page Status in Mahara: Fix Committed Bug description: We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience. Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type. Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience: 1. a link to edit a plan instance (description, title, tags etc) 2. a link to add a new task to a plan instance 3. the ability to edit a task instance (description, title, tags, completion date etc) 4. the ability to mark a task as complete or incomplete from Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages. All editing functionality will only be available to the page owner and when in the editing page mode. In addition they have also requested the following functionality: - the ability to select more than one plan instance per blocktype to reduce the unique number of blocktypes required on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1723961] A change has been merged
Reviewed: https://reviews.mahara.org/8800 Committed: https://git.mahara.org/mahara/mahara/commit/f94180b43cf29b6cbb360c74d4dd492e2fd51e7d Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit f94180b43cf29b6cbb360c74d4dd492e2fd51e7d Author: Robert Lyon Date: Fri Apr 13 09:08:21 2018 +1200 Bug 1723961: Allow update status of plan task via normal page display If the viewer is the owner of the page. This hooks into the functionality used on the edit screen Also added some padding to 'tags' div within a panel Also changed the javascript call from being an inline html onclick to being done via jQuery - allowing us to capture the event and stop the expander event from being triggered behatnotneeded Change-Id: I866486493dacb5c48878c539dbbbde3e841d8b91 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723961 Title: Edit plans more easily from a page Status in Mahara: Fix Committed Bug description: We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience. Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type. Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience: 1. a link to edit a plan instance (description, title, tags etc) 2. a link to add a new task to a plan instance 3. the ability to edit a task instance (description, title, tags, completion date etc) 4. the ability to mark a task as complete or incomplete from Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages. All editing functionality will only be available to the page owner and when in the editing page mode. In addition they have also requested the following functionality: - the ability to select more than one plan instance per blocktype to reduce the unique number of blocktypes required on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1723961] Re: Edit plans more easily from a page
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723961 Title: Edit plans more easily from a page Status in Mahara: Fix Committed Bug description: We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience. Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type. Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience: 1. a link to edit a plan instance (description, title, tags etc) 2. a link to add a new task to a plan instance 3. the ability to edit a task instance (description, title, tags, completion date etc) 4. the ability to mark a task as complete or incomplete from Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages. All editing functionality will only be available to the page owner and when in the editing page mode. In addition they have also requested the following functionality: - the ability to select more than one plan instance per blocktype to reduce the unique number of blocktypes required on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1766041] Re: Password policy setting for only upper and lowercase letters doesn't require uppercase
** Changed in: mahara/18.10 Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1766041 Title: Password policy setting for only upper and lowercase letters doesn't require uppercase Status in Mahara: Confirmed Status in Mahara 18.04 series: Confirmed Status in Mahara 18.10 series: Confirmed Bug description: Reported at https://mahara.org/interaction/forum/topic.php?id=8232 When the password policy is set to just upper and lowercase characters and a minimum of 8 letters, the following password is accepted even though it doesn't contain an uppercase letter: maggie12 It seems that uppercase letters are ignored in all scenarios for the password policy and a password is created when they are absent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1766041/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1723961] Re: Edit plans more easily from a page
The two issues were fixed in a subsequent patchset. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723961 Title: Edit plans more easily from a page Status in Mahara: In Progress Bug description: We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience. Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type. Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience: 1. a link to edit a plan instance (description, title, tags etc) 2. a link to add a new task to a plan instance 3. the ability to edit a task instance (description, title, tags, completion date etc) 4. the ability to mark a task as complete or incomplete from Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages. All editing functionality will only be available to the page owner and when in the editing page mode. In addition they have also requested the following functionality: - the ability to select more than one plan instance per blocktype to reduce the unique number of blocktypes required on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1763517] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8810 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1763517 Title: Comments can't be deleted when work is submitted for marking Status in Mahara: In Progress Bug description: Version: Mahara 18.04.0 Os: Mac Database: mysql Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit) Issue: When work is submitted for Marking, all comments and feedback during the marking process can be deleted by the user. Possible solution: While work is locked, to hide the delete comment form for annotation comments (Smart evidence feedback) and to check if work is in a submitted state before deleting page comments. Users can still show/hide comments from public as needed. Creators of comments can still edit them (during the edit timeframe), but will not be able to delete them while the page is under review. Attached is a patch with this possible solution. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1763517/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1702748] Re: View ID appended at download URL from another Mahara site
** Changed in: mahara/18.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1702748 Title: View ID appended at download URL from another Mahara site Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: Checked in 16.10 -> 17.04 When you have a public file on one Mahara site, link that for example in a journal entry on another Mahara site and make the page public, the file gets the viewID of that page appended even though there is no reason for it. It seems that Mahara only checks that /artefact/file/download.php?file= is present no matter the domain and then simply appends the viewID. To replicate: 1. Log into Mahara instance 1. 2. Upload a file into Admin menu -> Configure site -> Files -> Public. 3. Add the file to the public menu (to ensure that you are copying the correct download link that is available to people when not logged in): Admin menu -> Configure site -> Menus -> Public... 4. Copy the file's location. It should look something like http://domain.tld/artefact/file/download.php?file= 5. Log out of Mahara instance 1. 6. Log into Mahara instance 2. 7. Write a journal entry and link some text to the file. Save the entry. 8. Add your journal to a page and make it public. 9. View the page and hover over the link. Expected result: The link looks exactly the same as before and you can reach the file as it is a public one. Actual result: The link has a viewID appended, e.g. http://domain.tld/artefact/file/download.php?file=&view=YYY and if you are not logged into Mahara instance 1, you can't view it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1702748/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1702748] A change has been merged
Reviewed: https://reviews.mahara.org/8794 Committed: https://git.mahara.org/mahara/mahara/commit/b739c1e8d82d335c9aa4dd812872b36095e93903 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit b739c1e8d82d335c9aa4dd812872b36095e93903 Author: Robert Lyon Date: Tue Apr 10 14:14:31 2018 +1200 Bug 1702748: append_view_url() needs to respect site Currently there is a regex to append the view id to the embedded url But it doesn't take into account the domain of the site If you use a link from anther mahara it tries to append the viewid of the page the link is being used in causing confusion behatnotneeded Change-Id: Iece12b1c993d53cdf48e13da16af1156e3ddc9e2 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1702748 Title: View ID appended at download URL from another Mahara site Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: Checked in 16.10 -> 17.04 When you have a public file on one Mahara site, link that for example in a journal entry on another Mahara site and make the page public, the file gets the viewID of that page appended even though there is no reason for it. It seems that Mahara only checks that /artefact/file/download.php?file= is present no matter the domain and then simply appends the viewID. To replicate: 1. Log into Mahara instance 1. 2. Upload a file into Admin menu -> Configure site -> Files -> Public. 3. Add the file to the public menu (to ensure that you are copying the correct download link that is available to people when not logged in): Admin menu -> Configure site -> Menus -> Public... 4. Copy the file's location. It should look something like http://domain.tld/artefact/file/download.php?file= 5. Log out of Mahara instance 1. 6. Log into Mahara instance 2. 7. Write a journal entry and link some text to the file. Save the entry. 8. Add your journal to a page and make it public. 9. View the page and hover over the link. Expected result: The link looks exactly the same as before and you can reach the file as it is a public one. Actual result: The link has a viewID appended, e.g. http://domain.tld/artefact/file/download.php?file=&view=YYY and if you are not logged into Mahara instance 1, you can't view it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1702748/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1745014] A change has been merged
Reviewed: https://reviews.mahara.org/8465 Committed: https://git.mahara.org/mahara/mahara/commit/dd959f0c956475cc4aa7a8d9ac60c80ef76212dc Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit dd959f0c956475cc4aa7a8d9ac60c80ef76212dc Author: Robert Lyon Date: Wed Jan 24 09:08:28 2018 +1300 Bug 1745014: Allow page search 'tags only' to take a list of tags Tags will be separated by a comma and a checkbox will allow the choice of 'match all' tags (when checked) versus 'match any' tags (when unchecked) behatnotneeded Change-Id: Icf9235e96a0352da423c57571b304d051f8258ce Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1745014 Title: Allow page search 'tags only' option handle multiple tags Status in Mahara: Fix Committed Bug description: So that we can find a page that contains a set of specific tags, eg search for 'red,square,thin' will find the pages only with those tags. As per https://mahara.org/interaction/forum/topic.php?id=8153&offset=0&limit=10#post32681 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1745014/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1745014] Re: Allow page search 'tags only' option handle multiple tags
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1745014 Title: Allow page search 'tags only' option handle multiple tags Status in Mahara: Fix Committed Bug description: So that we can find a page that contains a set of specific tags, eg search for 'red,square,thin' will find the pages only with those tags. As per https://mahara.org/interaction/forum/topic.php?id=8153&offset=0&limit=10#post32681 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1745014/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
