[Mahara-contributors] [Bug 1765276] Re: Upgrade to Bootstrap 4
One thing I've noticed is when a user uploads files to their files area the last one to be uploaded is highlighted with a grey background - however there is an issue where the 'description' column is not fully grey - see attached ** Attachment added: "Screenshot-of-white-block-in-description-row.png" https://bugs.launchpad.net/mahara/+bug/1765276/+attachment/5248689/+files/Screenshot-of-white-block-in-description-row.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1765276 Title: Upgrade to Bootstrap 4 Status in Mahara: In Progress Bug description: Bootstrap 4 has been released. We should upgrade. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1771774] A change has been merged
Reviewed: https://reviews.mahara.org/9504
Committed:
https://git.mahara.org/mahara/mahara/commit/c2ef805b6c7523802bb8777f4a0ce60aa65f4540
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit c2ef805b6c7523802bb8777f4a0ce60aa65f4540
Author: bobthevirus
Date: Wed Jan 30 14:55:51 2019 +1300
Bug 1771774: Allow override of externallogin redirect
When trying to hit a non homepage page where login is required
behatnotneeded
Change-Id: Ia52dff12c16dd58304bbe9251723311e3b18325e
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1771774
Title:
No way to bypass externallogin
Status in Mahara:
Fix Committed
Bug description:
When the externallogin setting is turned on, it's impossible to fix
things such as metadata URLs etc which are required for some external
logins to work.
It would be good to be able to pass in a special URL parameter to make
Mahara skip the external login process. Here is a patch which I can
push up to gerrit once someone confirms that the proposed change is
useful and that the url parameter is unique enough:
diff --git a/htdocs/auth/lib.php b/htdocs/auth/lib.php
index 779d080352..4baf2c7875 100644
--- a/htdocs/auth/lib.php
+++ b/htdocs/auth/lib.php
@@ -1171,7 +1171,7 @@ function auth_draw_login_page($message=null, Pieform
$form=null) {
}
$externallogin = get_config('externallogin');
-if ($externallogin) {
+if ($externallogin && !isset($_GET['internallogin'])) {
$externallogin = preg_replace('/{shorturlencoded}/',
urlencode(get_relative_script_path()), $externallogin);
$externallogin = preg_replace('/{wwwroot}/', get_config('wwwroot'),
$externallogin);
redirect($externallogin);
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1771774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1771774] Re: No way to bypass externallogin
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1771774
Title:
No way to bypass externallogin
Status in Mahara:
Fix Committed
Bug description:
When the externallogin setting is turned on, it's impossible to fix
things such as metadata URLs etc which are required for some external
logins to work.
It would be good to be able to pass in a special URL parameter to make
Mahara skip the external login process. Here is a patch which I can
push up to gerrit once someone confirms that the proposed change is
useful and that the url parameter is unique enough:
diff --git a/htdocs/auth/lib.php b/htdocs/auth/lib.php
index 779d080352..4baf2c7875 100644
--- a/htdocs/auth/lib.php
+++ b/htdocs/auth/lib.php
@@ -1171,7 +1171,7 @@ function auth_draw_login_page($message=null, Pieform
$form=null) {
}
$externallogin = get_config('externallogin');
-if ($externallogin) {
+if ($externallogin && !isset($_GET['internallogin'])) {
$externallogin = preg_replace('/{shorturlencoded}/',
urlencode(get_relative_script_path()), $externallogin);
$externallogin = preg_replace('/{wwwroot}/', get_config('wwwroot'),
$externallogin);
redirect($externallogin);
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1771774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
