[Mahara-contributors] [Bug 1821859] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9676
Committed: 
https://git.mahara.org/mahara/mahara/commit/f127f134cfd499daab6f9a6cf044487b703fdccb
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit f127f134cfd499daab6f9a6cf044487b703fdccb
Author: Lisa Seeto 
Date:   Thu Mar 28 16:00:04 2019 +1300

Bug 1821859: Remove "Add to friends" text on new page header button

updated the pieform to conditionally display the button label
added title to the forms button element

behatnotneeded

Change-Id: I8ccbb92b64680b0d33a33ea27671bd2a21855a77
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821859

Title:
  Remove "Add to friends" text on new page header button

Status in Mahara:
  Fix Committed

Bug description:
  Follow-on to bug #1815829:

  Problem only on Mahara master (soon to be 19.04):

  There is still the button label "Add to friends" on the profile page
  of a user when they allow friends to be auto-added. This shouldn't be
  the case. We should only see the icon and the text should be there as
  tool tip.

  To replicate:

  1. Set up two users.
  2. User 1 should have the account setting "Friends control" set to "New 
friends are automatically authorised".
  3. Log in as user 2 and go to the profile page of user 1.
  4. Actual result: You see the button "Add to friends" with icon and text (see 
attached screenshot).
 Expected result: You see the button only with the icon and the text is in 
a tool tip that you see when you hover over it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821859/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1821859] Re: Remove "Add to friends" text on new page header button

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821859

Title:
  Remove "Add to friends" text on new page header button

Status in Mahara:
  Fix Committed

Bug description:
  Follow-on to bug #1815829:

  Problem only on Mahara master (soon to be 19.04):

  There is still the button label "Add to friends" on the profile page
  of a user when they allow friends to be auto-added. This shouldn't be
  the case. We should only see the icon and the text should be there as
  tool tip.

  To replicate:

  1. Set up two users.
  2. User 1 should have the account setting "Friends control" set to "New 
friends are automatically authorised".
  3. Log in as user 2 and go to the profile page of user 1.
  4. Actual result: You see the button "Add to friends" with icon and text (see 
attached screenshot).
 Expected result: You see the button only with the icon and the text is in 
a tool tip that you see when you hover over it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821859/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756182] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9669
Committed: 
https://git.mahara.org/mahara/mahara/commit/c69b66599afc11c8d3d4f8ad85f6c5992f991982
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit c69b66599afc11c8d3d4f8ad85f6c5992f991982
Author: Lisa Seeto 
Date:   Wed Mar 27 13:14:10 2019 +1300

Bug 1756182: delete icon not needed for primary email address

delete button for email will not be created if it is the primary email address
updated css, tpl files to reflect new design changes

behatnotneeded

Change-Id: I48d44293d5c6519a7eaaa275dda902126029054e
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756182

Title:
  delete icon not needed for primary email address

Status in Mahara:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: Chrome

  ===
  Manual Test Script
  ===

  1) user browse to Main menu > Profile > Contact information 
  2) User adds multiple email addresses 
  3) User tries to delete primary email address 

  Actual Result: error message is displayed "You cannot remove your
  primary email address."

  Expected Result: If user cannot delete a primary email address, then
  the delete icon next to the primary email should not be displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756182/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1756182] Re: delete icon not needed for primary email address

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
Milestone: None => 19.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1756182

Title:
  delete icon not needed for primary email address

Status in Mahara:
  Fix Committed

Bug description:
  Environment tested: Master
  Browser tested: Chrome

  ===
  Manual Test Script
  ===

  1) user browse to Main menu > Profile > Contact information 
  2) User adds multiple email addresses 
  3) User tries to delete primary email address 

  Actual Result: error message is displayed "You cannot remove your
  primary email address."

  Expected Result: If user cannot delete a primary email address, then
  the delete icon next to the primary email should not be displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1756182/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1212095] Re: The content of text boxes should be reset when clicking 'cancel' button

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
Milestone: None => 19.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1212095

Title:
  The content of text boxes should be reset when clicking 'cancel'
  button

Status in Mahara:
  Fix Committed

Bug description:
  Version: all
  Platform: all

  In many places of Mahara, e.g. 'Content/Resume/Interest', when an user
  clicks 'Cancel' button, the content should be reset to the initial
  value.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1212095/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1212095] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9674
Committed: 
https://git.mahara.org/mahara/mahara/commit/09ef3aad8ba459e044b2ca3f7cc49f9782901787
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 09ef3aad8ba459e044b2ca3f7cc49f9782901787
Author: Lisa Seeto 
Date:   Thu Mar 28 10:18:51 2019 +1300

Bug 1212095: The content of text boxes should be reset when clicking
'cancel' button

set content back to original content on cancellation via tinyMCE

behatnotneeded

Change-Id: I58c25cac88b437cb9eded3a9849ddef9bb0f5b9f
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1212095

Title:
  The content of text boxes should be reset when clicking 'cancel'
  button

Status in Mahara:
  Fix Committed

Bug description:
  Version: all
  Platform: all

  In many places of Mahara, e.g. 'Content/Resume/Interest', when an user
  clicks 'Cancel' button, the content should be reset to the initial
  value.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1212095/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1814621] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9682
Committed: 
https://git.mahara.org/mahara/mahara/commit/85e8d1bcf0f5411b417542c3a25aafa54e36
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 85e8d1bcf0f5411b417542c3a25aafa54e36
Author: Cecilia Vela Gurovic 
Date:   Fri Mar 29 15:15:30 2019 +1300

Bug 1814621: Updating steps in friends.feature

Change-Id: If122d14a6d64b83aea07d313c458710b4db7aca0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1814621

Title:
  Consolidate "My friends" and "Find people" screens

Status in Mahara:
  Fix Committed

Bug description:
  This is similar to bug #1813500.

  1. The base template of "People" is "Find people" as it contains most
  of the functionality that we need. The new URL will be
  /people/index.php

  2. To be added to that page: The filter options to filter for friends.
  The filter title is "Filter friends".

  3. The "Search" filter options stay as they are.

  4. When friend requests have been made, at the top on the right-hand
  side above "Send message", you see "Pending friend" and below that
  there are two buttons (the small size): "Approve" and "Deny" (with
  their respective current icon).

  5. The main menu navigation item will be "People".

  6. Consolidate the help icon text.

  7. The "Help" link in the footer will need to change once I've updated
  the user manual.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1814621/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822224] Re: File extract zip page has 'quota' error

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/184

Title:
  File extract zip page has 'quota' error

Status in Mahara:
  In Progress

Bug description:
  Trying to set the same sideblock twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/184/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822224] A patch has been submitted for review

2019-03-28 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9684

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/184

Title:
  File extract zip page has 'quota' error

Status in Mahara:
  In Progress

Bug description:
  Trying to set the same sideblock twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/184/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822224] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9683
Committed: 
https://git.mahara.org/mahara/mahara/commit/6d48f277b1d772fe29020d1bf4e7e084c0580423
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 6d48f277b1d772fe29020d1bf4e7e084c0580423
Author: Robert Lyon 
Date:   Fri Mar 29 15:41:21 2019 +1300

Bug 184: Stop trying to set quota block twice

behatnotneeded

Change-Id: I83b1067e9b90a36868be669ebb5aedb9d3435ef3
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/184

Title:
  File extract zip page has 'quota' error

Status in Mahara:
  Fix Committed

Bug description:
  Trying to set the same sideblock twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/184/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822224] A patch has been submitted for review

2019-03-28 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9683

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/184

Title:
  File extract zip page has 'quota' error

Status in Mahara:
  Fix Committed

Bug description:
  Trying to set the same sideblock twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/184/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822224] [NEW] File extract zip page has 'quota' error

2019-03-28 Thread Robert Lyon
Public bug reported:

Trying to set the same sideblock twice

** Affects: mahara
 Importance: High
 Status: Fix Committed


** Tags: regression

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => High

** Tags added: regression

** Changed in: mahara
Milestone: None => 19.04.0

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/184

Title:
  File extract zip page has 'quota' error

Status in Mahara:
  Fix Committed

Bug description:
  Trying to set the same sideblock twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/184/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1814621] A patch has been submitted for review

2019-03-28 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9682

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1814621

Title:
  Consolidate "My friends" and "Find people" screens

Status in Mahara:
  Fix Committed

Bug description:
  This is similar to bug #1813500.

  1. The base template of "People" is "Find people" as it contains most
  of the functionality that we need. The new URL will be
  /people/index.php

  2. To be added to that page: The filter options to filter for friends.
  The filter title is "Filter friends".

  3. The "Search" filter options stay as they are.

  4. When friend requests have been made, at the top on the right-hand
  side above "Send message", you see "Pending friend" and below that
  there are two buttons (the small size): "Approve" and "Deny" (with
  their respective current icon).

  5. The main menu navigation item will be "People".

  6. Consolidate the help icon text.

  7. The "Help" link in the footer will need to change once I've updated
  the user manual.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1814621/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1765276] Re: Upgrade to Bootstrap 4

2019-03-28 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765276

Title:
  Upgrade to Bootstrap 4

Status in Mahara:
  Fix Committed

Bug description:
  Bootstrap 4 has been released. We should upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1765276] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9668
Committed: 
https://git.mahara.org/mahara/mahara/commit/57a9051ed5b32c734e18c495ac86ff9feb6fee1b
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 57a9051ed5b32c734e18c495ac86ff9feb6fee1b
Author: Evonne Cheung 
Date:   Wed Mar 27 13:03:24 2019 +1300

Bug 1765276: Padding alignment

Adjusting padding of card-secondary header and body to be
flushed with margin, with exception of list-group.

behatnotneeded

Change-Id: If8a3193365c7b2e307149bd780a008e727b6c164

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765276

Title:
  Upgrade to Bootstrap 4

Status in Mahara:
  Fix Committed

Bug description:
  Bootstrap 4 has been released. We should upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] Re: Two $string['portfolio'] language strings in view.php lang file

2019-03-28 Thread Robert Lyon
** Changed in: mahara/17.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: In Progress => Fix Committed

** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9681
Committed: 
https://git.mahara.org/mahara/mahara/commit/a99b9b21dd2407283228ba11e0eee8b9fbed1d54
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.10_STABLE

commit a99b9b21dd2407283228ba11e0eee8b9fbed1d54
Author: Robert Lyon 
Date:   Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon 
(cherry picked from commit 11534107429252db169e7445dd31f53e4d9c27a7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9679
Committed: 
https://git.mahara.org/mahara/mahara/commit/b4322aa81a7f7512679e318acaf3b1ec041e62e3
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.10_STABLE

commit b4322aa81a7f7512679e318acaf3b1ec041e62e3
Author: Robert Lyon 
Date:   Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon 
(cherry picked from commit 11534107429252db169e7445dd31f53e4d9c27a7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9680
Committed: 
https://git.mahara.org/mahara/mahara/commit/750dac4b7693ad933658236ff4f0a8e1ce4c6ff9
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 750dac4b7693ad933658236ff4f0a8e1ce4c6ff9
Author: Robert Lyon 
Date:   Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon 
(cherry picked from commit 11534107429252db169e7445dd31f53e4d9c27a7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] Re: Two $string['portfolio'] language strings in view.php lang file

2019-03-28 Thread Steven
Environment tested: Master
Browser tested: Chrome

Scenario 1 -Site admin creates group and enables 'participation report'

PRECONDITIONS: 
 
1) Site admin exists
2) Site admin creates a "Site Participate Group" and 'participation report' is 
enabled
3) Reports page (admin -> reports) = Report configuration = All institutions 
and Report type is set to Overview


TEST STEPS: 
 
1) Log in as Site admin 
2) Browse to "Site Participate Group" report page 
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)
4) Site admin Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔ (note Upper case P)



Scenario 2 -Inst admin creates group and enables 'participation report'

PRECONDITIONS: 
 
1) User1 exists and is an Institution One admin
2) Institution One exists 
3) Institution One admin creates "Participate Group" and 'participation report' 
is enabled 
4) "Participate Group" exists and has the following members
  a) User1 - admin - has not added group page
  b) User3 - member - has added group page also has created a portfolio page 
  c) User4 - member - has not added group page  
5) Reports page (admin -> reports) = Report configuration = Institution One and 
Report type is set to Overview

TEST STEPS: 
 
1) Log in as User1 
2) Browse to "Participate Group" report page 
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)

NOTE: The following must be run before the graph displays
  a) Force the cron to run the daily stats by running this command in 
database:  UPDATE cron SET nextrun = NULL;
  b)  In a terminal run:  sudo -u www-data php htdocs/lib/cron.php

4) User1 Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔

Further Testing
-
Run the above test scripts on the following versions
a) 18.10_STABLE ✔
b) 18.04_STABLE ✔
c) 17.10_STABLE  ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1806524] Re: edit page has duplicated "addblock" in html tags

2019-03-28 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1806524

Title:
  edit page has duplicated "addblock" in html tags

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  when editing a page, if we inspect the html we can see there are two elements 
with the id="addblock". All id's in html tags should be unique.
  We need to fix this either for the form that pop's up when adding a block to 
the page by clicking on the block menu, or fix it for the modal that contains 
it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1806524/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1807616] Re: Styling needed for friendship attention message panel-warning block on the requester's profile page

2019-03-28 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Importance: Medium => Low

** Changed in: mahara
   Status: In Progress => Opinion

** Changed in: mahara
Milestone: 19.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1807616

Title:
  Styling needed for friendship attention message panel-warning block on
  the requester's profile page

Status in Mahara:
  Opinion

Bug description:
  Bug Summary: 
  When viewing the profile page of a user that has requested friendship, the 
Approve/Deny block is displayed at the top of the page, This display needs to 
be styled better as it takes up way too much room on the page.

  ===

  Environment tested: Master
  Browser tested: Chrome

  Preconditions: 
   
  1) UserA has requested friendship of UserB

  Test Steps: 
   
  1) Log in as UserB 
  2) Browse to UserA profile page 

  Expected result: attention message panel-warning block is displayed

  Actual result: attention message panel-warning block is displayed but
  there is too much space used up and is not aesthetically pleasing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1807616/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1775479] Re: obsolete code for displaying comments

2019-03-28 Thread Cecilia Vela Gurovic
** Changed in: mahara
Milestone: 19.04.0 => 19.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1775479

Title:
  obsolete code for displaying comments

Status in Mahara:
  In Progress

Bug description:
  We have old code not used anymore for displaying comment list from a text note
  in view/view.php ln 308

  It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in
  15.04

  for 
"Adjusting the textbox so it can show/hide comments (Bug #1037531)
  
  The comments will be displayed (or hidden) below the block by clicking
  on the 'Comments (x)' link. There is also a 'close' link at the bottom
  of the comment list as well to close them."

  We don't use this anymore since now, when clicking on coment(x) link,
  they are displayed in a right side modal panel.

  We have to check what other obsolete related code we need to clean.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1775479/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A patch has been submitted for review

2019-03-28 Thread Mahara Bot
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9679

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A patch has been submitted for review

2019-03-28 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9680

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A patch has been submitted for review

2019-03-28 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9681

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9640
Committed: 
https://git.mahara.org/mahara/mahara/commit/11534107429252db169e7445dd31f53e4d9c27a7
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 11534107429252db169e7445dd31f53e4d9c27a7
Author: Robert Lyon 
Date:   Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1804243] Re: Plan tasks are shown on timeline even when they didn't exist at the time

2019-03-28 Thread Steven
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
 
1) Mahara User exists (no roles)
2) User Plan exists with 2 tasks 
3) Portfolio page exists and has a Plan block
4) Portfolio page has been saved to a "Timeline" for the page 

TEST STEPS: 
 
1) Log in as Mahara User 
2) User add a task to the User plan 
3) User browse to the Portfolio page with the plan block in display view
4) Verify that a 3rd task is displayed in the plan block ✔
5) Click the view time line 
6) Verify that the page displayed only displays the first 2 task it has when 
saved to the timeline ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1804243

Title:
  Plan tasks are shown on timeline even when they didn't exist at the
  time

Status in Mahara:
  In Progress
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  In Progress

Bug description:
  New plan tasks appear in the timeline even when the tasks did not
  exist at the time of the snapshot.

  To replicate:

  1. Set up a plan with 2 task.
  2. Add the plan to a page and save the page to the timeline.
  3. Add another task to the plan.
  (4. Save the new state to the timeline.)
  Expected result: The third task does not appear in the first timeline item.
  Actual result: All tasks are shown no matter the version of the portfolio 
page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1804243/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] Re: Two $string['portfolio'] language strings in view.php lang file

2019-03-28 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: In Progress => Fix Committed

** Changed in: mahara/17.10
   Status: New => In Progress

** Changed in: mahara/18.04
   Status: New => In Progress

** Changed in: mahara/18.10
   Status: New => In Progress

** Changed in: mahara/17.10
   Importance: Undecided => Medium

** Changed in: mahara/18.04
   Importance: Undecided => Medium

** Changed in: mahara/18.10
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820927] Re: Two $string['portfolio'] language strings in view.php lang file

2019-03-28 Thread Steven
Environment tested: Master
Browser tested: Chrome

Scenario 1 -Site admin creates group and enables 'participation report'

PRECONDITIONS: 
 
1) Site admin exists
2) Site admin creates a "Site Participate Group" and 'participation report' is 
enabled
3) Reports page (admin -> reports) = Report configuration = All institutions 
and Report type is set to Overview


TEST STEPS: 
 
1) Log in as Site admin 
2) Browse to "Site Participate Group" report page 
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)
4) Site admin Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔ (note Upper case P)



Scenario 2 -Inst admin creates group and enables 'participation report'

PRECONDITIONS: 
 
1) User1 exists and is an Institution One admin
2) Institution One exists 
3) Institution One admin creates "Participate Group" and 'participation report' 
is enabled 
4) "Participate Group" exists and has the following members
  a) User1 - admin - has not added group page
  b) User3 - member - has added group page also has created a portfolio page 
  c) User4 - member - has not added group page  
5) Reports page (admin -> reports) = Report configuration = Institution One and 
Report type is set to Overview

TEST STEPS: 
 
1) Log in as User1 
2) Browse to "Participate Group" report page 
3) Verify that the page mentions 1 portfolio ✔ (note Lower case p)
4) User1 Browse to admin -> reports page
5) Verify the 'Pages by type' graph has 'Portfolio' ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  New
Status in Mahara 18.04 series:
  New
Status in Mahara 18.10 series:
  New
Status in Mahara 19.04 series:
  In Progress

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say 
'1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1765276] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9651
Committed: 
https://git.mahara.org/mahara/mahara/commit/bbfb90e27d10eca928d0fe24e03cc19d18da6562
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit bbfb90e27d10eca928d0fe24e03cc19d18da6562
Author: Evonne Cheung 
Date:   Fri Mar 22 15:19:21 2019 +1300

Bug 1765276: Fixing subtheme inheritance

behatnotneeded

Change-Id: Id9720bcebf690ca9c32e7fead9fd8252a5849ad4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765276

Title:
  Upgrade to Bootstrap 4

Status in Mahara:
  In Progress

Bug description:
  Bootstrap 4 has been released. We should upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1814621] Re: Consolidate "My friends" and "Find people" screens

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1814621

Title:
  Consolidate "My friends" and "Find people" screens

Status in Mahara:
  Fix Committed

Bug description:
  This is similar to bug #1813500.

  1. The base template of "People" is "Find people" as it contains most
  of the functionality that we need. The new URL will be
  /people/index.php

  2. To be added to that page: The filter options to filter for friends.
  The filter title is "Filter friends".

  3. The "Search" filter options stay as they are.

  4. When friend requests have been made, at the top on the right-hand
  side above "Send message", you see "Pending friend" and below that
  there are two buttons (the small size): "Approve" and "Deny" (with
  their respective current icon).

  5. The main menu navigation item will be "People".

  6. Consolidate the help icon text.

  7. The "Help" link in the footer will need to change once I've updated
  the user manual.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1814621/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1814621] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9553
Committed: 
https://git.mahara.org/mahara/mahara/commit/2b79e29a77aa35c8571586d4906eb617890cb336
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 2b79e29a77aa35c8571586d4906eb617890cb336
Author: Lisa Seeto 
Date:   Wed Feb 13 13:23:48 2019 +1300

Bug 1814621: Consolidate "My friends" and "Find people" screens

Change-Id: I4fc0334d50500d649e9f2c6125f0f181df0ccba4
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1814621

Title:
  Consolidate "My friends" and "Find people" screens

Status in Mahara:
  Fix Committed

Bug description:
  This is similar to bug #1813500.

  1. The base template of "People" is "Find people" as it contains most
  of the functionality that we need. The new URL will be
  /people/index.php

  2. To be added to that page: The filter options to filter for friends.
  The filter title is "Filter friends".

  3. The "Search" filter options stay as they are.

  4. When friend requests have been made, at the top on the right-hand
  side above "Send message", you see "Pending friend" and below that
  there are two buttons (the small size): "Approve" and "Deny" (with
  their respective current icon).

  5. The main menu navigation item will be "People".

  6. Consolidate the help icon text.

  7. The "Help" link in the footer will need to change once I've updated
  the user manual.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1814621/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822022] Re: Dialog box close button not working

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
Milestone: None => 19.04.0

** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1822022

Title:
  Dialog box close button not working

Status in Mahara:
  Fix Committed

Bug description:
  This is a follow-on issue to bug 1806524

  Database: Postgres, Mysql
  Browser: Chrome, Firefox, Safari
  OS: Mac

  The dialog button no longer closes the dialog.
  Update the javascript libraries to resolve

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1822022/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822022] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9675
Committed: 
https://git.mahara.org/mahara/mahara/commit/7eb7fc97dae427b14e9bc1f9d7d3d74f23133af4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 7eb7fc97dae427b14e9bc1f9d7d3d74f23133af4
Author: Kevin Dibble 
Date:   Thu Mar 28 16:00:35 2019 +1300

Bug 1822022: Dialog box cancel not closing

Updated Js library for referencing click event
for cancel button on dialog.

behatnotneeded

Change-Id: If0cfa88b645cccb17f8293b064e89575a399ccab

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1822022

Title:
  Dialog box close button not working

Status in Mahara:
  Fix Committed

Bug description:
  This is a follow-on issue to bug 1806524

  Database: Postgres, Mysql
  Browser: Chrome, Firefox, Safari
  OS: Mac

  The dialog button no longer closes the dialog.
  Update the javascript libraries to resolve

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1822022/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1821107] Re: Institution report pages graph not showing

2019-03-28 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821107

Title:
  Institution report pages graph not showing

Status in Mahara:
  Fix Committed

Bug description:
  When we updated the Chart.js plugin we made some adjustments to the 
displaying of the site pages graph 
  https://reviews.mahara.org/#/c/9436/12/htdocs/lib/statistics.php

  - but forgot to update the institution one

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821107/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1821107] A change has been merged

2019-03-28 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9647
Committed: 
https://git.mahara.org/mahara/mahara/commit/83c1aaa5e3f090e02196b03a2b01485b63b49206
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 83c1aaa5e3f090e02196b03a2b01485b63b49206
Author: Robert Lyon 
Date:   Thu Mar 21 13:01:14 2019 +1300

Bug 1821107: Getting institution pages report graph to render

This one was not fixed when the site ones were fixed in
https://reviews.mahara.org/#/c/9436/12/htdocs/lib/statistics.php

behatnotneeded

Change-Id: I290d24b0d5abdddca132ec331a38bf0d2176a0ee
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821107

Title:
  Institution report pages graph not showing

Status in Mahara:
  Fix Committed

Bug description:
  When we updated the Chart.js plugin we made some adjustments to the 
displaying of the site pages graph 
  https://reviews.mahara.org/#/c/9436/12/htdocs/lib/statistics.php

  - but forgot to update the institution one

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821107/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp