[Mahara-contributors] [Bug 1833495] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10140 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833495 Title: Syncing LDAP usernames with Mahara's internal username leads to incorrect user record matching Status in Mahara: New Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF / Chrome (really n/a) The LDAP sync_users() functionality is not correctly matching user records - i.e. LDAP username with Mahara username. Scenario: 1. Create an institution with and LDAP authentication - Update user info on login = Yes - We auto-create users = Yes - Sync users automatically via cron job = Yes - Update user info in cron = Yes - Auto-create users in cron = Yes - If a user is no longer present in LDAP = Suspend user's account 2. Create an XML-RPC authentication with a Moodle for this institution - Parent authority = LDAP auth created above - SSO direction = Yes - Update user info on login = Yes - We auto-create users = Yes - We import content = Yes * The Moodle instance needs to have LDAP set up as well. 3. Create an internal Mahara user (i.e. not LDAP) - username: AAA (make sure this username exists in the LDAP directory) * The username 'AAA' needs to be in Moodle created via LDAP. 4. Login to Moodle with the username AAA - the LDAP user 5. SSO to Mahara This will do the following - a new user record is created with username AAA1 - auth_remote_user table will link Mahara user AAA1 to Moodle user AAA 6. As Admin, update AAA1's auth method to LDAP. 7. Logout of Mahara and Moodle. 8. Run cron so LDAP syncs users Expected Results: user AAA1 to remain active in Mahara Actual Results: user AAA1 is suspended because it matches on username (i.e. AAA) That is, this join is correct: from {usr} u inner join {auth_ldap_extusers_temp} e on u.username = e.extusername The username in auth_ldap_extusers_temp is: AAA The LDAP username in Mahara is: AAA1 Hence, it will not match on username and think the user is no longer in the LDAP directory and suspend the user. The join needs to be on another field that is present in both LDAP and Mahara. We should also join to the auth_remote_user table to get the correct external username. i.e. select u.id as id, aru.remoteusername as username, u.suspendedreason as suspendedreason, ... from {usr} u inner join {auth_remote_user} aru on u.id = aru.localusr inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833495/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833330] Re: Institution top menu hovers under config buttons
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/180 Title: Institution top menu hovers under config buttons Status in Mahara: In Progress Bug description: On the Admin > institutions > settings page See attached screenshot To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/180/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833330] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10139 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/180 Title: Institution top menu hovers under config buttons Status in Mahara: In Progress Bug description: On the Admin > institutions > settings page See attached screenshot To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/180/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833390] Re: Anchor hides behind header
Commit hash: 399f99f9a4cb0b0fb26a88a6fa4a3bcdd184dddb Environment tested: Master Browser tested: Chrome Theme used: Raw | Default raw | Ocean | Modern | Primary school PRECONDITIONS: 1) Set config.php file code to have the following line $cfg->productionmode = false; 2) User3 Exists and has a portfolio page as follows: a) 5 paragraphs of text b) a link near top of page to an anchor near the bottom of the page TEST STEPS: Set config.php file code to have the following line $cfg->productionmode = false; 1) Log in as Site admin 2) Masquerade as User3 3) Browse to the Portfolio page as described above 4) click the link near the top of the page 5) Verify that the page scrolls down to anchor (near bottom of page ✔ 6) Verify the anchored text is displayed ✔ 7) Verify the anchor is not hidden behind the top header with the logo and the navigation ✔ 8) Log out and log back in as User3 9) Browse to the Portfolio page as described above 10) click the link near the top of the page 11) Verify that the page scrolls down to anchor (near bottom of page ✔ 12) Verify the anchored text is displayed ✔ 13) Verify the anchor is not hidden behind the top header with the logo and the navigation ✔ NOTE: 1) Set config.php file code to have the following line $cfg->productionmode = true; 2) Repeat the above test script 3) Verify that the page scrolls down to anchor (near bottom of page ✔ 4) Verify the anchored text is displayed ✔ 5) Verify the anchor is not hidden behind the top header with the logo and the navigation ✔ Catalyst QA ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833390 Title: Anchor hides behind header Status in Mahara: In Progress Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: In Progress Bug description: when you place an anchor into text and jump to it, the anchored text is not displayed, but you need to scroll a bit up to see it. The anchor link jumps all the way to the top of the view port. That places the anchor behind the top header with the logo and the navigation. Instead, the anchor should take that strip into consideration and display the text right below it thus effectively making the viewport smaller. The tricky thing here will be to take into consideration that the height of the header can vary depending on the site messages that are displayed. To replicate: 1. Create a page with a very long text, e.g. created via https://www.lipsum.com 2. Create an anchor in the text in the second paragraph. 3. Link to the anchor further down in the text. 4. Click "Display this page" and scroll down to the link. 5. Click the link. Expected result: The text to which the anchor points is displayed. Actual result: A few lines further down from the anchor are visible at the edge of the header and the anchor itself needs to be scrolled to as it is hidden by the header. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833390/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1834792] [NEW] "Results per page" doesn't change when using "Back" button in Chrome and IE11
Public bug reported: When you are on a page where you can select the "Results per page" and you set it to a high number, it doesn't go back to the original number yet still displays the paginator when you return to the page via the "Back" button. This is an issue observed in Chrome and IE11. IT doesn't happen in Firefox. Not tested in Safari yet, but will need to be checked there as well. To replicate: 1. Create 30 user accounts on your site via CSV upload. 2. Go to Main menu -> Engage -> People and make sure that you search for "Everyone". 3. Choose "50" in the "Results per page" drop-down menu. Expected and actual result: The paginator goes away and all 30 people are displayed. 4. Click one of the names. 5. Use the browser's "Back" button to return to the "People" page. Expected result: The "Results per page" drop-down menu is reset to "10" because the filter is not sticky and the paginator is displayed. Actual result: The "Results per page" drop-down menu still says "50" yet the paginator is displayed as well. The same happens for example on the "User search" page in Admin menu -> Users -> User search. ** Affects: mahara Importance: Medium Status: Confirmed ** Tags: bite-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1834792 Title: "Results per page" doesn't change when using "Back" button in Chrome and IE11 Status in Mahara: Confirmed Bug description: When you are on a page where you can select the "Results per page" and you set it to a high number, it doesn't go back to the original number yet still displays the paginator when you return to the page via the "Back" button. This is an issue observed in Chrome and IE11. IT doesn't happen in Firefox. Not tested in Safari yet, but will need to be checked there as well. To replicate: 1. Create 30 user accounts on your site via CSV upload. 2. Go to Main menu -> Engage -> People and make sure that you search for "Everyone". 3. Choose "50" in the "Results per page" drop-down menu. Expected and actual result: The paginator goes away and all 30 people are displayed. 4. Click one of the names. 5. Use the browser's "Back" button to return to the "People" page. Expected result: The "Results per page" drop-down menu is reset to "10" because the filter is not sticky and the paginator is displayed. Actual result: The "Results per page" drop-down menu still says "50" yet the paginator is displayed as well. The same happens for example on the "User search" page in Admin menu -> Users -> User search. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1834792/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1829940] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10138 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1829940 Title: Create a 'magic' placeholder block Status in Mahara: In Progress Bug description: Goal: Be able to create templates more easily by setting up the basic structure, including block headings, but without the need to choose a specific block type from the start. See the Mahara Wiki page for more information about what we want to achieve https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Basic_magic_block To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1829940/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1834261] Re: Reports generating error about time zone not specified
** Changed in: mahara Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1834261 Title: Reports generating error about time zone not specified Status in Mahara: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres 10.9 Browser: FF An error is generated with running several reports but I'll give the example of the masquerading report: [WAR] ac (lib/errors.php:858) Failed to get a recordset: postgres8 error: [-1: ERROR: invalid input syntax for type timestamp with time zone: "Not specified"] in EXECUTE("SELECT COUNT(*) FROM "usr" u JOIN "event_log" e ON e.usr = u.id WHERE u.id != 0 AND u.deleted = 0 AND e.event = 'loginas' AND e.ctime >= DATE(?) AND e.ctime <= DATE(?)")Command was: SELECT COUNT(*) FROM "usr" u JOIN "event_log" e ON e.usr = u.id WHERE u.id != 0 AND u.deleted = 0 AND e.event = 'loginas' AND e.ctime >= DATE(?) AND e.ctime <= DATE(?) and values was (0:Notspecified,1:Notspecified) Call stack (most recent first): log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, true, true) at /var/www/mahara/htdocs/lib/errors.php:95 log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/mahara/htdocs/lib/errors.php:858 SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/mahara/htdocs/lib/dml.php:517 get_recordset_sql("SELECT COUNT(*) FROM "usr" u JOIN "event_log" e O...", array(size 2)) at /var/www/mahara/htdocs/lib/dml.php:276 count_records_sql("SELECT COUNT(*) FROM {usr} u JOIN {event_log} e O...", array(size 2)) at /var/www/mahara/htdocs/lib/statistics.php:3535 masquerading_stats_table(10, 0, array(size 5), null, https://my_dev_mahara/admin/users/statistics.php...;) at /var/www/mahara/htdocs/lib/statistics.php:3504 masquerading_statistics(10, 0, array(size 5), null) at /var/www/mahara/htdocs/lib/statistics.php:4285 display_statistics("all", "users", object(stdClass)) at /var/www/mahara/htdocs/admin/users/statistics.php:251 To replicate: 1. Turn on all event logging: Admin > Configure site > Site options > Logging settings > Log events = All 2. Set up Time zone in Admin > Configure site > Site options > Site settings > Time zone = "Australia/Sydney" 3. Add User1 to Mahara 4. Masquerade User1 (ie do not log in as them bug masquerade) 5. Return back to admin user 65. Run the Masquerading report: Admin > Reports > Configure report 7. Select: - Report Type = Masquerading sessions - Submit What happens: Above error is generated with: Masquerading sessions | All institutions Mahara: Site unavailable A nonrecoverable error occurred. This probably means you have encountered a bug in the system What should happen: the report should be displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1834261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1834261] Re: Reports generating error about time zone not specified
** Changed in: mahara Milestone: None => 19.10.0 ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1834261 Title: Reports generating error about time zone not specified Status in Mahara: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres 10.9 Browser: FF An error is generated with running several reports but I'll give the example of the masquerading report: [WAR] ac (lib/errors.php:858) Failed to get a recordset: postgres8 error: [-1: ERROR: invalid input syntax for type timestamp with time zone: "Not specified"] in EXECUTE("SELECT COUNT(*) FROM "usr" u JOIN "event_log" e ON e.usr = u.id WHERE u.id != 0 AND u.deleted = 0 AND e.event = 'loginas' AND e.ctime >= DATE(?) AND e.ctime <= DATE(?)")Command was: SELECT COUNT(*) FROM "usr" u JOIN "event_log" e ON e.usr = u.id WHERE u.id != 0 AND u.deleted = 0 AND e.event = 'loginas' AND e.ctime >= DATE(?) AND e.ctime <= DATE(?) and values was (0:Notspecified,1:Notspecified) Call stack (most recent first): log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, true, true) at /var/www/mahara/htdocs/lib/errors.php:95 log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/mahara/htdocs/lib/errors.php:858 SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/mahara/htdocs/lib/dml.php:517 get_recordset_sql("SELECT COUNT(*) FROM "usr" u JOIN "event_log" e O...", array(size 2)) at /var/www/mahara/htdocs/lib/dml.php:276 count_records_sql("SELECT COUNT(*) FROM {usr} u JOIN {event_log} e O...", array(size 2)) at /var/www/mahara/htdocs/lib/statistics.php:3535 masquerading_stats_table(10, 0, array(size 5), null, https://my_dev_mahara/admin/users/statistics.php...;) at /var/www/mahara/htdocs/lib/statistics.php:3504 masquerading_statistics(10, 0, array(size 5), null) at /var/www/mahara/htdocs/lib/statistics.php:4285 display_statistics("all", "users", object(stdClass)) at /var/www/mahara/htdocs/admin/users/statistics.php:251 To replicate: 1. Turn on all event logging: Admin > Configure site > Site options > Logging settings > Log events = All 2. Set up Time zone in Admin > Configure site > Site options > Site settings > Time zone = "Australia/Sydney" 3. Add User1 to Mahara 4. Masquerade User1 (ie do not log in as them bug masquerade) 5. Return back to admin user 65. Run the Masquerading report: Admin > Reports > Configure report 7. Select: - Report Type = Masquerading sessions - Submit What happens: Above error is generated with: Masquerading sessions | All institutions Mahara: Site unavailable A nonrecoverable error occurred. This probably means you have encountered a bug in the system What should happen: the report should be displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1834261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1834261] A change has been merged
Reviewed: https://reviews.mahara.org/10133 Committed: https://git.mahara.org/mahara/mahara/commit/97f50e0c5bb1876cd6ae4b2484f5ded056603496 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 97f50e0c5bb1876cd6ae4b2484f5ded056603496 Author: anupamadharmajan Date: Wed Jun 26 13:14:30 2019 +1000 Bug 1834261: Reports generating error The start and end date are disambiguated by looking at the separator Sponsored by The Australian National University behatnotneeded Change-Id: I73d534391bc9eaaddb7cffb564d4fd1d3de0c0db -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1834261 Title: Reports generating error about time zone not specified Status in Mahara: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres 10.9 Browser: FF An error is generated with running several reports but I'll give the example of the masquerading report: [WAR] ac (lib/errors.php:858) Failed to get a recordset: postgres8 error: [-1: ERROR: invalid input syntax for type timestamp with time zone: "Not specified"] in EXECUTE("SELECT COUNT(*) FROM "usr" u JOIN "event_log" e ON e.usr = u.id WHERE u.id != 0 AND u.deleted = 0 AND e.event = 'loginas' AND e.ctime >= DATE(?) AND e.ctime <= DATE(?)")Command was: SELECT COUNT(*) FROM "usr" u JOIN "event_log" e ON e.usr = u.id WHERE u.id != 0 AND u.deleted = 0 AND e.event = 'loginas' AND e.ctime >= DATE(?) AND e.ctime <= DATE(?) and values was (0:Notspecified,1:Notspecified) Call stack (most recent first): log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, true, true) at /var/www/mahara/htdocs/lib/errors.php:95 log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/mahara/htdocs/lib/errors.php:858 SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: E...") at /var/www/mahara/htdocs/lib/dml.php:517 get_recordset_sql("SELECT COUNT(*) FROM "usr" u JOIN "event_log" e O...", array(size 2)) at /var/www/mahara/htdocs/lib/dml.php:276 count_records_sql("SELECT COUNT(*) FROM {usr} u JOIN {event_log} e O...", array(size 2)) at /var/www/mahara/htdocs/lib/statistics.php:3535 masquerading_stats_table(10, 0, array(size 5), null, https://my_dev_mahara/admin/users/statistics.php...;) at /var/www/mahara/htdocs/lib/statistics.php:3504 masquerading_statistics(10, 0, array(size 5), null) at /var/www/mahara/htdocs/lib/statistics.php:4285 display_statistics("all", "users", object(stdClass)) at /var/www/mahara/htdocs/admin/users/statistics.php:251 To replicate: 1. Turn on all event logging: Admin > Configure site > Site options > Logging settings > Log events = All 2. Set up Time zone in Admin > Configure site > Site options > Site settings > Time zone = "Australia/Sydney" 3. Add User1 to Mahara 4. Masquerade User1 (ie do not log in as them bug masquerade) 5. Return back to admin user 65. Run the Masquerading report: Admin > Reports > Configure report 7. Select: - Report Type = Masquerading sessions - Submit What happens: Above error is generated with: Masquerading sessions | All institutions Mahara: Site unavailable A nonrecoverable error occurred. This probably means you have encountered a bug in the system What should happen: the report should be displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1834261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833390] Re: Anchor hides behind header
When testing, test with: - productionmode = false - productionmode = true - each of the above also when masquerading as another user so as to get more site messages to display. The anchor should always be displayed below the final header. ** Changed in: mahara/19.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833390 Title: Anchor hides behind header Status in Mahara: In Progress Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: In Progress Bug description: when you place an anchor into text and jump to it, the anchored text is not displayed, but you need to scroll a bit up to see it. The anchor link jumps all the way to the top of the view port. That places the anchor behind the top header with the logo and the navigation. Instead, the anchor should take that strip into consideration and display the text right below it thus effectively making the viewport smaller. The tricky thing here will be to take into consideration that the height of the header can vary depending on the site messages that are displayed. To replicate: 1. Create a page with a very long text, e.g. created via https://www.lipsum.com 2. Create an anchor in the text in the second paragraph. 3. Link to the anchor further down in the text. 4. Click "Display this page" and scroll down to the link. 5. Click the link. Expected result: The text to which the anchor points is displayed. Actual result: A few lines further down from the anchor are visible at the edge of the header and the anchor itself needs to be scrolled to as it is hidden by the header. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833390/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp