[Mahara-contributors] [Bug 1840201] [NEW] Elastic search: Search results are not restricted for aretfacts on pages shared with group
Public bug reported: A user can create a page with media artefacts on it and share it with a group. The user can specify which users in that group have access, i.e "Everyone in group", "Member" and "Admin". When a user selects to share the page with "Member" or "Admin" all members of the group can view via the media category in Elastic Search page and can see the artefact. The preview image for an Image block for this issue is displaying as a broken link in FireFox and not displaying at all in Chrome. Have Elastic Search set up and able to search. 1. Create a group that has admin and members. 2. Log in as a user (doesn't have to be group member) and create a page with an Image block. 3. Share the page with the group and choose "Admin" in dropdown 4. Log in as an Member of the group and go to Elastic search with no search words (should return everything you have access to see. 5. Select Media tab and view Expected results: No artefacts from pages that are not shared with User are returned as results. Actual results: User can see artefacts from the page they do not have permission to access. Mahara: 19.10dev OS: Ubunt 18.04.2 DB: Postgres Browser: Firefox 68.01, Chrome 75.0.3770.142 ** Affects: mahara Importance: Undecided Status: New ** Tags: search ** Attachment added: "elastic-search-users-can-see.png" https://bugs.launchpad.net/bugs/1840201/+attachment/5282553/+files/elastic-search-users-can-see.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1840201 Title: Elastic search: Search results are not restricted for aretfacts on pages shared with group Status in Mahara: New Bug description: A user can create a page with media artefacts on it and share it with a group. The user can specify which users in that group have access, i.e "Everyone in group", "Member" and "Admin". When a user selects to share the page with "Member" or "Admin" all members of the group can view via the media category in Elastic Search page and can see the artefact. The preview image for an Image block for this issue is displaying as a broken link in FireFox and not displaying at all in Chrome. Have Elastic Search set up and able to search. 1. Create a group that has admin and members. 2. Log in as a user (doesn't have to be group member) and create a page with an Image block. 3. Share the page with the group and choose "Admin" in dropdown 4. Log in as an Member of the group and go to Elastic search with no search words (should return everything you have access to see. 5. Select Media tab and view Expected results: No artefacts from pages that are not shared with User are returned as results. Actual results: User can see artefacts from the page they do not have permission to access. Mahara: 19.10dev OS: Ubunt 18.04.2 DB: Postgres Browser: Firefox 68.01, Chrome 75.0.3770.142 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1840201/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1840195] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10263 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1840195 Title: Add a function to check if a cron callfunction needs to run before actually executing it Status in Mahara: New Bug description: There are cron functions that run many times a day that don't need to run that often but they need to monitor a condition. One of these is for example the user_login_tries_to_zero that resets the logintries value in the usr table to be 0, so the user can try to login again if they failed 5 times. This doesn't need to run if there are no values to reset. If we have a way to checks if the cron function needs to run or not, and we also work with elastic search, we can check if the triggers need to be dropped. This way we're reducing the times we drop and recreate elasticsearch triggers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1840195/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1794628] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10262 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1794628 Title: Clean up session duplication between auth/session and auth/saml Status in Mahara: Fix Committed Bug description: There is a bunch of checks for session handlers done by auth/session.php and also done by auth/saml/config/config.php We can make these checks simplified into one place To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1794628/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1836656] Re: LTI submission formatting improvements
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Wishlist ** Changed in: mahara Milestone: None => 19.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1836656 Title: LTI submission formatting improvements Status in Mahara: In Progress Bug description: - Link to title to portfolio - Update page title to reflect submission state - Make links bold To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1836656/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1840197] [NEW] Font Awesome: Icons being created from titles in collection pages
Public bug reported: Font Awesome seems to be transforming parts of the titles in the 'Add Pages to Collection' selector into its icons when Editing a Collection. 1. Log in as an user and create either one or all of the following pages with titles: 'C is for Car', 'Male Elephants', 'Admin Stuff', 'Banana' 2. Create a Collection, i.e 'Test Collection' 3. When given the option to edit collection in the 'Add Pages to Collection', view the page: Expected Result: All titles are represented correctly in text. Actual Result: Titles are partially transformed into Font Awesome icons (see attached screenshot) Note: When the affected pages are added to the 'Pages already in Collection' section, their titles are then displayed correctly in text. The issue seems to be on fieldset id = 'pagestoadd' and not affecting fieldset id = 'pagesadded' Mahara: 19.10dev Ubunt: 18.04.2 Database: Postgres Browser: FireFox 68.07, Chrome 75.0.3770.142 Theme tested: Raw ** Affects: mahara Importance: Undecided Status: New ** Tags: awesome font ** Attachment added: "font-awesome-transforming-titles.png" https://bugs.launchpad.net/bugs/1840197/+attachment/5282549/+files/font-awesome-transforming-titles.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1840197 Title: Font Awesome: Icons being created from titles in collection pages Status in Mahara: New Bug description: Font Awesome seems to be transforming parts of the titles in the 'Add Pages to Collection' selector into its icons when Editing a Collection. 1. Log in as an user and create either one or all of the following pages with titles: 'C is for Car', 'Male Elephants', 'Admin Stuff', 'Banana' 2. Create a Collection, i.e 'Test Collection' 3. When given the option to edit collection in the 'Add Pages to Collection', view the page: Expected Result: All titles are represented correctly in text. Actual Result: Titles are partially transformed into Font Awesome icons (see attached screenshot) Note: When the affected pages are added to the 'Pages already in Collection' section, their titles are then displayed correctly in text. The issue seems to be on fieldset id = 'pagestoadd' and not affecting fieldset id = 'pagesadded' Mahara: 19.10dev Ubunt: 18.04.2 Database: Postgres Browser: FireFox 68.07, Chrome 75.0.3770.142 Theme tested: Raw To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1840197/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1840195] [NEW] Add a function to check if a cron callfunction needs to run before actually executing it
Public bug reported: There are cron functions that run many times a day that don't need to run that often but they need to monitor a condition. One of these is for example the user_login_tries_to_zero that resets the logintries value in the usr table to be 0, so the user can try to login again if they failed 5 times. This doesn't need to run if there are no values to reset. If we have a way to checks if the cron function needs to run or not, and we also work with elastic search, we can check if the triggers need to be dropped. This way we're reducing the times we drop and recreate elasticsearch triggers. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1840195 Title: Add a function to check if a cron callfunction needs to run before actually executing it Status in Mahara: New Bug description: There are cron functions that run many times a day that don't need to run that often but they need to monitor a condition. One of these is for example the user_login_tries_to_zero that resets the logintries value in the usr table to be 0, so the user can try to login again if they failed 5 times. This doesn't need to run if there are no values to reset. If we have a way to checks if the cron function needs to run or not, and we also work with elastic search, we can check if the triggers need to be dropped. This way we're reducing the times we drop and recreate elasticsearch triggers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1840195/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1839581] Re: Have cleaner select2 choosing of user in send message
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1839581 Title: Have cleaner select2 choosing of user in send message Status in Mahara: Fix Committed Bug description: When an admin user is on the send message / compose message page and chooses to send a message to another user. That user displays with either - both their name and username or - their displayname, name, and username And that can get quite long and overlap the box the tab should live in See attached What should happen is: - the displayname and/or name + username should show in the dropdown list - but on selection the grey button shaped object should only display the displayname or name to save space To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1839581/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1838915] A change has been merged
Reviewed: https://reviews.mahara.org/10242 Committed: https://git.mahara.org/mahara/mahara/commit/0b568cedc8399957d0e2bec67d3926c093a5a855 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 0b568cedc8399957d0e2bec67d3926c093a5a855 Author: Robert Lyon Date: Mon Aug 5 13:31:25 2019 +1200 Bug 1838915: Fixing problem with comment ratings and fontawesome 5 Places to check - the Extensions -> Plugins -> Comment configuration - adding a Comment to a page/artefact and how it displays Change-Id: I6d0945ee0d54492b65ff285d98bd65bc14d6e723 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1838915 Title: Comment ratings not displaying correctly with font-awesome5 Status in Mahara: Fix Committed Bug description: The hollow (not rated) icons are not showing This will need to be tested for all the icon choices - star, heart, thumbsup, tick, smile (a new one) To test admin part: 1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments' 2) Turn on 'Enable comment ratings' 3) Select a new icon type 4) Save On this page you should see some icons filled in and some hollow in the generated example line To test comments part on page: 1) Go to a page and add a comment and choose a rating by clicking on the icon 2) Make sure the comment has the rating icons showing To test comments part on artefact: 1) Go to a page and add an artefact, like an image, then view the page and click on details link 2) Make a comment on the artefact and choose a rating by clicking on the icon 3) Make sure the comment has the rating icons showing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1838915] A change has been merged
Reviewed: https://reviews.mahara.org/10260 Committed: https://git.mahara.org/mahara/mahara/commit/2bb22fa51bbb2e2c40731acbbe805fb02dc00b0d Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 2bb22fa51bbb2e2c40731acbbe805fb02dc00b0d Author: Robert Lyon Date: Tue Aug 13 11:41:51 2019 +1200 Bug 1838915: Allow externalmedia / iframe sources to use FontAwsome icons if available behatnotneeded Change-Id: Ib060fef54ac3ef4a1b881743ed00774e9eb6424a Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1838915 Title: Comment ratings not displaying correctly with font-awesome5 Status in Mahara: Fix Committed Bug description: The hollow (not rated) icons are not showing This will need to be tested for all the icon choices - star, heart, thumbsup, tick, smile (a new one) To test admin part: 1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments' 2) Turn on 'Enable comment ratings' 3) Select a new icon type 4) Save On this page you should see some icons filled in and some hollow in the generated example line To test comments part on page: 1) Go to a page and add a comment and choose a rating by clicking on the icon 2) Make sure the comment has the rating icons showing To test comments part on artefact: 1) Go to a page and add an artefact, like an image, then view the page and click on details link 2) Make a comment on the artefact and choose a rating by clicking on the icon 3) Make sure the comment has the rating icons showing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1838915] A change has been merged
Reviewed: https://reviews.mahara.org/10250 Committed: https://git.mahara.org/mahara/mahara/commit/8af682ba0c9758e9247cd4c194d96f31e127b16b Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 8af682ba0c9758e9247cd4c194d96f31e127b16b Author: Robert Lyon Date: Thu Aug 8 14:14:58 2019 +1200 Bug 1838915: Fixing problem with some custom fontawesome placements Changing from fontawesome to fontawesome5 Change-Id: If7e324b11e5bfc070d3a947d8f04f88a87ba7875 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1838915 Title: Comment ratings not displaying correctly with font-awesome5 Status in Mahara: Fix Committed Bug description: The hollow (not rated) icons are not showing This will need to be tested for all the icon choices - star, heart, thumbsup, tick, smile (a new one) To test admin part: 1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments' 2) Turn on 'Enable comment ratings' 3) Select a new icon type 4) Save On this page you should see some icons filled in and some hollow in the generated example line To test comments part on page: 1) Go to a page and add a comment and choose a rating by clicking on the icon 2) Make sure the comment has the rating icons showing To test comments part on artefact: 1) Go to a page and add an artefact, like an image, then view the page and click on details link 2) Make a comment on the artefact and choose a rating by clicking on the icon 3) Make sure the comment has the rating icons showing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1838915] Re: Comment ratings not displaying correctly with font-awesome5
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1838915 Title: Comment ratings not displaying correctly with font-awesome5 Status in Mahara: Fix Committed Bug description: The hollow (not rated) icons are not showing This will need to be tested for all the icon choices - star, heart, thumbsup, tick, smile (a new one) To test admin part: 1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments' 2) Turn on 'Enable comment ratings' 3) Select a new icon type 4) Save On this page you should see some icons filled in and some hollow in the generated example line To test comments part on page: 1) Go to a page and add a comment and choose a rating by clicking on the icon 2) Make sure the comment has the rating icons showing To test comments part on artefact: 1) Go to a page and add an artefact, like an image, then view the page and click on details link 2) Make a comment on the artefact and choose a rating by clicking on the icon 3) Make sure the comment has the rating icons showing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1839785] Re: Make bulk import page instuctions a bit clearer
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1839785 Title: Make bulk import page instuctions a bit clearer Status in Mahara: Fix Committed Bug description: The bulk import page instructions are not quite clear in a couple of places - the structure if the zip file to import - the path to fetch the file from To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1839785/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1838915] A change has been merged
Reviewed: https://reviews.mahara.org/10259 Committed: https://git.mahara.org/mahara/mahara/commit/a159537346ae2789d770b49de039d60f1b6bd2de Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit a159537346ae2789d770b49de039d60f1b6bd2de Author: Robert Lyon Date: Tue Aug 13 10:13:10 2019 +1200 Bug 1838915: Allow social media to use FontAwsome icons if available with social media icons we fetch them from external server each time but a lot of them exist in the FontAwesome font library. We should use the FA icons instead behatnotneeded Change-Id: I7b66ae0882836c7a0715969e5e03353b1e4fd70d Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1838915 Title: Comment ratings not displaying correctly with font-awesome5 Status in Mahara: Fix Committed Bug description: The hollow (not rated) icons are not showing This will need to be tested for all the icon choices - star, heart, thumbsup, tick, smile (a new one) To test admin part: 1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments' 2) Turn on 'Enable comment ratings' 3) Select a new icon type 4) Save On this page you should see some icons filled in and some hollow in the generated example line To test comments part on page: 1) Go to a page and add a comment and choose a rating by clicking on the icon 2) Make sure the comment has the rating icons showing To test comments part on artefact: 1) Go to a page and add an artefact, like an image, then view the page and click on details link 2) Make a comment on the artefact and choose a rating by clicking on the icon 3) Make sure the comment has the rating icons showing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
