[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Fix Released Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara Milestone: 1.8rc1 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara/1.5 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara/1.6 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Committed Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara/1.7 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara/1.5 Status: In Progress = Fix Committed ** Changed in: mahara/1.6 Status: In Progress = Fix Committed ** Changed in: mahara/1.7 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
from Bob: things you will need to test: Portfolio page with comment moderation set in advanced option Portfolio page with comment moderation set in per access rule Group page with comment moderation set in advanced option Group page with comment moderation set in per access rule You will need to test with anonymous users, logged-in users, group members, page owners etc. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: In Progress Status in Mahara 1.5 series: In Progress Status in Mahara 1.6 series: In Progress Status in Mahara 1.7 series: In Progress Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
** Changed in: mahara/1.5 Status: New = Confirmed ** Changed in: mahara/1.6 Status: New = Confirmed ** Changed in: mahara/1.7 Status: New = Confirmed ** Changed in: mahara/1.5 Importance: Undecided = High ** Changed in: mahara/1.6 Importance: Undecided = High ** Changed in: mahara/1.7 Importance: Undecided = High ** Changed in: mahara/1.5 Assignee: (unassigned) = Robert Lyon (robertl-9) ** Changed in: mahara/1.6 Assignee: (unassigned) = Robert Lyon (robertl-9) ** Changed in: mahara/1.7 Assignee: (unassigned) = Robert Lyon (robertl-9) ** Changed in: mahara/1.5 Milestone: None = 1.5.11 ** Changed in: mahara/1.6 Milestone: None = 1.6.6 ** Changed in: mahara/1.7 Milestone: None = 1.7.2 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: In Progress Status in Mahara 1.5 series: Confirmed Status in Mahara 1.6 series: Confirmed Status in Mahara 1.7 series: Confirmed Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
I have submitted a patch for this bug https://reviews.mahara.org/#/c/2090/ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Triaged Status in Mahara 1.5 series: New Status in Mahara 1.6 series: New Status in Mahara 1.7 series: New Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
Whoops, I was logged in as the Mahara Bot user doing some work on the Translations set up earlier today, and it looks like I forgot to log out before logging this bug. :) ** Changed in: mahara Importance: Undecided = High ** Changed in: mahara Status: New = Triaged ** Changed in: mahara Milestone: None = 1.8.0 ** Also affects: mahara/1.5 Importance: Undecided Status: New ** Also affects: mahara/1.6 Importance: Undecided Status: New ** Also affects: mahara/1.7 Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Triaged Status in Mahara 1.5 series: New Status in Mahara 1.6 series: New Status in Mahara 1.7 series: New Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1171310] Re: Can bypass comment moderation by editing a comment
I also tested and verified that this happens with comments on Group Pages as well. It is not an issue for anonymous comments, however, because those can't be edited. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1171310 Title: Can bypass comment moderation by editing a comment Status in Mahara ePortfolio: Triaged Status in Mahara 1.5 series: New Status in Mahara 1.6 series: New Status in Mahara 1.7 series: New Bug description: A user can make their comments on a page public, even if the page is set to require comment moderation, if they create the comment as a private comment and then change its status to public while editing it. To replicate: 1. Create a Page for User 1 2. Make the page accessible to the public, and activate comments comment moderation for the page (this is all under the Sharing tab) 3. Log in as User 2 4. Place a comment on the Page, making sure to untick the Make public box so that the comment is private. 5. Click the edit icon next to the newly created comment. 6. On the edit page, tick the Make public box, and click Save. Expected result: The comment's status should be This comment is private | You have requested that this comment be made public; and it shouldn't become public until approved by User 1 Actual result: The comment becomes public immediately after you click Save on the Edit page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1171310/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
