[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
** Changed in: mahara Status: Fix Committed = Fix Released ** Changed in: mahara/1.8 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Fix Released Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Status in Mahara 1.8 series: Fix Released Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
** Changed in: mahara/1.7 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Status in Mahara 1.8 series: Fix Committed Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
** Changed in: mahara Milestone: 1.5.12 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
** Also affects: mahara/1.5 Importance: Undecided Status: New ** Changed in: mahara/1.5 Milestone: None = 1.5.12 ** Changed in: mahara/1.5 Status: New = Fix Committed ** Changed in: mahara/1.5 Importance: Undecided = Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
1.6: https://reviews.mahara.org/#/c/2507/ 1.7: https://reviews.mahara.org/#/c/2508/ ** Changed in: mahara/1.7 Status: Confirmed = Fix Committed ** Changed in: mahara/1.6 Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
1.5: https://reviews.mahara.org/2509 ** Changed in: mahara Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
Hi John, Thanks for the patch! I've pushed it into our code review system here: https://reviews.mahara.org/2492 Cheers, Aaron ** Changed in: mahara Status: Triaged = In Progress ** Changed in: mahara Status: In Progress = Triaged ** Changed in: mahara/1.8 Status: Triaged = In Progress ** Changed in: mahara/1.7 Status: Triaged = Confirmed ** Changed in: mahara/1.6 Status: Triaged = Confirmed ** Changed in: mahara/1.6 Status: Confirmed = Triaged ** Changed in: mahara/1.7 Status: Confirmed = Triaged ** Changed in: mahara/1.6 Status: Triaged = Confirmed ** Changed in: mahara Status: Triaged = Confirmed ** Changed in: mahara/1.7 Status: Triaged = Confirmed ** Changed in: mahara/1.8 Milestone: None = 1.8.0rc1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Confirmed Status in Mahara 1.6 series: Confirmed Status in Mahara 1.7 series: Confirmed Status in Mahara 1.8 series: In Progress Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215190] Re: LDAP support for non-standard port LDAP Urls
Possible solution attached. ** Patch added: 1215190.patch https://bugs.launchpad.net/mahara/+bug/1215190/+attachment/3816972/+files/1215190.patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215190 Title: LDAP support for non-standard port LDAP Urls Status in Mahara ePortfolio: Triaged Status in Mahara 1.6 series: Triaged Status in Mahara 1.7 series: Triaged Status in Mahara 1.8 series: Triaged Bug description: This came up from a user asking for help on IRC. They had upgraded their site from Mahara 1.4 to Mahara 1.5 and found that LDAP authentication stopped working. Their LDAP host URL field was in this format: ldap://fake-dc1.fake.ac.uk:3268; In Mahara 1.4, this string would be passed in as the first and only parameter to ldap_connect(). In Mahara 1.5, the code is smarter and notices the final colon before the port number 3268. It strips this off of the URL, and passes ldap://fake-dc1.fake.ac.uk; as the first parameter and 3268 as the second parameter to ldap_connect(). The problem is, if the first parameter to ldap-connect is in URL style starting with a protocol ldap:// or ldaps://, ldap_connect() IGNORES the second parameter. And so the port was stripped off, and then ignored, and the connection didn't work. Making matters worse, the documentation tells people to put a protocol header on the front of their Host URL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
