[Mahara-contributors] [Bug 1215702] Re: Reduce false positives in syntax checker for unbracketed SQL tables
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215702 Title: Reduce false positives in syntax checker for unbracketed SQL tables Status in Mahara ePortfolio: Fix Released Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Bug description: The check for SQL tables that aren't surrounded by {}, which was added to test/coding-standard-check.pl, also matches comments that contain these very common words, and that results in a lot of false positives from the script, which mkaes people less likely to pay attention to its output. We should reduce the false positives by changing the regular expression so that it ignores the words from and join when they occur in comments. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215702] Re: Reduce false positives in syntax checker for unbracketed SQL tables
** Changed in: mahara/1.5 Status: Fix Committed = Fix Released ** Changed in: mahara/1.6 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215702 Title: Reduce false positives in syntax checker for unbracketed SQL tables Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Committed Bug description: The check for SQL tables that aren't surrounded by {}, which was added to test/coding-standard-check.pl, also matches comments that contain these very common words, and that results in a lot of false positives from the script, which mkaes people less likely to pay attention to its output. We should reduce the false positives by changing the regular expression so that it ignores the words from and join when they occur in comments. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215702] Re: Reduce false positives in syntax checker for unbracketed SQL tables
** Changed in: mahara/1.7 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215702 Title: Reduce false positives in syntax checker for unbracketed SQL tables Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Released Status in Mahara 1.6 series: Fix Released Status in Mahara 1.7 series: Fix Released Bug description: The check for SQL tables that aren't surrounded by {}, which was added to test/coding-standard-check.pl, also matches comments that contain these very common words, and that results in a lot of false positives from the script, which mkaes people less likely to pay attention to its output. We should reduce the false positives by changing the regular expression so that it ignores the words from and join when they occur in comments. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215702] Re: Reduce false positives in syntax checker for unbracketed SQL tables
** Changed in: mahara Milestone: 1.8rc1 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1215702 Title: Reduce false positives in syntax checker for unbracketed SQL tables Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Bug description: The check for SQL tables that aren't surrounded by {}, which was added to test/coding-standard-check.pl, also matches comments that contain these very common words, and that results in a lot of false positives from the script, which mkaes people less likely to pay attention to its output. We should reduce the false positives by changing the regular expression so that it ignores the words from and join when they occur in comments. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215702] Re: Reduce false positives in syntax checker for unbracketed SQL tables
Already merged into master, don't know why I didn't bother creating a bug for it: https://reviews.mahara.org/#/c/2388/ ** Also affects: mahara/1.5 Importance: Undecided Status: New ** Also affects: mahara/1.6 Importance: Undecided Status: New ** Also affects: mahara/1.7 Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1215702 Title: Reduce false positives in syntax checker for unbracketed SQL tables Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: New Status in Mahara 1.6 series: New Status in Mahara 1.7 series: New Bug description: The check for SQL tables that aren't surrounded by {}, which was added to test/coding-standard-check.pl, also matches comments that contain these very common words, and that results in a lot of false positives from the script, which mkaes people less likely to pay attention to its output. We should reduce the false positives by changing the regular expression so that it ignores the words from and join when they occur in comments. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1215702] Re: Reduce false positives in syntax checker for unbracketed SQL tables
** Changed in: mahara/1.5 Status: New = Fix Committed ** Changed in: mahara/1.6 Status: New = Fix Committed ** Changed in: mahara/1.7 Status: New = Fix Committed ** Changed in: mahara/1.5 Importance: Undecided = Medium ** Changed in: mahara/1.6 Importance: Undecided = Medium ** Changed in: mahara/1.7 Importance: Undecided = Medium ** Changed in: mahara/1.5 Milestone: None = 1.5.12 ** Changed in: mahara/1.6 Milestone: None = 1.6.7 ** Changed in: mahara/1.7 Milestone: None = 1.7.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1215702 Title: Reduce false positives in syntax checker for unbracketed SQL tables Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.5 series: Fix Committed Status in Mahara 1.6 series: Fix Committed Status in Mahara 1.7 series: Fix Committed Bug description: The check for SQL tables that aren't surrounded by {}, which was added to test/coding-standard-check.pl, also matches comments that contain these very common words, and that results in a lot of false positives from the script, which mkaes people less likely to pay attention to its output. We should reduce the false positives by changing the regular expression so that it ignores the words from and join when they occur in comments. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp