[Mahara-contributors] [Bug 1220093] Re: Make a copy in Text Box block no longer works
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1220093 Title: Make a copy in Text Box block no longer works Status in Mahara ePortfolio: Fix Released Bug description: While testing https://bugs.launchpad.net/mahara/+bug/1194255 I noticed that the Make a copy link no longer works. And you no longer get the Make a copy link while first editing the Text Box. To reproduce: 1. Install Mahara 1.8 2. Create a page 3. Put a Text Box on the page. Give it some content so you can tell it apart from others. 4. Put a second Text Box on the page. Use the Use content from another text box link to make it use the same Note as the first Text Box. Expected Results: When you select the first text box, in addition to seeing its content in the config form, you should also see a link that says If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy? Actual Result: You do not see that link. Carrying on... 5. Save the second text box. 6. Click the edit icon for the second text box to edit it further 7. You will now see the link that asks where you would like to Make a copy. 8. Click on that link. 9. Change the contents of the block. 10. Save the block. Expected Result: The content of the second block will change, and there will now be two Notes in your Content-Notes page Actual Result: The content of both blocks will change, and there will only be one Note in Content-Notes (because it did not actually make a copy). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1220093/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1220093] Re: Make a copy in Text Box block no longer works
** Changed in: mahara Milestone: 1.8rc1 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1220093 Title: Make a copy in Text Box block no longer works Status in Mahara ePortfolio: Fix Committed Bug description: While testing https://bugs.launchpad.net/mahara/+bug/1194255 I noticed that the Make a copy link no longer works. And you no longer get the Make a copy link while first editing the Text Box. To reproduce: 1. Install Mahara 1.8 2. Create a page 3. Put a Text Box on the page. Give it some content so you can tell it apart from others. 4. Put a second Text Box on the page. Use the Use content from another text box link to make it use the same Note as the first Text Box. Expected Results: When you select the first text box, in addition to seeing its content in the config form, you should also see a link that says If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy? Actual Result: You do not see that link. Carrying on... 5. Save the second text box. 6. Click the edit icon for the second text box to edit it further 7. You will now see the link that asks where you would like to Make a copy. 8. Click on that link. 9. Change the contents of the block. 10. Save the block. Expected Result: The content of the second block will change, and there will now be two Notes in your Content-Notes page Actual Result: The content of both blocks will change, and there will only be one Note in Content-Notes (because it did not actually make a copy). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1220093/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1220093] Re: Make a copy in Text Box block no longer works
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1220093 Title: Make a copy in Text Box block no longer works Status in Mahara ePortfolio: Fix Committed Bug description: While testing https://bugs.launchpad.net/mahara/+bug/1194255 I noticed that the Make a copy link no longer works. And you no longer get the Make a copy link while first editing the Text Box. To reproduce: 1. Install Mahara 1.8 2. Create a page 3. Put a Text Box on the page. Give it some content so you can tell it apart from others. 4. Put a second Text Box on the page. Use the Use content from another text box link to make it use the same Note as the first Text Box. Expected Results: When you select the first text box, in addition to seeing its content in the config form, you should also see a link that says If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy? Actual Result: You do not see that link. Carrying on... 5. Save the second text box. 6. Click the edit icon for the second text box to edit it further 7. You will now see the link that asks where you would like to Make a copy. 8. Click on that link. 9. Change the contents of the block. 10. Save the block. Expected Result: The content of the second block will change, and there will now be two Notes in your Content-Notes page Actual Result: The content of both blocks will change, and there will only be one Note in Content-Notes (because it did not actually make a copy). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1220093/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1220093] Re: Make a copy in Text Box block no longer works
Using the always magical git-bisect, I've found that it's commit d2b438c51a4d006759631919950fc5d9c9d0c905 that introduced the problem that stops the Make a copy link from showing up while first creating the Text Box. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1220093 Title: Make a copy in Text Box block no longer works Status in Mahara ePortfolio: Confirmed Bug description: While testing https://bugs.launchpad.net/mahara/+bug/1194255 I noticed that the Make a copy link no longer works. And you no longer get the Make a copy link while first editing the Text Box. To reproduce: 1. Install Mahara 1.8 2. Create a page 3. Put a Text Box on the page. Give it some content so you can tell it apart from others. 4. Put a second Text Box on the page. Use the Use content from another text box link to make it use the same Note as the first Text Box. Expected Results: When you select the first text box, in addition to seeing its content in the config form, you should also see a link that says If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy? Actual Result: You do not see that link. Carrying on... 5. Save the second text box. 6. Click the edit icon for the second text box to edit it further 7. You will now see the link that asks where you would like to Make a copy. 8. Click on that link. 9. Change the contents of the block. 10. Save the block. Expected Result: The content of the second block will change, and there will now be two Notes in your Content-Notes page Actual Result: The content of both blocks will change, and there will only be one Note in Content-Notes (because it did not actually make a copy). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1220093/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1220093] Re: Make a copy in Text Box block no longer works
Using my favorite tool git-bisect, it looks like the commit to be blame is our old favorite, 8b34dc82d4f25e8fec7f97658e5a53789dce8058, i.e. https://reviews.mahara.org/#/c/2387/ , the Flexible layouts mega-commit. ** Changed in: mahara Assignee: (unassigned) = Aaron Wells (u-aaronw) ** Changed in: mahara Assignee: Aaron Wells (u-aaronw) = Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1220093 Title: Make a copy in Text Box block no longer works Status in Mahara ePortfolio: Confirmed Bug description: While testing https://bugs.launchpad.net/mahara/+bug/1194255 I noticed that the Make a copy link no longer works. And you no longer get the Make a copy link while first editing the Text Box. To reproduce: 1. Install Mahara 1.8 2. Create a page 3. Put a Text Box on the page. Give it some content so you can tell it apart from others. 4. Put a second Text Box on the page. Use the Use content from another text box link to make it use the same Note as the first Text Box. Expected Results: When you select the first text box, in addition to seeing its content in the config form, you should also see a link that says If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy? Actual Result: You do not see that link. Carrying on... 5. Save the second text box. 6. Click the edit icon for the second text box to edit it further 7. You will now see the link that asks where you would like to Make a copy. 8. Click on that link. 9. Change the contents of the block. 10. Save the block. Expected Result: The content of the second block will change, and there will now be two Notes in your Content-Notes page Actual Result: The content of both blocks will change, and there will only be one Note in Content-Notes (because it did not actually make a copy). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1220093/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1220093] Re: Make a copy in Text Box block no longer works
Yep that mega commit is the problem and it is due to the jQuery and Mochikit not playing nice. They both want to use $() to access DOM elements. I've altered the code so that it uses jQuery, and we know this because I've gone with jQuery() instead of $() so it is easier to understand which js library is doing what. https://reviews.mahara.org/#/c/2471 ** Changed in: mahara Status: Confirmed = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1220093 Title: Make a copy in Text Box block no longer works Status in Mahara ePortfolio: In Progress Bug description: While testing https://bugs.launchpad.net/mahara/+bug/1194255 I noticed that the Make a copy link no longer works. And you no longer get the Make a copy link while first editing the Text Box. To reproduce: 1. Install Mahara 1.8 2. Create a page 3. Put a Text Box on the page. Give it some content so you can tell it apart from others. 4. Put a second Text Box on the page. Use the Use content from another text box link to make it use the same Note as the first Text Box. Expected Results: When you select the first text box, in addition to seeing its content in the config form, you should also see a link that says If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy? Actual Result: You do not see that link. Carrying on... 5. Save the second text box. 6. Click the edit icon for the second text box to edit it further 7. You will now see the link that asks where you would like to Make a copy. 8. Click on that link. 9. Change the contents of the block. 10. Save the block. Expected Result: The content of the second block will change, and there will now be two Notes in your Content-Notes page Actual Result: The content of both blocks will change, and there will only be one Note in Content-Notes (because it did not actually make a copy). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1220093/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
