[Mahara-contributors] [Bug 1233403] Re: adding custom layout duplication
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1233403 Title: adding custom layout duplication Status in Mahara ePortfolio: Fix Released Bug description: In Mahara 1.8 Portfolio - Pages section When I edit the layout for a page and choose the 'create custom layout' option I can add a new option that matches existing options. I can also add multiple copies of a non existing layout. There should be some checking to make sure one is not adding an existing option otherwise the available options get quite filled up with duplication pretty quickly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1233403/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1233403] Re: adding custom layout duplication
It seems like the patch https://reviews.mahara.org/#/c/2548/1 is still not fully identifying whether there's an existing layout or not. What it does is check for an existing layout that has the same number of rows as the new layout. But, it doesn't check to see if each of those rows has the same number of columns as in the new layout. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1233403 Title: adding custom layout duplication Status in Mahara ePortfolio: In Progress Bug description: In Mahara 1.8 Portfolio - Pages section When I edit the layout for a page and choose the 'create custom layout' option I can add a new option that matches existing options. I can also add multiple copies of a non existing layout. There should be some checking to make sure one is not adding an existing option otherwise the available options get quite filled up with duplication pretty quickly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1233403/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1233403] Re: adding custom layout duplication
Isn't that what the
WHERE (' . $rowscolssql . ')
checks ?
so does a
WHERE ((row = 1 AND columns = 5) OR (row = 2 AND columns = 2) OR (row =
3 AND columns = 5))
for:
5 cols
3 cols
5 cols
grid
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1233403
Title:
adding custom layout duplication
Status in Mahara ePortfolio:
In Progress
Bug description:
In Mahara 1.8 Portfolio - Pages section
When I edit the layout for a page and choose the 'create custom
layout' option I can add a new option that matches existing options. I
can also add multiple copies of a non existing layout.
There should be some checking to make sure one is not adding an
existing option otherwise the available options get quite filled up
with duplication pretty quickly.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1233403/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1233403] Re: adding custom layout duplication
Yeah, you're right. Somehow I missed that bit when reviewing it before. :) It still looks like the double-group-by is redundant, but since it's only checked like once per page load it's not that big of a problem. ** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1233403 Title: adding custom layout duplication Status in Mahara ePortfolio: Fix Committed Bug description: In Mahara 1.8 Portfolio - Pages section When I edit the layout for a page and choose the 'create custom layout' option I can add a new option that matches existing options. I can also add multiple copies of a non existing layout. There should be some checking to make sure one is not adding an existing option otherwise the available options get quite filled up with duplication pretty quickly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1233403/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
