[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
** No longer affects: mahara/1.8 ** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: Fix Committed Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: Fix Released Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Okay, I've decided to just remove the section that was checking for orphaned group content. It's no longer necessary, since the earlier patch resolved the bugs that could come from having orphan content, and it took an unreasonably long amount of time to run for the sites that had been around since 1.4, which are the ones that actually could benefit from it. https://reviews.mahara.org/2640 I'll spin off a separate bug about the lesser issue of deleted group names being too long and throwing a warning. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Hm, after running that, the deleted pages still show up on the popular pages report, they just don't crash it anymore... maybe I'll add a more precise check that just finds the deleted groups that have pages, and runs those through group_delete()... -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Okay, after some more testing, even with a more targeted deletion cycle it still takes a really long time. Since it's not a regression (those deleted pages would show up in the report in 1.7 as well) I'm going to just leave them in place and consider this fixed. If the orphaned pages cause problems somewhere else, we can revisit the issue. ** Changed in: mahara/1.8 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.8 series: Fix Committed Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Whoops, just realized that I still need to merge the part that removes the orphaned content section. Okay, pushing that as https://reviews.mahara.org/2647 ** Changed in: mahara/1.8 Status: Fix Committed = In Progress ** Changed in: mahara/1.8 Assignee: (unassigned) = Aaron Wells (u-aaronw) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Patch 2606 was merged into 1.8rc2. But since then, we've found that the one-time script that goes through and deletes orphaned group pages, needs some work. The problem is, that since there's no way to tell which groups were deleted prior to 1.5, it cycles through every deleted group, and runs the group_delete() method for it. In the case of an old/large site, this can take a really long time. Additionally, running group_delete() a second time causes the group names to get re-munged. When you delete it the first time it's changed to something like deleted.$name.$timestamp. If you call group_delete() on the same group a second time, it becomes something like deleted.deleted.$name.$timestamp.$timestamp. And this was long enough, in the case of some groups, that it caused the update to fail because the name was too long to fit into the table column. So both of those issues need to be fixed for 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
** Changed in: mahara/1.8 Status: Incomplete = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
https://reviews.mahara.org/2606 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: In Progress Status in Mahara 1.8 series: In Progress Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Actually on further testing, I find that this is a 1.8 regression. Which is to say, if you upgrade from 1.4 to 1.5, 1.6, or 1.7, you don't encounter this problem. It's not until the 1.8 upgrade that the statistics page quits. So, I'm going to bump this back up to a high priority, because it's likely to occur in any Mahara site that has been live since 1.4. Cheers, Aaron ** Tags added: regression ** Changed in: mahara/1.8 Importance: Low = High ** Changed in: mahara/1.8 Milestone: 1.8.1 = 1.8.0 ** Description changed: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. - The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); - It should check if the group has been deleted and cater for that - situation. + Update: This only occurs when the group was deleted in Mahara 1.4 or + earlier. After 1.5, the group_delete() function was updated to also + delete all the group's Pages. And the error on the report page only + happens in Mahara 1.8, probably due to some change we made in + View::get_extra_view_info(). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: Incomplete Status in Mahara 1.8 series: Incomplete Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236661] Re: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8
Huh, it looks like we added an (unused) function to the GroupType class, public static abstract function get_view_editing_roles(), and a bit of code in the View constructor that tries to call that function, when viewing a group page, in order to find out the editingroles for the group. This was added as part of https://reviews.mahara.org/#/c/2387/ , the mega-patch for all the changes to the page builder. But it looks like it's unnecessary to that code. So, I'll go ahead and remove it, since it's causing problems. I will also add a one-time script in the update script to delete orphaned group pages. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236661 Title: Site statistics: Pages - Page not found error when a page's group has been deleted in 1.4, followed by an upgrade to 1.8 Status in Mahara ePortfolio: Incomplete Status in Mahara 1.8 series: Incomplete Bug description: If a group has been deleted, the Admin Home/Site Statistics/Pages tab (Most Popular Pages) comes up with the error: Page not found You tried to access a page that does not exist. Page with id 0 not found. The View construct is trying to load the deleted group but as it is deleted, it automatically throws an exception ViewNotFoundException. Called in function htdocs/lib/view.php::get_extra_view_info() line 4124 ($view = new View(0, $v); Update: This only occurs when the group was deleted in Mahara 1.4 or earlier. After 1.5, the group_delete() function was updated to also delete all the group's Pages. And the error on the report page only happens in Mahara 1.8, probably due to some change we made in View::get_extra_view_info(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
