[Mahara-contributors] [Bug 1240776] Re: PDF media looks incomplete
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240776 Title: PDF media looks incomplete Status in Mahara ePortfolio: Fix Released Bug description: Mahara 1.8 Testing - Environment = Linux / Chrome URL = http://myportfolio-school2-mahara.testing.elearning.catalyst.net.nz/user/spintester/spinner-s-page-8 The PDF block looks incomplete on a Profile page, it looks as though it needs a bottom. The other problem is that the block only shows half of the first page. I would have expected it to show the whole first page. See the attachment for more details To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240776/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240776] Re: PDF media looks incomplete
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240776 Title: PDF media looks incomplete Status in Mahara ePortfolio: Fix Committed Bug description: Mahara 1.8 Testing - Environment = Linux / Chrome URL = http://myportfolio-school2-mahara.testing.elearning.catalyst.net.nz/user/spintester/spinner-s-page-8 The PDF block looks incomplete on a Profile page, it looks as though it needs a bottom. The other problem is that the block only shows half of the first page. I would have expected it to show the whole first page. See the attachment for more details To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240776/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240776] Re: PDF media looks incomplete
** Changed in: mahara Assignee: (unassigned) = Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240776 Title: PDF media looks incomplete Status in Mahara ePortfolio: New Bug description: Mahara 1.8 Testing - Environment = Linux / Chrome URL = http://myportfolio-school2-mahara.testing.elearning.catalyst.net.nz/user/spintester/spinner-s-page-8 The PDF block looks incomplete on a Profile page, it looks as though it needs a bottom. The other problem is that the block only shows half of the first page. I would have expected it to show the whole first page. See the attachment for more details To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240776/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240776] Re: PDF media looks incomplete
Have added a patch https://reviews.mahara.org/#/c/2622/ That gives some dark colour to the base of the pdf block so it looks less broken. Ideally though it would be nice to get the system to work out how high each rendered pdf page is and alter the iframe height accordingly. Currently we have: - the iframe hardcoded at 500px - the css of the pdf pages = page - the height of the pages is set as style=width: 427px; height: 604px; (for example) so what we need to do is: - find the first page of this particular blockinstance - get it's height - calculate how tall the iframe needs to be (height of page + plus toolbar, padding etc. ) - update the iframe to have the new height (possibly with some nifty transition) ** Changed in: mahara Status: New = In Progress ** Changed in: mahara Importance: Undecided = Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240776 Title: PDF media looks incomplete Status in Mahara ePortfolio: In Progress Bug description: Mahara 1.8 Testing - Environment = Linux / Chrome URL = http://myportfolio-school2-mahara.testing.elearning.catalyst.net.nz/user/spintester/spinner-s-page-8 The PDF block looks incomplete on a Profile page, it looks as though it needs a bottom. The other problem is that the block only shows half of the first page. I would have expected it to show the whole first page. See the attachment for more details To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240776/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
