[Mahara-contributors] [Bug 1243015] Re: On custom layout builder, disable the add row button when you're at the maximum number of rows
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1243015 Title: On custom layout builder, disable the add row button when you're at the maximum number of rows Status in Mahara ePortfolio: Fix Committed Bug description: We shouldn't display the add a row button when it won't do anything. Or at least, we should display it in a grayed-out disabled mode. To replicate: 1. Create a page 2. Go to Edit layout 3. Expand Advanced options 4. Expand Create custom layout 5. Click Add a row 5 times, each time adding one row, until you have 6. Actual result: Add a row looks exactly the same, but now clicking on it won't do anything Expected result: Add a row should be grayed out or disappear in order to indicate that it's no longer usable. If you delete a row, it should re-enable. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1243015/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1243015] Re: On custom layout builder, disable the add row button when you're at the maximum number of rows
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1243015 Title: On custom layout builder, disable the add row button when you're at the maximum number of rows Status in Mahara ePortfolio: Fix Released Bug description: We shouldn't display the add a row button when it won't do anything. Or at least, we should display it in a grayed-out disabled mode. To replicate: 1. Create a page 2. Go to Edit layout 3. Expand Advanced options 4. Expand Create custom layout 5. Click Add a row 5 times, each time adding one row, until you have 6. Actual result: Add a row looks exactly the same, but now clicking on it won't do anything Expected result: Add a row should be grayed out or disappear in order to indicate that it's no longer usable. If you delete a row, it should re-enable. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1243015/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1243015] Re: On custom layout builder, disable the add row button when you're at the maximum number of rows
You should grey it out. Not make it disappear if you want to respect interface guidelines. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1243015 Title: On custom layout builder, disable the add row button when you're at the maximum number of rows Status in Mahara ePortfolio: In Progress Bug description: We shouldn't display the add a row button when it won't do anything. Or at least, we should display it in a grayed-out disabled mode. To replicate: 1. Create a page 2. Go to Edit layout 3. Expand Advanced options 4. Expand Create custom layout 5. Click Add a row 5 times, each time adding one row, until you have 6. Actual result: Add a row looks exactly the same, but now clicking on it won't do anything Expected result: Add a row should be grayed out or disappear in order to indicate that it's no longer usable. If you delete a row, it should re-enable. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1243015/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1243015] Re: On custom layout builder, disable the add row button when you're at the maximum number of rows
Actually the problem was more widespread and this patch fixes it: https://reviews.mahara.org/#/c/2639 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1243015 Title: On custom layout builder, disable the add row button when you're at the maximum number of rows Status in Mahara ePortfolio: In Progress Bug description: We shouldn't display the add a row button when it won't do anything. Or at least, we should display it in a grayed-out disabled mode. To replicate: 1. Create a page 2. Go to Edit layout 3. Expand Advanced options 4. Expand Create custom layout 5. Click Add a row 5 times, each time adding one row, until you have 6. Actual result: Add a row looks exactly the same, but now clicking on it won't do anything Expected result: Add a row should be grayed out or disappear in order to indicate that it's no longer usable. If you delete a row, it should re-enable. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1243015/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1243015] Re: On custom layout builder, disable the add row button when you're at the maximum number of rows
https://reviews.mahara.org/#/c/2634/ have made patch for this ** Changed in: mahara Status: Confirmed = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1243015 Title: On custom layout builder, disable the add row button when you're at the maximum number of rows Status in Mahara ePortfolio: In Progress Bug description: We shouldn't display the add a row button when it won't do anything. Or at least, we should display it in a grayed-out disabled mode. To replicate: 1. Create a page 2. Go to Edit layout 3. Expand Advanced options 4. Expand Create custom layout 5. Click Add a row 5 times, each time adding one row, until you have 6. Actual result: Add a row looks exactly the same, but now clicking on it won't do anything Expected result: Add a row should be grayed out or disappear in order to indicate that it's no longer usable. If you delete a row, it should re-enable. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1243015/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
