[Mahara-contributors] [Bug 1660101] Re: Search box in configurable theme needs better outline
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660101 Title: Search box in configurable theme needs better outline Status in Mahara: Fix Released Bug description: When using the configurable theme, the search box looks a bit odd when the search buttons have an outline as the outline is only for 3 sides but not all 4 (see screenshot). I can see two options: 1. Extend the button outline to the search box itself. 2. Ensure that the 4th side of the button has the outline. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1660101] Re: Search box in configurable theme needs better outline
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 17.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660101 Title: Search box in configurable theme needs better outline Status in Mahara: Fix Committed Bug description: When using the configurable theme, the search box looks a bit odd when the search buttons have an outline as the outline is only for 3 sides but not all 4 (see screenshot). I can see two options: 1. Extend the button outline to the search box itself. 2. Ensure that the 4th side of the button has the outline. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1660101] Re: Search box in configurable theme needs better outline
You don't even need to change to another theme. Just a click on "Save" is sufficient. :-) That's normal behavior for that theme right now as the values are stored in the DB until changed via "Save". So this is acceptable and not a bug of your patch, Liam. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660101 Title: Search box in configurable theme needs better outline Status in Mahara: In Progress Bug description: When using the configurable theme, the search box looks a bit odd when the search buttons have an outline as the outline is only for 3 sides but not all 4 (see screenshot). I can see two options: 1. Extend the button outline to the search box itself. 2. Ensure that the 4th side of the button has the outline. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1660101] Re: Search box in configurable theme needs better outline
Hi Niranjan It works fine on my computer but I have realised one thing: You need to disable the institution theme (in the institution settings) and set it to another theme e.g. raw, then click save. And then set it as config theme and save again. Only after doing this are the changes applied as the CSS is generated and stored on the database so it ignores any code changes until the config theme is re-applied. Thanks, Liam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660101 Title: Search box in configurable theme needs better outline Status in Mahara: In Progress Bug description: When using the configurable theme, the search box looks a bit odd when the search buttons have an outline as the outline is only for 3 sides but not all 4 (see screenshot). I can see two options: 1. Extend the button outline to the search box itself. 2. Ensure that the 4th side of the button has the outline. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1660101] Re: Search box in configurable theme needs better outline
** Attachment added: "Search.jpg" https://bugs.launchpad.net/mahara/+bug/1660101/+attachment/4811601/+files/Search.jpg -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660101 Title: Search box in configurable theme needs better outline Status in Mahara: In Progress Bug description: When using the configurable theme, the search box looks a bit odd when the search buttons have an outline as the outline is only for 3 sides but not all 4 (see screenshot). I can see two options: 1. Extend the button outline to the search box itself. 2. Ensure that the 4th side of the button has the outline. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1660101] Re: Search box in configurable theme needs better outline
I opted to add both a border to the left side of the button and around the input block as I thought this looked the best from the available options. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660101 Title: Search box in configurable theme needs better outline Status in Mahara: In Progress Bug description: When using the configurable theme, the search box looks a bit odd when the search buttons have an outline as the outline is only for 3 sides but not all 4 (see screenshot). I can see two options: 1. Extend the button outline to the search box itself. 2. Ensure that the 4th side of the button has the outline. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
