[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
** Changed in: mahara/18.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Fix Released Status in Mahara 18.04 series: Fix Released Status in Mahara 18.10 series: Fix Released Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
** Changed in: mahara/18.10 Status: In Progress => Fix Committed ** Changed in: mahara/18.04 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
** Changed in: mahara/18.10 Assignee: (unassigned) => Liam (liam-sharpe) ** Changed in: mahara/18.04 Assignee: Liam (liam-sharpe) => (unassigned) ** Changed in: mahara/18.04 Status: In Progress => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Confirmed Status in Mahara 18.04 series: Confirmed Status in Mahara 18.10 series: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
** Changed in: mahara/18.04 Assignee: Jaque (jaque777) => Liam (liam-sharpe) ** Changed in: mahara/18.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Confirmed Status in Mahara 18.04 series: Confirmed Status in Mahara 18.10 series: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
I do notice for the 'ocean' theme there is this on the sass/utilities/ dir: _custom-variables.scss:$arrow-color: $brand-primary; _custom-variables.scss:$arrow-text-color: #fff; _custom-variables.scss:$arrow-link-color: #fff; _custom-variables.scss:$arrow-link-hover-color: $text-color; _custom-variables.scss:$arrow-link-active-color: #20738f; _custom-variables.scss:$arrow-link-background-color: #fff; _bootstrap-variables.scss:$arrow-color: darken($brand-info, 10%); _bootstrap-variables.scss:$arrow-text-color: #fff; _bootstrap-variables.scss:$arrow-link-color: #fff; _bootstrap-variables.scss:$arrow-link-hover-color: $arrow-color; _bootstrap-variables.scss:$arrow-link-active-color: $arrow-color; And it looks like some things are defined twice and with different values -- In primary school theme we have _custom-variables.scss:$arrow-color: $brand-primary; _custom-variables.scss:$arrow-text-color: #fff; _custom-variables.scss:$arrow-link-color: #ca0238; _custom-variables.scss:$arrow-link-hover-color: $text-color; _custom-variables.scss:$arrow-link-active-color: $brand-primary; _custom-variables.scss:$arrow-link-background-color: #fff; _custom-variables.scss:$arrow-link-group-color: #799323; and I notice _custom-variables.scss:$arrow-link-color: #ca0238; would give the 'Sent' button the red colour -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Confirmed Status in Mahara 18.04 series: Confirmed Status in Mahara 18.10 series: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
I can show you tomorrow, Jaque. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Confirmed Status in Mahara 18.04 series: Confirmed Status in Mahara 18.10 series: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
** Also affects: mahara/18.04 Importance: High Assignee: Jaque (jaque777) Status: In Progress ** Also affects: mahara/18.10 Importance: Undecided Status: New ** Changed in: mahara/18.10 Milestone: None => 18.10.0 ** Changed in: mahara/18.10 Importance: Undecided => High ** Changed in: mahara/18.04 Status: In Progress => Confirmed ** Changed in: mahara/18.10 Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: Confirmed Status in Mahara 18.04 series: Confirmed Status in Mahara 18.10 series: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
On my local instance, I can not replicate the problem on either the Ocean or the primary school theme, the colors are working correctly. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756154] Re: Fix link color in Primary School and Ocean themes for "Notifications"
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756154 Title: Fix link color in Primary School and Ocean themes for "Notifications" Status in Mahara: In Progress Bug description: When you have the Primary School or Ocean theme on your site, the navigation bar in the inbox (/module/multirecipientnotification/inbox.php) does not show the links in the nav bar in the correct colors. In Ocean it is only the active link that is a problem, in Primary School it is both Inbox and Sent. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
