[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: Fix Released Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
** Tags removed: blocks locking ** Tags added: nominatedfeature -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: Fix Committed Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 18.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: Fix Committed Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Hi Kevin, Thank you for the tips. You can add them to the wiki yourself as your mahara.org login works on the wiki as well. :-) Cheers Kristina -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: In Progress Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Hi Mahara team, The commit has been created in Gerrit on its own branch for review: https://reviews.mahara.org/#/c/9033/ Note: If the Mac version of "xargs" is being run, this error will appear: xargs: illegal option -- - If "sed" on a mac is being run, this error will appear: sed: illegal option -- r Linux Sed and xargs are not the same as Mac ones... (silent moan into the void) Commands for "sed" and "xargs" require that homebrew be installed and these commands be run: brew install gnu-sed --with-default-names (on a mac - sed is called gsed, the --with-default-names option will make it run as "sed" as per the makefile call) brew install findutils --with-default-names (or brew reinstall findutils --with-default-names) as the default xargs on a mac runs differently to linux, and hombrew will install the "linux" version as gxargs - the option --with-default-names will make it behave. These little tips could be be added to the https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code for those that code on mac. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: In Progress Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Master branch patch - tested. Still having issues updating via gerrit, will get these sorted. This is the patch based on the Mahara Master Branch. ** Patch added: "Master_patch.diff" https://bugs.launchpad.net/mahara/+bug/1781844/+attachment/5169278/+files/Master_patch.diff -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: In Progress Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Hi Kristina, Attached is an updated patch with the bugs addressed and the working/ wording updated. The settings area now features the lockblocks setting Copying collections will respect the lockblock setting Setting the lock block share for a collection will update all pages in the collection. ** Patch added: "Upgraded_lockblock_patch.diff" https://bugs.launchpad.net/mahara/+bug/1781844/+attachment/5167925/+files/Upgraded_lockblock_patch.diff -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: In Progress Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Hi Kevin, I had a look at the functionality and think we can include it into Mahara core with a few adjustments and fixing of bugs. Can you please take a look at my comments at https://reviews.mahara.org/#/c/9019 and fix things up? Thank you Kristina -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: In Progress Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: In Progress Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Hi Kevin, Your patch is in reviews now here https://reviews.mahara.org/#/c/9015/ You'll have to keep an eye on it to see when it's updated, since there wasn't an email address in the commit. Cheers, Cecilia -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: New Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident
Hi Kevin, Thank you for this new functionality. We'll take it over into the code review system at https://reviews.mahara.org to take a look. Cheers Kristina ** Changed in: mahara Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1781844 Title: When pages are shared - users can delete blocks by accident Status in Mahara: New Bug description: Mahara 18.04.02 DB: Mysql OS: Ubuntu Browser: Chrome A lot of users in Mahara create (Template) pages to share out to users. This reduces the setup a new user will have to do to. There is an issue that on their personal copy, the blocks that were so carefully setup can be deleted. This patch creates a new column in the database called "lockblocks" that can be enabled/disabled on the share page. When the user copies the page, this setting is copied over and the "delete" icon is hidden from view should the lockblocks setting be enabled. To unset - the user can open the advanced options in the shared area and disable the lock blocks feature to enable the deletion of the blocks as per normal. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
