[Mahara-contributors] [Bug 1801993] A change has been merged
Reviewed: https://reviews.mahara.org/9292 Committed: https://git.mahara.org/mahara/mahara/commit/bc4c1e9f4322961e42cacea78cd87c4c54863efe Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:18.04_STABLE commit bc4c1e9f4322961e42cacea78cd87c4c54863efe Author: Robert Lyon Date: Wed Nov 7 07:47:31 2018 +1300 Bug 1801993: Remove old Mochikit function call And replace it with equivalent jQuery call To test: 1) Set in cofig.php file: $cfg->blockeditormaxwidth = true; 2) Add a text block to a page behatnotneeded Change-Id: I26855778c53ac36591b6188c477f25648dab9057 Signed-off-by: Robert Lyon (cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e) (cherry picked from commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1801993 Title: Old Mochikit function still in views.js Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When we have the config setting $cfg->blockeditormaxwidth set to true And go to add a block to a page we get an error -> "ReferenceError: getViewportDimensions is not defined" This is due to the getViewportDimensions() function being an old MochiKit function. We need to adjust this to get the needed value from a jQuery function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1801993] A change has been merged
Reviewed: https://reviews.mahara.org/9287 Committed: https://git.mahara.org/mahara/mahara/commit/07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e Author: Robert Lyon Date: Wed Nov 7 07:47:31 2018 +1300 Bug 1801993: Remove old Mochikit function call And replace it with equivalent jQuery call To test: 1) Set in cofig.php file: $cfg->blockeditormaxwidth = true; 2) Add a text block to a page behatnotneeded Change-Id: I26855778c53ac36591b6188c477f25648dab9057 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1801993 Title: Old Mochikit function still in views.js Status in Mahara: In Progress Status in Mahara 18.04 series: New Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: When we have the config setting $cfg->blockeditormaxwidth set to true And go to add a block to a page we get an error -> "ReferenceError: getViewportDimensions is not defined" This is due to the getViewportDimensions() function being an old MochiKit function. We need to adjust this to get the needed value from a jQuery function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1801993] A change has been merged
Reviewed: https://reviews.mahara.org/9291 Committed: https://git.mahara.org/mahara/mahara/commit/e3fa699be8ca0970e0f776551afb2dc8e981c4ef Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:18.10_STABLE commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef Author: Robert Lyon Date: Wed Nov 7 07:47:31 2018 +1300 Bug 1801993: Remove old Mochikit function call And replace it with equivalent jQuery call To test: 1) Set in cofig.php file: $cfg->blockeditormaxwidth = true; 2) Add a text block to a page behatnotneeded Change-Id: I26855778c53ac36591b6188c477f25648dab9057 Signed-off-by: Robert Lyon (cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1801993 Title: Old Mochikit function still in views.js Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When we have the config setting $cfg->blockeditormaxwidth set to true And go to add a block to a page we get an error -> "ReferenceError: getViewportDimensions is not defined" This is due to the getViewportDimensions() function being an old MochiKit function. We need to adjust this to get the needed value from a jQuery function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
