[Mahara-contributors] [Bug 1826788] A patch has been submitted for review

2019-04-29 Thread Mahara Bot
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9916

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788

Title:
  Tags under institutions cause error

Status in Mahara:
  Fix Committed

Bug description:
  We now have a system where we can use special 'Institution tags' but
  we also allow institution admins to tag things in the normal was as
  well. The following case causes the error:

  [WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at 
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
  error(8, "Trying to get property of non-object", 
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at 
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
  display_tag("fats", array(size 2)) at 
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
  ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at 
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164

  
  Steps to reproduce:

  1) Have a site with an institution (Institution A) that contains 2 
institution admins
  2) Institution admin A logs in and uploads a file to the Admin -> Institution 
-> Files section
  3) They then edit the file metadata and add a tag 'Cats'
  4) They log out
  5) Institution admin B logs in and goes to the Admin -> Institution -> Files 
section

  They see the error

  6) They then edit the file metadata and instead of seeing 'Cats' they
  see 'null'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1826788] A patch has been submitted for review

2019-04-28 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9894

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788

Title:
  Tags under institutions cause error

Status in Mahara:
  In Progress

Bug description:
  We now have a system where we can use special 'Institution tags' but
  we also allow institution admins to tag things in the normal was as
  well. The following case causes the error:

  [WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at 
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
  error(8, "Trying to get property of non-object", 
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at 
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
  display_tag("fats", array(size 2)) at 
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
  ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at 
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164

  
  Steps to reproduce:

  1) Have a site with an institution (Institution A) that contains 2 
institution admins
  2) Institution admin A logs in and uploads a file to the Admin -> Institution 
-> Files section
  3) They then edit the file metadata and add a tag 'Cats'
  4) They log out
  5) Institution admin B logs in and goes to the Admin -> Institution -> Files 
section

  They see the error

  6) They then edit the file metadata and instead of seeing 'Cats' they
  see 'null'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp