[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views
** Changed in: mahara Status: Fix Committed = Fix Released -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Fix Released Bug description: If you create a new group, and then delete it, it's views are not deleted. As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist. Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views
** Changed in: mahara Status: Opinion = Fix Committed -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Fix Committed Bug description: If you create a new group, and then delete it, it's views are not deleted. As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist. Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views
So we want to remove grouphomepage views from the newviews block type (where they shouldn't be displayed). newviews/lib.php uses View::view_search() However, the grouphomepage views should be visible to group admins on view/groupviews.php for editting etc and view/groupviews.php also uses View::view_search() Since they're only ever shown to admins, it doesn't really matter if a grouphomepage view is shown in the newviews blocktype. I've also pushed a fix to ensure that deleted group views are not displayed; and a fix to display_title when using grouphomepages. -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: New Bug description: If you create a new group, and then delete it, it's views are not deleted. As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist. Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views
I've pushed the above fixes. I'll leave this for others to decide whether the newviews blocktype should display grouphomepage views. ** Changed in: mahara Assignee: Andrew Robert Nicols (dobedobedoh) = (unassigned) -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: New Bug description: If you create a new group, and then delete it, it's views are not deleted. As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist. Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views
** Changed in: mahara Status: New = Opinion -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Opinion Bug description: If you create a new group, and then delete it, it's views are not deleted. As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist. Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views
I don't think they should be in the newviews block, but yeah, I agree it's not super high priority because it's only admin's that see them. Maybe we could pass a view type filter to the view_search function. It would make that function even more hairy and indecipherable, but it could be the easiest way to fix this. -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Opinion Bug description: If you create a new group, and then delete it, it's views are not deleted. As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist. Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
