[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara: Fix Released Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Also affects: mahara/15.10 Importance: Undecided Status: New ** Also affects: mahara/15.10 Importance: Undecided Status: Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara/15.04 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara/15.04 Milestone: 15.10.0 = 15.04.3 ** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** No longer affects: mahara/1.10 ** Changed in: mahara/15.04 Milestone: 15.04.0 = 15.10.0 ** Tags added: performance -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: In Progress Status in Mahara 15.04 series: In Progress Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Also affects: mahara/1.11 Importance: Medium Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Also affects: mahara/1.10 Importance: Undecided Status: New ** Changed in: mahara/1.11 Milestone: 1.10.0 = 1.11.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: New Status in Mahara 1.11 series: In Progress Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Status: Triaged = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: In Progress Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
After having done some profiling and preparation of patches over the last few days, I think 32M is reasonable for normal operation, but we will definitely still need to raise the memory limit for some operations. The main one I've focused on so far is adding users from a CSV file. Profiling got me focusing on execution time as well as memory use, and I have a few patches that together do better than halving the execution time (one in particular - to handle_event - will probably have far wider implications and accounts for most of the savings) while only raising memory use by a small amount. 64MB is more than enough even for an import of 5000 users. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
I'm going to give this a go... ** Changed in: mahara Assignee: (unassigned) = Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Milestone: 1.9.0 = 1.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
I would classify this bug as a new feature. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
I would use KCachegrind for analysing the memory usage of this scripts then optimize them. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
Would flushing the output buffer for each iteration of the heavy load loops help? Or is more a server machine problem? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
Instead of eliminating them we now have more :(
./htdocs/lib/cron.php:raise_memory_limit('128M');
./htdocs/lib/csvfile.php:raise_memory_limit(512M);
./htdocs/lib/mahara.php:raise_memory_limit('128M');
./htdocs/lib/mahara.php:function raise_memory_limit ($newlimit) {
./htdocs/lib/imageresizer.php:raise_memory_limit($newlimitMB . 'M');
./htdocs/lib/db/upgrade.php:raise_memory_limit('256M');
./htdocs/admin/users/bulkimport.php:raise_memory_limit('1024M');
./htdocs/admin/users/uploadcsv.php:raise_memory_limit(512M);
./htdocs/admin/users/bulkdownload.php:raise_memory_limit(1024M);
./htdocs/admin/groups/uploadcsv.php:raise_memory_limit(512M);
./htdocs/admin/groups/uploadmemberscsv.php:raise_memory_limit(512M);
./htdocs/export/html/lib.php:raise_memory_limit('128M');
./htdocs/import/index.php:raise_memory_limit(512M);
./htdocs/search/elasticsearch/cron.php:raise_memory_limit('256M');
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/785472
Title:
Eliminate all raise_memory_limit() calls
Status in Mahara ePortfolio:
Triaged
Bug description:
There are very few places in Mahara were we raise PHP's memory limit,
but it is bad practice since that memory may not be reclaimed by
Apache until that child process is terminated.
Unless we are confident that a particular operation is impossible to
do without raising the memory limit, we should rewrite code which
fails to work within 32 MB of memory.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Milestone: 1.8.0 = 1.9.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Milestone: 1.8rc1 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Milestone: 1.7.0 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
** Changed in: mahara Milestone: None = 1.7.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
affects the following:
./htdocs/export/html/lib.php:raise_memory_limit('128M');
./htdocs/lib/csvfile.php:raise_memory_limit(512M);
./htdocs/lib/cron.php:raise_memory_limit('128M');
./htdocs/lib/db/upgrade.php:raise_memory_limit('256M');
./htdocs/lib/mahara.php:raise_memory_limit('128M');
./htdocs/lib/mahara.php:function raise_memory_limit ($newlimit) {
./htdocs/admin/users/uploadcsv.php:raise_memory_limit(512M);
./htdocs/admin/users/bulkdownload.php:raise_memory_limit(1024M);
./htdocs/admin/users/bulkimport.php:raise_memory_limit('1024M');
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/785472
Title:
Eliminate all raise_memory_limit() calls
Status in Mahara ePortfolio:
Triaged
Bug description:
There are very few places in Mahara were we raise PHP's memory limit,
but it is bad practice since that memory may not be reclaimed by
Apache until that child process is terminated.
Unless we are confident that a particular operation is impossible to
do without raising the memory limit, we should rewrite code which
fails to work within 32 MB of memory.
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
