[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Released Status in Mahara 15.04 series: Fix Released Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara/1.8 Milestone: None = 1.8.6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara/1.10 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara/1.8 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara/1.9 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Released Status in Mahara 15.04 series: Fix Committed Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
There were two patches for this bug. The first one, https://reviews.mahara.org/#/c/3506/, fixes the problem initially described. The second one, https://reviews.mahara.org/#/c/3507/, fixes a related problem described in comment #15. I've merged patch 3506, but found problems with patch 3507. So to make record-keeping easier, I've moved patch 3507 to a new bug 1391393. ** Changed in: mahara/15.04 Status: In Progress = Fix Committed ** Also affects: mahara/1.8 Importance: Undecided Status: New ** Also affects: mahara/1.10 Importance: Undecided Status: New ** Also affects: mahara/1.9 Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara/1.10 Importance: Undecided = Low ** Changed in: mahara/1.10 Status: New = Fix Committed ** Changed in: mahara/1.10 Milestone: None = 1.10.1 ** Changed in: mahara/1.8 Importance: Undecided = Low ** Changed in: mahara/1.8 Status: New = Fix Committed ** Changed in: mahara/1.8 Milestone: None = 1.8.6 ** Changed in: mahara/1.9 Importance: Undecided = Low ** Changed in: mahara/1.9 Status: New = Fix Committed ** Changed in: mahara/1.9 Milestone: None = 1.9.4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** No longer affects: mahara/1.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Confirmed Status in Mahara 15.04 series: In Progress Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara Milestone: 1.10.0 = 1.10.1 ** Also affects: mahara/1.11 Importance: Undecided Status: New ** Changed in: mahara/1.11 Milestone: None = 1.11.0 ** Also affects: mahara/1.10 Importance: Low Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara/1.11 Importance: Undecided = Low ** Changed in: mahara/1.11 Assignee: (unassigned) = Nigel Cunningham (nigelc-g) ** Changed in: mahara/1.11 Status: New = In Progress ** Changed in: mahara/1.10 Status: In Progress = Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Confirmed Status in Mahara 1.10 series: Confirmed Status in Mahara 1.11 series: In Progress Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara Assignee: Kristina Hoeppner (kris-hoeppner) = Nigel Cunningham (nigelc-g) ** Changed in: mahara Status: Triaged = In Progress ** Changed in: mahara Milestone: None = 1.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: In Progress Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
I have another suggestion, with a patch that I've just pushed. The required fields form works by hijacking any link that the user has requested, so all we need to do after the user has successfully addressed the requirements is drop out of generating the form and let the normal execution for the requested URL continue. My patch accomplishes that by adding a small amount of code allowing this to happen. It relies on the fact that $form-build() always returns a string (the rendered HTML), and instead returns FALSE if we need to back out of the form generation. I've successfully tested it by running an install on the URL http://mahara, which causes the warning about the noreply email address. I then clicked on the noreply link (fixed by the first patch of the two in the submission) and was taken to the site_options URL, overridden by the required fields form. After the required fields form was submitted with a valid admin password, the page loaded with the requested form for setting the noreply link. At the point where I clicked on the noreply link, I also clicked on other links, opening them in other tabs. All tabs displayed the required fields form under the requested URL, as expected. After successful submission on one of the tabs, reloading all other tabs then displayed the expected page content. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
Since we have links everywhere else, a link would be great. If you aren't logged in yet, shouldn't the link redirect you to the login page form and then take you to the correct page? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
Argh. That doesn't work because the site admin hasn't chosen the password or email yet. I would go for a new string as I said in comment #8 instead of reusing the one that a site admin sees on the site admin homepage when logged in. This new string would then not include a link as that doesn't take you anywhere properly unless this can be resolved. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
There would need to be added a check to see if we are installing or not to display message with/without link. Or we could just display: Administration - Configure site - Email settings as words rather than a link to indicate where user needs to go to edit -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
Also look at the fix for https://bugs.launchpad.net/mahara/+bug/1239539 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
I tried navigating to the site by just using the link, was asked for a new password and email address and then was taken to the dashboard instead of the site settings. Thus, it would be better not to have a link there but change the wording. However, the same string is used on the admin overview page. Therefore, a new string would need to be created. ** Changed in: mahara Assignee: (unassigned) = Kristina Hoeppner (kris-hoeppner) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
I see this error warning on fresh install if I have set the url to be something based on an entry in my /etc/hosts file eg: 127.0.0.1 mahara-testing and Apache set up for that so the url for the site is http://mahara- testing/ and therefore $cfg-noreplyaddress gets set to something bad like: noreply@mahara-testing The fix $SESSION-add_error_msg($w,false); will get the href link to display correctly. But should there be a link in the warning at this stage as one can't navigate to that page until they have set their default password and email first. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
What are the steps to replicate the original problem? I don't see any warning when I do a clean install. $cfg-noreplyaddress seems to get set to a sensible default by init.php if none is supplied. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
I tried it using 1.7_STABLE and master. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
Apparently the problem is actually only visible on upgrade, not on clean installs. Looks like it's just how the HTML is displayed. According to the method add_error_msg, witch displays the error, the HTML code inside errors can be escaped or not with the second parameter set it to FALSE or TRUE. The error messages had HTML and the method invocation was set to escape HTML (The default option), giving as result HTML escaped, where it should not be escaped, it should be displayed as HTML. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
Attached is the error message on the first Mahara screen right after a fresh install of master. ** Attachment added: escaped_html.png https://bugs.launchpad.net/mahara/+bug/946880/+attachment/3661799/+files/escaped_html.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Tags added: upgrades -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
The HTML of the warning message was escaped. The method that displays the
messages has a default parameter for escape HTML as true.
The solution is to set to false the second parameter when that method is
invoked:
Method definition on class Session.
public function add_error_msg($message, $escape=true) {
Method invocation on line 37 of file admin/upgrade.php
$SESSION-add_error_msg($w);
should be: $SESSION-add_error_msg($w,false);
** Attachment added: upgrade.php
https://bugs.launchpad.net/mahara/+bug/946880/+attachment/3662020/+files/upgrade.php
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/946880
Title:
Broken html error message for no-reply email setting
Status in Mahara ePortfolio:
Triaged
Bug description:
error message when upgrading from 1.4 to 1.5:
The noreply address setting is either empty or has an invalid email
address. Please check the configuration in the a
href=http://15stable/admin/site/options.php?fs=emailsettings;site
options in the email settings/a.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara Status: In Progress = Triaged -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Tags added: academy -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara Assignee: (unassigned) = Christian Tuveve-Aiono (handlethesandal) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: In Progress Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
** Changed in: mahara Milestone: 1.5.0 = None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the a href=http://15stable/admin/site/options.php?fs=emailsettings;site options in the email settings/a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
